[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. IMPALA-3436: Return a decimal when rounding a double Before

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6183: Fix Decimal to Double conversion

2017-11-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8547 Change subject: IMPALA-6183: Fix Decimal to Double conversion .. IMPALA-6183: Fix Decimal to Double conversion When converting a

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. IMPALA-3436: Return a decimal when rounding a double Before

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. IMPALA-3436: Return a decimal when rounding a double Before

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 1: (13 comments)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 2: (12 comments)

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-10-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 1: Ooops, canceled -- To view, visit

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-10-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8404 Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-10-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8398 Change subject: IMPALA-3436: Return a decimal when rounding a double .. IMPALA-3436: Return a decimal when rounding a double Before

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. IMPALA-5018: Error on decimal modulo or divide by zero

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: I spoke to Greg and Alex yesterday, and we

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: Rebased. -- To view, visit

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. IMPALA-5018: Error on decimal modulo or divide by zero

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5018: Error on decimal divide by and modulo zero

2017-10-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal divide by and modulo zero .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. IMPALA-5018: Error on decimal modulo or divide by zero

[Impala-ASF-CR] IMPALA-5018: Error on decimal divide by and modulo zero

2017-10-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8344 Change subject: IMPALA-5018: Error on decimal divide by and modulo zero .. IMPALA-5018: Error on decimal divide by and modulo zero

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8329 Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8309 Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-10-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-10-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 12: Code-Review+2 Fixed the uninitialized

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 11: Code-Review+2 Updated FE tests. Forwarding

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 11: The run failed due to

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 10: Code-Review+2 Rebased, forwarding the +2 --

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 8: I made some additional changes in patch 8 as a

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: I think we should explore your suggestion to

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-09-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-09-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-18 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7639 to look at the new patch set (#6). Change subject: IMPALA-5776: Write partial tuple to the correct mempool

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 5: (1 comment)

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7639/5//COMMIT_MSG Commit Message:

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-16 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7639 to look at the new patch set (#5). Change subject: MPALA-5776: Write partial tuple to the correct mempool ..

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (1 comment)

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/7639/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. IMPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-2422: Fix escaping in LIKE clause .. IMPALA-2422: Fix escaping in LIKE clause There are two stages to processing a like clause. First, we determine if

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-2422: Fix escaping in LIKE clause .. IMPALA-2422: Fix escaping in LIKE clause There are two stages to processing a like clause. First, we determine if

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5681: release reservation from blocking operators .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7660 Change subject: IMPALA-2422: Fix escaping in LIKE clause .. IMPALA-2422: Fix escaping in LIKE clause There are two stages to

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7639 Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-08-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Code-Review+2 Rebased and forwarding the +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. IMPALA-5689: Avoid inverting non-equi left joins When checking if a join can be inverted, we forgot to

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7476 to look at the new patch set (#4). Change subject: IMPALA-5689: Avoid inverting non-equi left joins

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi right joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi right joins .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7476/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7517 Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-5679: Fix Parquet count(*) with group by string

2017-07-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7481 Change subject: IMPALA-5679: Fix Parquet count(*) with group by string .. IMPALA-5679: Fix Parquet count(*) with group by string In

  1   2   3   4   5   6   7   >