Tim Armstrong has uploaded a new patch set (#8).
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
IMPALA-4674: Part 3: fix null-aware anti join
Part 2 regressed NAAJ by tightening up the spilling invariants
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
Patch Set 8:
Rebase onto the BTSV2 -> BTS rename
--
To view, visit http://gerrit.cloudera.org:8080/7367
To
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5708: Test failure with invalid exec summary
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 3:
(1 comment)
Is there any regression in performance ?
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
IMPALA-5412: Fix scan result with partitions on same file
The maps storing file descriptors and file
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5412 Fix scan result with partitions on same file
..
Patch Set 3:
(3 comments)
I ended up combining the tests in test_partition_metadata and adding
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 2:
(2 comments)
Jim Apple has posted comments on this change.
Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 5:
> (14 comments)
It looks like you may have forgotten to push your new patch set?
--
To
Tim Armstrong has posted comments on this change.
Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 6:
Oops, thanks for pointing that out
--
To view, visit
Jim Apple has posted comments on this change.
Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 6:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt
File
anujphadke has uploaded a new patch set (#3).
Change subject: IMPALA-2689: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 15:
I've tested (at least by building) this on all the platforms we distribute at
Cloudera.
Thomas Tauber-Marshall has uploaded a new patch set (#2).
Change subject: IMPALA-5708: Test failure with invalid exec summary
..
IMPALA-5708: Test failure with invalid exec summary
For some queries, the exec summary will not be
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
..
Patch Set 1:
Do you think should add this as a separate patch, rather than updating an
existing one? That
Lars Volker has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
..
Patch Set 2:
> Yes, please do create a separate patch. We have done the same thing
> in Thrift where we've
Matthew Jacobs has uploaded a new patch set (#4).
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
IMPALA-4833: Compute precise per-host reservation size
Before this change, the per-host reservation
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5717
To unsubscribe, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 2:
> Should any startup scripts be modified to trap '' SIGUSR1 before
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Patch Set 5: Code-Review+1
Looks good
--
To view, visit http://gerrit.cloudera.org:8080/7625
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
..
Patch Set 1:
Yes, please do create a separate patch. We have done the same thing in Thrift
where we've
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 3: Code-Review+1
Looks good to me, I'll just give others a chance to
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
IMPALA-5773: Correctly account for memory used in data stream receiver queue
Tim Armstrong has uploaded a new patch set (#8).
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
IMPALA-4674: Part 3: fix null-aware anti join
Part 2 regressed NAAJ by tightening up the spilling invariants
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-5412 Fix scan result with partitions on same file
..
IMPALA-5412 Fix scan result with partitions on same file
The maps storing file descriptors and file
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7658
Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
..
IMPALA-5477: Fix minidump-2-core tool in breakpad
The recent PPC
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 2:
Thanks! Unfortunately there's an issue with the ASAN build - the huge
group_concat
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 3: Code-Review+1
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 3: Code-Review+1
(1 comment)
Alex Behm has posted comments on this change.
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7639/2/be/src/exec/hdfs-text-scanner.cc
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4407: Move Impala setup procedures to main repo
..
IMPALA-4407: Move Impala setup procedures to main repo
Before this change, Impala has
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5681: release reservation from blocking operators
..
IMPALA-5681: release reservation from blocking operators
When an in-memory blocking aggregation or
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 2:
(6 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4407: Move Impala setup procedures to main repo
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7587
To
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7657
Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get
failure
..
IMPALA-5791: Make bootstrap_development.sh survive
anujphadke has posted comments on this change.
Change subject: IMPALA-2689: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Patch Set 3:
(13 comments)
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get
failure
..
IMPALA-5791: Make bootstrap_development.sh survive apt-get failure
This
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get
failure
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7657
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 14:
Build started:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 17:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1034/
--
To
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5708: Test failure with invalid exec summary
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7627
To unsubscribe, visit
Tianyi Wang has uploaded a new patch set (#7).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
IMPALA-5327: Handle return of JNI GetStringUTFChar
GetStringUTFChars may return NULL or throw exception and it
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
..
Patch Set 3:
Thanks Dimitris for the quick reviews. I'll run the metadata benchmark again
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7630
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 7:
(4 comments)
Yeah, we use Status almost universally for error handling. We don't currently
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 4: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/7619
To
Sounds good to me.
Dimitris
On Fri, Aug 11, 2017 at 2:21 PM, Bharath Vissapragada (Code Review) <
ger...@cloudera.org> wrote:
> Bharath Vissapragada has posted comments on this change.
>
> Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
>
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2689: Log why codegen is disabled in
TextConverter::CodegenWriteSlot()
..
Patch Set 3: Code-Review+1
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 5:
Build started:
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7625
to look at the new patch set (#6).
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 2:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 14: Verified-1
Build failed:
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 6:
D
> (7 comments)
Done(Test is still ongoing). I have a question: when doing error handling
Taras Bobrovytsky has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7660
Change subject: IMPALA-2422: Fix escaping in LIKE clause
..
IMPALA-2422: Fix escaping in LIKE clause
There are two stages to
Alex Behm has posted comments on this change.
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7625/5/be/src/exec/hdfs-scan-node-base.h
Tianyi Wang has uploaded a new patch set (#8).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
IMPALA-5327: Handle return of JNI GetStringUTFChar
GetStringUTFChars may return NULL or throw exception and it
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-3208: max_row_size option
..
IMPALA-3208: max_row_size option
This is a preview because it is missing tests. I have manually tested
it and it is behaving
Alex Behm has posted comments on this change.
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7625
To unsubscribe,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 17:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1033/
--
To
Jim Apple has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 14:
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1032/
Bharath Vissapragada has uploaded a new patch set (#2).
Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
..
IMPALA-4847: Simplify HdfsTable block metadata loading code
This commit is a part of ground
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
..
Patch Set 2:
(3 comments)
Yay, more lined deleted :)
Tianyi Wang has uploaded a new patch set (#6).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
IMPALA-5327: Handle return of JNI GetStringUTFChar
GetStringUTFChars may return NULL or throw exception and it
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7652
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1038/
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7630
To unsubscribe,
Kim Jin Chul has posted comments on this change.
Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil
..
Patch Set 4:
(2 comments)
Sorry for the late. Let me answer Jim's comment soon.
Tianyi Wang has uploaded a new patch set (#5).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
IMPALA-5327: Handle return of JNI GetStringUTFChar
GetStringUTFChars may return NULL or throw exception and it
Bharath Vissapragada has uploaded a new patch set (#3).
Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
..
IMPALA-4847: Simplify HdfsTable block metadata loading code
This commit is a part of ground
Jim Apple has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 4:
> Build started:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5708: Test failure with invalid exec summary
..
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1039/
--
To
Hello Thomas Tauber-Marshall,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7619
to look at the new patch set (#4).
Change subject: IMPALA-5681: release reservation from blocking operators
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7619/3//COMMIT_MSG
Commit Message:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 17: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1033/
Jim Apple has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 17:
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1033/
This was a bug in a
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 14:
Build started:
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code
..
Patch Set 1:
(5 comments)
Tianyi Wang has uploaded a new patch set (#4).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
IMPALA-5327: Handle return of JNI GetStringUTFChar
GetStringUTFChars may return NULL or throw exception and it
Hello Michael Ho, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7577
to look at the new patch set (#3).
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 4: Code-Review+1
(3 comments)
Looks good to me. Not sure if Lars wants to take a look too.
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 8:
> (4 comments)
>
> Yeah, we use Status almost universally for error handling. We don't
>
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Patch Set 5:
(3 comments)
Hello Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7646
to look at the new patch set (#4).
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 3:
(2 comments)
I didn't notice any significant performance
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7630
to look at the new patch set (#5).
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 4:
(2 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7591
to look at the new patch set (#3).
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Henry Robinson has abandoned this change.
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/6473
To unsubscribe, visit
Henry Robinson has abandoned this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7103
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 5: Verified+1
--
To view, visit
Jim Apple has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt
File LICENSE.txt:
Line
Taras Bobrovytsky has posted comments on this change.
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 2:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 18: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1043/
Michael Ho has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 8:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/codegen-anyval.h
Jim Apple has posted comments on this change.
Change subject: IMPALA-5708: Test failure with invalid exec summary
..
Patch Set 2:
GVD is going to fail. I think you need to rebase:
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 4:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1040/
--
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5412: Fix scan result with partitions on same file
..
Patch Set 7: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/7625
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1038/
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
Patch Set 14:
Build failed:
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5716
to look at the new patch set (#15).
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
1 - 100 of 142 matches
Mail list logo
