[Impala-ASF-CR] IMPALA-5855: reserve enough memory for preaggs

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5855: reserve enough memory for preaggs .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1172/ -- To

[Impala-ASF-CR] KUDU-2065: Support cancellation for outbound RPC call

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7743 To unsubscribe,

[Impala-ASF-CR] KUDU-2065: Support cancellation for outbound RPC call

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: KUDU-2065: Support cancellation for outbound RPC call .. KUDU-2065: Support cancellation for outbound RPC call This change implements a new

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-08-30 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6989 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3877: support unpatched LLVM

2017-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-3877: support unpatched LLVM .. Abandoned Didn't mean to push -- To view, visit http://gerrit.cloudera.org:8080/7836 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3877: support unpatched LLVM

2017-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3877: support unpatched LLVM .. IMPALA-3877: support unpatched LLVM The p1 patch we use for LLVM avoided merging of structurally identical Struct types in

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-30 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7897 to review the following change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-30 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. Patch Set 1: (2 comments) Thanks for the speedy review!

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-30 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. IMPALA-3548: Prune runtime filters based on query options in the FE Currently, the FE

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-30 Thread Attila Jeges (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7564 to look at the new patch set (#4). Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7884 to look at the new patch set (#2). Change subject: IMPALA-5850: Cast sender partition exprs under unions.

[Impala-ASF-CR] IMPALA-5855: reserve enough memory for preaggs

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5855: reserve enough memory for preaggs .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1175/ -- To view,

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Zach Amsden (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7892 to look at the new patch set (#2). Change subject: IMPALA-5854: Update external hadoop versions .. IMPALA-5854:

[Impala-ASF-CR] rpc: some small cleanup in ConnectionId

2017-08-30 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7896 to review the following change. Change subject: rpc: some small cleanup in ConnectionId .. rpc: some

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7884 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1173/ -- To

[Impala-ASF-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7893 To

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7872 To unsubscribe, visit

[Impala-ASF-CR] rpc: move ConnectionId to its own file

2017-08-30 Thread Sailesh Mukil (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7895 to review the following change. Change subject: rpc: move ConnectionId to its own file .. rpc: move

[Impala-ASF-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: KUDU-1865: Avoid heap allocation for payload slices .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1177/ -- To

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1174/ -- To view,

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-08-30 Thread Sailesh Mukil (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7898 to review the following change. Change subject: [security] avoid kerberos ticket renewal and only reacquire

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7872/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. IMPALA-5863: Include-what-you-use for Kudu client A recent commit in Kudu removed some unnecessary

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet.

2017-08-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). Change subject: IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet. .. IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet. Having the

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet.

2017-08-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. Change subject: IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7870/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: (3 comments) Replied via Gerrit controls.

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Patch Set 2: Good catch; generalized logic in test_tpch_nested_queries.py to change in one place "next

[Impala-ASF-CR] IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations

2017-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 5: (1 comment)

[Impala-ASF-CR] rpc: move ConnectionId to its own file

2017-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 2: Code-Review+1 > This just a back-port of e4c7c812cdef66f3ff1f87ea792d80945cbdad75, > right? Yup, that's

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: (1 comment)

[Impala-ASF-CR] rpc: move ConnectionId to its own file

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7895 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7901/1/.gitignore File .gitignore: PS1, Line 18: *.pb.h

[Impala-ASF-CR] security: only lookup hostname if HOST substitution is required

2017-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: security: only lookup hostname if _HOST substitution is required .. Patch Set 2: Code-Review+1 Clean cherry-pick. Carry +1. -- To view, visit

[Impala-ASF-CR] rpc: some small cleanup in ConnectionId

2017-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId .. Patch Set 2: Code-Review+1 Clean cherry-pick. Carry +1. -- To view, visit http://gerrit.cloudera.org:8080/7896 To

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 1: Cherry-pick wasn't clean, but the resolution was trivial. Kudu uses #ifdef

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: Code-Review+1 Conflicts in kudu/rpc/rpc-test.cc, however, they were trivial

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Updates several .gitignore files. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7902/1/.gitignore File .gitignore: PS1, Line 41:

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Patch Set 2: PS A "fgrep -i nested" of all files under tests, Testing and testdata did not turn up any

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 2: MB: Reworded summary and added testing summary. DK: Removed the str()s. I've

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new change for review. http://gerrit.cloudera.org:8080/7902 Change subject: Updates several .gitignore files. .. Updates several .gitignore files. Ran into these when compiling (generated files

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has uploaded a new patch set (#2). Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. IMPALA-5617: Rename tpch_nested query files per pattern The concurrent test driver did not pick them up

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Patch Set 1: Hi, Don't forget to use the same Change-Id when updating Gerrit reviews. This is

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7891/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has abandoned this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Abandoned Mistakenly replaced original Gerrit ID with one from new commit. -- To view, visit

[Impala-ASF-CR] rpc: move ConnectionId to its own file

2017-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 2: Code-Review+1 This just a back-port of e4c7c812cdef66f3ff1f87ea792d80945cbdad75, right? -- To view,

[Impala-ASF-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7893 To

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: > MB: Reworded summary and added testing summary. > DK: Removed the

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: Code-Review+1 Since David left comments, I'll let him finish up. -- To

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7884 To

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. IMPALA-5850: Cast sender partition exprs under unions. For a series of partitioned

[Impala-ASF-CR] security: only lookup hostname if HOST substitution is required

2017-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: security: only lookup hostname if _HOST substitution is required .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7894 To

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has uploaded a new change for review. http://gerrit.cloudera.org:8080/7899 Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. IMPALA-5617: Rename tpch_nested query files per pattern The

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-30 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 Thrift commit taken from:

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. Patch Set 5: Code-Review+2 Verified+1 Verified by a toolchain build. -- To view, visit

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Tim Wood (Code Review)
Tim Wood has uploaded a new patch set (#3). Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. IMPALA-5617: Include full workload name in tpch_nested query filenames The concurrent test

[Impala-ASF-CR] rpc: some small cleanup in ConnectionId

2017-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7896 To unsubscribe, visit

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7897 To

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: > MB: Reworded summary and added testing summary. > DK: Removed the

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7901 Change subject: IMPALA-4670: Introduces RpcMgr class .. IMPALA-4670: Introduces RpcMgr class This patch introduces a new class, RpcMgr

[Impala-ASF-CR] IMPALA-5653: Remove "unlimited" process mem limit option

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5653: Remove "unlimited" process mem_limit option .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1184/ -- To

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/7901/1//COMMIT_MSG Commit Message: Line 16: Could you

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 6: (9 comments) Still going through the comments, but I thought I'd put up some quick

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. IMPALA-5617: Include full workload name in tpch_nested query

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Updates several .gitignore files. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7902 To unsubscribe, visit

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Vuk Ercegovac (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7902 to look at the new patch set (#3). Change subject: Updates several .gitignore files. .. Updates several .gitignore

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. IMPALA-5863: Include-what-you-use for Kudu client A recent commit in Kudu removed some

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7872 To unsubscribe,

[Impala-ASF-CR] Bump Kudu version to 1c70e5d

2017-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7903 Change subject: Bump Kudu version to 1c70e5d .. Bump Kudu version to 1c70e5d Change-Id:

[Impala-ASF-CR] IMPALA-5816: xfail wildcard TLS cert tests

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5816: xfail wildcard TLS cert tests .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1183/ -- To view, visit

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-30 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7866 to look at the new patch set (#2). Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/7730/6/be/src/exec/kudu-scan-node.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/6//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-08-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7910 Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. IMPALA-5867: Fix bugs parsing 2-digit year This patch fixes several bugs

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-08-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-08-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-2810: Remove column stats restoration when altering table .. IMPALA-2810: Remove column stats restoration when altering table This patch removes most code

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 6: (2 comments) Havent looked through all the code yet but had a high level question.

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: Updates several .gitignore files. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7902/1/.gitignore File .gitignore: PS1, Line 41:

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Updates several .gitignore files. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7902/2/testdata/.gitignore File testdata/.gitignore: PS2,

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: Updates several .gitignore files. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7902/2/testdata/.gitignore File testdata/.gitignore: PS2,

[Impala-ASF-CR] Updates several .gitignore files.

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Updates several .gitignore files. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7902 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations .. Patch Set 7: Build started:

[Impala-ASF-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: KUDU-1865: Avoid heap allocation for payload slices .. KUDU-1865: Avoid heap allocation for payload slices As shown in KUDU-1865, the heap

[Impala-ASF-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 1: Build started:

[Impala-ASF-CR] rpc: some small cleanup in ConnectionId

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7896 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu version to 1c70e5d

2017-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1180/ -- To view, visit

[Impala-ASF-CR] IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations

2017-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations

2017-08-30 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7760 to look at the new patch set (#7). Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations

[Impala-ASF-CR] IMPALA-5816: xfail wildcard TLS cert tests

2017-08-30 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7908 Change subject: IMPALA-5816: xfail wildcard TLS cert tests .. IMPALA-5816: xfail wildcard TLS cert tests Wildcard support is not

  1   2   >