[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-23 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8303 to look at the new patch set (#10). Change subject: IMPALA-1575: Part 1: eagerly release query exec resources

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-23 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8196 to look at the new patch set (#9). Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ..

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 10: Code-Review+1 Carry Joe's +1 -- To view,

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8146 to look at the new patch set (#12). Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 12: (10 comments)

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 3: Feel free

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between

[Impala-ASF-CR] IMPALA-6100: increase test exchange delays timeout on slow builds

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8357 ) Change subject: IMPALA-6100: increase test_exchange_delays timeout on slow builds .. IMPALA-6100: increase

[Impala-ASF-CR] IMPALA-6100: increase test exchange delays timeout on slow builds

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8357 ) Change subject: IMPALA-6100: increase test_exchange_delays timeout on slow builds .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 9: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8146 to look at the new patch set (#13). Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 13: Code-Review+1 PS13 is a rebase -- To

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 2: (2 comments) Looks good, just a couple of things that could

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. IMPALA-5018: Error on decimal modulo or divide by zero

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-23 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Matthew Jacobs, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7822 to look at the new patch set (#6). Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6004: Fix test row filters failure on ASAN

2017-10-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 ) Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6004: Fix test row filters failure on ASAN

2017-10-23 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8358 to look at the new patch set (#2). Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN .. IMPALA-6004:

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8334 to look at the new patch set (#3). Change subject: IMPALA-6060: Check the return value of JNI exception handling functions

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 21: Verified+1 -- To

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. IMPALA-5376: Implement all

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: OK. Will take a look. -- To view, visit

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-23 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#12). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 11: (13 comments)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Vuk Ercegovac (Code Review)
Hello Michael Brown, Philip Zeyliger, Balazs Jeszenszky, Dimitris Tsirogiannis, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#12). Change subject: IMPALA-4704: Turns on client connections when local catalog

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 11: (4 comments) One more questions, looks

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-23 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6100: increase test exchange delays timeout on slow builds

2017-10-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8357 ) Change subject: IMPALA-6100: increase test_exchange_delays timeout on slow builds .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-10-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 4: (20 comments) First pass. I think

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 3: (1

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. IMPALA-4456: Address

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 12: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 2: (1 comment) The next upload does two things: 1.

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Joe McDonnell (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8350 to look at the new patch set (#3). Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat ..

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 3: (4

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-23 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

2017-10-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 9: Code-Review+1 (1 comment) This makes sense

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 6: (10 comments) Few more comments following on from the

[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac

2017-10-23 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8356 ) Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac .. Patch Set 1: > Thanks Valencia! Thanks, Tim!

[Impala-ASF-CR] IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls. .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#10). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#8). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6004: Fix test row filters failure on ASAN

2017-10-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8358 Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN .. IMPALA-6004: Fix test_row_filters failure on ASAN "Test

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 11: Michael, this uses some of the constant

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-23 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#11). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-6004: Fix test row filters failure on ASAN

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 ) Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#9). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8330 ) Change subject: IMPALA-6080: clean up table descriptor handling .. IMPALA-6080: clean up table descriptor handling * Add

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 11: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6100: increase test exchange delays timeout on slow builds

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8357 ) Change subject: IMPALA-6100: increase test_exchange_delays timeout on slow builds .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: BTW,

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8334 to look at the new patch set (#2). Change subject: IMPALA-6060: Check the return value of JNI exception handling functions

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6100: increase text exchange delays timeout on slow builds

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8357 Change subject: IMPALA-6100: increase text_exchange_delays timeout on slow builds .. IMPALA-6100: increase text_exchange_delays timeout

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Code-Review+2 After a rebase, the binaries

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 11: Code-Review+1 (4

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 11: Code-Review+1 (1 comment) BE

[Impala-ASF-CR] IMPALA-6100: increase test exchange delays timeout on slow builds

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8357 ) Change subject: IMPALA-6100: increase test_exchange_delays timeout on slow builds .. Patch Set 2: Fix type in commit msg -- To

[Impala-ASF-CR] IMPALA-6100: increase test exchange delays timeout on slow builds

2017-10-23 Thread Tim Armstrong (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8357 to look at the new patch set (#2). Change subject: IMPALA-6100: increase test_exchange_delays timeout on slow builds

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 8: (19 comments)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8267 to look at the new patch set (#11). Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding ..

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 11: -Code-Review -- To view, visit

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls. .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 8: (2 comments) Please check the latest

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, David Knupp, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8354 to look at the new patch set (#4). Change subject: IMPALA-6070: Parallel compute_table_stats.py

[Impala-ASF-CR] IMPALA-6100: increase text exchange delays timeout on slow builds

2017-10-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8357 ) Change subject: IMPALA-6100: increase text_exchange_delays timeout on slow builds .. Patch Set 1: Code-Review+2 -- To view, visit

  1   2   >