[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#12). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 12: Code-Review+2 Fix more clang-tidy issue. Keep Dan's +2 -- To view,

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#13). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 13: Code-Review+2 Fix another clang-tidy madness... -- To view, visit h

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5495: Improve error message if no impalad role is configured .. Patch Set 2: Code-Review+2 Thanks for fixing this :) -- To view, visit http://g

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 10: (11 comments) Flushing some comments. Will focus on testing next

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 12: (10 comments) http://gerrit.cloudera.org:8080/#/c/41

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 13: (15 comments) http://gerrit.cloudera.org:8080/#/c/41

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (94 comments) http://gerrit.cloudera.org:8080/#/c/4414/1//COMMIT_MSG Comm

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (14 comments) Very nice! Minor nits in the code, som

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 5: (13 comments) http://gerrit.cloudera.org:8080/#/c/4047/5/be/src/exec/kudu-table-sink.cc File b

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4144

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (23 comments) http://gerrit.cloudera.org:8080/#/c/4414/3/common/thrift/Ca

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4414/3/common/thrift/Cata

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 15: The concern that Marcel raised is also related to https://issues.cloud

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 4: (54 comments) http://gerrit.cloudera.org:8080/#/c/4414/4/common/thrift/Ca

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4327/5/testdata/datasets/tpcds/tpcds_kudu_temp

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and TPC-DS

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (15 comments) http://gerrit.cloudera.org:8080/#/c/4414/5/bin/start-impala

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#7). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (41 comments) http://gerrit.cloudera.org:8080/#/c/4414/5//COMMIT_MSG Comm

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (63 comments) Still a few minor asks to go through (e.g. add JIRA numbers

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#8). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 16: Attila, any updates on this one? Let me know if you n

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (4 comments) A few minor clarifications. http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#9). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#7). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: Code-Review+1 (2 comments) Carry Michael's +1 http://gerrit.cloudera.org:8080/#/c/4327/6/testd

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4327/6/testdata/datasets/tpcds/tpcds_kudu_templ

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4144

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 9: Code-Review+1 (9 comments) Carry mikeb's +1 for python tests. http://ger

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#10). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4327/6/testdata/datasets/tpcds/tpcds_kudu_templ

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#8). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4414/7/common/thrift/Cata

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#11). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-19 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#12). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 12: Code-Review+1 Fixed some test loading issues and modified the dropTable()

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 9: Code-Review+2 Rebase and carry MJ's +2. -- To view, visit http://gerrit.cloudera.org:8080/4327

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (13 comments) Flushing out some comments. Haven't looked at tests yet

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: Yonghyun, one minor comment on the code review the process. You don

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4414/12/fe/src/main/jav

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#13). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#10). Change subject: IMPALA-3739: Enable stress tests on Kudu

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 10: Code-Review+2 Fix data loading for Kudu tables and rebase. Carry MJ's +2. -- To view, visit h

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4144

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: I'll make a final pass at the new patch. Nice work!

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4746/4/fe/src/main/j

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4845/1/test

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 1: (8 comments) Flushing some initial comments. Still need to wrap my head around a

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/4856 Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partition

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit Messag

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/4860 Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. IMPALA-4374: Use new syntax for

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4860/1/tes

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. Patch Set 1: How come this discrepancy between Impala's and Hive's output wasn't caught

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4815/1/fe/src/main

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4860 to look at the new patch set (#2). Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 2: Code-Review+2 (1 comment) Carry MJ's +2 http://gerrit.clo

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 19: Code-Review+1 (8 comments) Minor fixes in the tests.

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for non-coverin

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4869 To unsubscribe,

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4857/2/fe/src/test/jav

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment) Just flushing out one comment. Working on the rest of the comments.

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4856/2/common/thrift/CatalogObje

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for non-coverin

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (22 comments) http://gerrit.cloudera.org:8080/#/c/4856/2/common/thrift/CatalogOb

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for non-coverin

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (19 comments) http://gerrit.cloudera.org:8080/#/c/4856/3/common/thrift/CatalogOb

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4856/3/testdata/workloads/funct

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for non-coverin

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for non-coverin

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/4856/5/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4923/1//COM

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4856/5/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 7: Code-Review+2 Fix minor data loading issue and rebase. Carry Alex's +2 -- To vi

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4856 to look at the new patch set (#7). Change subject: IMPALA-3724: Support Kudu non-covering range partitions ..

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4856 to look at the new patch set (#8). Change subject: IMPALA-3724: Support Kudu non-covering range partitions ..

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 8: Code-Review+2 Fix test issue. Rebase and carry Alex's +2 -- To view, visit http

[Impala-ASF-CR] Fix TPCH and TPCDS Kudu loading templates

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix TPCH and TPCDS Kudu loading templates .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4939 To unsubscribe,

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-04 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4856 to look at the new patch set (#9). Change subject: IMPALA-3724: Support Kudu non-covering range partitions ..

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 9: Code-Review+2 Update tests and rebase. Carry Alex's +2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5026 Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column op

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: No e2e tests with inserts yet as there seems to be an issue with Kudu wrt hand

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (25 comments) Still need to address the parser changes wrt the use of DEFAULT

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/cup/sql-pa

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 4: Changes the parser to use the DEFAULT keyword without breaking compatibility (

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-4000: Disable Sentry column-level privileges for Kudu

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu .. Patch Set 1: I don't think disabling column-level privileges is the desired behavior. Can

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-11-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4861/2/tests/metadata/test

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-11-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4861/2/tests/metadata/test

<    1   2   3   4   5   6   >