[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 2: > Thanks!Do you think I should add some code to catalog to validate the

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner * Extend

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Let me know when that build passes, and I'll submit this for GVO. -- To view, visit

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5142 Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. IMPALA-4509: Initialise Sasl-specific mutex Call sasl_set_mutex() to

[Impala-ASF-CR] IMPALA-4511: Add missing total time counter() to PFE::Exec()

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5149 Change subject: IMPALA-4511: Add missing total_time_counter() to PFE::Exec() .. IMPALA-4511: Add missing total_time_counter() to

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5095

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner * Extend

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 3: s/binary/dictionary in last comment. -- To view, visit

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 1: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-4459: Consider making ReportExecStatus() RPC execute asynchronously

2016-11-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4459: Consider making ReportExecStatus() RPC execute asynchronously .. Patch Set 1: Have you run any performance tests to see what difference this

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4893 Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410: Safer tear-down of RuntimeState * Add

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 1: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Abandoned Yeah that's weird - the Change-Id's in the wrong place. -- To view, visit

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4935 Change subject: IMPALA-3882: Simplify some query exec state locking .. IMPALA-3882: Simplify some query exec state locking

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-3882: Simplify some query exec state locking .. IMPALA-3882: Simplify some query exec state locking query_exec_state_map_lock_ is implicated in many

[Impala-ASF-CR] IMPALA-4383: Ensure plan fragment report thread is always started

2016-10-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4383: Ensure plan fragment report thread is always started .. Patch Set 1: FragmentComplete() might not be called if the fragment never completes (e.g.

[Impala-ASF-CR] IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation

2016-10-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation

2016-10-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4683/2/community.html File

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-10-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4880 Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable

[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples." .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4890 To

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/service/impala-http-handler.cc

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time'

[Impala-ASF-CR] IMPALA-4415: Fix unassigned scan range of size 1

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4907 Change subject: IMPALA-4415: Fix unassigned scan range of size 1 .. IMPALA-4415: Fix unassigned scan range of size 1

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4910 Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410: Safer tear-down of RuntimeState * Add

[Impala-ASF-CR] IMPALA-4415: Fix unassigned scan range of size 1

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4415: Fix unassigned scan range of size 1 .. Patch Set 1: (2 comments) Started a GVO, but won't commit until I know that one of the Local / S3 builds

[Impala-ASF-CR] IMPALA-4415: Fix unassigned scan range of size 1

2016-11-01 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4907 to look at the new patch set (#2). Change subject: IMPALA-4415: Fix unassigned scan range of size 1 ..

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File

[Impala-ASF-CR] IMPALA-4314: Standardize on MT-related data structures

2016-10-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4314: Standardize on MT-related data structures .. Patch Set 3: Code-Review+1 (4 comments) Looked at .cc / .thrift only.

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#12). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#11). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 15: Code-Review+2 Rebase, carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#16). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#17). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#20). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#21). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 21: Rebase. Carry +2. Fixed a bug in test_hs2::test_get_log where the test

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4736 Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. IMPALA-2905: Move QueryResultSet

[Impala-ASF-CR] review comments 1

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4735 Change subject: review comments 1 .. review comments 1 Change-Id: I3d1094dffd6b0341f8554283c3b77c6a970ca7ec --- M

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html File bylaws.html: PS1, Line

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2916: Add warning to query profile if debug build .. Patch Set 1: (2 comments) This will be useful to have.

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 8: Code-Review+1 (11 comments)

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. IMPALA-4608: Fix fragment completion times for INSERTs Fix a bug where completion times weren't

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5418 Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. IMPALA-4608: Fix fragment completion times for INSERTs Fix a

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5418 to look at the new patch set (#3). Change subject: IMPALA-4608: Fix fragment completion times for INSERTs ..

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 4: Code-Review+2 (1 comment) Rebase, carry +2

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 5: Code-Review+2 Rebase past IMPALA-4628 fix -- To view, visit

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc File

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5394 Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. IMPALA-4613: Make sure timers are finished

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. IMPALA-4613: Make sure timers are finished before sending report profile

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-07 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. IMPALA-4613: Make sure timers are finished before sending report profile

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc File

[Impala-ASF-CR] IMPALA-4648: remove build thirdparty.sh

2016-12-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4648: remove build_thirdparty.sh .. Patch Set 1: Code-Review+2 Excellent. -- To view, visit http://gerrit.cloudera.org:8080/5477 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. Patch Set 2: I'd like it removed, but I'm fine if we do that as a follow-on patch. -- To

[Impala-ASF-CR] IMPALA-4650: Allow protobuf to find non-system libraries and binaries

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries .. IMPALA-4650: Allow protobuf to find non-system libraries and binaries This

[Impala-ASF-CR] IMPALA-4650: Add Protobuf to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4650: Add Protobuf to build .. IMPALA-4650: Add Protobuf to build This patch adds Protobuf 2.6.1 to Impala's build, and bumps the toolchain

[Impala-ASF-CR] IMPALA-4650: Add Protobuf to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4650: Add Protobuf to build .. Patch Set 2: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5657 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC This

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5720 Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. IMPALA-4670 / IMPALA-4672: Add RpcMgr

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Copy kudu/util from commit e1f68b8

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5714 Change subject: IMPALA-4669: [KUTIL] Copy kudu/util from commit e1f68b8 .. IMPALA-4669: [KUTIL] Copy kudu/util from commit e1f68b8

[Impala-ASF-CR] IMPALA-4669: [KRPC] Import kudu/rpc from commit e1f68b8

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5718 Change subject: IMPALA-4669: [KRPC] Import kudu/rpc from commit e1f68b8 .. IMPALA-4669: [KRPC] Import kudu/rpc from commit e1f68b8

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5719 Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kutil library to the build.

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5715 Change subject: IMPALA-4669: [KUTIL] Add kutil library to the build. .. IMPALA-4669: [KUTIL] Add kutil library to the build. A few

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5717 Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build One

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add Kudu security library from commit e1f68b8

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5716 Change subject: IMPALA-4669: [SECURITY] Add Kudu security library from commit e1f68b8 .. IMPALA-4669: [SECURITY] Add Kudu security

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5656 Change subject: Add Kudu cmake utilities .. Add Kudu cmake utilities This commit imports some CMake utility methods from Kudu, in

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5659 Change subject: IMPALA-4651: Add LibEv to build .. IMPALA-4651: Add LibEv to build Add libev 4.20 to the Impala build. This is a

[Impala-ASF-CR] IMPALA-4650: Add Protobuf to build

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5657 Change subject: IMPALA-4650: Add Protobuf to build .. IMPALA-4650: Add Protobuf to build This patch adds Protobuf 2.6.1 to Impala's

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5660 Change subject: IMPALA-4652: Add crcutil to build .. IMPALA-4652: Add crcutil to build Add crcutil, built from a git hash since there

[Impala-ASF-CR] IMPALA-4650: Allow protobuf to find non-system libraries and binaries

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5658 Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries .. IMPALA-4650: Allow protobuf to find

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5656 to look at the new patch set (#3). Change subject: Add Kudu cmake utilities .. Add Kudu cmake utilities This

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 3: Code-Review+2 Verified+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5660 To unsubscribe,

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment .. IMPALA-4036: invalid SQL generated for partitioned table with comment For a

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5648 To

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4651: Add LibEv to build .. IMPALA-4651: Add LibEv to build Add libev 4.20 to the Impala build. This is a dependency of KRPC. FindLibEv.cmake

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5659 To unsubscribe, visit

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5656/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 17:

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: Add Kudu cmake utilities .. Add Kudu cmake utilities This commit imports some CMake utility methods from Kudu, in preparation for adding KRPC and its

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: Why can't this be fixed on the consumer side? Stripping out leading and trailing white

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5686 To

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5660/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4652: Add

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5659/1//COMMIT_MSG Commit Message: Line 9: Add libev 4.20 to

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5660 to look at the new patch set (#2). Change subject: IMPALA-4652: Add crcutil to build .. IMPALA-4652: Add crcutil

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5659 to look at the new patch set (#2). Change subject: IMPALA-4651: Add LibEv to build .. IMPALA-4651: Add LibEv to

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017)

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5687 Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017) .. IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede

[Impala-ASF-CR] IMPALA-3875: Thrift threaded server hang in some cases

2016-12-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3875: Thrift threaded server hang in some cases .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5263 To unsubscribe,

[Impala-ASF-CR] IMPALA-3875: Thrift threaded server hang in some cases

2016-12-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3875: Thrift threaded server hang in some cases .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4580: Fix crash with FETCH FIRST when #rows < result cache size

2016-12-02 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5335 Change subject: IMPALA-4580: Fix crash with FETCH_FIRST when #rows < result cache size .. IMPALA-4580: Fix crash with FETCH_FIRST when

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 6: (11 comments) Some more comments about the refcounting, many in response to yours.

[Impala-ASF-CR] IMPALA-4580: Fix crash with FETCH FIRST when #rows < result cache size

2016-12-02 Thread Henry Robinson (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5335 to look at the new patch set (#2). Change subject: IMPALA-4580: Fix crash with FETCH_FIRST when #rows < result cache size

<    1   2   3   4   5   6   7   8   9   >