[kudu-CR] WIP [catalog manager] added 3-4-3 behavior

2017-11-21 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8619 to look at the new patch set (#3). Change subject: WIP [catalog_manager] added 3-4-3 behavior

[kudu-CR](branch-1.3.x) [security] test and fixes for TLS socket EINTR issues

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8599 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. [security] test and fixes for TLS socket EINTR issues

[kudu-CR](branch-1.3.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8600 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. KUDU-2218. tls_socket: properly

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8602 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. KUDU-2218. tls_socket: properly

[kudu-CR](branch-1.3.x) [security] test and fixes for TLS socket EINTR issues

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8599 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.3.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8600 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR](branch-1.4.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8602 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR](branch-1.4.x) [security] test and fixes for TLS socket EINTR issues

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8601 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.4.x) [security] test and fixes for TLS socket EINTR issues

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8601 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. [security] test and fixes for TLS socket EINTR issues

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 9: Code-Review+2 Carrying forward Mike's +2 -- To view,

[kudu-CR] handle disk failures during tablet copies

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7654 ) Change subject: handle disk failures during tablet copies .. handle disk failures during tablet copies There are two components

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8606 ) Change subject: tablet: add early returns to maintenance functions .. tablet: add early returns to maintenance functions When a

[kudu-CR] tablet: make various update paths atomic

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. tablet: make various update paths atomic A few codepaths in the

[kudu-CR](branch-1.5.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8604 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR](branch-1.5.x) KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8604 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. KUDU-2218. tls_socket: properly

[kudu-CR](branch-1.5.x) [security] test and fixes for TLS socket EINTR issues

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8603 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) [security] test and fixes for TLS socket EINTR issues

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8603 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. [security] test and fixes for TLS socket EINTR issues

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 11: (2 comments)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 12: Code-Review+2 -- To view, visit

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8606 ) Change subject: tablet: add early returns to maintenance functions .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] handle disk failures during tablet copies

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7654 ) Change subject: handle disk failures during tablet copies .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] tablet: remove ignore result in ApplyRowOperation

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8620 ) Change subject: tablet: remove ignore_result in ApplyRowOperation .. tablet: remove ignore_result in ApplyRowOperation

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7442 to look at the new patch set (#11). Change subject: shutdown tablets on disk failure at runtime

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 10: (15 comments)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 12: (2 comments)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#12). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] tablet: make various update paths atomic

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 14: Code-Review+2 -- To view, visit

[kudu-CR] tablet: remove ignore result in ApplyRowOperation

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8620 ) Change subject: tablet: remove ignore_result in ApplyRowOperation .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] tablet: remove ignore result in ApplyRowOperation

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8620 ) Change subject: tablet: remove ignore_result in ApplyRowOperation .. Patch Set 4: fixed iwyu and rebased. -- To view, visit

[kudu-CR] tablet: remove ignore result in ApplyRowOperation

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8620 to look at the new patch set (#4). Change subject: tablet: remove ignore_result in ApplyRowOperation

[kudu-CR] tablet: remove ignore result in ApplyRowOperation

2017-11-21 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8620 to look at the new patch set (#3). Change subject: tablet: remove ignore_result in ApplyRowOperation

[kudu-CR] ntp: dump diagnostics when NTP is unsynchronized or error is too high

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8557 ) Change subject: ntp: dump diagnostics when NTP is unsynchronized or error is too high .. ntp: dump diagnostics when NTP is

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8627 ) Change subject: schema: fast-path for Schema::KeyEquals, etc. .. schema: fast-path for Schema::KeyEquals, etc. If two schemas

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. Patch Set 1: (1 comment)

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. Patch Set 1: (1 comment)

[kudu-CR] WIP [catalog manager] added 3-4-3 behavior

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 ) Change subject: WIP [catalog_manager] added 3-4-3 behavior .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-2222. update scan delta compact-test: increase write timeout

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8628 ) Change subject: KUDU-. update_scan_delta_compact-test: increase write timeout .. KUDU-. update_scan_delta_compact-test:

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Add a test for data consistency after stopping tablets

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. Patch Set 1: (1 comment)

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: Verified+1 Code-Review+2 Build failure was caused

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: Add a test for data consistency after stopping tablets .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8618 To

[kudu-CR] ntp: dump diagnostics when NTP is unsynchronized or error is too high

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8557 ) Change subject: ntp: dump diagnostics when NTP is unsynchronized or error is too high .. Patch Set 5: Code-Review+2 -- To view,

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 ) Change subject: schema: fast-path for Schema::KeyEquals, etc. .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

2017-11-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8627 to look at the new patch set (#2). Change subject: schema: fast-path for Schema::KeyEquals, etc. ..

[kudu-CR] schema: fast-path for Schema::KeyEquals

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 ) Change subject: schema: fast-path for Schema::KeyEquals .. Patch Set 1: (1 comment)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 39: Code-Review+2 -- To view, visit

[kudu-CR] ntp: dump diagnostics when NTP is unsynchronized or error is too high

2017-11-21 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8557 to look at the new patch set (#5). Change subject: ntp: dump diagnostics when NTP is unsynchronized or error

[kudu-CR] ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8557 ) Change subject: ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2222. update scan delta compact-test: increase write timeout

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8628 ) Change subject: KUDU-. update_scan_delta_compact-test: increase write timeout .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] schema: fast-path for Schema::KeyEquals

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 ) Change subject: schema: fast-path for Schema::KeyEquals .. Patch Set 1: (1 comment)

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. Patch Set 1: (1 comment)

[kudu-CR] ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8557 ) Change subject: ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high .. Patch Set 4: (7 comments)

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. Patch Set 1: (1 comment)

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. Patch Set 1: (1 comment)

[kudu-CR] schema: fast-path for Schema::KeyEquals

2017-11-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8627 to review the following change. Change subject: schema: fast-path for Schema::KeyEquals .. schema: fast-path for

[kudu-CR] KUDU-2222. update scan delta compact-test: increase write timeout

2017-11-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8628 to review the following change. Change subject: KUDU-. update_scan_delta_compact-test: increase write timeout

[kudu-CR] ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high

2017-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8557 ) Change subject: ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high .. Patch Set 4: (7 comments) overall looks

[kudu-CR] WIP [catalog manager] added 3-4-3 behavior

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 ) Change subject: WIP [catalog_manager] added 3-4-3 behavior .. Patch Set 2: (6 comments)

[kudu-CR] [java] Add ReplicaSelection in KuduScanToken

2017-11-21 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8559 ) Change subject: [java] Add ReplicaSelection in KuduScanToken .. [java] Add ReplicaSelection in KuduScanToken This patch adds

[kudu-CR] consensus: Add gflag to enable 3-4-3 re-replication

2017-11-21 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8626 to review the following change. Change subject: consensus: Add gflag to enable 3-4-3 re-replication .. consensus:

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: (1 comment)

[kudu-CR] WIP [catalog manager] added 3-4-3 behavior

2017-11-21 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8619 to look at the new patch set (#2). Change subject: WIP [catalog_manager] added 3-4-3 behavior

[kudu-CR] KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8617 ) Change subject: KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics .. KUDU-2165 workaround: avoid TSAN warnings on

[kudu-CR] KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8617 ) Change subject: KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics .. Patch Set 4: Verified+1 Unrelated race -- To view, visit

[kudu-CR] KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

2017-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8617 To

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 39: Code-Review+2 -- To view, visit

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#39). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 39: Fixed IWYU + the build failure was KUDU- -- To

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8606 ) Change subject: tablet: add early returns to maintenance functions .. Patch Set 8: Code-Review+2 (1 comment)

[kudu-CR] tablet: make various update paths atomic

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] tablet: remove ignore result in ApplyRowOperation

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8620 ) Change subject: tablet: remove ignore_result in ApplyRowOperation .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] handle disk failures during tablet copies

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7654 ) Change subject: handle disk failures during tablet copies .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 7: (2 comments)

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8606 ) Change subject: tablet: add early returns to maintenance functions .. Patch Set 8: (1 comment)

[kudu-CR] tablet: make various update paths atomic

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#13). Change subject: tablet: make various update paths atomic

[kudu-CR] tablet: make various update paths atomic

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: tablet: make various update paths atomic .. Patch Set 13: (1 comment)

[kudu-CR] tablet: add early returns to maintenance functions

2017-11-21 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8606 to look at the new patch set (#8). Change subject: tablet: add early returns to maintenance functions

[kudu-CR] handle disk failures during tablet copies

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7654 ) Change subject: handle disk failures during tablet copies .. Patch Set 8: (1 comment)

[kudu-CR] handle disk failures during tablet copies

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7654 to look at the new patch set (#8). Change subject: handle disk failures during tablet copies

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-21 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8605 to look at the new patch set (#7). Change subject: tablet: mark delta tracker read-only on error

[kudu-CR] KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8617 ) Change subject: KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: (1 comment)

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: (1 comment)

[kudu-CR] Add a test for data consistency after stopping tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 ) Change subject: Add a test for data consistency after stopping tablets .. Patch Set 3: (2 comments)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 38: Code-Review+2 -- To view, visit

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 38: (1 comment)

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#38). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: tablet: introduce closed mvcc and stopped tablets .. Patch Set 37: (1 comment) looks good

[kudu-CR] tablet: introduce closed mvcc and stopped tablets

2017-11-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#37). Change subject: tablet: introduce closed mvcc and stopped tablets

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2017-11-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8585 ) Change subject: [spark] add 'local-cluster' mode for unit test .. Patch Set 1: I pointed SPARK_HOME at the unpacked release tarball

[kudu-CR] KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

2017-11-21 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8617 to look at the new patch set (#4). Change subject: KUDU-2165 workaround: avoid TSAN warnings on CacheMetrics

[kudu-CR] [java] Add ReplicaSelection in KuduScanToken

2017-11-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 ) Change subject: [java] Add ReplicaSelection in KuduScanToken .. Patch Set 2: Code-Review+2 Looks good. Are you going to add support to

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2017-11-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8585 ) Change subject: [spark] add 'local-cluster' mode for unit test .. Patch Set 1: > (5 comments) > > I wasn't able to get the tests to run on

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2017-11-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8585 ) Change subject: [spark] add 'local-cluster' mode for unit test .. Patch Set 1: (5 comments) I wasn't able to get the tests to run on my

[kudu-CR] KUDU-1454 [part 2]: enable scan locality for Spark

2017-11-21 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8560 ) Change subject: KUDU-1454 [part 2]: enable scan locality for Spark .. KUDU-1454 [part 2]: enable scan locality for Spark This

  1   2   >