[kudu-CR] [tool-test] scenario for ksck and unusual tserver flags

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13380 ) Change subject: [tool-test] scenario for ksck and unusual tserver flags .. Patch Set 2: Verified+1 unrelated failures in: *

[kudu-CR] [tool-test] scenario for ksck and unusual tserver flags

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13380 ) Change subject: [tool-test] scenario for ksck and unusual tserver flags .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [tool] update type of loadgen's --num rows per thread flag

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13373 ) Change subject: [tool] update type of loadgen's --num_rows_per_thread flag .. Patch Set 2: (1 comment)

[kudu-CR] [tool] update type of loadgen's --num rows per thread flag

2019-05-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13373 to look at the new patch set (#3). Change subject: [tool] update type of loadgen's --num_rows_per_thread flag

[kudu-CR] Allow alter legacy tables in Hive Metastore Kudu plugin

2019-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13317 ) Change subject: Allow alter legacy tables in Hive Metastore Kudu plugin .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [tool-test] scenario for ksck and unusual tserver flags

2019-05-21 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13380 to look at the new patch set (#2). Change subject: [tool-test] scenario for ksck and unusual tserver flags

[kudu-CR] [java] Fix TestHybridTime

2019-05-21 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13397 Change subject: [java] Fix TestHybridTime .. [java] Fix TestHybridTime TestHybridTime tests client propagated timestamps when

[kudu-CR] hms: fix flakiness of master-stress-test from managed tables

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13384 ) Change subject: hms: fix flakiness of master-stress-test from managed tables .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 30: (2 comments)

[kudu-CR] [tool-test] scenario for ksck and unusual tserver flags

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13380 ) Change subject: [tool-test] scenario for ksck and unusual tserver flags .. Patch Set 1: (1 comment)

[kudu-CR] [backup] Add a basic CLI tool

2019-05-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13356 ) Change subject: [backup] Add a basic CLI tool .. Patch Set 4: Looks good. Can you add a simple unit test to just verify that the tool

[kudu-CR] [tools] a small cleanup on ksck code

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13379 ) Change subject: [tools] a small cleanup on ksck code .. [tools] a small cleanup on ksck code Change-Id:

[kudu-CR] Change all dependency sources to https

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 ) Change subject: Change all dependency sources to https .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Support priorities for tables in MM compaction .. Patch Set 7: Verified+1 Failures look unrelated. -- To

[kudu-CR] [doc] Update the doc of AsyncKuduClient

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13389 ) Change subject: [doc] Update the doc of AsyncKuduClient .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] [doc] Update the doc of AsyncKuduClient

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13389 ) Change subject: [doc] Update the doc of AsyncKuduClient .. Patch Set 1: Verified+1 Code-Review+2 Failures are unrelated. -- To view,

[kudu-CR] [doc] Update the doc of AsyncKuduClient

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13389 ) Change subject: [doc] Update the doc of AsyncKuduClient .. [doc] Update the doc of AsyncKuduClient Remove MasterErrorException

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Support priorities for tables in MM compaction .. Patch Set 7: Code-Review+2 Carrying forward Will's +2.

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Support priorities for tables in MM compaction .. [maintenance] Support priorities for tables in MM

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Support priorities for tables in MM compaction .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] hms: fix flakiness of master-stress-test from managed tables

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13384 ) Change subject: hms: fix flakiness of master-stress-test from managed tables .. Patch Set 1: (1 comment) Looks like the patch this one

[kudu-CR] [tool-test] scenario for ksck and unusual tserver flags

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13380 ) Change subject: [tool-test] scenario for ksck and unusual tserver flags .. Patch Set 1: Code-Review+2 (2 comments)

[kudu-CR] [tools] a small cleanup on ksck code

2019-05-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13379 ) Change subject: [tools] a small cleanup on ksck code .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 ) Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. Patch Set 1: (2 comments)

[kudu-CR] Allow alter legacy tables in Hive Metastore Kudu plugin

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13317 ) Change subject: Allow alter legacy tables in Hive Metastore Kudu plugin .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 ) Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 ) Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. Patch Set 1: > It can be in a follow up, but can you add a test

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 ) Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. Patch Set 1: Verified+1 Unrelated flaky test. -- To view,

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13387 To

[kudu-CR] [backup] Add a basic CLI tool

2019-05-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13356 ) Change subject: [backup] Add a basic CLI tool .. Patch Set 3: Done. Need to test out on a real cluster (we lost the one where i had a

[kudu-CR] [backup] Add a basic CLI tool

2019-05-21 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13356 to look at the new patch set (#4). Change subject: [backup] Add a basic CLI tool

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13381 ) Change subject: hms: synchronize column comments to the HMS .. hms: synchronize column comments to the HMS This patch ensures

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: hms: synchronize column comments to the HMS .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13381 To unsubscribe,

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13381 ) Change subject: hms: synchronize column comments to the HMS .. Patch Set 3: Verified+1 -- To view, visit

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13381 ) Change subject: hms: synchronize column comments to the HMS .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Change all dependency sources to https

2019-05-21 Thread Attila Bukor (Code Review)
Hello Mike Percy, Dan Burkert, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13390 to review the following change. Change subject: Change all dependency sources to https

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13381 to look at the new patch set (#3). Change subject: hms: synchronize column comments to the HMS

[kudu-CR] Allow alter legacy tables in Hive Metastore Kudu plugin

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13317 ) Change subject: Allow alter legacy tables in Hive Metastore Kudu plugin .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 30: This patch looks good to me, I think we just need to

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13381 ) Change subject: hms: synchronize column comments to the HMS .. Patch Set 1: (3 comments)

[kudu-CR] hms: synchronize column comments to the HMS

2019-05-21 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13381 to look at the new patch set (#2). Change subject: hms: synchronize column comments to the HMS

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 29: (1 comment)

[kudu-CR] [backup] Publish the backup jars in the next release

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13359 ) Change subject: [backup] Publish the backup jars in the next release .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [backup] Publish the backup jars in the next release

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [backup] Publish the backup jars in the next release .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13359 To

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 ) Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. Patch Set 1: Code-Review+1 It can be in a follow up, but

[kudu-CR] [util] Support for entity type/id/attrs/metrics filtering in metrics

2019-05-21 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13376 to look at the new patch set (#3). Change subject: [util] Support for entity type/id/attrs/metrics filtering in metrics

[kudu-CR] [doc] Update the doc of AsyncKuduClient

2019-05-21 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13389 Change subject: [doc] Update the doc of AsyncKuduClient .. [doc] Update the doc of AsyncKuduClient Remove MasterErrorException in doc.

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Support priorities for tables in MM compaction .. Patch Set 7: > Patch Set 6: Code-Review+2 > > (2

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Support priorities for tables in MM compaction .. Patch Set 7: (2 comments)

[kudu-CR] [maintenance] Support priorities for tables in MM compaction

2019-05-21 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12852 to look at the new patch set (#7). Change subject: [maintenance] Support priorities for tables in MM compaction

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-05-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Patch Set 10: (18 comments) Well, it seems that the failure of jenkins

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-05-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Patch Set 10: Well, it seems that the failure of jenkins is not caused

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-05-21 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#10). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] replace nvml with memkind

2019-05-21 Thread ye yuqiang (Code Review)
ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 ) Change subject: replace nvml with memkind .. Patch Set 9: > > The TSAN version of client_symbol-test failed with: > > > > Found bad

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-05-21 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#9). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-05-21 Thread Yao Xu (Code Review)
Yao Xu has abandoned this change. ( http://gerrit.cloudera.org:8080/13388 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13388 To unsubscribe,

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-05-21 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13388 Change subject: KUDU-2514 Part 1: Support extra config for table. .. KUDU-2514 Part 1: Support extra config for table. We have thousands of

[kudu-CR] Allow alter legacy tables in Hive Metastore Kudu plugin

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13317 ) Change subject: Allow alter legacy tables in Hive Metastore Kudu plugin .. Patch Set 6: (1 comment)

[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin

2019-05-21 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13387 Change subject: hms: allow skip validation in Hive Metastore Kudu plugin .. hms: allow skip validation in Hive Metastore Kudu plugin This

[kudu-CR] hms: fix flakiness of master-stress-test from managed tables

2019-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13384 ) Change subject: hms: fix flakiness of master-stress-test from managed tables .. Patch Set 1: (3 comments)