[kudu-CR] [txns][tools] add a state filter to `txns list` tool

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17371 ) Change subject: [txns][tools] add a state filter to `txns list` tool .. Patch Set 4: (1 comment)

[kudu-CR] [txns][tools] tool to list transactions

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 ) Change subject: [txns][tools] tool to list transactions .. Patch Set 5: (1 comment)

[kudu-CR] [tests] fix a few typos in comments

2021-05-03 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17394 ) Change subject: [tests] fix a few typos in comments .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Hongjiang Zhang (Code Review)
Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Management of per-table level limit .. Patch Set 36: (2 comments)

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Hongjiang Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17273 to look at the new patch set (#36). Change subject: KUDU-3223: Management of per-table level limit

[kudu-CR] [tests] fix a few typos in comments

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17394 Change subject: [tests] fix a few typos in comments .. [tests] fix a few typos in comments This patch does not contain any functional

[kudu-CR] KUDU-3273: check null for cache entry

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17288 ) Change subject: KUDU-3273: check null for cache entry .. Patch Set 5: Code-Review+1 (8 comments) Thank you for the patch! I

[kudu-CR] KUDU-2612: update C++ client API to commit a transaction

2021-05-03 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17392 to look at the new patch set (#3). Change subject: KUDU-2612: update C++ client API to commit a transaction

[kudu-CR] KUDU-2612: update Java client API to commit a transaction

2021-05-03 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17393 to look at the new patch set (#2). Change subject: KUDU-2612: update Java client API to commit a transaction

[kudu-CR] [txns][tools] tool to list transactions

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 ) Change subject: [txns][tools] tool to list transactions .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] [txns][tools] tool to list transactions

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 ) Change subject: [txns][tools] tool to list transactions .. Patch Set 5: (9 comments) Took a quick look over the patch. Overall

[kudu-CR] KUDU-2612: update Java client API to commit a transaction

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17393 Change subject: KUDU-2612: update Java client API to commit a transaction .. KUDU-2612: update Java client API to commit a transaction

[kudu-CR] [txns][tools] tool to list transactions

2021-05-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17370 to look at the new patch set (#5). Change subject: [txns][tools] tool to list transactions .. [txns][tools] tool

[kudu-CR] [txns][tools] add a state filter to `txns list` tool

2021-05-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17371 to look at the new patch set (#4). Change subject: [txns][tools] add a state filter to `txns list` tool

[kudu-CR] KUDU-2612: update C++ client API to commit a transaction

2021-05-03 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17392 to look at the new patch set (#2). Change subject: KUDU-2612: update C++ client API to commit a transaction

[kudu-CR] [docs] Fix doxygen build

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17390 ) Change subject: [docs] Fix doxygen build .. [docs] Fix doxygen build Error in doxygen build due to incorrect function

[kudu-CR] [docs] Fix doxygen build

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17390 ) Change subject: [docs] Fix doxygen build .. Patch Set 1: > I know Alexey is also in the area addressing feedback on the API. Yep,

[kudu-CR] [docs] Fix doxygen build

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17390 ) Change subject: [docs] Fix doxygen build .. Patch Set 1: Code-Review+2 Thank you for fixing these! -- To view, visit

[kudu-CR] KUDU-2612: update C++ client API to commit a transaction

2021-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17392 Change subject: KUDU-2612: update C++ client API to commit a transaction .. KUDU-2612: update C++ client API to commit a transaction

[kudu-CR] [docs] Fix doxygen build

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17390 ) Change subject: [docs] Fix doxygen build .. Patch Set 1: Code-Review+2 I know Alexey is also in the area addressing feedback on the

[kudu-CR] wip [txns][tools] show details of a transaction

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17391 Change subject: wip [txns][tools] show details of a transaction .. wip [txns][tools] show details of a transaction This adds a tool to

[kudu-CR] [txns][tools] tool to list transactions

2021-05-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17370 to look at the new patch set (#4). Change subject: [txns][tools] tool to list transactions .. [txns][tools] tool

[kudu-CR] [txns][tools] add a state filter to `txns list` tool

2021-05-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17371 to look at the new patch set (#3). Change subject: [txns][tools] add a state filter to `txns list` tool

[kudu-CR] [docs] Fix doxygen build

2021-05-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17390 Change subject: [docs] Fix doxygen build .. [docs] Fix doxygen build Error in doxygen build due to incorrect function parameters.

[kudu-CR] [util] Add special handling for empty strings in FastHash

2021-05-03 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17376 to look at the new patch set (#4). Change subject: [util] Add special handling for empty strings in FastHash

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Management of per-table level limit .. Patch Set 35: (2 comments)

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: (3 comments)

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: (1 comment)

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: Will change the commit message

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-03 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17388 Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. [backup] KUDU-3183 Add tablePrefix option to

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Hongjiang Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17273 to look at the new patch set (#35). Change subject: KUDU-3223: Management of per-table level limit

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Hongjiang Zhang (Code Review)
Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Management of per-table level limit .. Patch Set 34: (11 comments)

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Hongjiang Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17273 to look at the new patch set (#34). Change subject: KUDU-3223: Management of per-table level limit

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-03 Thread Hongjiang Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17273 to look at the new patch set (#33). Change subject: KUDU-3223: Management of per-table level limit