[kudu-CR] [iwyu] modernize stdlib/stdint header files

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17602 ) Change subject: [iwyu] modernize stdlib/stdint header files .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [tools] add --row count only and --report scanner stats flags

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17598 ) Change subject: [tools] add --row_count_only and --report_scanner_stats flags .. Patch Set 3: Code-Review+2 -- To view, visit http://ge

[kudu-CR] [tools] tooling to set/clear table comments

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17600 Change subject: [tools] tooling to set/clear table comments .. [tools] tooling to set/clear table comments This patch introduces the 'kud

[kudu-CR] [k8s] Implement an operator for a KuduCluster CRD

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17566 ) Change subject: [k8s] Implement an operator for a KuduCluster CRD .. Patch Set 1: (27 comments) Thanks for the contribution! Most of my

[kudu-CR] [tools] add --row count only and --report scanner stats flags

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17598 ) Change subject: [tools] add --row_count_only and --report_scanner_stats flags .. Patch Set 2: Code-Review+2 -- To view, visit http://ge

[kudu-CR] [tools] add --row count only and --report scanner stats flags

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17598 ) Change subject: [tools] add --row_count_only and --report_scanner_stats flags .. Patch Set 2: (1 comment) Neat addition! Though it look

[kudu-CR] [tools] use --timeout ms in tablet scanner

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17597 ) Change subject: [tools] use --timeout_ms in tablet_scanner .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 12: (1 comment) http://gerrit.clouder

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. [consensus] KUDU-2302: don't crash if new

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17584 ) Change subject: [util] flag to specify hosts to fail DNS resolution .. [util] flag to specify hosts to fail DNS resolution This

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#11). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 10: (1 comment) http://gerrit.clouder

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 9: (1 comment) http://gerrit.cloudera

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#10). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#9). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ..

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#8). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ..

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#7). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ..

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 6: (2 comments) http://gerrit.clouder

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#6). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ..

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17584 ) Change subject: [util] flag to specify hosts to fail DNS resolution .. Patch Set 3: Verified+1 (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [util] flag to specify hosts to fail DNS resolution .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17584 To unsubscrib

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 5: (3 comments) http://gerrit.clouder

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-11 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17584 to look at the new patch set (#3). Change subject: [util] flag to specify hosts to fail DNS resolution .

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#5). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 4: (2 comments) http://gerrit.clouder

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#4). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ...

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 ) Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. Patch Set 3: (1 comment) http://gerrit.cloudera

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17584 ) Change subject: [util] flag to specify hosts to fail DNS resolution .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/175

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17584 to look at the new patch set (#2). Change subject: [util] flag to specify hosts to fail DNS resolution

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#3). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ...

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17585 to look at the new patch set (#2). Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer

[kudu-CR] [consensus] KUDU-2302: don't crash if new leader can't resolve peer

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17585 Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer .. [consensus] KUDU-2302: don't crash if new leader c

[kudu-CR] [util] flag to specify hosts to fail DNS resolution

2021-06-11 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17584 Change subject: [util] flag to specify hosts to fail DNS resolution .. [util] flag to specify hosts to fail DNS resolution This patch add

[kudu-CR](branch-1.15.x) docs: use PNG instead of SVG for image

2021-06-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17579 ) Change subject: docs: use PNG instead of SVG for image .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] docs: use PNG instead of SVG for image

2021-06-10 Thread Andrew Wong (Code Review)
Hello Grant Henke, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17578 to review the following change. Change subject: docs: use PNG instead of SVG for image .. docs: use P

[kudu-CR] [docker] Add support for publishing UBI based runtime images

2021-06-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 ) Change subject: [docker] Add support for publishing UBI based runtime images .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cl

[kudu-CR] [docker] Add support for publishing UBI based runtime images

2021-06-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 ) Change subject: [docker] Add support for publishing UBI based runtime images .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:80

[kudu-CR] consensus: make some methods void

2021-06-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17565 ) Change subject: consensus: make some methods void .. consensus: make some methods void Some methods never returned anything but

[kudu-CR] [docker] Add support for publishing UBI based runtime images

2021-06-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 ) Change subject: [docker] Add support for publishing UBI based runtime images .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cl

[kudu-CR] consensus: make some methods void

2021-06-08 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17565 to review the following change. Change subject: consensus: make some methods void .. consensus: mak

[kudu-CR] [docker] Add support for publishing UBI based runtime images

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 ) Change subject: [docker] Add support for publishing UBI based runtime images .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [docker] Add support for publishing UBI based runtime images

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 ) Change subject: [docker] Add support for publishing UBI based runtime images .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [docker] Add support for publishing UBI based runtime images

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 ) Change subject: [docker] Add support for publishing UBI based runtime images .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:80

[kudu-CR](branch-1.15.x) [client] replace Equals() with operator==()

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17563 ) Change subject: [client] replace Equals() with operator==() .. Patch Set 1: Code-Review+2 LGTM but will defer to Bankim. -- To view, v

[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17562 ) Change subject: [test] make new scenario in security-itest more robust .. Patch Set 1: Verified+1 Code-Review+2 LGTM but will defer to B

[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [test] make new scenario in security-itest more robust .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17562 To unsubsc

[kudu-CR](branch-1.15.x) [docs] Add release notes for 1.15.0 release

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17539 ) Change subject: [docs] Add release notes for 1.15.0 release .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR](branch-1.15.x) KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17561 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. KUDU-3291: properly disambig

[kudu-CR] [test] make new scenario in security-itest more robust

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17559 ) Change subject: [test] make new scenario in security-itest more robust .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR](branch-1.15.x) [docs] Add release notes for 1.15.0 release

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17539 ) Change subject: [docs] Add release notes for 1.15.0 release .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17539/5/doc

[kudu-CR](branch-1.15.x) KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17561 Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. KUDU-3291: properly disambiguate betw

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. KUDU-3291: properly disambig

[kudu-CR] [test] make new scenario in security-itest more robust

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17559 ) Change subject: [test] make new scenario in security-itest more robust .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.clouder

[kudu-CR] [client] replace Equals() with operator==()

2021-06-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17558 ) Change subject: [client] replace Equals() with operator==() .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Patch Set 4: Verified+1 Test failur

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17547 to look at the new patch set (#4). Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timesta

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Patch Set 3: (8 comments) http://g

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-06 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17547 to look at the new patch set (#3). Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timesta

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-06 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17547 to look at the new patch set (#2). Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timesta

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17547 Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. KUDU-3291: properly disambiguate betw

[kudu-CR](branch-1.15.x) [docs] Add release notes for 1.15.0 release

2021-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17539 ) Change subject: [docs] Add release notes for 1.15.0 release .. Patch Set 4: Code-Review+2 LGTM! Ditto to getting more confirmation from

[kudu-CR](branch-1.15.x) [docs] Add release notes for 1.15.0 release

2021-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17539 ) Change subject: [docs] Add release notes for 1.15.0 release .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17539/2/do

[kudu-CR](branch-1.15.x) KUDU-3265 txn-related options to 'kudu perf loadgen'

2021-06-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17540 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 1: Code-Review+2 While not absolutely critical, if we

[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'

2021-06-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.o

[kudu-CR] KUDU-3265 txn-related options to 'kudu perf loadgen'

2021-06-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 3: Code-Review+2 (1 comment) It's not necessary, but

[kudu-CR](branch-1.15.x) [hms] Avoid blocking table alterations that are not relevant to Kudu

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17537 ) Change subject: [hms] Avoid blocking table alterations that are not relevant to Kudu .. Patch Set 1: Code-Review+2 -- To view, visit h

[kudu-CR](branch-1.15.x) [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17536 ) Change subject: [docs] add a design overview for multi-row transactions .. Patch Set 1: Given the new experimental feature, it'd be grea

[kudu-CR](branch-1.15.x) [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17536 Change subject: [docs] add a design overview for multi-row transactions .. [docs] add a design overview for multi-row transactions This a

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17525 ) Change subject: [docs] add a design overview for multi-row transactions .. [docs] add a design overview for multi-row transaction

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17525 ) Change subject: [docs] add a design overview for multi-row transactions .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17525 to look at the new patch set (#4). Change subject: [docs] add a design overview for multi-row transactions .

[kudu-CR] WIP KUDU-3265 txn-related options to 'kudu perf loadgen'

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 ) Change subject: WIP KUDU-3265 txn-related options to 'kudu perf loadgen' .. Patch Set 2: (1 comment) +1 for the approach. http://gerri

[kudu-CR] [hms] Avoid blocking table alterations that are not relevant to Kudu

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17531 ) Change subject: [hms] Avoid blocking table alterations that are not relevant to Kudu .. Patch Set 4: Code-Review+2 (1 comment) http://

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17525 ) Change subject: [docs] add a design overview for multi-row transactions .. Patch Set 2: (23 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-06-02 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17525 to look at the new patch set (#3). Change subject: [docs] add a design overview for multi-row transactions ..

[kudu-CR] [hms] Avoid blocking table alterations that are not relevant to Kudu

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17531 ) Change subject: [hms] Avoid blocking table alterations that are not relevant to Kudu .. Patch Set 3: (6 comments) http://gerrit.cloude

[kudu-CR](branch-1.15.x) KUDU-2612 allow system user to read list of table replicas

2021-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17532 ) Change subject: KUDU-2612 allow system user to read list of table replicas .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] KUDU-2612 allow system user to read list of table replicas

2021-06-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17529 ) Change subject: KUDU-2612 allow system user to read list of table replicas .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.clou

[kudu-CR] wip KUDU-2975 p1: introduce WAL dir manager

2021-06-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15427 to look at the new patch set (#3). Change subject: wip KUDU-2975 p1: introduce WAL dir manager .. wip KUDU-2975 p1:

[kudu-CR] WIP: KUDU-2612 allow system user to read list of table replicas

2021-06-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17529 ) Change subject: WIP: KUDU-2612 allow system user to read list of table replicas .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[kudu-CR] WIP: KUDU-2612 allow system user to read list of table replicas

2021-06-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17529 ) Change subject: WIP: KUDU-2612 allow system user to read list of table replicas .. Patch Set 1: (3 comments) http://gerrit.cloudera.org

[kudu-CR] wip: [master] AddMaster and copy sys catalog automatically

2021-05-31 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17528 to look at the new patch set (#2). Change subject: wip: [master] AddMaster and copy sys catalog automatically .. wi

[kudu-CR] wip: [master] AddMaster and copy sys catalog automatically

2021-05-31 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17528 Change subject: wip: [master] AddMaster and copy sys catalog automatically .. wip: [master] AddMaster and copy sys catalog automatically

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-05-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17525 to look at the new patch set (#2). Change subject: [docs] add a design overview for multi-row transactions .. [docs

[kudu-CR] [docs] add a design overview for multi-row transactions

2021-05-27 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17525 Change subject: [docs] add a design overview for multi-row transactions .. [docs] add a design overview for multi-row transactions This a

[kudu-CR] [txn manager] allow a super user to call txn-related RPCs

2021-05-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17510 ) Change subject: [txn_manager] allow a super user to call txn-related RPCs .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloud

[kudu-CR] [txn manager] allow a super user to call txn-related RPCs

2021-05-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17510 ) Change subject: [txn_manager] allow a super user to call txn-related RPCs .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloud

[kudu-CR] [test] minor clean up on TestUnsafeChangeConfigLeaderWithPendingConfig

2021-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17504 ) Change subject: [test] minor clean up on TestUnsafeChangeConfigLeaderWithPendingConfig .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [consensus] a small optimisation on log prefix

2021-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17489 ) Change subject: [consensus] a small optimisation on log prefix .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls

2021-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17491 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] KUDU-2612: disable TxnSystemClient initialization by default

2021-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17499 ) Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. KUDU-2612: disable TxnSystemClient initialization

[kudu-CR] KUDU-2612: disable TxnSystemClient initialization by default

2021-05-24 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17499 to look at the new patch set (#3). Change subject: KUDU-2612: disable TxnSystemClient initialization by default ...

[kudu-CR] KUDU-2612: disable TxnSystemClient initialization by default

2021-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17499 ) Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-2612: disable TxnSystemClient initialization by default

2021-05-24 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17499 to look at the new patch set (#2). Change subject: KUDU-2612: disable TxnSystemClient initialization by default .

[kudu-CR] KUDU-2612: disable TxnSystemClient initialization by default

2021-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17499 Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. KUDU-2612: disable TxnSystemClient initialization by defau

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job   While Kudu does not have a notion of database, usually the full table name is stored as . on kudu sid

2021-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job   While Kudu does not have a notion of database, usually the full table name is stored as . on kudu side. (NOTE: database n

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job   While Kudu does not have a notion of database, usually the full table name is stored as . on kudu sid

2021-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job   While Kudu does not have a notion of database, usually the full table name is stored as . on kudu side. (NOTE: database n

[kudu-CR] [txns] Allow the TxnSystemClient to run in Authorized environments

2021-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17490 ) Change subject: [txns] Allow the TxnSystemClient to run in Authorized environments .. Patch Set 3: Code-Review+2 Nice find! -- To vie

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job    While Kudu does not have a notion of database, usually the full table name is stored as . on kudu si

2021-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job    While Kudu does not have a notion of database, usually the full table name is stored as . on kudu side. (NOTE: database

<    2   3   4   5   6   7   8   9   10   11   >