Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/13702 )
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
..
Patch Set 4:
Can some committers of Kudu please merge
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/13702 )
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
..
Patch Set 4:
(5 comments)
I tested with this patch with
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13702
to look at the new patch set (#4).
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/13702 )
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
..
Patch Set 3:
The server shutdown test case in rpc-test
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/13702 )
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
..
Patch Set 3:
I mostly tested this change using iptables
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13702
to look at the new patch set (#3).
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13702
to look at the new patch set (#2).
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
..
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/13702
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections
..
KUDU-2192: Enable TCP keepalive for all outbound
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/12545 )
Change subject: KUDU-2706: Work around the lack of thread safety in
krb5_parse_name()
..
Patch Set 2:
(1 comment)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12545
to look at the new patch set (#4).
Change subject: KUDU-2706: Work around the lack of thread safety in
krb5_parse_name()
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12545
to look at the new patch set (#2).
Change subject: KUDU-2706: Work around the lack of thread safety in
krb5_parse_name()
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/12545 )
Change subject: KUDU-2706: Work around the lack of thread safety in
krb5_parse_name()
..
Patch Set 3:
(1 comment)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12545
to look at the new patch set (#3).
Change subject: KUDU-2706: Work around the lack of thread safety in
krb5_parse_name()
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/12545 )
Change subject: KUDU-2706: Work around the lack of thread safety in
krb5_parse_name()
..
Patch Set 2:
(3 comments)
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/12545
Change subject: KUDU-2706: Workaround the lack of thread safety in
krb5_parse_name()
..
KUDU-2706: Workaround the lack of thread safety
Hello Kudu Jenkins, Adar Dembo, Sailesh Mukil, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11681
to look at the new patch set (#5).
Change subject: Add "network_plane" as part of ConnectionId
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11681
to look at the new patch set (#4).
Change subject: Add "network_plane" as part of ConnectionId
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11681
to look at the new patch set (#3).
Change subject: Add "network_plane" as part of ConnectionId
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/11681 )
Change subject: Add "network_plane" as part of ConnectionId
..
Patch Set 1:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/11681 )
Change subject: Add "service_name" as part of ConnectionId
..
Patch Set 1:
(1 comment)
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11681
to look at the new patch set (#2).
Change subject: Add "service_name" as part of ConnectionId
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/11681 )
Change subject: Add "service_name" as part of ConnectionId
..
Patch Set 2:
(3 comments)
Thanks for the review.
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/11681
Change subject: Add "service_name" as part of ConnectionId
..
Add "service_name" as part of ConnectionId
The motivation for doing so is
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/11150
Change subject: Add const attribute to RpcContext::GetInboundSidecar()
..
Add const attribute to RpcContext::GetInboundSidecar()
Testing
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Abandoned
Not needed after the fix of IMPALA-5518
--
To view, visit
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9840 )
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..
Patch Set 2:
Many tests failed with:
Runtime error: Failed to start
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9840 )
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..
Patch Set 2:
(1 comment)
Hi Todd, good suggestion. It'd be better if
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9840
to look at the new patch set (#2).
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9840 )
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..
Patch Set 1:
Todd, we use this macro here:
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9840 )
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..
Patch Set 1:
Build failure doesn't look relevant:
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/9840
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..
KUDU-2385: Fix typo in KinitContext::DoRenewal()
On platforms without
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/9796
Change subject: KUDU-2374: Add RpcContext::GetTimeReceived()
..
KUDU-2374: Add RpcContext::GetTimeReceived()
This change adds
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code
..
Patch Set 8: Code-Review+1
(3 comments)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code
..
Patch Set 3:
(4 comments)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code
..
Patch Set 2:
(2 comments)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9587 )
Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with
SSL_write()
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9587 )
Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with
SSL_write()
..
Patch Set 2:
Hit with flaky tests again
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9587 )
Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with
SSL_write()
..
Patch Set 1:
(11 comments)
Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9587
to look at the new patch set (#2).
Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with
SSL_write()
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9587 )
Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with
SSL_write()
..
Patch Set 1:
the test failure seems to be
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/9587
Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with
SSL_write()
..
KUDU-2334: Fix
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9355 )
Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages
..
Patch Set 3:
Ping. Impala also needs this patch once this
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9355 )
Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages
..
Patch Set 3:
(2 comments)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9343 )
Change subject: KUDU-2031: Add metrics per connection to the reactor metrics
..
Patch Set 3:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9343 )
Change subject: KUDU-2031: Add metrics per connection to the reactor metrics
..
Patch Set 3:
(3 comments)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9048 )
Change subject: rpc: micro-optimize delayed task handling
..
Patch Set 3: Code-Review+1
--
To view, visit
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Patch Set 4:
Thanks for the review. We need to re-evaluate the
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9117 )
Change subject: KUDU-2270: Add a flag to control logging in
RpczStore::LogTrace()
..
Patch Set 3:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9117 )
Change subject: KUDU-2270: Add a flag to control logging in
RpczStore::LogTrace()
..
Patch Set 2:
(1 comment)
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9117
to look at the new patch set (#2).
Change subject: KUDU-2270: Add a flag to control logging in
RpczStore::LogTrace()
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9048 )
Change subject: rpc: micro-optimize delayed task handling
..
Patch Set 3:
(1 comment)
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/9117
Change subject: KUDU-2270: Add a flag to control logging in
RpczStore::LogTrace()
..
KUDU-2270: Add a flag to control logging in
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/9047 )
Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall
..
Patch Set 1: Code-Review+1
--
To view, visit
Hello Tidy Bot, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, Mostafa Mokhtar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8895
to look at the new patch set (#4).
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
Hello Tidy Bot, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, Mostafa Mokhtar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8895
to look at the new patch set (#3).
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Patch Set 2:
(3 comments)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8895 )
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Patch Set 1:
(7 comments)
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8895
to look at the new patch set (#2).
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8895
Change subject: KUDU-1865: Avoid some heap allocations in RPC paths
..
KUDU-1865: Avoid some heap allocations in RPC paths
As shown in
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8831
to look at the new patch set (#8).
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8831
to look at the new patch set (#7).
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8831
to look at the new patch set (#6).
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8831 )
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
..
Patch Set 6:
(4 comments)
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8831
to look at the new patch set (#5).
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8831
to look at the new patch set (#4).
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8831
to look at the new patch set (#3).
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8831
Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
..
KUDU-2237: Allow idle server connection scanning to be
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8789 )
Change subject: KUDU-2228: Make Messenger options configurable
..
Patch Set 3:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8789 )
Change subject: KUDU-2228: Make Messenger options configurable
..
Patch Set 3:
(1 comment)
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/8700 )
Change subject: [security] Make the kerberos principal configurable for Kudu
servers
..
Patch Set 1:
(1 comment)
Michael Ho has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8273
Change subject: Reduce log spew from rpcz_store.cc
..
Reduce log spew from rpcz_store.cc
The sampled RPC call statement has been filing
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 5:
The verification failure may be infra related. Not sure if I have the
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7599
to look at the new patch set (#5).
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 4:
(4 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7599
to look at the new patch set (#4).
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7599
to look at the new patch set (#3).
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 3:
(5 comments)
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 2:
(20 comments)
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 2:
(4 comments)
Thanks again for taking a look. Replies to some questions below
Michael Ho has posted comments on this change.
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
Patch Set 2:
(33 comments)
http://gerrit.cloudera.org:8080/#/c/7599/1//COMMIT_MSG
Commit
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7599
Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or
timeout
..
KUDU-2065, KUDU-2011: Release sidecars on
Michael Ho has posted comments on this change.
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7455/5/src/kudu/rpc/rpc-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7455
to look at the new patch set (#6).
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Michael Ho has posted comments on this change.
Change subject: KUDU-1865: Avoid heap allocation for payload slices
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7471/3/src/kudu/rpc/inbound_call.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7471
to look at the new patch set (#4).
Change subject: KUDU-1865: Avoid heap allocation for payload slices
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7455
to look at the new patch set (#5).
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Michael Ho has posted comments on this change.
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7455/4/src/kudu/rpc/rpc-test.cc
File
Michael Ho has posted comments on this change.
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7455/3/src/kudu/rpc/connection.h
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7455
to look at the new patch set (#4).
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7471
to look at the new patch set (#3).
Change subject: KUDU-1865: Avoid heap allocation for payload slices
..
Michael Ho has posted comments on this change.
Change subject: KUDU-1865: Avoid heap allocation for payload slices
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7471/1/src/kudu/rpc/inbound_call.h
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7471
to look at the new patch set (#2).
Change subject: KUDU-1865: Avoid heap allocation for payload slices
..
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7471
Change subject: KUDU-1865: Avoid heap allocation for payload slices
..
KUDU-1865: Avoid heap allocation for payload slices
As shown in
Michael Ho has posted comments on this change.
Change subject: KUDU-2065: Support cancellation for outbound RPC call
..
Patch Set 2:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/7455/2//COMMIT_MSG
Commit Message:
PS2,
1 - 100 of 105 matches
Mail list logo