Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943: Add BlockTransaction to Block Manager
This adds a new layer of abstraction
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 34: Verified+1
We can't let IWYU get in the way of progress.
--
To view, visit
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 34:
Not sure why IWYU is complaining about including ext/alloc_traits.h for
log_block_manager.cc, etc?
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 34: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7207
To unsubscribe, visit
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#34).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 33: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7207
To unsubscribe, visit
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#33).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h
File
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc
File
Mike Percy has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.cc
File
Mike Percy has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 32:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 30: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7207
To unsubscribe, visit
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 30:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/29/src/kudu/fs/log_block_manager.cc
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#30).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 29:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/29/src/kudu/fs/log_block_manager.cc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 29:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7207/28/src/kudu/fs/log_block_manager.cc
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#29).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 28:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7207/28/src/kudu/fs/log_block_manager.cc
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#28).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 27:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/25/src/kudu/fs/log_block_manager.cc
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#27).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#26).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 25:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/25/src/kudu/fs/log_block_manager.cc
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#25).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 24:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/block_manager.h
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#24).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 23:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/7207/23/src/kudu/fs/log_block_manager.cc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(10 comments)
> (1 comment)
>
> Looks good! I'm very pleased how this came together, net-net I
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#23).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Mike Percy has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/block_manager.cc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/log_block_manager.cc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/block_manager.cc
File
Mike Percy has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(13 comments)
Looks pretty good to me, I mainly have nits.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(1 comment)
Looks good! I'm very pleased how this came together, net-net I think the code
is
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7207
To unsubscribe, visit
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/20/src/kudu/fs/log_block_manager.cc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7207/21/src/kudu/fs/block_manager-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#22).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 21:
(8 comments)
Almost there, just a few nits left.
Dan, since the implementation has changed
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#21).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 21:
(30 comments)
http://gerrit.cloudera.org:8080/#/c/7207/19//COMMIT_MSG
Commit Message:
PS19, Line
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 20:
(30 comments)
http://gerrit.cloudera.org:8080/#/c/7207/19//COMMIT_MSG
Commit Message:
PS19,
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 20:
(26 comments)
http://gerrit.cloudera.org:8080/#/c/7207/19//COMMIT_MSG
Commit Message:
PS19, Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#20).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 19:
(14 comments)
I think I reviewed everything, but I'm curious to see how this will evolve
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#19).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#18).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 17:
(10 comments)
I think I'm done reviewing everything outside log_block_manager.cc. Still a lot
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 16:
> (5 comments)
>
> Hao, Dan, and I had a long discussion about this patch, and I
> wanted to
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 16:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7207/16/src/kudu/cfile/cfile-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#17).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 10:
(5 comments)
Hao, Dan, and I had a long discussion about this patch, and I wanted to
reproduce
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#16).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 14:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/file_block_manager.cc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 15:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/block_manager-stress-test.cc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#15).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 14:
(4 comments)
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 14:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/7207/13//COMMIT_MSG
Commit Message:
PS13, Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#14).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 13:
(19 comments)
http://gerrit.cloudera.org:8080/#/c/7207/5//COMMIT_MSG
Commit Message:
PS5, Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#13).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 12:
(38 comments)
http://gerrit.cloudera.org:8080/#/c/7207/10/src/kudu/cfile/cfile-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#12).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#11).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#10).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7207/9/src/kudu/cfile/cfile-test.cc
File
69 matches
Mail list logo
