[kudu-CR] KUDU-1906. Fix lost callback for scanner path

2017-03-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1906. Fix lost callback for scanner path .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6239 To unsubscribe, visit

[kudu-CR] KUDU-1906. Fix lost callback for scanner path

2017-03-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1906. Fix lost callback for scanner path .. KUDU-1906. Fix lost callback for scanner path Fixes another case similar to KUDU-1888 in which we

[kudu-CR](branch-1.2.x) KUDU-1893 Ensure evaluation of added columns

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6225 To unsubscribe, visit

[kudu-CR] [security] introduced TokenSigner::HasValidKey() method

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6246 Change subject: [security] introduced TokenSigner::HasValidKey() method .. [security] introduced TokenSigner::HasValidKey() method

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#7). Change subject: [catalog_manager] categorization of rw operation failures

[kudu-CR](branch-1.3.x) ITBLL: avoid creating client many times during Generator step

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ITBLL: avoid creating client many times during Generator step .. Patch Set 1: Code-Review+2 just a cherry-pick -- To view, visit

[kudu-CR](branch-1.3.x) ITBLL: avoid creating client many times during Generator step

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ITBLL: avoid creating client many times during Generator step .. Patch Set 1: Verified+1 Failure is unrelated (think it's related to

[kudu-CR](branch-1.3.x) KUDU-1834 Don't redact KuduRowResult::ToString()

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6244 To unsubscribe, visit

[kudu-CR](branch-1.3.x) ITBLL: avoid creating client many times during Generator step

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ITBLL: avoid creating client many times during Generator step .. ITBLL: avoid creating client many times during Generator step Previously ITBLL was

[kudu-CR](branch-1.3.x) KUDU-1906. Fix lost callback for scanner path

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6253 Change subject: KUDU-1906. Fix lost callback for scanner path .. KUDU-1906. Fix lost callback for scanner path Fixes another case similar

[kudu-CR](branch-1.3.x) KUDU-1834 Don't redact KuduRowResult::ToString()

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. KUDU-1834 Don't redact KuduRowResult::ToString() A user on the client side calling ToString on the

[kudu-CR](branch-1.3.x) KUDU-1893 Ensure evaluation of added columns

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6240 To unsubscribe, visit

[kudu-CR](branch-1.3.x) [security] disable PLAIN SASL mech when authentication is required

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [security] disable PLAIN SASL mech when authentication is required .. [security] disable PLAIN SASL mech when authentication is required Change-Id:

[kudu-CR](branch-1.3.x) KUDU-1893 Ensure evaluation of added columns

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893 Ensure evaluation of added columns During a normal scan, a CFileIterator sets a flag to

[kudu-CR](branch-1.3.x) [security] disable PLAIN SASL mech when authentication is required

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] disable PLAIN SASL mech when authentication is required .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6243 To

[kudu-CR](branch-1.3.x) mapreduce: support for running on secure clusters

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: mapreduce: support for running on secure clusters .. mapreduce: support for running on secure clusters This adds the appropriate hooks to grab

[kudu-CR](branch-1.3.x) mapreduce: support for running on secure clusters

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: mapreduce: support for running on secure clusters .. Patch Set 1: this failed because it needs to go on top of the other ITBLL patch on this branch. Couldn't

[kudu-CR](branch-1.3.x) mapreduce: support for running on secure clusters

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: mapreduce: support for running on secure clusters .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6242 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-1906. Fix lost callback for scanner path

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1906. Fix lost callback for scanner path .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6253 To unsubscribe, visit

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#8). Change subject: [catalog_manager] categorization of rw operation failures

[kudu-CR](branch-1.2.x) KUDU-1893 Ensure evaluation of added columns

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893 Ensure evaluation of added columns During a normal scan, a CFileIterator sets a flag to

[kudu-CR] env: Add support for getting FS capacity

2017-03-03 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6255 to review the following change. Change subject: env: Add support for getting FS capacity .. env: Add support for

[kudu-CR] [security] introduced TokenSigner::HasValidKey() method

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] introduced TokenSigner::HasValidKey() method .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-03 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#3). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR] KUDU-1897: disable Kerberos replay cache

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1897: disable Kerberos replay cache .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6254/2/src/kudu/rpc/rpc-negotiation-bench.cc File

[kudu-CR] [kudu-jepsen] install Kudu packages into local repo

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6256 Change subject: [kudu-jepsen] install Kudu packages into local repo .. [kudu-jepsen] install Kudu packages into local repo Install Kudu

[kudu-CR](branch-1.3.x) KUDU-1906. Fix lost callback for scanner path

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1906. Fix lost callback for scanner path .. KUDU-1906. Fix lost callback for scanner path Fixes another case similar to KUDU-1888 in which we were

[kudu-CR] subprocess: Get rid of fork/exec SIGPIPE reset race

2017-03-03 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6259 to review the following change. Change subject: subprocess: Get rid of fork/exec SIGPIPE reset race ..

[kudu-CR] Reserve 1% of disk space by default

2017-03-03 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6192 to look at the new patch set (#2). Change subject: Reserve 1% of disk space by default .. Reserve 1%

[kudu-CR] Reserve 1% of disk space by default

2017-03-03 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6192 to look at the new patch set (#3). Change subject: Reserve 1% of disk space by default .. Reserve 1%

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 2: (12 comments) I am still addressing some refactoring/testing

[kudu-CR] KUDU-1897: disable Kerberos replay cache

2017-03-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1897: disable Kerberos replay cache .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6254/1/src/kudu/rpc/rpc-negotiation-bench.cc File

[kudu-CR] KUDU-1897: disable Kerberos replay cache

2017-03-03 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: KUDU-1897: disable Kerberos replay cache .. KUDU-1897: disable Kerberos replay cache Also provides an initial cut of an RPC negotiation benchmark / stress tester.

[kudu-CR] [security] introduced TokenSigner::HasValidKey() method

2017-03-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] introduced TokenSigner::HasValidKey() method .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6246/1/src/kudu/security/token_signer.cc

[kudu-CR] WIP: KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6258 Change subject: WIP: KUDU-1905 - Allow reinserts on pk only tables .. WIP: KUDU-1905 - Allow reinserts on pk only tables Doing a

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/6170/8//COMMIT_MSG Commit Message:

[kudu-CR] [security] introduced TokenSigner::HasValidKey() method

2017-03-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] introduced TokenSigner::HasValidKey() method .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6246/1/src/kudu/security/token_signer.cc

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/6258/1//COMMIT_MSG Commit Message: PS1, Line 9:

[kudu-CR] env: Add support for getting FS capacity

2017-03-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: env: Add support for getting FS capacity .. Patch Set 1: Verified+1 Overriding jenkins flakiness -- To view, visit http://gerrit.cloudera.org:8080/6255 To

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#9). Change subject: [catalog_manager] categorization of rw operation failures ..

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables .. Patch Set 2: (1 comment)

[kudu-CR] [security] introduced TokenSigner::HasValidKey() method

2017-03-03 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6246 to look at the new patch set (#2). Change subject: [security] introduced TokenSigner::HasValidKey() method ..

[kudu-CR] subprocess: Get rid of fork/exec SIGPIPE reset race

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: subprocess: Get rid of fork/exec SIGPIPE reset race .. Patch Set 1: Not sure I follow this. Between fork and exec there is only one thread running (fork only

[kudu-CR] [security] added TokenSigner::IsCurrentKeyValid() method

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] added TokenSigner::IsCurrentKeyValid() method .. Patch Set 3: Verified+1 Flake: org.apache.kudu.client.ITClient.test -- To view, visit

[kudu-CR] Ignore SIGPIPE earlier in startup process

2017-03-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Ignore SIGPIPE earlier in startup process .. Patch Set 1: (1 comment) > What's the plan for the client? I thought we could deal with the client in a separate

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6258/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6258 to look at the new patch set (#3). Change subject: KUDU-1905 - Allow reinserts on pk only tables .. KUDU-1905 -

[kudu-CR] Ignore SIGPIPE earlier in startup process

2017-03-03 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6262 to review the following change. Change subject: Ignore SIGPIPE earlier in startup process .. Ignore SIGPIPE

[kudu-CR] [security] added TokenSigner::IsCurrentKeyValid() method

2017-03-03 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6246 to look at the new patch set (#3). Change subject: [security] added TokenSigner::IsCurrentKeyValid() method ..

[kudu-CR] Ignore SIGPIPE earlier in startup process

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Ignore SIGPIPE earlier in startup process .. Patch Set 1: (1 comment) What's the plan for the client?

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 9: Verified+1 Flake: org.apache.kudu.spark.kudu.DefaultSourceTest.Test SparkSQL

[kudu-CR] Ignore SIGPIPE earlier in startup process

2017-03-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Ignore SIGPIPE earlier in startup process .. Patch Set 1: (3 comments) > > What's the plan for the client? > > I thought we could deal with the client in a

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 9: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6258 to look at the new patch set (#4). Change subject: KUDU-1905 - Allow reinserts on pk only tables .. KUDU-1905 -

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/6170/8//COMMIT_MSG Commit Message:

[kudu-CR] subprocess: Get rid of fork/exec SIGPIPE reset race

2017-03-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: subprocess: Get rid of fork/exec SIGPIPE reset race .. Patch Set 1: Verified+1 Overriding unrelated failure due to KUDU-1736 (I attached the failure log to that

[kudu-CR] Make ExternalDaemon::StartProcess() handle fault injection

2017-03-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Make ExternalDaemon::StartProcess() handle fault injection .. Patch Set 6: Is this patch necessary if we pull in https://gerrit.cloudera.org/6262 ? -- To view,

[kudu-CR] subprocess: Get rid of fork/exec SIGPIPE reset race

2017-03-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: subprocess: Get rid of fork/exec SIGPIPE reset race .. Patch Set 1: I thought fork included all threads. I guess the difference is that the child gets all the

[kudu-CR] subprocess: Get rid of fork/exec SIGPIPE reset race

2017-03-03 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: subprocess: Get rid of fork/exec SIGPIPE reset race .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6259 To unsubscribe, visit

[kudu-CR] Reserve 1% of disk space by default

2017-03-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reserve 1% of disk space by default .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6192 To unsubscribe, visit

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#10). Change subject: [catalog_manager] categorization of rw operation failures ..

[kudu-CR] KUDU-1897: disable Kerberos replay cache

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1897: disable Kerberos replay cache .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6254/2/src/kudu/rpc/rpc-negotiation-bench.cc File

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 8: Verified+1 Looks like a couple of flakes:

[kudu-CR] KUDU-1897: disable Kerberos replay cache

2017-03-03 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/6254 Change subject: KUDU-1897: disable Kerberos replay cache .. KUDU-1897: disable Kerberos replay cache Also provides an initial cut of an

[kudu-CR] KUDU-1897: disable Kerberos replay cache

2017-03-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1897: disable Kerberos replay cache .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6254/2/src/kudu/rpc/rpc-negotiation-bench.cc File

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6258 to look at the new patch set (#2). Change subject: KUDU-1905 - Allow reinserts on pk only tables .. KUDU-1905 -