[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 ) Change subject: cmake: rename integration-tests and mini-cluster .. Patch Set 2: Code-Review+2 Carrying forward Todd's +2. -- To view,

[kudu-CR] KUDU-2161 ColumnSchemaBuilder missing Audience annotation

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8214 ) Change subject: KUDU-2161 ColumnSchemaBuilder missing Audience annotation .. KUDU-2161 ColumnSchemaBuilder missing Audience

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-04 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8138 to look at the new patch set (#7). Change subject: WIP [consensus] adding/removing NON_VOTER members

[kudu-CR] KUDU-2161 ColumnSchemaBuilder missing Audience annotation

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8214 Change subject: KUDU-2161 ColumnSchemaBuilder missing Audience annotation .. KUDU-2161 ColumnSchemaBuilder missing Audience annotation

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8187 ) Change subject: external_mini_cluster: don't pipe daemon subprocess stdout .. external_mini_cluster: don't pipe daemon subprocess

[kudu-CR] mini-cluster: make available when building with NO TESTS

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8209 ) Change subject: mini-cluster: make available when building with NO_TESTS .. mini-cluster: make available when building with

[kudu-CR] KUDU-2161 ColumnSchemaBuilder missing Audience annotation

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8214 ) Change subject: KUDU-2161 ColumnSchemaBuilder missing Audience annotation .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] mini-cluster: make available when building with NO TESTS

2017-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8209 ) Change subject: mini-cluster: make available when building with NO_TESTS .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 ) Change subject: cmake: rename integration-tests and mini-cluster .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.4.x) rpc: move ConnectionId to its own file

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8184 ) Change subject: rpc: move ConnectionId to its own file .. rpc: move ConnectionId to its own file This class was previously

[kudu-CR](branch-1.3.x) rpc: move ConnectionId to its own file

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8181 ) Change subject: rpc: move ConnectionId to its own file .. rpc: move ConnectionId to its own file This class was previously

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8187 ) Change subject: external_mini_cluster: don't pipe daemon subprocess stdout .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8210 ) Change subject: cmake: rename integration-tests and mini-cluster .. cmake: rename integration-tests and mini-cluster They are now

[kudu-CR] itest: allow use of verifiers with EMCs that specify non-default block managers

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8208 ) Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers .. Patch Set 3: (10 comments)

[kudu-CR](branch-1.3.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8182 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: Code-Review+2 Forwarding Alexey's

[kudu-CR](branch-1.3.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8182 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. KUDU-2032 (part 1): pass pre-resolution

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8037 ) Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries. .. Patch Set 1: yea, sorry, was traveling

[kudu-CR](branch-1.4.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8186 ) Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. KUDU-2032 (part 2): propagate master hostnames

[kudu-CR](branch-1.3.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8183 ) Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. KUDU-2032 (part 2): propagate master hostnames

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. KUDU-2032 (part 1): pass pre-resolution

[kudu-CR](branch-1.3.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8183 ) Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 4: Code-Review+2 Forwarding Alexey's +2 after

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 3: Code-Review+2 Forwarding Alexey's

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#9). Change subject: [webui] Allow custom response codes and headers

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 6: (4 comments)

[kudu-CR] tool: add cluster shell action

2017-10-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (1 comment)

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 10: (2 comments)

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 12: Code-Review+1 -- To view, visit

[kudu-CR] [tablet copy] comment on TabletCopyClient lifecycle

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8197 ) Change subject: [tablet copy] comment on TabletCopyClient lifecycle .. Patch Set 1: (2 comments)

[kudu-CR] [tablet copy] comment on TabletCopyClient lifecycle

2017-10-04 Thread Alexey Serbin (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8197 to look at the new patch set (#2). Change subject: [tablet copy] comment on TabletCopyClient lifecycle

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#10). Change subject: [webui] Allow custom response codes and headers

[kudu-CR] [tablet copy] comment on TabletCopyClient lifecycle

2017-10-04 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8197 ) Change subject: [tablet copy] comment on TabletCopyClient lifecycle .. Patch Set 1: (2 comments) Looks good, I just left some minor

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#11). Change subject: [webui] Allow custom response codes and headers

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-04 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] adding/removing NON_VOTER members .. Patch Set 6: (8 comments) This is looking pretty good although I

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-04 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#12). Change subject: [webui] Allow custom response codes and headers

[kudu-CR] tool: new action for running mini-clusters

2017-10-04 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#9). Change subject: tool: new action for running mini-clusters

[kudu-CR] java: replace bespoke minicluster implementation with control shell

2017-10-04 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8194 to look at the new patch set (#2). Change subject: java: replace bespoke minicluster implementation with control shell

[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8210 to review the following change. Change subject: cmake: rename integration-tests and mini-cluster .. cmake: rename

[kudu-CR] tool: new action for running mini-clusters

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: new action for running mini-clusters .. Patch Set 8: (27 comments)

[kudu-CR] mini-cluster: make available when building with NO TESTS

2017-10-04 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8209 to review the following change. Change subject: mini-cluster: make available when building with NO_TESTS ..

[kudu-CR] tool: new action for running mini-clusters

2017-10-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: new action for running mini-clusters .. Patch Set 8: (4 comments)

[kudu-CR] mini-cluster: make available when building with NO TESTS

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8209 ) Change subject: mini-cluster: make available when building with NO_TESTS .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] mini-cluster: make available when building with NO TESTS

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8209 ) Change subject: mini-cluster: make available when building with NO_TESTS .. Patch Set 1: Verified+1 Overriding Jenkins, the test failure

[kudu-CR] [tablet copy] comment on TabletCopyClient lifecycle

2017-10-04 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8197 ) Change subject: [tablet copy] comment on TabletCopyClient lifecycle .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] itest: allow use of verifiers with EMCs that specify non-default block managers

2017-10-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8208 Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers .. itest: allow use of verifiers with

[kudu-CR] itest: allow use of verifiers with EMCs that specify non-default block managers

2017-10-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8208 to look at the new patch set (#3). Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers

[kudu-CR] periodic: add one-shot timers

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. periodic: add one-shot timers One-shot timers will Stop() themselves after

[kudu-CR] periodic: add one-shot timers

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 3: (1 comment)

[kudu-CR](branch-1.4.x) rpc: move ConnectionId to its own file

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8184 ) Change subject: rpc: move ConnectionId to its own file .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.3.x) rpc: move ConnectionId to its own file

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8181 ) Change subject: rpc: move ConnectionId to its own file .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] periodic: add one-shot timers

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.4.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8186 ) Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.3.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8182 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.3.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8183 ) Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [tablet copy] comment on TabletCopyClient lifecycle

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8197 ) Change subject: [tablet copy] comment on TabletCopyClient lifecycle .. [tablet copy] comment on TabletCopyClient lifecycle

[kudu-CR] itest: allow use of verifiers with EMCs that specify non-default block managers

2017-10-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8208 to look at the new patch set (#2). Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers

[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 ) Change subject: cmake: rename integration-tests and mini-cluster .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8210 ) Change subject: cmake: rename integration-tests and mini-cluster .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] cmake: rename integration-tests and mini-cluster

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 ) Change subject: cmake: rename integration-tests and mini-cluster .. Patch Set 1: Verified+1 Overriding Jenkins, known (very old) test

[kudu-CR] periodic: add one-shot timers

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 3: Code-Review+1 (1 comment) Overall looks good. Are you going to address

[kudu-CR] tool: new action for running mini-clusters

2017-10-04 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#10). Change subject: tool: new action for running mini-clusters

[kudu-CR] java: replace bespoke minicluster implementation with control shell

2017-10-04 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8194 to look at the new patch set (#3). Change subject: java: replace bespoke minicluster implementation with control shell

[kudu-CR] java client: fix TestKuduTable.testAlterNoWait

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8213 Change subject: java client: fix TestKuduTable.testAlterNoWait .. java client: fix TestKuduTable.testAlterNoWait My brain must have been

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] adding/removing NON_VOTER members .. Patch Set 6: (8 comments)

[kudu-CR] tool: new action for running mini-clusters

2017-10-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: new action for running mini-clusters .. Patch Set 10: (3 comments)