[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] WIP: KUDU-2509 fix use-after-free in case of WAL replay error

2018-07-19 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10997 to look at the new patch set (#2). Change subject: WIP: KUDU-2509 fix use-after-free in case of WAL replay error

[kudu-CR] WIP: KUDU-2509 fix use-after-free in case of WAL replay error

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10997 ) Change subject: WIP: KUDU-2509 fix use-after-free in case of WAL replay error .. Patch Set 2: (4 comments)

[kudu-CR] WIP: KUDU-2509 fix use-after-free in case of WAL replay error

2018-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10997 ) Change subject: WIP: KUDU-2509 fix use-after-free in case of WAL replay error .. Patch Set 2: (3 comments)

[kudu-CR] WIP: KUDU-2509 fix use-after-free in case of WAL replay error

2018-07-19 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10997 to look at the new patch set (#3). Change subject: WIP: KUDU-2509 fix use-after-free in case of WAL replay error

[kudu-CR] WIP: KUDU-2509 fix use-after-free in case of WAL replay error

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10997 ) Change subject: WIP: KUDU-2509 fix use-after-free in case of WAL replay error .. Patch Set 3: Code-Review+2 But if you can conceive of a

[kudu-CR] WIP: KUDU-2509 fix use-after-free in case of WAL replay error

2018-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10997 Change subject: WIP: KUDU-2509 fix use-after-free in case of WAL replay error .. WIP: KUDU-2509 fix use-after-free in case of WAL

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 3: (4 comments)

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#5). Change subject: schema: add is_deleted virtual column

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10990 to look at the new patch set (#3). Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10929 to look at the new patch set (#4). Change subject: memrowset: support iteration with include_deleted_rows

[kudu-CR] tablet: add second snapshot to iterator options

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10925 ) Change subject: tablet: add second snapshot to iterator options .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] tablet: add second snapshot to iterator options

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10925 ) Change subject: tablet: add second snapshot to iterator options .. tablet: add second snapshot to iterator options This commit

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 5: (1 comment)

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 3: (1 comment)

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 5: (1 comment)

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 3: (2 comments)

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 3: (1 comment)

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10990 to look at the new patch set (#4). Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#6). Change subject: schema: add is_deleted virtual column

[kudu-CR] tablet: add second snapshot to iterator options

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10925 ) Change subject: tablet: add second snapshot to iterator options .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Add error handling to KuduBackup

2018-07-19 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#3). Change subject: Add error handling to KuduBackup .. Add error

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 5: (3 comments) Nice test!

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 ) Change subject: memrowset: support iteration with is_deleted virtual column .. Patch Set 2: (4 comments)

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with omit_deleted_rows=false .. Patch Set 3: (1 comment)

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with omit_deleted_rows=false .. Patch Set 2: (1 comment) overall looks good

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 5: (3 comments)

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 4: (3 comments)

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 5: (1 comment)

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10929 to look at the new patch set (#3). Change subject: memrowset: support iteration with omit_deleted_rows=false

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with omit_deleted_rows=false .. Patch Set 2: (1 comment)

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#4). Change subject: schema: add is_deleted virtual column

[kudu-CR] tablet: encapsulate common iterator options

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10802 ) Change subject: tablet: encapsulate common iterator options .. tablet: encapsulate common iterator options I intend to introduce

[kudu-CR] Add error handling to KuduBackup

2018-07-19 Thread Tony Foerster (Code Review)
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/10941 ) Change subject: Add error handling to KuduBackup .. Patch Set 4: Code-Review-1 (16 comments)

[kudu-CR] Add error handling to KuduBackup

2018-07-19 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#4). Change subject: Add error handling to KuduBackup .. Add error

[kudu-CR] tablet: encapsulate common iterator options

2018-07-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10802 ) Change subject: tablet: encapsulate common iterator options .. Patch Set 6: Code-Review+2 LGTM if Todd is onboard -- To view, visit

[kudu-CR] Add error handling to Backup and Restore

2018-07-19 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#5). Change subject: Add error handling to Backup and Restore .. Add

[kudu-CR] Add error handling to Backup and Restore

2018-07-19 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#6). Change subject: Add error handling to Backup and Restore .. Add

[kudu-CR] WIP: KUDU-1291 Efficiently support predicates on non-prefix key components

2018-07-19 Thread Anupama Gupta (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10983 to look at the new patch set (#2). Change subject: WIP: KUDU-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with omit_deleted_rows=false .. Patch Set 3: (1 comment)

[kudu-CR] schema: add is deleted virtual column

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 4: (3 comments)

[kudu-CR] tablet: add second snapshot to iterator options

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10925 ) Change subject: tablet: add second snapshot to iterator options .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated test failures.

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 6: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] tablet: add second snapshot to iterator options

2018-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10925 ) Change subject: tablet: add second snapshot to iterator options .. Removed reviewer Kudu Jenkins with the following votes: *