[kudu-CR] [sentry] Fill out more sentry client API

2018-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11657 ) Change subject: [sentry] Fill out more sentry client API .. Patch Set 1: (1 comment)

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11665 to look at the new patch set (#4). Change subject: [tools] Add a describe table tool

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11668 Change subject: Remove column ids from KuduSchema::ToString .. Remove column ids from KuduSchema::ToString

[kudu-CR] [sentry] move ParseTableName to table util

2018-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11658 ) Change subject: [sentry] move ParseTableName to table_util .. Patch Set 1: (2 comments)

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11666 to look at the new patch set (#4). Change subject: [tools] Add locate row tool

[kudu-CR] wip: [sentry] add SentryAuthzProvider

2018-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: wip: [sentry] add SentryAuthzProvider .. Patch Set 1: (2 comments) high level looks good, I didn't check the actual

[kudu-CR] WIP: Remove the Maven Build

2018-10-12 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11667 to look at the new patch set (#2). Change subject: WIP: Remove the Maven Build .. WIP: Remove the Maven Build

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 ) Change subject: Remove column ids from KuduSchema::ToString .. Patch Set 2: (1 comment)

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Attila Bukor, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11666 to look at the new patch set (#7). Change subject: [tools] Add locate row tool

[kudu-CR] WIP: Remove the Maven Build

2018-10-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11667 Change subject: WIP: Remove the Maven Build .. WIP: Remove the Maven Build This patch removes the Maven poms and remaining references to

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 6: Failure looks unrelated. -- To view, visit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11666/6//COMMIT_MSG Commit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11666/6//COMMIT_MSG

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 ) Change subject: Remove column ids from KuduSchema::ToString .. Patch Set 2: Verified+1 I think the failures are unrelated. -- To

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11668 ) Change subject: Remove column ids from KuduSchema::ToString .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] Move TabletReplica::Stop() VLOG to end of function

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11672 Change subject: Move TabletReplica::Stop() VLOG to end of function .. Move TabletReplica::Stop() VLOG to end of function Change-Id:

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 ) Change subject: Remove column ids from KuduSchema::ToString .. Patch Set 1: (1 comment)

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11668 to look at the new patch set (#2). Change subject: Remove column ids from KuduSchema::ToString

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11666/6//COMMIT_MSG

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11666/6//COMMIT_MSG Commit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 7: Code-Review+1 (1 comment)

[kudu-CR](gh-pages) [site] Add http to https redirect

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11162 ) Change subject: [site] Add http to https redirect .. Patch Set 1: Code-Review+2 After doing some more research on this topic I agree

[kudu-CR](gh-pages) Add archived releases section

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11295 ) Change subject: Add archived releases section .. Patch Set 3: > Anyone knows what the LATREL/PREVREL tags do and if they're ok like

[kudu-CR] Move TabletReplica::Stop() VLOG to end of function

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11672 ) Change subject: Move TabletReplica::Stop() VLOG to end of function .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11666 to look at the new patch set (#8). Change subject: [tools] Add locate row tool

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 7: (1 comment)

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11665 ) Change subject: [tools] Add a describe table tool .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11666 to look at the new patch set (#9). Change subject: [tools] Add locate row tool

[kudu-CR] Move TabletReplica::Stop() VLOG to end of function

2018-10-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11672 ) Change subject: Move TabletReplica::Stop() VLOG to end of function .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] move ParseTableName to table util

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11658 ) Change subject: [sentry] move ParseTableName to table_util .. Patch Set 1: (4 comments)

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 9: (1 comment)

[kudu-CR] client: add tablet id to scanner error messages

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11645 ) Change subject: client: add tablet id to scanner error messages .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] backup: add script to run backup/restore benchmark

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11676 Change subject: backup: add script to run backup/restore benchmark .. backup: add script to run backup/restore benchmark Example

[kudu-CR] Create parallelized loader Spark job

2018-10-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11147 to look at the new patch set (#3). Change subject: Create parallelized loader Spark job .. Create

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 9: (1 comment)

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11665 ) Change subject: [tools] Add a describe table tool .. Patch Set 5: Would it be possible to output Impala-compatible syntax ala /table in

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 ) Change subject: Remove column ids from KuduSchema::ToString .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 ) Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 28: I think we can abandon this approach now that we

[kudu-CR] consensus: atomicize timestamp/opid assignment

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11144 ) Change subject: consensus: atomicize timestamp/opid assignment .. Patch Set 3: abandon? -- To view, visit

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11665 ) Change subject: [tools] Add a describe table tool .. Patch Set 5: Yeah, we can do that. Though, re: the CREATE TABLE on /table, we

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 9: Code-Review+2 LGTM as long as Andrew is good w/ it -- To view, visit

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11665 ) Change subject: [tools] Add a describe table tool .. Patch Set 5: Verified+1 Failure looks unrelated. -- To view, visit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11666 To

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11665 ) Change subject: [tools] Add a describe table tool .. Removed reviewer Kudu Jenkins. -- To view, visit

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [tools] Add a describe table tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11665 To unsubscribe, visit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 13: (13 comments) I don't see a place where we lazily choose the

[kudu-CR] disk failure: local testing for disk failure

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/7441 ) Change subject: disk failure: local testing for disk failure .. Abandoned Other tests subsumed testing of these disk failure code paths -- To

[kudu-CR] WIP tool to rewrite cfiles

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11078 ) Change subject: WIP tool to rewrite cfiles .. Abandoned not sure quite how useful this will be with automated CFile checksum error handling --

[kudu-CR] WIP disk failure: tests for disk failure recovery

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/7031 ) Change subject: WIP disk failure: tests for disk failure recovery .. Abandoned Other tests subsumed this sort of testing for disk failures -- To

[kudu-CR] Remove column ids from KuduSchema::ToString

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11668 ) Change subject: Remove column ids from KuduSchema::ToString .. Remove column ids from KuduSchema::ToString

[kudu-CR] consensus: atomicize timestamp/opid assignment

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11144 ) Change subject: consensus: atomicize timestamp/opid assignment .. Abandoned went with a different approach for KUDU-2463 -- To view, visit

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 ) Change subject: [tools] Add locate row tool .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-2463 pt 3: don't scan if MVCC hasn't moved

2018-10-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11428 ) Change subject: KUDU-2463 pt 3: don't scan if MVCC hasn't moved .. KUDU-2463 pt 3: don't scan if MVCC hasn't moved In cases

[kudu-CR](branch-1.8.x) Add release notes for 1.8.0

2018-10-12 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11647 ) Change subject: Add release notes for 1.8.0 .. Add release notes for 1.8.0 Change-Id:

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11665 to look at the new patch set (#2). Change subject: [tools] Add a describe table tool

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11666 Change subject: [tools] Add locate row tool .. [tools] Add locate row tool Sometimes while debugging I find it frustrating that it's

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11665 ) Change subject: [tools] Add a describe table tool .. Patch Set 1: (7 comments)

[kudu-CR] [tools] Add locate row tool

2018-10-12 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11666 to look at the new patch set (#2). Change subject: [tools] Add locate row tool

[kudu-CR] [tools] Add a describe table tool

2018-10-12 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11665 Change subject: [tools] Add a describe table tool .. [tools] Add a describe table tool This adds a very basic tool to describe a