[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15181 Change subject: [thirdparty] libcurl is now run-time dependency .. [thirdparty] libcurl is now run-time dependency Since we started usi

[kudu-CR] [util] use libcurl from thirdparty

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15180 Change subject: [util] use libcurl from thirdparty .. [util] use libcurl from thirdparty Since libcurl is now used not only as a build-

[kudu-CR] [cmake modules] shared libs for yaml and gumbo on macOS

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15182 Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS .. [cmake_modules] shared libs for yaml and gumbo on macOS I no

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2020-02-07 Thread Volodymyr Verovkin (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14517 to look at the new patch set (#16). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) ...

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2020-02-07 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 15: Changes in Java code do not i

[kudu-CR] KUDU-2973 Add semi-database support for Ranger

2020-02-07 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15018 to look at the new patch set (#13). Change subject: KUDU-2973 Add semi-database support for Ranger ...

[kudu-CR] KUDU-2973 Add semi-database support for Ranger

2020-02-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 ) Change subject: KUDU-2973 Add semi-database support for Ranger .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/15018/

[kudu-CR] KUDU-1438: [java] Upgrade to Netty 4

2020-02-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15136 ) Change subject: KUDU-1438: [java] Upgrade to Netty 4 .. Patch Set 6: (3 comments) I fixed TestAuthTokenReacquire which was failing ~20%

[kudu-CR] KUDU-1438: [java] Upgrade to Netty 4

2020-02-07 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15136 to look at the new patch set (#7). Change subject: KUDU-1438: [java] Upgrade to Netty 4

[kudu-CR] KUDU-1438: [java] Upgrade to Netty 4

2020-02-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15136 ) Change subject: KUDU-1438: [java] Upgrade to Netty 4 .. Patch Set 7: Test failure is unrelated, but I will rebase to get another clean r

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 16: Tests fail: java.lang.IllegalArgu

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 16: Backup test scenarios also fail, a

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2020-02-07 Thread Volodymyr Verovkin (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14517 to look at the new patch set (#17). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) ...

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15181 to look at the new patch set (#2). Change subject: [thirdparty] libcurl is now run-time dependency .

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-07 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14329 to look at the new patch set (#20). Change subject: [java] KUDU-2971: process communicates via protobuf-based proto

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 20: (1 comment) http://gerrit.cloudera.org

[kudu-CR] [util] use libcurl from thirdparty

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15180 ) Change subject: [util] use libcurl from thirdparty .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15180

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 2: This license seems Apache-compatible to me. Is that your

[kudu-CR] [cmake modules] shared libs for yaml and gumbo on macOS

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15182 ) Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-1438: [java] Upgrade to Netty 4

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15136 ) Change subject: KUDU-1438: [java] Upgrade to Netty 4 .. Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/1513

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 20: Code-Review+1 -- To view, visit htt

[kudu-CR] KUDU-1438: [java] Upgrade to Netty 4

2020-02-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15136 ) Change subject: KUDU-1438: [java] Upgrade to Netty 4 .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/15136/8/java/kudu

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 20: Code-Review+2 -- To view, visit ht

[kudu-CR] [clock] introduce time source auto selection

2020-02-07 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-02-07 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 13: (40 comments) http://gerrit.cloudera.org:8080/#/c/1417

[kudu-CR] [clock] introduce time source auto selection

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/15161/1//C

[kudu-CR] subprocess: add an optional sleep to Echo service

2020-02-07 Thread Andrew Wong (Code Review)
Hello Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15184 to review the following change. Change subject: subprocess: add an optional sleep to Echo service .. subprocess: add an o

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-07 Thread Andrew Wong (Code Review)
Hello Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15185 to review the following change. Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. [cpp] KUDU-29

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-02-07 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14177 to look at the new patch set (#14). Change subject: KUDU-2780: create thread for auto-rebalancing

[kudu-CR] [util] use libcurl from thirdparty

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15180 ) Change subject: [util] use libcurl from thirdparty .. [util] use libcurl from thirdparty Since libcurl is now used not only as

[kudu-CR] [clock] introduce time source auto selection

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15161/1

[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15187 Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest .. [tests] address flakiness in MasterReplicationAndR

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 2: > This license seems Apache-compatible to me. Is that

[kudu-CR] [clock] introduce time source auto selection

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15161/6/sr

[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15187 ) Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest .. Patch Set 1: Code-Review+2 (1 comment) http://gerr

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 2: > This license seems Apache-compatible to me. Is that

[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest

2020-02-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15187 to look at the new patch set (#2). Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest ..

[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15187 ) Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15187 ) Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest .. Patch Set 2: Code-Review+2 Out of curiosity, are th

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 2: > > This license seems Apache-compatible to me. Is tha

[kudu-CR] [clock] introduce time source auto selection

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15161/6

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15181/2/

[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15187 ) Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest .. [tests] address flakiness in MasterReplic

[kudu-CR] KUDU-1438: [java] Upgrade to Netty 4

2020-02-07 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15136 ) Change subject: KUDU-1438: [java] Upgrade to Netty 4 .. KUDU-1438: [java] Upgrade to Netty 4 This patch upgrades from Netty 3 to

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 12: (4 comments) http://gerri

[kudu-CR] [clock] declare 'system unsync' time source as unsafe

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15188 Change subject: [clock] declare 'system_unsync' time source as unsafe .. [clock] declare 'system_unsync' time source as unsafe Since it

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 4: (2 comments) http://gerrit.

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15166 ) Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .. Patch Set 1: (4 comments) http://gerrit.c

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 4: (5 comments) http://gerrit.cloudera.o

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15166 to look at the new patch set (#2). Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#13). Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15121 to look at the new patch set (#5). Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#5). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client ..

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2971 p2: add basic protobuf msg .. Patch Set 19: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/144

[kudu-CR] [clock] introduce time source auto selection

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] introduce time source auto selection .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15161/6/

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-07 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. [java] KUDU-2971: process communicates via pro

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-07 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2971 p2: add basic protobuf msg .. KUDU-2971 p2: add basic protobuf msg This commit adds some basic protobuf me

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-02-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2971 p2: add basic protobuf msg .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/14426/19//COMMIT_MSG

[kudu-CR] [clock] declare 'system unsync' time source as unsafe

2020-02-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15188 to look at the new patch set (#2). Change subject: [clock] declare 'system_unsync' time source as unsafe ...

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15181 to look at the new patch set (#3). Change subject: [thirdparty] libcurl is now run-time dependency .

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15181

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [clock] declare 'system unsync' time source as unsafe

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15188 ) Change subject: [clock] declare 'system_unsync' time source as unsafe .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 13: > In general, the bloom filter

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 5: Verified+1 Overriding Jenkins, f

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 5: Code-Review+2 (1 comment) http:

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15166 ) Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8

[kudu-CR] [thirdparty] libcurl is now run-time dependency

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15181 ) Change subject: [thirdparty] libcurl is now run-time dependency .. [thirdparty] libcurl is now run-time dependency Since we st

[kudu-CR] [clock] declare 'system unsync' time source as unsafe

2020-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15188 ) Change subject: [clock] declare 'system_unsync' time source as unsafe .. [clock] declare 'system_unsync' time source as unsafe