[kudu-CR] WIP: [tools] added insert-generated-rows into kudu tools

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#9). Change subject: WIP: [tools] added insert-generated-rows into kudu tools .. WIP:

[kudu-CR] [util] minor clean-up on kudu::Subprocess

Todd Lipcon has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

Alexey Serbin has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File sr

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

Alexey Serbin has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File sr

[kudu-CR] [c++compilation] fixed 'unused' warnings

Alexey Serbin has posted comments on this change. Change subject: [c++compilation] fixed 'unused' warnings .. Patch Set 1: (1 comment) Oops, it seems I pressed 'Submit' instead of reply. Anyway, I'm definitely open to change

[kudu-CR] [c++compilation] fixed 'unused' warnings

Alexey Serbin has submitted this change and it was merged. Change subject: [c++compilation] fixed 'unused' warnings .. [c++compilation] fixed 'unused' warnings Use DCHECK() instead of DCHECK_NOTNULL() as recommended by glog/log

[kudu-CR] docs: add master permanent failure recovery workflow

Adar Dembo has posted comments on this change. Change subject: docs: add master permanent failure recovery workflow .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4436/1/docs/administration.adoc File docs/adm

[kudu-CR] docs: add master permanent failure recovery workflow

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4436 to look at the new patch set (#2). Change subject: docs: add master permanent failure recovery workflow .. docs: ad

[kudu-CR] thirdparty: upgrade LLVM to 3.9.0

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4507 to review the following change. Change subject: thirdparty: upgrade LLVM to 3.9.0 .. thirdparty: upgrade

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4514 to review the following change. Change subject: thirdparty: stifle unused argument warnings when building with clang

[kudu-CR] thirdparty: upgrade cmake to 3.6.1

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4506 to review the following change. Change subject: thirdparty: upgrade cmake to 3.6.1 .. thirdparty: upgrade

[kudu-CR] c++ client: adjust kudu::client::sp

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4510 to review the following change. Change subject: c++ client: adjust kudu::client::sp .. c++ client: adjust

[kudu-CR] c++ client: stop requiring the old gcc ABI

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4515 to review the following change. Change subject: c++ client: stop requiring the old gcc ABI .. c++ client:

[kudu-CR] tsan-suppressions: suppress various glog/gflags data races

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4509 to review the following change. Change subject: tsan-suppressions: suppress various glog/gflags data races ...

[kudu-CR] thirdparty: fix up libtool scripts if needed

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4512 to review the following change. Change subject: thirdparty: fix up libtool scripts if needed .. thirdpart

[kudu-CR] ensure every gflag is defined outside of a namespace

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4505 to review the following change. Change subject: ensure every gflag is defined outside of a namespace .. e

[kudu-CR] thirdparty: patch glog to omit tests from build

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4508 to review the following change. Change subject: thirdparty: patch glog to omit tests from build .. thirdp

[kudu-CR] thirdparty: split into dependency groups

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4513 to review the following change. Change subject: thirdparty: split into dependency groups .. thirdparty: s

[kudu-CR] thirdparty: use libc++ instead libstdc++ for TSAN builds

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4511 to review the following change. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds .

[kudu-CR] [c++compilation] fixed 'unused' warnings

Adar Dembo has posted comments on this change. Change subject: [c++compilation] fixed 'unused' warnings .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4503/1/src/kudu/codegen/row_projector.cc Fil

[kudu-CR] [website] broken link to an adoc

Will Berkeley has posted comments on this change. Change subject: [website] broken link to an adoc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4504 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] [website] broken link to an adoc

Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4504 Change subject: [website] broken link to an adoc .. [website] broken link to an adoc Change-Id: I8fe88073807eceb8927d6ca7ddf109bd0a

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

Brock Noland has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (12 comments) Still have work todo, but wanted to wanted to get these comments out of my buffer.

[kudu-CR] [c++compilation] fixed 'unused' warnings

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4503 Change subject: [c++compilation] fixed 'unused' warnings .. [c++compilation] fixed 'unused' warnings Use DCHECK() instead of DCHECK_NOTN

[kudu-CR] [util] minor clean-up on kudu::Subprocess

Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [util] minor clean-up on kudu::Subprocess

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4502 Change subject: [util] minor clean-up on kudu::Subprocess .. [util] minor clean-up on kudu::Subprocess Do not call CHECK_EQ() in case wh

[kudu-CR] [java client] Reinstate KUDU-1364's behavior, fix NPE

Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4501 Change subject: [java client] Reinstate KUDU-1364's behavior, fix NPE .. [java client] Reinstate KUDU-1364's behavior, fix NPE When

[kudu-CR] [java client] Few ITClient improvements

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Few ITClient improvements .. [java client] Few ITClient improvements ITClient has been flaky for a while now, mostly due to the "Row

[kudu-CR] [java client] Fix an NPE in KuduException

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Fix an NPE in KuduException .. [java client] Fix an NPE in KuduException Saw this in a Jenkins run and also running ITClient on my ma

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. [java client] Improve and hide OperationResponse#getWriteTimestamp That meth

[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers

Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4450/5/src/kud

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Adar Dembo has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4487 To unsubsc

[kudu-CR] [java client] Few ITClient improvements

Adar Dembo has posted comments on this change. Change subject: [java client] Few ITClient improvements .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4489 To unsubscribe, visit http://gerrit.cl

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Adar Dembo has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client/src/mai

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

David Ribeiro Alves has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4487 T

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client

[kudu-CR] [java client] Few ITClient improvements

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4489 to look at the new patch set (#3). Change subject: [java client] Few ITClient improvements .. [java client] Few ITC

[kudu-CR] [java client] Few ITClient improvements

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Few ITClient improvements .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4489/1/java/kudu-client/src/test/java/org/apache/ku

[kudu-CR] [java client] Few ITClient improvements

Adar Dembo has posted comments on this change. Change subject: [java client] Few ITClient improvements .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4489/1/java/kudu-client/src/test/java/org/apache/kudu/clien

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Adar Dembo has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client/src/mai

[kudu-CR] [java client] Few ITClient improvements

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4489 to look at the new patch set (#2). Change subject: [java client] Few ITClient improvements .. [java client] Few ITC

[kudu-CR] [java client] Few ITClient improvements

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Few ITClient improvements .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4489/1/java/kudu-client/src/test/java/org/apache/k

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client

[kudu-CR] [java client] Fix an NPE in KuduException

Adar Dembo has posted comments on this change. Change subject: [java client] Fix an NPE in KuduException .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4488 To unsubscribe, visit http://gerrit.

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Adar Dembo has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client/src/mai

[kudu-CR] [java client] Fix an NPE in KuduException

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4488 to look at the new patch set (#2). Change subject: [java client] Fix an NPE in KuduException .. [java client] Fix a

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4487 to look at the new patch set (#2). Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-clien

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

David Ribeiro Alves has submitted this change and it was merged. Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 .. Patch gperftools to be able to work on macOS Sierra/XCode 8 Apparently gperftools n

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4492 to look at the new patch set (#4). Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. [client

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

Alexey Serbin has posted comments on this change. Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4492/3/src/kudu/client/client-test.cc File

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

Alexey Serbin has posted comments on this change. Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4492/3/src/kudu/client/client-test.cc File

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4477 to look at the new patch set (#5). Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session .. [twitter-dem

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

David Ribeiro Alves has posted comments on this change. Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4492/3/src/kudu/client/client-test.c

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

Adar Dembo has posted comments on this change. Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4495 To unsubscribe, vi

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 .. Patch gperftools to be able to work on macOS Sierra/XCode 8 Apparently gperftools needs to be

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

David Ribeiro Alves has posted comments on this change. Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4495/1/thirdparty/download-th

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4492 to look at the new patch set (#3). Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. [client

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

Alexey Serbin has submitted this change and it was merged. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND In tests, run KuduSession in AUTO_FLUSH_BACKGROUND inst

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

Alexey Serbin has posted comments on this change. Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4492/1/src/kudu/client/client-test.cc File

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4492 to look at the new patch set (#2). Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. [client

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

Adar Dembo has posted comments on this change. Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4495/1/thirdparty/download-thirdparty.

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4495 Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 .. Patch gperftools to be able to work on macOS Sierra/

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

David Ribeiro Alves has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4471 To unsubscribe, visit

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

Alexey Serbin has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4471/3/src/kudu/integration-tests/all_types-ites

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4471 to look at the new patch set (#6). Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. [tests] MANUAL

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

Dan Burkert has submitted this change and it was merged. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. cli tool: List all tablets/replica_uuids with 'kudu table list' I noticed that given a

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

David Ribeiro Alves has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. Patch Set 5: (2 comments) oops had a unpublished comment. my apologies. http://gerrit.cloudera.org:8080

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

David Ribeiro Alves has posted comments on this change. Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4492/1/src/kudu/client/client-test.c

[kudu-CR] [java client] Improve and hide OperationResponse#getWriteTimestamp

David Ribeiro Alves has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-clien

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

David Ribeiro Alves has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (17 comments) http://gerrit.cloudera.org:8080/#/c/4491/2/java/kudu-client/src/main/java/org

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

David Ribeiro Alves has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: At first glance I'd start by suggesting you split the patches for the various clients. Diff

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#2). Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. [WIP] KUDU-156