[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#5). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] Bump LLVM to 4.0.0

Dan Burkert has submitted this change and it was merged. Change subject: Bump LLVM to 4.0.0 .. Bump LLVM to 4.0.0 I'm working on integrating Thrift into the Kudu build, and hit https://reviews.llvm.org/D22800, which is fixed

[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin

Hello David Ribeiro Alves, Grant Henke, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7070 to review the following change. Change subject: [java-client] update protoc maven plugin

[kudu-CR] Bump LLVM to 4.0.0

Adar Dembo has posted comments on this change. Change subject: Bump LLVM to 4.0.0 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7069 To unsubscribe, visit

[kudu-CR] Bump LLVM to 4.0.0

Dan Burkert has posted comments on this change. Change subject: Bump LLVM to 4.0.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7069/2/thirdparty/vars.sh File thirdparty/vars.sh: Line 128: # Our llvm

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#4). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] Bump LLVM to 4.0.0

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7069 to look at the new patch set (#3). Change subject: Bump LLVM to 4.0.0 .. Bump LLVM to 4.0.0 I'm working on

[kudu-CR] Bump LLVM to 4.0.0

Adar Dembo has posted comments on this change. Change subject: Bump LLVM to 4.0.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7069/2/thirdparty/vars.sh File thirdparty/vars.sh: Line 128: # Our llvm

[kudu-CR](branch-1.3.x) KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet

Dan Burkert has posted comments on this change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet .. Patch Set 1: The protobuf plugin repo is down, so builds are

[kudu-CR] Bump LLVM to 4.0.0

Dan Burkert has posted comments on this change. Change subject: Bump LLVM to 4.0.0 .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7069/1//COMMIT_MSG Commit Message: Line 7: Bump LLVM to 4.0.0 > Can you

[kudu-CR] Bump LLVM to 4.0.0

Dan Burkert has uploaded a new patch set (#2). Change subject: Bump LLVM to 4.0.0 .. Bump LLVM to 4.0.0 I'm working on integrating Thrift into the Kudu build, and hit https://reviews.llvm.org/D22800, which is fixed in 4.0.0.

[kudu-CR] WIP: Add basic Hive MetaStore client

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#2). Change subject: WIP: Add basic Hive MetaStore client .. WIP: Add basic Hive

[kudu-CR] Bump LLVM to 4.0.0

Adar Dembo has posted comments on this change. Change subject: Bump LLVM to 4.0.0 .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7069/1//COMMIT_MSG Commit Message: Line 7: Bump LLVM to 4.0.0 Can you explain

[kudu-CR] Bump LLVM to 4.0.0

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7069 to review the following change. Change subject: Bump LLVM to 4.0.0 .. Bump LLVM to 4.0.0 Change-Id:

[kudu-CR] Add fault injection of EIOs

Andrew Wong has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 11: (7 comments) Haven't addressed everything, marked some "will do"s. Pushed after rebasing as along with the EMC

[kudu-CR] Add fault injection of EIOs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#11). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] external minicluster: expand EMC dir usage

Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: (7 comments) Retriggered after rebasing to master for tsan build.

[kudu-CR] external minicluster: expand EMC dir usage

Adar Dembo has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: (1 comment)

[kudu-CR] tool: add a 'pbc edit' command

Adar Dembo has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/tool_action_pbc.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#8). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] external minicluster: expand EMC dir usage

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#21). Change subject: external minicluster: expand EMC dir usage ..

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

Adar Dembo has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 1: (4 comments) > curious whether you think this is still useful considering the > 'kudu pbc edit'

[kudu-CR] external minicluster: expand EMC dir usage

Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: (1 comment)

[kudu-CR] external minicluster: expand EMC dir usage

Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: (1 comment)

[kudu-CR] Add fault injection of EIOs

Adar Dembo has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc:

[kudu-CR] disk failure: make DataDirManager failure-aware

Adar Dembo has posted comments on this change. Change subject: disk failure: make DataDirManager failure-aware .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/7028/1/src/kudu/fs/data_dirs-test.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (7 comments)

[kudu-CR] external minicluster: expand EMC dir usage

Adar Dembo has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: (6 comments) http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/CMakeLists.txt

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#7). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] external minicluster: expand EMC dir usage

Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 17: (5 comments) Yep, added the results to the commit message

[kudu-CR] external minicluster: expand EMC dir usage

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#20). Change subject: external minicluster: expand EMC dir usage ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 45: Code-Review+2 Verified+1 Known flake, let's override Jenkins. -- To view, visit

[kudu-CR] Add a workaround for LSAN bug #757

Mike Percy has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc File

[kudu-CR] Add a workaround for LSAN bug #757

Mike Percy has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7052 To unsubscribe, visit

[kudu-CR] external minicluster: expand EMC dir usage

Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: (5 comments) I don't think the test should be flaky anymore but did you try a few dist-test loops?

[kudu-CR] external minicluster: expand EMC dir usage

Todd Lipcon has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit

[kudu-CR] external minicluster: expand EMC dir usage

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#19). Change subject: external minicluster: expand EMC dir usage ..

[kudu-CR] external minicluster: expand EMC dir usage

Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-1952 Remove round-robin for block placement

Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 45: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tablet/tablet_metadata.h File

[kudu-CR] external minicluster: expand EMC dir usage

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#18). Change subject: external minicluster: expand EMC dir usage ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#45). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Todd Lipcon has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7037/3/src/kudu/client/scanner-internal.cc

[kudu-CR] consensus: Remove Consensus interface

Mike Percy has posted comments on this change. Change subject: consensus: Remove Consensus interface .. Patch Set 3: Code-Review+2 Rolling forward +1 from Todd and +2 from David after include-ordering fixes. -- To view,

[kudu-CR] consensus: Remove Consensus interface

Mike Percy has submitted this change and it was merged. Change subject: consensus: Remove Consensus interface .. consensus: Remove Consensus interface We only have one Consensus implementation now, and have no plans for

[kudu-CR] external minicluster: expand EMC dir usage

Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 17: (9 comments) http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/fs/fs_manager.h File

[kudu-CR] external minicluster: expand EMC dir usage

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#17). Change subject: external minicluster: expand EMC dir usage .. external

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#3). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

Alexey Serbin has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7037/2/src/kudu/client/scanner-internal.cc

[kudu-CR](branch-1.3.x) KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet

Dan Burkert has posted comments on this change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet .. Patch Set 1: Failed due to the CI protobuf upgrade issues.

[kudu-CR](branch-1.3.x) KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet

Hello Jean-Daniel Cryans, Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7057 to review the following change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated

[kudu-CR] Add a workaround for LSAN bug #757

Todd Lipcon has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc File

[kudu-CR] consensus: Remove Consensus interface

Hello David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7040 to look at the new patch set (#3). Change subject: consensus: Remove Consensus interface

[kudu-CR] consensus: Remove Consensus interface

Mike Percy has posted comments on this change. Change subject: consensus: Remove Consensus interface .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7040/2/src/kudu/consensus/leader_election.h File

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 2: (4 comments)

[kudu-CR] Add a workaround for LSAN bug #757

David Ribeiro Alves has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc File

[kudu-CR] consensus: Remove Consensus interface

David Ribeiro Alves has posted comments on this change. Change subject: consensus: Remove Consensus interface .. Patch Set 2: Code-Review+1 (2 comments) lgtm, just found a couple of minor nits. Feel free to upgrade +2 when