[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 3: (4 comments)

[kudu-CR] [tests] fixed flake in delete table-itest

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [tests] fixed flake in delete_table-itest .. [tests] fixed flake in delete_table-itest Fixed flake in DeleteTableITest.TestNoDeleteTombstonedTablets: if leader

[kudu-CR] [tests] fixed flake in delete table-itest

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7972 Change subject: [tests] fixed flake in delete_table-itest .. [tests] fixed flake in delete_table-itest Fixed flake in

[kudu-CR] KUDU-1807: improve IsCreateInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1807: improve IsCreateInProgress performance .. Patch Set 2: (11 comments) > Is there any way we can add a debug-mode consistency check of some > sort that

[kudu-CR] KUDU-1807: improve IsCreateInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7957 to look at the new patch set (#3). Change subject: KUDU-1807: improve IsCreateInProgress performance .. KUDU-1807:

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/1/src/kudu/cfile/encoding-test.cc File

[kudu-CR] catalog manager: improve IsAlterInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: catalog_manager: improve IsAlterInProgress performance .. catalog_manager: improve IsAlterInProgress performance To mentally prepare for KUDU-1807, I

[kudu-CR] cow object: lazily copy dirty state

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: cow_object: lazily copy dirty state .. cow_object: lazily copy dirty state This addresses a long-standing TODO that ought to improve performance of tablet

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/1//COMMIT_MSG Commit Message: Line 16: The fix just

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7966/1//COMMIT_MSG Commit

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/1/src/kudu/cfile/encoding-test.cc File

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-05 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7961 to look at the new patch set (#3). Change subject: tablet copy: Allow voting from crashed initial tablet copies ..

[kudu-CR](branch-1.2.x) KUDU-2083. Decrement running maintenance ops on failed prepare

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7970 Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed

[kudu-CR](branch-1.3.x) KUDU-2083. Decrement running maintenance ops on failed prepare

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7969 Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed

[kudu-CR](branch-1.4.x) KUDU-2083. Decrement running maintenance ops on failed prepare

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7968 Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed

[kudu-CR] KUDU-2119. Fix failure in encoding-test

2017-09-05 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7967 to review the following change. Change subject: KUDU-2119. Fix failure in encoding-test .. KUDU-2119. Fix failure

[kudu-CR] KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. KUDU-2130 (part 2): more fixes for ITClientStress This fixes some more race conditions in connection

[kudu-CR] KUDU-2134: Defer block transaction commit to the end of a tablet copy

2017-09-05 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/7966 Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy .. KUDU-2134: Defer block transaction commit to the end

[kudu-CR] Implement a lock table

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement a lock table .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7918/2/src/kudu/util/lock_table.h File src/kudu/util/lock_table.h: PS2,

[kudu-CR] KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. Patch Set 2: Code-Review+2 (2 comments)

[kudu-CR] KUDU-1807: improve IsCreateInProgress performance

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807: improve IsCreateInProgress performance .. Patch Set 2: (11 comments) I only partially followed this patch... it's one of those ones that's hard to

[kudu-CR] cow object: lazily copy dirty state

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: cow_object: lazily copy dirty state .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7951 To unsubscribe, visit

[kudu-CR] catalog manager: improve IsAlterInProgress performance

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: catalog_manager: improve IsAlterInProgress performance .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7950 To unsubscribe, visit

[kudu-CR] KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7964 to look at the new patch set (#2). Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. KUDU-2130

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-05 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7961 to look at the new patch set (#2). Change subject: tablet copy: Allow voting from crashed initial tablet copies ..

[kudu-CR] KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-2130 (part 2): more fixes for ITClientStress

2017-09-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7964 to review the following change. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. KUDU-2130: java client: handle termination during negotiation edge case

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7961/1//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 3: Code-Review+2 Results prior to applying this patch:

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7961/1//COMMIT_MSG Commit Message:

[kudu-CR] tablet copy: Allow voting from crashed initial tablet copies

2017-09-05 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7961 to review the following change. Change subject: tablet copy: Allow voting from crashed initial tablet copies

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7960 to look at the new patch set (#3). Change subject: KUDU-2130: java client: handle termination during negotiation edge case

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7960

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7960 to look at the new patch set (#2). Change subject: KUDU-2130: java client: handle termination during negotiation edge case

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 2: (3 comments)

[kudu-CR] catalog manager: improve IsAlterInProgress performance

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: improve IsAlterInProgress performance .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7950 To unsubscribe, visit

[kudu-CR] cow object: lazily copy dirty state

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: cow_object: lazily copy dirty state .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7951 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/6968/10/src/kudu/tablet/diskrowset.cc File

[kudu-CR] cow object: lazily copy dirty state

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cow_object: lazily copy dirty state .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7951/1/src/kudu/util/cow_object.h File

[kudu-CR] KUDU-1807: improve IsCreateInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7957 to look at the new patch set (#2). Change subject: KUDU-1807: improve IsCreateInProgress performance .. KUDU-1807:

[kudu-CR] catalog manager: improve IsAlterInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: improve IsAlterInProgress performance .. Patch Set 2: (3 comments) > What's your thoughts on test coverage, are you assuming we have > enough

[kudu-CR] cow object: lazily copy dirty state

2017-09-05 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7951 to look at the new patch set (#2). Change subject: cow_object: lazily copy dirty state .. cow_object:

[kudu-CR] catalog manager: improve IsAlterInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7950 to look at the new patch set (#3). Change subject: catalog_manager: improve IsAlterInProgress performance ..

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2130: java client: handle termination during negotiation edge case

2017-09-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7960 to review the following change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case

[kudu-CR] [tidy] updated the 'tidy' target

2017-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tidy] updated the 'tidy' target .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7947/2/build-support/clang_tidy_gerrit.py File

[kudu-CR] [tidy] updated the 'tidy' target

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tidy] updated the 'tidy' target .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7947/2/build-support/clang_tidy_gerrit.py File

[kudu-CR] kudu-tool-test: find path to false at runtime

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: kudu-tool-test: find path to false at runtime .. kudu-tool-test: find path to false at runtime On macos the false binary is in /usr/bin/false.

[kudu-CR] kudu-tool-test: find path to false at runtime

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kudu-tool-test: find path to false at runtime .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7959 To unsubscribe, visit

[kudu-CR] kudu-tool-test: find path to false at runtime

2017-09-05 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7959 to review the following change. Change subject: kudu-tool-test: find path to false at runtime .. kudu-tool-test: find

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2017-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#13). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] cow object: lazily copy dirty state

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: cow_object: lazily copy dirty state .. Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/7951/1/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: improve IsAlterInProgress performance

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: improve IsAlterInProgress performance .. Patch Set 2: (3 comments) What's your thoughts on test coverage, are you assuming we have enough

[kudu-CR] feat: add task interruption checking for RowIterator

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: feat: add task interruption checking for RowIterator .. Patch Set 5: Yep, looks like it was just a flaky test. Thanks caiconghui! -- To view, visit

[kudu-CR] feat: add task interruption checking for RowIterator

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: feat: add task interruption checking for RowIterator .. feat: add task interruption checking for RowIterator Once we the submit a spark job to spark

[kudu-CR] feat: add task interruption checking for RowIterator

2017-09-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: feat: add task interruption checking for RowIterator .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7753 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#12). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 11: Odd...I compiled and ran some tests just before pushing this to review. And TSAN worked.

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#11). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 10: (11 comments)

[kudu-CR] KUDU-1807: improve IsCreateInProgress performance

2017-09-05 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7957 to review the following change. Change subject: KUDU-1807: improve IsCreateInProgress performance ..