David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 19:
(1 comment)
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8099
to look at the new patch set (#2).
Change subject: standard notation for fixed-size integer type names
Adar Dembo has posted comments on this change.
Change subject: standard notation for fixed-size integer type names
..
Patch Set 1: Code-Review+2
Looks OK to me, though I'm curious whether Todd thinks we should stay with the
Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: make ScopedTabletInfoCommitter generic
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h
File
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: make ScopedTabletInfoCommitter generic
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h
File
Andrew Wong has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8093/3/docs/troubleshooting.adoc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups
of blocks
..
Patch Set 6:
(9 comments)
Here's my first pass. I'll do a deeper pass after you've
Adar Dembo has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc
File
David Ribeiro Alves has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 3: Code-Review+1
lgtm adar's nits
--
To view, visit
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8045
To
Dan Burkert has posted comments on this change.
Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8045
To unsubscribe,
Adar Dembo has submitted this change and it was merged.
Change subject: data_dirs: fix a LOG statement
..
data_dirs: fix a LOG statement
This is currently logging like so:
No directories available to add to
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1807 (part 1): deprecate GetTableSchema.create_table_done
..
KUDU-1807 (part 1): deprecate GetTableSchema.create_table_done
Improving
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in
clients
..
Patch Set 5: Code-Review+2
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-2135 (part 2): don't use previously failed disks
..
Patch Set 30:
(2 comments)
Not many new comments from me since I already reviewed this a while ago, and
Adar Dembo has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8093/3/src/kudu/fs/fs_manager.cc
File
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint
interval list
..
Patch Set 1:
(1 comment)
Todd Lipcon has posted comments on this change.
Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint
interval list
..
Patch Set 2:
(5 comments)
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [docs] fixup releasing git instructions
..
[docs] fixup releasing git instructions
Change-Id: I83f98350ddcaf062477db1ee0b90f1811f87524b
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] fixup releasing git instructions
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7876
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-2135 (part 1): add persistent disk states
..
Patch Set 7:
(14 comments)
I think Todd should review this.
Will Berkeley has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint
interval list
..
Patch Set 2:
(21 comments)
http://gerrit.cloudera.org:8080/#/c/8041/1//COMMIT_MSG
Commit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8041
to look at the new patch set (#2).
Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint
interval list
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 19:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc
File
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6968
to look at the new patch set (#21).
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
Will Berkeley has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 21:
Something mysterious happened and so 19 + 1 = 21.
--
To view, visit
Will Berkeley has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 19:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/consensus/log.h
File
David Ribeiro Alves has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc
Adar Dembo has posted comments on this change.
Change subject: [iwyu] update std::move
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8088/1/build-support/iwyu/mappings/libstdcpp.imp
File
Dan Burkert has submitted this change and it was merged.
Change subject: Bump protobuf to 3.4.1
..
Bump protobuf to 3.4.1
This allows us to drop the 'experimental' flag for move constructors
introduced in 1632d16aa5993, since
Adar Dembo has submitted this change and it was merged.
Change subject: c++ client: try harder to pass table IDs into RPCs that can
accept them
..
c++ client: try harder to pass table IDs into RPCs that can accept them
Some
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] update std::move
..
Patch Set 1:
(26 comments)
Thank you for the review.
Adar Dembo has posted comments on this change.
Change subject: Bump protobuf to 3.4.1
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8086
To unsubscribe, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8093
to look at the new patch set (#2).
Change subject: Link to troubleshooting docs for two common problems
..
Link to
Dan Burkert has posted comments on this change.
Change subject: [docs] fixup releasing git instructions
..
Patch Set 3:
This is ready to review
--
To view, visit http://gerrit.cloudera.org:8080/7876
To unsubscribe, visit
Dan Burkert has posted comments on this change.
Change subject: kudu-spark: change default master address to local fqdn
..
Patch Set 2:
(1 comment)
Dan Burkert has posted comments on this change.
Change subject: WIP: Import ArrayView type from WebRTC
..
Patch Set 1:
woops. duplicate.
--
To view, visit http://gerrit.cloudera.org:8080/8095
To unsubscribe, visit
Dan Burkert has abandoned this change.
Change subject: WIP: Import ArrayView type from WebRTC
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/8095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8095
to review the following change.
Change subject: WIP: Import ArrayView type from WebRTC
..
WIP: Import ArrayView type
Mike Percy has posted comments on this change.
Change subject: docs: clarify steps for changing master from multi-master
deployment
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8032
To
Mike Percy has submitted this change and it was merged.
Change subject: docs: clarify steps for changing master from multi-master
deployment
..
docs: clarify steps for changing master from multi-master deployment
The current
Andrew Wong has posted comments on this change.
Change subject: docs: clarify steps for changing master from multi-master
deployment
..
Patch Set 3:
(1 comment)
Mike Percy has posted comments on this change.
Change subject: docs: clarify steps for changing master from multi-master
deployment
..
Patch Set 3:
(1 comment)
David Ribeiro Alves has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7019
To unsubscribe, visit
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Kudu Consistency Blog Post Pt1
..
Kudu Consistency Blog Post Pt1
This is the first part of multi-part blog post series about
consistency in Kudu.
Will Berkeley has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7019
To unsubscribe, visit
Hello Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7019
to look at the new patch set (#14).
Change subject: Kudu Consistency Blog Post Pt1
..
Kudu Consistency Blog Post
David Ribeiro Alves has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7019/13/_posts/2017-09-18-kudu-consistency-pt1.md
File
Will Berkeley has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 13:
(1 comment)
One thing then I'm +2
David Ribeiro Alves has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 11:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/7019/12/_posts/2017-08-21-kudu-consistency-pt1.md
File
Hello Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7019
to look at the new patch set (#13).
Change subject: Kudu Consistency Blog Post Pt1
..
Kudu Consistency Blog Post
Dan Burkert has posted comments on this change.
Change subject: Bump protobuf to 3.4.1
..
Patch Set 2:
Yeah this seems to be protobuf's MO:
https://github.com/google/protobuf/issues/3602
--
To view, visit
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8086
to look at the new patch set (#3).
Change subject: Bump protobuf to 3.4.1
..
Bump protobuf to 3.4.1
Dan Burkert has posted comments on this change.
Change subject: Bump protobuf to 3.4.1
..
Patch Set 2:
https://github.com/google/protobuf/issues/3656
I'm going to change it back to 3.4.0 in the meantime, since I suspect it
Dan Burkert has posted comments on this change.
Change subject: c++ client: try harder to pass table IDs into RPCs that can
accept them
..
Patch Set 3:
(1 comment)
Will Berkeley has posted comments on this change.
Change subject: Link to troubleshooting docs for two common problems
..
Patch Set 1:
Not really for review just yet- will be IWYU things to fix and I want a unit
test run
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8093
Change subject: Link to troubleshooting docs for two common problems
..
Link to troubleshooting docs for two common problems
>From
Alexey Serbin has posted comments on this change.
Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader
..
Patch Set 2:
> can you explain a little better the exact scenario that happens?
> could you cause it
David Ribeiro Alves has posted comments on this change.
Change subject: data_dirs: fix a LOG statement
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8091
To unsubscribe, visit
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8045
To
David Ribeiro Alves has posted comments on this change.
Change subject: c++ client: try harder to pass table IDs into RPCs that can
accept them
..
Patch Set 4: Code-Review+2
--
To view, visit
Alexey Serbin has posted comments on this change.
Change subject: c++ client: try harder to pass table IDs into RPCs that can
accept them
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8066
64 matches
Mail list logo
