[kudu-CR] Fix JIRA number typo in test name

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10225 ) Change subject: Fix JIRA number typo in test name .. Fix JIRA number typo in test name Change-Id: I8ffc7f96c15aceb9a552262d4a9

[kudu-CR] Fix JIRA number typo in test name

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10225 ) Change subject: Fix JIRA number typo in test name .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10225

[kudu-CR] Retry pre-move ksck check in case of transient errors

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10226 ) Change subject: Retry pre-move ksck check in case of transient errors .. Patch Set 1: Unrelated flake. -- To view, visit http://gerr

[kudu-CR] Fix JIRA number typo in test name

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10225 ) Change subject: Fix JIRA number typo in test name .. Patch Set 1: Unrelated flake. -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] Retry pre-move ksck check in case of transient errors

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10226 ) Change subject: Retry pre-move ksck check in case of transient errors .. Retry pre-move ksck check in case of transient errors

[kudu-CR] Retry pre-move ksck check in case of transient errors

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Retry pre-move ksck check in case of transient errors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10226 To unsubs

[kudu-CR] Retry pre-move ksck check in case of transient errors

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10226 ) Change subject: Retry pre-move ksck check in case of transient errors .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clou

[kudu-CR] Fix JIRA number typo in test name

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Fix JIRA number typo in test name .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10225 To unsubscribe, visit http://

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-26 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10151 to look at the new patch set (#10). Change subject: [tools] ksck improvements [6/n]: Refactor result handling ..

[kudu-CR] [tools] ksck improvements [6/n]: Refactor printing

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor printing .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [tools] ksck improvements [6/n]: Refactor printing

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor printing .. Patch Set 5: (16 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-26 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10187 to look at the new patch set (#3). Change subject: [Java] Use spotbugs in place of findbugs in gradle .

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10215 ) Change subject: [Java] Check in the Gradle wrapper properties .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10215/1//

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-26 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10215 to look at the new patch set (#2). Change subject: [Java] Check in the Gradle wrapper properties ..

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10215 ) Change subject: [Java] Check in the Gradle wrapper properties .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10215/1//C

[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10219 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Patch Set 1: Verified+1 Code-Review+2 -- To

[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10219 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. java: fix a mistaken reference-equali

[kudu-CR] Retry pre-move ksck check in case of transient errors

2018-04-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10226 ) Change subject: Retry pre-move ksck check in case of transient errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] Fix JIRA number typo in test name

2018-04-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10225 ) Change subject: Fix JIRA number typo in test name .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10225

[kudu-CR] Retry pre-move ksck check in case of transient errors

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10226 Change subject: Retry pre-move ksck check in case of transient errors .. Retry pre-move ksck check in case of transient errors ksck som

[kudu-CR] Fix JIRA number typo in test name

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10225 Change subject: Fix JIRA number typo in test name .. Fix JIRA number typo in test name Change-Id: I8ffc7f96c15aceb9a552262d4a99241834d5

[kudu-CR] KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

2018-04-26 Thread Anonymous Coward (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10072 to look at the new patch set (#5). Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python .

[kudu-CR] [tools] ksck improvements [6/n]: Refactor printing

2018-04-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor printing .. Patch Set 9: (16 comments) Most entirely nits, I think this would

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Patch Set 2: I can work on switching over to testng and using test gro

[kudu-CR] KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

2018-04-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10072 ) Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python .. Patch Set 4: (1 comment) thanks for the explan

[kudu-CR] docs: workflow for backing up or restoring an entire node

2018-04-26 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10223 to review the following change. Change subject: docs: workflow for backing up or restoring an entire node .

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 5: (1 comment) http://gerrit.cloudera.or

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 5: (2 comments) http://gerrit.cl

[kudu-CR] [java] Fix the high priority spotbugs warings

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10221 ) Change subject: [java] Fix the high priority spotbugs warings .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] [java] Fix the high priority spotbugs warings

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10221 ) Change subject: [java] Fix the high priority spotbugs warings .. [java] Fix the high priority spotbugs warings None of these are

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10187 ) Change subject: [Java] Use spotbugs in place of findbugs in gradle .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1018

[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10203 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. java: fix a mistaken reference-equali

[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10203 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Patch Set 2: Verified+1 Code-Review+2 Portin

[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] java: fix remainder of error-prone issues

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. java: fix remainder of error-prone issues - Suppress a few false po

[kudu-CR] java: fix remainder of error-prone issues

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: java: fix remainder of error-prone issues .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10202 To unsubscribe, visit h

[kudu-CR] java: fix remainder of error-prone issues

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10199 ) Change subject: java: fix minor synchronization issues exposed by error-prone .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] java: fix various test style issues

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10201 ) Change subject: java: fix various test style issues .. java: fix various test style issues error-prone flagged a number of cases

[kudu-CR] java: fix various integer-math error-prone issues

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10200 ) Change subject: java: fix various integer-math error-prone issues .. java: fix various integer-math error-prone issues - Adds ex

[kudu-CR] java: fix ClassCanBeStatic[1] error-prone checks

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10198 ) Change subject: java: fix ClassCanBeStatic[1] error-prone checks .. java: fix ClassCanBeStatic[1] error-prone checks This should

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Patch Set 2: hmm, I bet ITExportCSV didn't get checked by my run becau

[kudu-CR] java: make all enum members immutable

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: java: make all enum members immutable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http:

[kudu-CR] java: make all enum members immutable

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/1019

[kudu-CR] java: make all enum members immutable

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. java: make all enum members immutable This fixes instances of the Immut

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for java builds error-prone (http://errorpro

[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10194 ) Change subject: java: fix error message when attempting to import Parquet TIMESTAMP .. java: fix error message when attempting t

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10193 ) Change subject: Fix missing @Override annotations .. Fix missing @Override annotations This fixes a bunch of error-prone warning

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 5: (2 comments) http://gerrit.cloudera.o

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10075/6/src/kudu/tools/to

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 3: Flaky tests due to clock synchronization issue. -- To view,

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-26 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 4: (2 comments) http://gerrit.cloudera.

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 5: (2 comments) http://gerrit.cl

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [tools] ksck improvements [6/n]: Refactor printing

2018-04-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor printing .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-26 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#3). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10217/2/src

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10197 ) Change subject: java: fix error-prone DefaultCharset[1] issues .. Patch Set 2: ah, I forgot about StandardCharsets. It's new in Java7 an

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9849 ) Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. [docs] Update kudu-spark section and a

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10193 ) Change subject: Fix missing @Override annotations .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10193 To

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix missing @Override annotations .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10193 To unsubscribe, visit http://ge

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-26 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#10). Change subject: KUDU-2191: Metadata Upgrade Tool .

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 ) Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Remove some obsolete limitations related to disks

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10220 ) Change subject: [docs] Remove some obsolete limitations related to disks .. [docs] Remove some obsolete limitations related to

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [docs] Remove some obsolete limitations related to disks

2018-04-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10220 ) Change subject: [docs] Remove some obsolete limitations related to disks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] java: fix various integer-math error-prone issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10200 ) Change subject: java: fix various integer-math error-prone issues .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] java: fix remainder of error-prone issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] java: fix ClassCanBeStatic[1] error-prone checks

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10198 ) Change subject: java: fix ClassCanBeStatic[1] error-prone checks .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10193 ) Change subject: Fix missing @Override annotations .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10193

[kudu-CR] java: fix various test style issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10201 ) Change subject: java: fix various test style issues .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/102

[kudu-CR] java: make all enum members immutable

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gra

[kudu-CR] cache: switch to std::atomic

2018-04-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10209 ) Change subject: cache: switch to std::atomic .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10209 To un

[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10194 ) Change subject: java: fix error message when attempting to import Parquet TIMESTAMP .. Patch Set 2: Code-Review+2 -- To view, visit ht

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 7: Fixed my accidental rebase back onto the old patch. -- To view

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for jav

[kudu-CR] [java] Fix the high priority spotbugs warings

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10221 Change subject: [java] Fix the high priority spotbugs warings .. [java] Fix the high priority spotbugs warings None of these are function

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-26 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10187 to look at the new patch set (#2). Change subject: [Java] Use spotbugs in place of findbugs in gradle .

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for jav

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Patch Set 1: I see warnings that still exist in ITExportCsv -- To vi

[kudu-CR] [docs] Remove some obsolete limitations related to disks

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [docs] Remove some obsolete limitations related to disks .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10220 To uns

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10211/1/d

[kudu-CR] [docs] Remove some obsolete limitations related to disks

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10220 ) Change subject: [docs] Remove some obsolete limitations related to disks .. Patch Set 1: Verified+1 Docs-only change. -- To view, vi

[kudu-CR] [docs] Remove some obsolete limitations related to disks

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10220 ) Change subject: [docs] Remove some obsolete limitations related to disks .. Removed reviewer Kudu Jenkins. -- To view, visit ht

[kudu-CR] [docs] Remove some obsolete limitations related to disks

2018-04-26 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10220 Change subject: [docs] Remove some obsolete limitations related to disks .. [docs] Remove some obsolete limitations related to disks Th

[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10219 Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. java: fix a mistaken reference-equality check

[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10203 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Patch Set 1: Code-Review+2 -- To view, visi

[kudu-CR] java: fix remainder of error-prone issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] java: fix various test style issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10201 ) Change subject: java: fix various test style issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/102

[kudu-CR] java: fix various integer-math error-prone issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10200 ) Change subject: java: fix various integer-math error-prone issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10199 ) Change subject: java: fix minor synchronization issues exposed by error-prone .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] java: fix ClassCanBeStatic[1] error-prone checks

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10198 ) Change subject: java: fix ClassCanBeStatic[1] error-prone checks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10197 ) Change subject: java: fix error-prone DefaultCharset[1] issues .. Patch Set 1: Why not use the built in java.nio.charset.StandardCharset

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10196/1/

[kudu-CR] java: make all enum members immutable

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

  1   2   >