[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 13: (10 comments)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-10 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#13). Change subject: KUDU-2191: Metadata Upgrade Tool

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 3: (19 comments)

[kudu-CR] [tools] ksck improvements [7/n] Add JSON output option to ksck

2018-05-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 ) Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] Add a column renaming tool

2018-05-10 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10368 ) Change subject: Add a column renaming tool .. Add a column renaming tool This commit introduces a tool to rename a table's column.

[kudu-CR] [tools] ksck improvements [7/n] Add JSON output option to ksck

2018-05-10 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10288 to look at the new patch set (#10). Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck

[kudu-CR] [tools] ksck improvements [7/n] Add JSON output option to ksck

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 ) Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck .. Patch Set 9: (9 comments)

[kudu-CR] Add a column renaming tool

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10368 ) Change subject: Add a column renaming tool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10368 To

[kudu-CR] [tools] ksck improvements [7/n] Add JSON output option to ksck

2018-05-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 ) Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck .. Patch Set 9: (9 comments) Mostly nits, looks good!

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. thirdparty: tweak clang compiler flags Prior to this small tweak the

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-10 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 4: (4 comments) There seems to be no

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-10 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10332 to look at the new patch set (#4). Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-10 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10332 to look at the new patch set (#3). Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Fix int overflow GetClockTimeMicros() on macOS On

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 4: (4 comments)

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Patch Set 2: Code-Review+2 This passes my failing Java tests on mac.

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Patch Set 1: (2 comments)

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread David Ribeiro Alves (Code Review)
Hello Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10371 to look at the new patch set (#2). Change subject: Fix int overflow GetClockTimeMicros() on macOS

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Patch Set 1: (1 comment)

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10352 to look at the new patch set (#5). Change subject: thirdparty: tweak clang compiler flags ..

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 5: (1 comment)

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10371 ) Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 13: (2 comments) Approach looks good. Needs a test for

[kudu-CR] Fix int overflow GetClockTimeMicros() on macOS

2018-05-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10371 Change subject: Fix int overflow GetClockTimeMicros() on macOS .. Fix int overflow GetClockTimeMicros() on macOS On macOS

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 13: > > Unrelated flaky test. > > Did you try to run it

[kudu-CR] [tools] Add ids to tables and tablets; table name to tablets

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10369 ) Change subject: [tools] Add ids to tables and tablets; table name to tablets .. Patch Set 1: Known + unrelated failure. -- To view,

[kudu-CR] [tools] Add ids to tables and tablets; table name to tablets

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10369 ) Change subject: [tools] Add ids to tables and tablets; table name to tablets .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [tools] Add ids to tables and tablets; table name to tablets

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10369 ) Change subject: [tools] Add ids to tables and tablets; table name to tablets .. [tools] Add ids to tables and tablets; table

[kudu-CR] [tools] Add ids to tables and tablets; table name to tablets

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [tools] Add ids to tables and tablets; table name to tablets .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10369

[kudu-CR] [docs] Update macOS build docs

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 ) Change subject: [docs] Update macOS build docs .. Patch Set 2: > > Patch Set 2: > > > > > > Patch Set 2: > > > > > > > > Is

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Abandoned Will added corresponding functionality with 0355d373a,

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 6: > After chatting with Alexey I added these

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 13: > Unrelated flaky test. Did you try to run it

[kudu-CR] [docs] Update macOS build docs

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 ) Change subject: [docs] Update macOS build docs .. Patch Set 2: > Patch Set 2: > > > > Patch Set 2: > > > > > > Is this relevant after

[kudu-CR] [docs] Update macOS build docs

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 ) Change subject: [docs] Update macOS build docs .. Patch Set 2: > > Patch Set 2: > > > > Is this relevant after

[kudu-CR] [tools] Add ids to tables and tablets; table name to tablets

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10369 ) Change subject: [tools] Add ids to tables and tablets; table name to tablets .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add a column renaming tool

2018-05-10 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: Add a column renaming tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10368 To unsubscribe, visit

[kudu-CR] Add a column renaming tool

2018-05-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10368 ) Change subject: Add a column renaming tool .. Patch Set 1: Verified+1 Unrelated flaky test. -- To view, visit

[kudu-CR] [flags] run validators after processing help flags

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. [flags] run validators after processing help flags Run

[kudu-CR] [tools] ksck improvements [7/n] Add JSON output option to ksck

2018-05-10 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10288 to look at the new patch set (#9). Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck

[kudu-CR] [tools] ksck improvements [7/n] Add JSON output option to ksck

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 ) Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck .. Patch Set 8: (4 comments)

[kudu-CR] [tools] Add ids to tables and tablets; table name to tablets

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10369 Change subject: [tools] Add ids to tables and tablets; table name to tablets .. [tools] Add ids to tables and tablets; table name to

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 2: (5 comments)

[kudu-CR] [docs] Update macOS build docs

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 ) Change subject: [docs] Update macOS build docs .. Patch Set 2: (2 comments) > Patch Set 2: > > > Patch Set 2: > > > > Is this relevant

[kudu-CR] Add a column renaming tool

2018-05-10 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10368 Change subject: Add a column renaming tool .. Add a column renaming tool This commit introduces a tool to rename a table's column. Similar

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-05-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 6: After chatting with Alexey I added these as

[kudu-CR] [flags] run validators after processing help flags

2018-05-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 4: (1 comment)

[kudu-CR] [flags] run validators after processing help flags

2018-05-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. Patch Set 7: (7 comments)

[kudu-CR] [flags] run validators after processing help flags

2018-05-10 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10342 to look at the new patch set (#8). Change subject: [flags] run validators after processing help flags

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10352 to look at the new patch set (#4). Change subject: thirdparty: tweak clang compiler flags ..

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 4: (1 comment)

[kudu-CR] [flags] run validators after processing help flags

2018-05-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. Patch Set 7: (7 comments)

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-10 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 4: (1 comment) > Patch Set 2: > > (1 comment) thanks for

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-10 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10293 to look at the new patch set (#4). Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-10 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10293 to look at the new patch set (#3). Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-10 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#13). Change subject: KUDU-2287 Expose election failures as metrics