[kudu-CR] [tablet] fix non-handled switch warning

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17970 ) Change subject: [tablet] fix non-handled switch warning .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [rpc] re-add methods by name()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17969 ) Change subject: [rpc] re-add methods_by_name() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17969

[kudu-CR] [rpc] re-add methods by name()

2021-10-25 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17969 to look at the new patch set (#2). Change subject: [rpc] re-add methods_by_name() .. [rpc] re-add

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17968 ) Change subject: [rpc] add kudu namespace to DnsResolver in generated code .. [rpc] add kudu namespace to DnsResolver in

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17968 ) Change subject: [rpc] add kudu namespace to DnsResolver in generated code .. Patch Set 1: Verified+1 Code-Review+2 unrelated test

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] add kudu namespace to DnsResolver in generated code .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17968 To

[kudu-CR] [client] fix recently introduced ABI compatiblity issue

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17972 ) Change subject: [client] fix recently introduced ABI compatiblity issue .. Patch Set 1: Verified+1 unrelated test failures: *

[kudu-CR] [client] fix recently introduced ABI compatiblity issue

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [client] fix recently introduced ABI compatiblity issue .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17972 To

[kudu-CR] [rpc] re-add methods by name()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17969 ) Change subject: [rpc] re-add methods_by_name() .. Patch Set 1: Code-Review+1 Ah, good catch! Thank you for adding a new test. It

[kudu-CR] [tablet] fix non-handled switch warning

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17970 ) Change subject: [tablet] fix non-handled switch warning .. Patch Set 1: Code-Review+1 Thank you for addressing this! It seems IWYU

[kudu-CR] KUDU-1959 - Implement server startup progress page for tablet and master servers

2021-10-25 Thread Abhishek Chennaka (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17730 to look at the new patch set (#25). Change subject: KUDU-1959 - Implement server startup progress page for tablet and master

[kudu-CR] KUDU-1959 - Implement server startup progress page for tablet and master servers

2021-10-25 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 ) Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers .. Patch Set 24: (3 comments)

[kudu-CR] [client] fix recently introduced ABI compatiblity issue

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17972 Change subject: [client] fix recently introduced ABI compatiblity issue .. [client] fix recently introduced ABI compatiblity issue

[kudu-CR] KUDU-3295: Fix the number of replicas does not equal the number of servers

2021-10-25 Thread Hongjiang Zhang (Code Review)
Hongjiang Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17971 Change subject: KUDU-3295: Fix the number of replicas does not equal the number of servers .. KUDU-3295: Fix the number of replicas

[kudu-CR] [rpc] re-add methods by name()

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17969 Change subject: [rpc] re-add methods_by_name() .. [rpc] re-add methods_by_name() This patch reverts the removal of the methods_by_name()

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17968 Change subject: [rpc] add kudu namespace to DnsResolver in generated code .. [rpc] add kudu namespace to DnsResolver in generated code

[kudu-CR] [tablet] fix non-handled switch warning

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17970 Change subject: [tablet] fix non-handled switch warning .. [tablet] fix non-handled switch warning This patch addresses the following

[kudu-CR] KUDU-3318 [LBM] Runtime compact log container metadata

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 ) Change subject: KUDU-3318 [LBM] Runtime compact log container metadata .. Patch Set 9: Code-Review+1 (4 comments)

[kudu-CR] Revert "[tool] Add a '-list statistics' flag to the 'kudu table list'."

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/17966 ) Change subject: Revert "[tool] Add a '-list_statistics' flag to the 'kudu table list'." .. Abandoned Will post a fix instead of revert. -- To

[kudu-CR] Revert "[tool] Add a '-list statistics' flag to the 'kudu table list'."

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17966 ) Change subject: Revert "[tool] Add a '-list_statistics' flag to the 'kudu table list'." .. Patch Set 1: It seems it's easier to

[kudu-CR] Revert "[tool] Add a '-list statistics' flag to the 'kudu table list'."

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17966 Change subject: Revert "[tool] Add a '-list_statistics' flag to the 'kudu table list'." .. Revert "[tool] Add a '-list_statistics'

[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. Patch Set 13: (1 comment) I'm late to reviewing

[kudu-CR] KUDU-1959 - Implement server startup progress page for tablet and master servers

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 ) Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers .. Patch Set 24: (3 comments)

[kudu-CR] [LBM] Speed up server bootstrap by using multi-thread to compact containers

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 ) Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers .. Patch Set 2: (1 comment)

[kudu-CR] [LBM] Speed up server bootstrap by using multi-thread to compact containers

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 ) Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers .. Patch Set 2: (1 comment)

[kudu-CR] [LBM] Speed up server bootstrap by using multi-thread to compact containers

2021-10-25 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 ) Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers .. Patch Set 2: Code-Review+1 -- To

[kudu-CR] [LBM] Speed up server bootstrap by using multi-thread to compact containers

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 ) Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1959 - Implement server startup progress page for tablet and master servers

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 ) Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers .. Patch Set 24: Code-Review+1 (2

[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17965 ) Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked() .. [mvcc] avoid copying in

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17961 ) Change subject: KUDU-3330 Define operator<< for MonoTime .. KUDU-3330 Define operator<< for MonoTime This patch implements

[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

2021-10-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17965 ) Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.

2021-10-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 ) Change subject: KUDU-3330 Define operator<< for MonoTime .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17965 ) Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked() .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17965 ) Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked() .. Patch Set 1: unrelated test failures in *

[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17965 To

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 ) Change subject: KUDU-3330 Define operator<< for MonoTime .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 ) Change subject: KUDU-3330 Define operator<< for MonoTime .. Patch Set 5: (1 comment) Fixed IWYU

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Abhishek Chennaka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17961 to look at the new patch set (#5). Change subject: KUDU-3330 Define operator<< for MonoTime

[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

2021-10-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17965 Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked() .. [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 ) Change subject: KUDU-3330 Define operator<< for MonoTime .. Patch Set 4: Code-Review+2 Fix the IWYU issue and ship it! -- To view,

[kudu-CR] KUDU-3308: Add health check endpoint to webserver

2021-10-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17962 ) Change subject: KUDU-3308: Add health check endpoint to webserver .. Patch Set 1: Code-Review+1 Is this API easily extendable to add

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

2021-10-25 Thread Abhishek Chennaka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17961 to look at the new patch set (#4). Change subject: KUDU-3330 Define operator<< for MonoTime