[kudu-CR] [KUDU-1728] parallelize download blocks in tablet-copy-client

2020-08-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16274 ) Change subject: [KUDU-1728] parallelize download blocks in tablet-copy-client .. Patch Set 2: (4 comments)

[kudu-CR] Block Bloom filter false positive rate correction

2020-08-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16248 ) Change subject: Block Bloom filter false positive rate correction .. Patch Set 7: Thanks for fixing this, Jim. Some high level

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-31 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols .. [loadgen] Separate flags to

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-31 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#6). Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-31 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols .. Patch Set 5: (2 comments)

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols .. Patch Set 5: (3 comments)

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#5). Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols

[kudu-CR] [loadgen] Add separate flags to populate random values for PK and non-PK cols

2020-07-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#4). Change subject: [loadgen] Add separate flags to populate random values for PK and non-PK cols

[kudu-CR] [tool] Add option in loadgen to populate random values only for non-pk columns

2020-07-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#3). Change subject: [tool] Add option in loadgen to populate random values only for non-pk columns

[kudu-CR] [tool] Add option in loadgen to populate random values only for non-pk columns

2020-07-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [tool] Add option in loadgen to populate random values only for non-pk columns .. Patch Set 2: (3 comments)

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 ) Change subject: Update Jekyll and site-tool .. Patch Set 4: Code-Review+1 (1 comment) Thanks for fixing this, Attila!

[kudu-CR] Block Bloom filter false positive rate correction

2020-07-29 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16248 ) Change subject: Block Bloom filter false positive rate correction .. Patch Set 4: (3 comments)

[kudu-CR] [tool] Add option in loadgen to populate random values only for non-pk columns

2020-07-29 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#2). Change subject: [tool] Add option in loadgen to populate random values only for non-pk columns

[kudu-CR] [tool] Add option in loadgen to populate random values only for non-pk columns

2020-07-29 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16253 Change subject: [tool] Add option in loadgen to populate random values only for non-pk columns .. [tool] Add option in loadgen to

[kudu-CR] Block Bloom filter false positive rate correction

2020-07-28 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16248 ) Change subject: Block Bloom filter false positive rate correction .. Patch Set 3: > Patch Set 2: > > > Build Failed > > > >

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: (1 comment)

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: (2 comments) The test failures look relevant.

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16189 ) Change subject: client: allocate InFlightOp from a Batcher Arena .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docker] Use ccache and Gradle cache across builds

2020-07-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 ) Change subject: [docker] Use ccache and Gradle cache across builds .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [docker] Use ccache and Gradle cache across builds

2020-07-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 ) Change subject: [docker] Use ccache and Gradle cache across builds .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR] [ranger client-test] fix build

2020-07-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16168 ) Change subject: [ranger_client-test] fix build .. Patch Set 1: Code-Review+2 How did this sneak through? -- To view, visit

[kudu-CR] [docker] KUDU-2857: Rewrite docker build script in python

2020-07-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16161 ) Change subject: [docker] KUDU-2857: Rewrite docker build script in python .. Patch Set 5: (3 comments) Curious were you able to run

[kudu-CR] [master] set RPC queue length to 100 by default

2020-07-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16154 ) Change subject: [master] set RPC queue length to 100 by default .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [gutil] fix assignment operator signature in DISALLOW COPY AND ASSIGN

2020-07-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16158 ) Change subject: [gutil] fix assignment operator signature in DISALLOW_COPY_AND_ASSIGN .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. [docs][docker] KUDU-3159 Fix missing

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 2: (4 comments)

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-08 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16114 to look at the new patch set (#3). Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 2: (1 comment)

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16145 ) Change subject: test: fix flakiness of TestDeletedRowsetGc .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR](gh-pages) [site] Add Bankim Bhavsar to committers page

2020-07-01 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16132 ) Change subject: [site] Add Bankim Bhavsar to committers page .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](gh-pages) [site] Add Bankim Bhavsar to committers page

2020-07-01 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16132 ) Change subject: [site] Add Bankim Bhavsar to committers page .. [site] Add Bankim Bhavsar to committers page Keeping it up

[kudu-CR] [metrics] add Counter::Reset() method

2020-07-01 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16133 ) Change subject: [metrics] add Counter::Reset() method .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [site] Add Bankim Bhavsar to committers page

2020-07-01 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16132 Change subject: [site] Add Bankim Bhavsar to committers page .. [site] Add Bankim Bhavsar to committers page Keeping it up to date

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-06-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 1: > Patch Set 1: > > > Patch Set 1: >

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-06-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16114 to look at the new patch set (#2). Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

2020-06-29 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16117 ) Change subject: [blog] Cross post from Boris Tyukin .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

2020-06-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16117 ) Change subject: [blog] Cross post from Boris Tyukin .. Patch Set 2: Link to the Part 1 of the blog is missing. It'd be good link

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-06-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 1: > Patch Set 1: > > We can publish

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. [perf] KUDU-3140 Heuristics

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-06-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 1: > Patch Set 1: > > Why not just

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-06-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16114 Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. [docs][docker] KUDU-3159 Fix missing devtoolset3

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-25 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#7). Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 6: (9 comments)

[kudu-CR] [test util] multiple bind address for WaitFor{Tcp,Udp}Bind()

2020-06-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16110 ) Change subject: [test_util] multiple bind address for WaitFor{Tcp,Udp}Bind() .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 3: > Patch Set 3: > > Looking at the C++ client for

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 3: Looking at the C++ client for comparison and in

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 6: > Patch Set 5: > > >

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-23 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#6). Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 5: > Patch Set 5:

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 4: (2 comments)

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-22 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#5). Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] [consensus] remove redundant instruction

2020-06-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16097 ) Change subject: [consensus] remove redundant instruction .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()

2020-06-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16034 ) Change subject: [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() .. Patch Set 5: (1 comment)

[kudu-CR] [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()

2020-06-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16034 ) Change subject: [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() .. Patch Set 5: (1 comment) LGTM but don't have enough

[kudu-CR] WIP [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()

2020-06-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16034 ) Change subject: WIP [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() .. Patch Set 2: (2 comments) Interesting trick to

[kudu-CR] [master] cache for table locations

2020-06-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15971 ) Change subject: [master] cache for table locations .. Patch Set 2: (6 comments) I mostly focussed on TableLocationsCache class and

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-17 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#4). Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 3: (3 comments)

[kudu-CR] WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 3: (12 comments)

[kudu-CR] [util] add BlockingQueueTest.MultiThreadPerf test scenario

2020-06-11 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16064 ) Change subject: [util] add BlockingQueueTest.MultiThreadPerf test scenario .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [util] improved performance of BlockingQueue

2020-06-11 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16063 ) Change subject: [util] improved performance of BlockingQueue .. Patch Set 3: (2 comments)

[kudu-CR] [util] add BlockingQueueTest.MultiThreadPerf test scenario

2020-06-11 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16064 ) Change subject: [util] add BlockingQueueTest.MultiThreadPerf test scenario .. Patch Set 1: (3 comments)

[kudu-CR] WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-11 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#3). Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 2: (5 comments)

[kudu-CR] [consensus] small clean-up on Log

2020-06-10 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16061 ) Change subject: [consensus] small clean-up on Log .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 2: (5 comments) Just took a high-level look. Some

[kudu-CR] WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-09 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#2). Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] Fix linker error with tablet replica-test-base.cc on Mac OS

2020-06-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16038 Change subject: Fix linker error with tablet_replica-test-base.cc on Mac OS .. Fix linker error with tablet_replica-test-base.cc on

[kudu-CR] WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16036 Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. WIP [perf] KUDU-3140 Heuristics

[kudu-CR] [consensus] small cleanup on Peer::SignalRequest()

2020-06-02 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16021 ) Change subject: [consensus] small cleanup on Peer::SignalRequest() .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [scanner] output the essential error message first

2020-05-29 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15999 ) Change subject: [scanner] output the essential error message first .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2020-05-26 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/5905 ) Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 7: (3 comments)

[kudu-CR] replace shared ptr(new T) with make shared()

2020-05-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15981 ) Change subject: replace shared_ptr(new T) with make_shared() .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] replace shared ptr(new T) with make shared()

2020-05-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15981 ) Change subject: replace shared_ptr(new T) with make_shared() .. Patch Set 5: (1 comment)

[kudu-CR] replace shared ptr(new T) with make shared()

2020-05-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15981 ) Change subject: replace shared_ptr(new T) with make_shared() .. Patch Set 2: (1 comment)

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 3: (1 comment)

[kudu-CR] replace shared ptr(new T) with make shared()

2020-05-22 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15981 ) Change subject: replace shared_ptr(new T) with make_shared() .. Patch Set 2: (1 comment)

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. [client] Remove allocator param for

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 2: (1 comment)

[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15970 ) Change subject: auto_rebalancer: ignore deleted tables .. Patch Set 2: (1 comment)

[kudu-CR] rebalancer: throttle logging when building cluster info

2020-05-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15920 ) Change subject: rebalancer: throttle logging when building cluster info .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-18 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 2: (1 comment)

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-18 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15947 to look at the new patch set (#2). Change subject: [client] Remove allocator param for direct Bloom filter predicate

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-18 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15947 Change subject: [client] Remove allocator param for direct Bloom filter predicate .. [client] Remove allocator param for direct Bloom

[kudu-CR] KUDU-2817: Upgrade bitshuffle to 0.3.5

2020-05-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15936 ) Change subject: KUDU-2817: Upgrade bitshuffle to 0.3.5 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2817: Upgrade zlib to 1.2.11

2020-05-17 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15938 ) Change subject: KUDU-2817: Upgrade zlib to 1.2.11 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. Patch Set 1: (1 comment)

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. [perf] Check range predicate

[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2817: Upgrade lz4 to 1.9.2

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15925 ) Change subject: KUDU-2817: Upgrade lz4 to 1.9.2 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 ) Change subject: KUDU-2817: Upgrade glog to 0.4.0 .. Patch Set 1: (1 comment)

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-15 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#5). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. Patch Set 5: (10 comments)

[kudu-CR] rebalancer: throttle logging when building cluster info

2020-05-14 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15920 ) Change subject: rebalancer: throttle logging when building cluster info .. Patch Set 1: (2 comments)

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#4). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#3). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#2). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

<    2   3   4   5   6   7   8   9   10   11   >