[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 2: to work around in that particular test, why not explicitly wait for a

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3719/2/src/kudu/fs/log_block_manage

[kudu-CR] WIP: KUDU-1271: allow primary keys not at the start of the row

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3722 Change subject: WIP: KUDU-1271: allow primary keys not at the start of the row .. WIP: KUDU-1271: allow primary keys not at the start of th

[kudu-CR](gh-pages) www: Add list of committers to the site

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: www: Add list of committers to the site .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3721 To unsubscribe, visit http://gerrit.c

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 2: (1 comment) Did you want to update the call sites to not use the deprecated function (a coupl

[kudu-CR] Remove ASF incubation callouts

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove ASF incubation callouts .. Patch Set 1: k, I'll do a follow-up -- To view, visit http://gerrit.cloudera.org:8080/3699 To unsubscribe, visit http://gerrit.

[kudu-CR] Remove ASF incubation callouts

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove ASF incubation callouts .. Remove ASF incubation callouts Now that the resolution has passed, we no longer need to call out incubation status. Thi

[kudu-CR] Fix mailing list archive links to not reference incubator

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3725 to review the following change. Change subject: Fix mailing list archive links to not reference incubator .. Fix mailin

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3718

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 2: Alright, let's try this and see if people complain about the UX. (I'm

[kudu-CR] master: do not delete unknown tablets

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3645/5//COMMIT_MSG Commit Message: Line 7: ma

[kudu-CR](gh-pages) Update the overview page

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3726 to review the following change. Change subject: Update the overview page .. Update the overview page Long-overdue upda

[kudu-CR](gh-pages) Update the overview page

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update the overview page .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3726 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update the docs webpages to reflect the master branch .. Patch Set 1: I think updating prior to release is nice, but only if we do the "this is an unreleased docu

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3632/4/src/kudu/tools/

[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: improve output for long-running ksck checksums .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3715/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] ksck: fix a test flake caused by a race on timeout

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3727 to review the following change. Change subject: ksck: fix a test flake caused by a race on timeout .

[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3715 to look at the new patch set (#2). Change subject: ksck: improve output for long-running ksck checksums

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3632 to look at the new patch set (#5). Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) ..

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3719/2/src/kudu/fs/log_block_manag

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3719 to look at the new patch set (#3). Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss ..

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. KUDU-1538: prevent block ID reuse to avoid potential data loss This changes the block ma

[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3733 to review the following change. Change subject: Fix block_manager-test running in some builds .. Fix block

[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3733 to look at the new patch set (#2). Change subject: Fix block_manager-test running in some builds .. Fix

[kudu-CR] ksck-test: fix failure on OSX

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3734 to review the following change. Change subject: ksck-test: fix failure on OSX .. ksck-test: fix fa

[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3733 to look at the new patch set (#3). Change subject: Fix block_manager-test running in some builds .. Fix block_manag

[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add weekly update for 07/25 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3763/3/_posts/2016-07-26-weekly-update.md File _posts/2016-07-26-weekl

[kudu-CR] docs: fix links to MR examples in developing

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: fix links to MR examples in developing .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3821/1/docs/developing.adoc File docs/developing.adoc

[kudu-CR] docs: Add missing DISTRIBUTE to quickstart

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Add missing DISTRIBUTE to quickstart .. Patch Set 1: Did you verify this syntax by trying it? (I can't remember if the DISTRIBUTE BY goes before or after TB

[kudu-CR] KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation .. KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation This

[kudu-CR] KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3819 To

[kudu-CR] KUDU-1416 Upsert support for Flume sink

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 2: Mike, can you take another look at this before it gets too stale? (Maybe already is stale due to the great

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. KUDU-1358 (part 1): master should accept heartbeat even if follower This patch cha

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsu

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3610 To unsubscribe, visit http://g

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1358 (part 2): heartbeat to every master .. KUDU-1358 (part 2): heartbeat to every master Now that followers accept heartbeats, let's modify the tser

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 13: Code-Review+1 have you looped this one? Also, Dan, any further comments? -- To view, visit http

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-08-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1358 (part 3): new multi-master stress test .. KUDU-1358 (part 3): new multi-master stress test This commit adds a stress test for multiple masters.

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

2016-08-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3643 To uns

[kudu-CR] master: do not delete unknown tablets

2016-08-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: master: do not delete unknown tablets .. master: do not delete unknown tablets Quoting from docs/design-docs/multi-master-1.0.md: "The master and/or tser

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

2016-08-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. KUDU-1374: send full tablet report when new leader master is detected This shoul

[kudu-CR] master: do not delete unknown tablets

2016-08-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cl

[kudu-CR] push to asf.py: update repo URL

2016-08-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: Code-Review+2 Guess we should send an email to dev@ so everyone can change their own apache remotes, too? Do we n

[kudu-CR] Fix ksck-test reliance on unordered map iteration order

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix ksck-test reliance on unordered map iteration order .. Patch Set 1: Hey Will. I actually put a patch up already for this here https://gerrit.cloudera.org/#/c/

[kudu-CR] ksck-test: fix failure on OSX

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ksck-test: fix failure on OSX .. ksck-test: fix failure on OSX We previously relied on deleting the 'first' element of an unordered_map to set up a test c

[kudu-CR] ksck-test: fix failure on OSX

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck-test: fix failure on OSX .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3734 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix block_manager-test running in some builds .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3733/3/src/kudu/util/CMakeLists.txt File src/kudu/u

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3733 to look at the new patch set (#4). Change subject: Fix block_manager-test running in some builds .. Fix block_manag

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elec

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3809 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elec

[kudu-CR] external mini cluster: adjust single master data directory

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: external_mini_cluster: adjust single master data directory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3810 To unsubscribe, vi

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:logging,

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3834/1/src/kudu/client/scan_batch.h File src/kud

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:logging,

[kudu-CR] Add docs for non-covering range partitioning

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 1: Dan, do you have time to look at this before the 0.10 release? -- To view, visit http://gerrit.cloud

[kudu-CR] docs: design for handling permanent master failures

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3393/3/docs/design-docs/master-perm-failure-1

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File src/kudu/util

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: additional leader lock assertions in catalog manager .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3684/5/src/kudu/master/catalog_manag

[kudu-CR] Make UTF-8 characters display correctly in the web ui

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Make UTF-8 characters display correctly in the web ui .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3830 To unsubscribe, visit h

[kudu-CR] Make UTF-8 characters display correctly in the web ui

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Make UTF-8 characters display correctly in the web ui .. Make UTF-8 characters display correctly in the web ui Some valid UTF-8 characters don't display c

[kudu-CR] c++ client: remove unnecessary code

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: c++ client: remove unnecessary code .. c++ client: remove unnecessary code 1. GetTableSchema() was implemented using its own RPC instead of a much simp

[kudu-CR] c++ client: remove unnecessary code

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3809 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3786/3/src/kudu/master/sys_catalog.

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http:/

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBatch::const_iterator] a minor clean-up More 'standardized' signature for the prefix incremen

[kudu-CR] remote bootstrap client: mild API changes

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3811 To unsubscribe, visit http://gerrit

[kudu-CR] Predicate evaluation pushdown

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3841/1/src/kudu/cfile/binary_dict_block.cc File src/kudu/cfile/binar

[kudu-CR] [java-client] Re-enable multi-master tests

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 4: Adar, do you think we can push this now? I'll hit a rebase to make sure it still passes tests -- To v

[kudu-CR] [java-client] Re-enable multi-master tests

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 4: Oh, apparently it needs a manual rebase (I guess due to the package change) -- To view, visit http://g

[kudu-CR] KUDU-1303 Document code style guidelines for C++11 move semantics and rvalue references

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1303 Document code style guidelines for C++11 move semantics and rvalue references .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-1303 Document code style guidelines for C++11 move semantics and rvalue references

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1303 Document code style guidelines for C++11 move semantics and rvalue references .. KUDU-1303 Document code style guidelines for C++11 move semanti

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: master: additional leader lock assertions in catalog manager .. master: additional leader lock assertions in catalog manager I went through the catalog ma

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: additional leader lock assertions in catalog manager .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3684 To unsubscribe,

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

2016-08-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3848 to review the following change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Rename Remote Bootst

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

2016-08-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3848 to look at the new patch set (#2). Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Rename Remote B

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

2016-08-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 1: yea, I'm also currently going through and doing a bunch of manual cleanup/edits for things that my

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

2016-08-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Rename Remote Bootstrap to Tablet Copy (part 1) This does a bunch of automated substitutions of the ter

[kudu-CR] Rename Remote Bootstrap: some manual changes

2016-08-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3852 to review the following change. Change subject: Rename Remote Bootstrap: some manual changes .. Rename Remote Bootstrap

[kudu-CR] Rename remote bootstrap files to 'tablet copy'

2016-08-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3853 to review the following change. Change subject: Rename remote bootstrap files to 'tablet copy' .. Rename remote bootstr

[kudu-CR] [java-client] Re-enable multi-master tests

2016-08-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerri

[kudu-CR] Rename Remote Bootstrap: some manual changes

2016-08-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3852 to look at the new patch set (#2). Change subject: Rename Remote Bootstrap: some manual changes .. Rena

[kudu-CR] Rename Remote Bootstrap: some manual changes

2016-08-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Rename Remote Bootstrap: some manual changes .. Rename Remote Bootstrap: some manual changes This patch has a bunch more manual fixes to replace "Remote B

[kudu-CR] Rename remote bootstrap files to 'tablet copy'

2016-08-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Rename remote bootstrap files to 'tablet copy' .. Rename remote bootstrap files to 'tablet copy' Change-Id: I3f31fb72d11d16ee05bf90be3a7c77a82e5db6f7 Revi

[kudu-CR] [CMakeLists.txt] dot is mandatory for doxygen

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [CMakeLists.txt] dot is mandatory for doxygen .. [CMakeLists.txt] dot is mandatory for doxygen Require dot (graphviz) support for doxygen since the dot is

[kudu-CR] [CMakeLists.txt] dot is mandatory for doxygen

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [CMakeLists.txt] dot is mandatory for doxygen .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3855 To unsubscribe, visit http://ge

[kudu-CR] catalog manager: cleanup status messages

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: catalog manager: cleanup status messages .. catalog manager: cleanup status messages We were using the protobuf 'DebugString' method to fill out status me

[kudu-CR] catalog manager: cleanup status messages

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: catalog manager: cleanup status messages .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3858 To unsubscribe, visit http://gerrit.

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add table id to AlterTableResponsePB .. Patch Set 1: you don't want to use this new field in the client? seems strange to add it with no use case -- To view, vi

[kudu-CR] KUDU-1552: schema corruption cause kudu crash

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1552: schema corruption cause kudu crash .. Patch Set 4: Do we have any idea why this is happening, yet? I agree that crashing is not good behavior, but I al

[kudu-CR] build: Make 'download-thirdparty.sh' resilient to failure

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: build: Make 'download-thirdparty.sh' resilient to failure .. build: Make 'download-thirdparty.sh' resilient to failure Many contributors work at home on f

[kudu-CR] build: Make 'download-thirdparty.sh' resilient to failure

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: build: Make 'download-thirdparty.sh' resilient to failure .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3857 To unsubscribe, vis

[kudu-CR] heartbeater: slight fixes to backoff behavior

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: heartbeater: slight fixes to backoff behavior .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3847 To unsubscribe, visit http://ge

[kudu-CR] heartbeater: slight fixes to backoff behavior

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: heartbeater: slight fixes to backoff behavior .. heartbeater: slight fixes to backoff behavior 1. There was an off-by-one error when deciding how many fai

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3864 Change subject: Add weekly update for 8/8 .. Add weekly update for 8/8 Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b --- A _posts/2

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add weekly update for 8/8 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3864/1/_posts/2016-08-08-weekly-update.md File _posts/2016-08-08-weekly-

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: Add weekly update for 8/8 .. Add weekly update for 8/8 Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b --- A _posts/2016-08-08-weekly-update.md 1 file changed,

[kudu-CR] Upgrade to NVML 1.1

2016-08-08 Thread Todd Lipcon (Code Review)
Hello Sarah Jelinek, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3866 to review the following change. Change subject: Upgrade to NVML 1.1 .. Upgrade to NVML 1.1 Change-Id: I

[kudu-CR] Persistent cache support for NVM

2016-08-08 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2593 to look at the new patch set (#18). Change subject: Persistent cache support for NVM .. Persistent cache support fo

[kudu-CR] Persistent cache support for NVM

2016-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Persistent cache support for NVM .. Patch Set 17: Just rebased and uploading here, looking at latest revision now while it runs through tests. -- To view, visit

  1   2   3   4   5   6   7   8   9   10   >