[kudu-CR](gh-pages) Add weekly update for 06/06

2016-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3316/5/_posts/2016-06-06-weekly-update.md File

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Patch Set 2: It's used in the following patch. Maybe I should just squash it. -- To view, visit

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: > (1 comment) > > can you add a test for this? something simple like setting the >

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#4). Change subject: Remove the LocalConsensus implementation .. Remove the LocalConsensus implementation This implementation was intended as scaffolding while we built a true consensus

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#3). Change subject: RaftConsensus: Trigger election at startup if single node .. RaftConsensus: Trigger election at startup if single node If a tablet's replication factor is 1 then

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#3). Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Use RaftConsensus instead of LocalConsensus in tests This paves the way to remove the LocalConsensus

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Abandoned Squashing this into the following commit. -- To view, visit http://gerrit.cloudera.org:8080/3345 To unsubscribe,

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: (1 comment)

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 3: OK, still let's do it a bit later. -- To view, visit http://gerrit.cloudera.org:8080/3350 To

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#4). Change subject: RaftConsensus: Trigger election at startup if single node .. RaftConsensus: Trigger election at startup if single node If a tablet's replication factor is 1 then

[kudu-CR] create-demo-table must specify partition columns

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: create-demo-table must specify partition columns .. create-demo-table must specify partition columns This is a recent API change that didn't make it into this dev

[kudu-CR] Fix variable name typo in ITBLL

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3367 Change subject: Fix variable name typo in ITBLL .. Fix variable name typo in ITBLL Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 6: (1 comment) I wish there was an easier way to hide the data object so that we can only

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: (1 comment)

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 2: Verified+1 Overriding Jenkins due to super flaky Java test

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: Verified+1 Overriding Jenkins due to super flaky Java test

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-09 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3344 to look at the new patch set (#2). Change subject: RaftConsensus: Trigger election at startup if single node ..

[kudu-CR] Always write last known addr into ConsensusMetadata

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Always write last_known_addr into ConsensusMetadata .. Abandoned abandoning this one -- To view, visit http://gerrit.cloudera.org:8080/3349 To unsubscribe, visit

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: Code-Review+1 lgtm but Dan should take a look too, since he develops on a Mac -- To view, visit

[kudu-CR] Prepare some tests for RaftConsensus

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Prepare some tests for RaftConsensus .. Abandoned squashing this one. hard to do it separate -- To view, visit http://gerrit.cloudera.org:8080/3348 To unsubscribe, visit

[kudu-CR] Convert alter table-test to use RaftConsensus

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Convert alter_table-test to use RaftConsensus .. Abandoned squashing this. hard to do it separate -- To view, visit http://gerrit.cloudera.org:8080/3347 To unsubscribe,

[kudu-CR](gh-pages) Blog post for 0.9.0 release

2016-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3357/2/_posts/2016-06-10-apache-kudu-0-9-0-released.md File

[kudu-CR] Improve tpch usability

2016-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 3: Overriding Jenkins due to flaky test -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit

[kudu-CR] Improve tpch usability

2016-06-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Improve tpch usability .. Improve tpch usability * tpch.sh should use $ROOT to find the CPU scaling script (I had a problem with it otherwise) *

[kudu-CR] Improve tpch usability

2016-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-08 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3345 to review the following change. Change subject: Add WaitUntilLeader() to Consensus interface .. Add

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-08 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3346 to review the following change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Use

[kudu-CR] Always write last known addr into ConsensusMetadata

2016-06-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Always write last_known_addr into ConsensusMetadata .. Patch Set 1: I'm actually not quite sure about this solution. It works for now but it may not work well for

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-05-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/3135/4//COMMIT_MSG Commit Message: Line

[kudu-CR] Don't use InMemoryEnv in deltafile-test

2016-05-27 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3235 to look at the new patch set (#2). Change subject: Don't use InMemoryEnv in deltafile-test .. Don't use

[kudu-CR] Don't use InMemoryEnv in deltafile-test

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Don't use InMemoryEnv in deltafile-test .. Don't use InMemoryEnv in deltafile-test Get out the vote: #NeverMemEnv. This is causing problems due to

[kudu-CR](gh-pages) Add support for anchors.js to get permalinks on all headers

2016-05-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add support for anchors.js to get permalinks on all headers .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2739 To unsubscribe,

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3258 to look at the new patch set (#2). Change subject: Remove InMemoryEnv completely .. Remove InMemoryEnv completely

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: Ah, should've used git grep. -- To view, visit http://gerrit.cloudera.org:8080/3258 To unsubscribe, visit

[kudu-CR] Fix license issues

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Fix license issues .. Fix license issues Change-Id: Id23c13f3bb0b5f2b8dd21af5decf061c9ee825a4 Reviewed-on: http://gerrit.cloudera.org:8080/3254

[kudu-CR] Fix license issues

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix license issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3254 To unsubscribe, visit

[kudu-CR] Improve tpch usability

2016-06-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 70:

[kudu-CR] Improve tpch usability

2016-06-02 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Improve tpch usability .. Abandoned accidental dup review -- To view, visit http://gerrit.cloudera.org:8080/3280 To unsubscribe, visit

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-05-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3135 to look at the new patch set (#3). Change subject: Allow for reserving disk space for non-Kudu processes .. Allow

[kudu-CR] Don't use InMemoryEnv in deltafile-test

2016-05-26 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3235 Change subject: Don't use InMemoryEnv in deltafile-test .. Don't use InMemoryEnv in deltafile-test Get out the vote: #NeverMemEnv. This

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-05-26 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3234 to review the following change. Change subject: log: Mark allocation finished even if allocation had an error

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-05-26 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3135 to look at the new patch set (#2). Change subject: Allow for reserving disk space for non-Kudu processes

[kudu-CR] Make BuildLog() return Status

2016-05-26 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3134 to look at the new patch set (#2). Change subject: Make BuildLog() return Status .. Make

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-05-27 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3135 to look at the new patch set (#4). Change subject: Allow for reserving disk space for non-Kudu processes .. Allow

[kudu-CR] Replace boost::{lock, unique_lock, mutex} with std lib equivalents

2016-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3262 To

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents .. Patch Set 7: Although I'm not overriding Adar's concern, he should chime back in. -- To view,

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents .. Patch Set 7: Code-Review+2 On second thought, I agree with Adar that it looks cleaner without

[kudu-CR] Improve tpch usability

2016-06-01 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3280 Change subject: Improve tpch usability .. Improve tpch usability * tpch.sh should use $ROOT to find the CPU scaling script (I had a

[kudu-CR] Fix reorder warning in TabletMetadata

2016-06-01 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3281 Change subject: Fix reorder warning in TabletMetadata .. Fix reorder warning in TabletMetadata Fix the following warning: In file

[kudu-CR] KUDU-1262. Fix WritableFile::PreAllocate() on MemEnv

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: KUDU-1262. Fix WritableFile::PreAllocate() on MemEnv .. Abandoned MemEnv has been removed -- To view, visit http://gerrit.cloudera.org:8080/1439 To unsubscribe, visit

[kudu-CR] Remove last two usages of MemEnv in tests

2016-05-31 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3257 to review the following change. Change subject: Remove last two usages of MemEnv in tests .. Remove last two usages of

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3258 to review the following change. Change subject: Remove InMemoryEnv completely .. Remove InMemoryEnv completely Every

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base that I could find. For the

[kudu-CR] Remove last two usages of MemEnv in tests

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Remove last two usages of MemEnv in tests .. Remove last two usages of MemEnv in tests TestEnv.TestReadFully still only takes about 6ms to execute.

[kudu-CR] Make BuildLog() return Status

2016-05-27 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Make BuildLog() return Status .. Make BuildLog() return Status This allows for writing a reasonable test related to du.reserved Change-Id:

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc

[kudu-CR] Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix stray memory writes due to tcmalloc profiling .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3445 To unsubscribe, visit

[kudu-CR] docs: informal design for handling permanent master failures

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: informal design for handling permanent master failures .. Patch Set 1: (15 comments) This is sounding more formal, let's just call it a real design doc :)

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: Add Raft remote bootstrap design doc .. Add Raft remote bootstrap design doc This was ported over from a Google doc Change-Id:

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Raft remote bootstrap design doc .. Patch Set 2: See the rendered page at

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: RaftConsensus: Trigger election at startup if single node .. RaftConsensus: Trigger election at startup if single node If a tablet's replication factor is

[kudu-CR] Add more helpful CHECK message at master startup

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add more helpful CHECK message at master startup .. Patch Set 1: Jenkins in borken so +1ing myself -- To view, visit http://gerrit.cloudera.org:8080/3396 To

[kudu-CR] Add more helpful CHECK message at master startup

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Add more helpful CHECK message at master startup .. Add more helpful CHECK message at master startup Maybe this could help debug KUDU-1488 a little bit

[kudu-CR] Add more helpful CHECK message at master startup

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add more helpful CHECK message at master startup .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3396 To unsubscribe, visit

[kudu-CR] Link to raft config change design from design-docs index page

2016-06-16 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3394 to review the following change. Change subject: Link to raft config change design from design-docs index page .. Link

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3395 to review the following change. Change subject: Add Raft remote bootstrap design doc .. Add Raft remote bootstrap

[kudu-CR] Add more helpful CHECK message at master startup

2016-06-16 Thread Mike Percy (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3396 to review the following change. Change subject: Add more helpful CHECK message at master startup .. Add more

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3346/4/src/kudu/consensus/consensus.h File

[kudu-CR] Link to raft config change design from design-docs index page

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Link to raft config change design from design-docs index page .. Link to raft config change design from design-docs index page Change-Id:

[kudu-CR] Link to raft config change design from design-docs index page

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Link to raft config change design from design-docs index page .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3394 To unsubscribe,

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3395 to look at the new patch set (#3). Change subject: Add Raft remote bootstrap design doc .. Add Raft remote

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Raft remote bootstrap design doc .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3395/2/docs/design-docs/raft-remote-bootstrap.md File

[kudu-CR] Add Raft remote bootstrap design doc

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Raft remote bootstrap design doc .. Patch Set 2: Updated HTML: https://github.com/mpercy/kudu/blob/consensus-docs-3a/docs/design-docs/raft-remote-bootstrap.md

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-16 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3346 to look at the new patch set (#5). Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Use

[kudu-CR] Remove the LocalConsensus implementation

2016-06-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3350/5/src/kudu/consensus/metadata.proto File

[kudu-CR] Reformat raft-config-change.md to clean it up

2016-06-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Reformat raft-config-change.md to clean it up .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md File

[kudu-CR] Reformat raft-config-change.md to clean it up

2016-06-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Reformat raft-config-change.md to clean it up .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md File

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3234 to look at the new patch set (#3). Change subject: log: Mark allocation finished even if allocation had an error

[kudu-CR] docs: design for handling permanent master failures

2016-06-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 2: Mind updating the rendered HTML version? -- To view, visit

[kudu-CR] Add Env::GetBytesFree() method

2016-06-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3451 to look at the new patch set (#3). Change subject: Add Env::GetBytesFree() method .. Add Env::GetBytesFree()

[kudu-CR] Add Env::GetBytesFree() method

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Env::GetBytesFree() method .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3451/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: (1 comment)

[kudu-CR] Add Env::GetBytesFree() method

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Env::GetBytesFree() method .. Patch Set 3: Filed a JIRA for the data race discovered by Jenkins: https://issues.apache.org/jira/browse/KUDU-1491 -- To view,

[kudu-CR] Add Env::GetBytesFree() method

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Env::GetBytesFree() method .. Patch Set 3: Verified+1 Overriding unrelated failure -- To view, visit http://gerrit.cloudera.org:8080/3451 To unsubscribe,

[kudu-CR] Add Env::GetBytesFree() method

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Add Env::GetBytesFree() method .. Add Env::GetBytesFree() method This method returns the number of bytes free on the filesystem represented by its path

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: (1 comment)

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: log: Mark allocation finished even if allocation had an error .. log: Mark allocation finished even if allocation had an error This fixes two bugs: 1. If

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. KUDU-1469. Fix handling of fully-deduped requests after a leader change This

[kudu-CR] Add Env::GetBytesFree() method

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Env::GetBytesFree() method .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3451/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc:

[kudu-CR](gh-pages) Control how content is cached on the Kudu web site

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control how content is cached on the Kudu web site .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3462/1/.htaccess File .htaccess: Line 1: #

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-06-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3135 to look at the new patch set (#7). Change subject: Allow for reserving disk space for non-Kudu processes .. Allow

[kudu-CR](gh-pages) Control how content is cached on the Kudu web site

2016-06-22 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3462 to review the following change. Change subject: Control how content is cached on the Kudu web site .. Control how

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-06-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3135 to look at the new patch set (#6). Change subject: Allow for reserving disk space for non-Kudu processes .. Allow

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 5: (24 comments) http://gerrit.cloudera.org:8080/#/c/3135/5/src/kudu/consensus/log.cc File

[kudu-CR] consensus: Crash if we fail to append to the WAL

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: Crash if we fail to append to the WAL .. consensus: Crash if we fail to append to the WAL Being unable to write to the WAL is a serious problem

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/4/src/kudu/consensus/log.cc

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-06-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3135 to look at the new patch set (#5). Change subject: Allow for reserving disk space for non-Kudu processes .. Allow

  1   2   3   >