Review Request 48773: Added docs on aufs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48773/ --- Review request for mesos, Guangya Liu and Jie Yu. Bugs: MESOS-5549

Re: Review Request 48387: Delay before initiating a connection with master.

> On June 14, 2016, 2:40 p.m., Anand Mazumdar wrote: > > This is looking much better. > > > > Can you include both `flags.hpp/flags.cpp` in `src/Makefile.am`? This would > > fix the ReviewBot build failures. Hey Jose, I see that you marked the issues as resolved. Did you forget publishing

Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48687/ --- (Updated 六月 16, 2016, 1:51 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

> On 六月 16, 2016, 1:11 a.m., zhou xing wrote: > > src/master/http.cpp, line 1371 > > > > > > for some of the set_xxx or update_xxx method, we do not need > > contentType, we keep this param only for consistency? >

Re: Review Request 48387: Delay before initiating a connection with master.

> On June 14, 2016, 11:40 a.m., Anand Mazumdar wrote: > > src/scheduler/scheduler.cpp, line 320 > > > > > > As per my review comment in an earlier version of the patch, let's have > > the signature of this method

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

> On June 16, 2016, 12:59 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 262 > > > > > > hmm. you are still copying all the metrics into a hashmap and returning > > it, incuring an

Re: Review Request 48364: Removed hard dependence on `libnvidia-ml.so` for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48364/#review137590 --- Fix it, then Ship it! Nice to see the build time depedency

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

> On June 16, 2016, 1:11 a.m., zhou xing wrote: > > src/master/http.cpp, line 1371 > > > > > > for some of the set_xxx or update_xxx method, we do not need > > contentType, we keep this param only for consistency?

Re: Review Request 48530: Moved working groups from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48530/#review137904 --- Ship it! Ship It! - haosdent huang On June 15, 2016, 8:01

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

> On June 16, 2016, 12:59 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 262 > > > > > > hmm. you are still copying all the metrics into a hashmap and returning > > it, incuring an

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/#review137901 --- src/master/http.cpp (line 1371)

Review Request 48767: WIP: Add log replica tests that exercise election retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48767/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Neil

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137899 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 4:28 p.m.,

Re: Review Request 48602: Implemented v1::master::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48602/#review137898 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 4:28 p.m.,

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48601/#review137863 --- 3rdparty/libprocess/src/metrics/metrics.cpp (line 252)

Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48687/#review137888 --- Fix it, then Ship it! Could you this nit in `recover()` and

Re: Review Request 48721: Editorialized on the new Docker volume isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48721/#review137890 --- docs/docker-volume.md (line 32)

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On 六月 15, 2016, 11:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 524 > > > > > > I think that we should also remove this checking here as `mode` is > > required, comments? Posted a patch here

Review Request 48769: Removed has_mode check in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48769/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5341

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137878 --- src/docker/docker.cpp (line 524)

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 15, 2016, 11:02 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 14, 2016, 8:45 a.m., Neil Conway wrote: > > src/slave/slave.cpp, line 2540 > > > > > > I think this justifies a unit test. What do you think? Added checks in unit test to verify that contents of

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 15, 2016, 11:01 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 1:28 p.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/ --- (Updated June 15, 2016, 11:01 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated June 15, 2016, 11 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48483: Clarified dvdcli needs to be installed on each agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48483/ --- (Updated 六月 15, 2016, 10:52 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/#review137873 --- Ship it! Ship It! - Jie Yu On June 15, 2016, 10:42 p.m.,

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/ --- (Updated June 15, 2016, 3:42 p.m.) Review request for mesos, Artem

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review137868 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

> On June 15, 2016, 6:08 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 967 > > > > > > We should make these keys ("labels", "task-id", "args") as `constexpr` >

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 15, 2016, 10:23 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 48759: Removed missing headers from 'src/Makefile.am'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48759/#review137864 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 9:42 p.m.,

Re: Review Request 48669: Modified os user test for user switching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48669/ --- (Updated June 15, 2016, 2:56 p.m.) Review request for mesos, Artem

Review Request 48759: Removed missing headers from 'src/Makefile.am'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48759/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 15, 2016, 9:41 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47892/#review137857 --- Ship it! Ship It! - Kapil Arya On June 15, 2016, 5:34 p.m.,

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47892/ --- (Updated June 15, 2016, 9:34 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47893/#review137858 --- Ship it! Ship It! - Kapil Arya On June 15, 2016, 5:34 p.m.,

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47893/ --- (Updated June 15, 2016, 9:34 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/#review137643 --- Given that we already have `os::ls()` I don't see this as

Re: Review Request 48744: Changed agent and scheduler authentication timeouts to ensure progress.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48744/ --- (Updated June 15, 2016, 11:20 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48600/#review137851 --- Fix it, then Ship it! include/mesos/agent/agent.proto (line

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/#review137849 --- src/tests/api_tests.cpp (line 71)

Re: Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48597/#review137850 --- src/tests/api_tests.cpp (line 272)

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 15, 2016, 9:10 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 48737: Added comments for `Call::SET_LOGGING_LEVEL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48737/#review137847 --- Fix it, then Ship it! include/mesos/agent/agent.proto (line

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/#review137846 --- Fix it, then Ship it! src/slave/http.cpp (line 267)

Re: Review Request 48584: Added unversioned protos for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/#review137843 --- src/Makefile.am (line 220)

Re: Review Request 48574: Added assertion for a write in CoordinatorTest.Elect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48574/ --- (Updated June 15, 2016, 2:03 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 48572: Updated whitespace style in log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48572/ --- (Updated June 15, 2016, 2:03 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 48571: Added assertion for initialization success to the log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48571/ --- (Updated June 15, 2016, 2:03 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 48745: Removed JNI major version check.

> On June 15, 2016, 1:30 p.m., Vinod Kone wrote: > > Ship It! Thanks, will wait for reviewbot to get to it and then commit it. - Jiang Yan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137836 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 2:26 p.m.,

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/ --- (Updated June 15, 2016, 8:52 p.m.) Review request for mesos, Anand Mazumdar

Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5489

Re: Review Request 48745: Removed JNI major version check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48745/#review137833 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 7:48 p.m.,

Re: Review Request 48530: Moved working groups from wiki to page.

> On June 10, 2016, 2:16 a.m., haosdent huang wrote: > > site/source/working-groups.html.erb, line 4 > > > > > > Add one blank line below to keep consistent with other erb template. @hasodent Could you review it one

Re: Review Request 47352: Fixed the configuration.md for docker volume checkpoint flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47352/#review137818 --- Ship it! Ship It! - Jie Yu On June 14, 2016, 12:06 a.m.,

Re: Review Request 46594: Added test for isolator cleanup before prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/#review137817 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 6:06 p.m.,

Re: Review Request 46593: Added test for containerizer destroy while provisioning race.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46593/#review137815 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 6:05 p.m.,

Review Request 48745: Removed JNI major version check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48745/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5571

Re: Review Request 48619: Removed fs::aufs::supported and fs::overlay::supported.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48619/#review137813 --- Ship it! Ship It! - Jie Yu On June 13, 2016, 9:33 a.m.,

Re: Review Request 48618: Refactored overlay, overlayfs and aufs check to fs::supported.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48618/#review137812 --- Ship it! Ship It! - Jie Yu On June 13, 2016, 10:18 a.m.,

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On June 12, 2016, 7:10 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 559-562 > > > > > > I don't get this check. if we end up here, has_host_path() is false and > > has_source() is false, why we bother

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

> On June 15, 2016, 11 a.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp, line 219 > > > > > > Per your TODO above, maxgroups will be 16 on OSX. If ngroups is greater > > than 16, what will

Re: Review Request 48733: Updated TODO and comments refering to 0.29.

> On June 15, 2016, 6:55 p.m., Alexander Rukletsov wrote: > > src/module/manager.cpp, line 100 > > > > > > Did you leave out that 0.29.0 on purpose? Fixed in an addendum commit:

Re: Review Request 48733: Updated TODO and comments refering to 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48733/ --- (Updated June 15, 2016, 6:59 p.m.) Review request for mesos and Alexander

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/ --- (Updated June 15, 2016, 11:58 a.m.) Review request for mesos, Artem

Re: Review Request 48733: Updated TODO and comments refering to 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48733/#review137802 --- Fix it, then Ship it! I'll fix the last outstanding issue and

Re: Review Request 48733: Updated TODO and comments refering to 0.29.

> On June 15, 2016, 6:32 p.m., Alexander Rukletsov wrote: > > src/authorizer/local/authorizer.cpp, line 352 > > > > > > According to the changelog, we call it 1.0.0 officially. Could you > > please update? After

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47668/#review137795 --- Ship it! Ship It! - Jie Yu On June 15, 2016, 5:46 p.m.,

Re: Review Request 48733: Updated TODO and comments refering to 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48733/#review137793 --- Fix it, then Ship it! src/authorizer/local/authorizer.cpp

Re: Review Request 48056: Windows: Added build and run instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/ --- (Updated June 15, 2016, 6:19 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/#review137784 --- 3rdparty/stout/include/stout/os/posix/su.hpp (line 219)

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/#review137776 --- Fix it, then Ship it!

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 47661: Improved the mesos containerizer windows related logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47661/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 48669: Modified os user test for user switching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48669/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47668/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 47666: Added stout functions to set uid and gid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47666/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 48711: Fixed isolator proto message bracket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48711/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 47660: Fixed agent switch user redundant logic in 'getExecutorInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47660/ --- (Updated June 15, 2016, 10:46 a.m.) Review request for mesos, Artem

Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48600/ --- (Updated June 15, 2016, 5:35 p.m.) Review request for mesos, Abhishek

Re: Review Request 48737: Added comments for `Call::SET_LOGGING_LEVEL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48737/ --- (Updated June 15, 2016, 5:32 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48084: [WIP] Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 15, 2016, 5:20 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/ --- (Updated June 15, 2016, 5:14 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 48737: Added comments for `Call::SET_LOGGING_LEVEL`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48737/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/ --- (Updated June 15, 2016, 5:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48600/ --- (Updated June 15, 2016, 5:12 p.m.) Review request for mesos, Abhishek

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/#review137774 --- Patch looks great! Reviews applied: [48495, 48496, 48497]

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/#review137686 --- Fix it, then Ship it! src/launcher/executor.cpp (lines 78 -

Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47663/ --- (Updated June 15, 2016, 9:51 a.m.) Review request for mesos, Artem

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/ --- (Updated June 15, 2016, 9:52 a.m.) Review request for mesos, Artem

Re: Review Request 47665: Passed image user to mesos containerizer launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47665/ --- (Updated June 15, 2016, 9:52 a.m.) Review request for mesos, Artem

Re: Review Request 47662: Added image user to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47662/ --- (Updated June 15, 2016, 9:50 a.m.) Review request for mesos, Artem

Re: Review Request 48711: Fixed isolator proto message bracket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48711/#review137759 --- Ship it! Ship It! - Jie Yu On June 14, 2016, 11:27 p.m.,

Re: Review Request 47660: Fixed agent switch user redundant logic in 'getExecutorInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47660/#review137757 --- Ship it! Ship It! - Jie Yu On June 14, 2016, 11:27 p.m.,

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 15, 2016, 4:28 p.m.) Review request for mesos, Abhishek

  1   2   >