Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49781/#review141853 --- Patch looks great! Reviews applied: [49943, 49781] Passed

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the

Re: Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/#review141851 --- src/examples/CMakeLists.txt (line 112)

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/#review141849 --- src/slave/CMakeLists.txt (lines 24 - 29)

Re: Review Request 49921: Fixed mesos tests to run 723 test on Unix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/#review141847 --- src/tests/CMakeLists.txt (line 51)

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- (Updated July 12, 2016, 4:40 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 12, 2016, 4:39 a.m.) Review request for mesos. Bugs:

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/ --- (Updated July 12, 2016, 4:39 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated July 12, 2016, 4:38 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49784: Increase framework numbers to allocator benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49784/#review141843 --- src/tests/hierarchical_allocator_tests.cpp (line 3196)

Re: Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review141842 --- 3rdparty/libprocess/src/CMakeLists.txt (line 90)

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review141841 --- src/CMakeLists.txt (line 477)

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141840 --- src/tests/CMakeLists.txt (line 156)

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141822 --- cmake/MesosConfigure.cmake (line 94)

Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 12, 2016, 12:11 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 12, 2016, 12:08 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

> On July 12, 2016, 12:20 a.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > also, can you rebase the chain? Thanks a lot for your reviews, just updated. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/ --- (Updated July 12, 2016, 4:03 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49799: Added test case for 'GetTasks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49799/ --- (Updated July 12, 2016, 4:02 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49798: Added test case for 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49798/ --- (Updated July 12, 2016, 4:02 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49759: Implemented 'GetTasks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49759/ --- (Updated July 12, 2016, 4:01 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49797: Added test case for 'GetFrameworks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49797/ --- (Updated July 12, 2016, 4:02 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49760: Implemented 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49760/ --- (Updated July 12, 2016, 4:02 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49759: Implemented 'GetTasks' call in v1 agent API.

> On July 8, 2016, 12:11 p.m., Jay Guo wrote: > > src/slave/http.cpp, lines 1240-1261 > > > > > > @zhitao and I once had a conversation to create a helper function to > > create approvers, which can be used by

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49757/ --- (Updated July 12, 2016, 3:59 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49758: Implemented 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49758/ --- (Updated July 12, 2016, 4 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/#review141836 --- Bad patch! Reviews applied: [49800, 49799, 49798, 49797, 49760,

Re: Review Request 49843: Added benchmark test for sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49843/ --- (Updated 七月 12, 2016, 3:19 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/#review141832 --- src/tests/mesos.hpp (line 582)

Re: Review Request 48593: Refactor Ranges Subtraction.

> On July 11, 2016, 11:37 p.m., Joseph Wu wrote: > > Content-wise, looks good. > > > > I've left some comments below on a few stylistic nits, which I'll fix > > before committing. > > I also went ahead and tweaked your patch description to explain what the > > improvement was. Hi, Joseph,

Review Request 49939: Updated GET_METRICS call in AGENT v1 api to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49939/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-5731

Review Request 49938: Updated GET_METRICS call in MASTER v1 api to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-5731

Review Request 49937: Added snapshotByTypes() method in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49937/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-5731

Review Request 49936: Added metric types in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49936/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-5731

Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49781/ --- (Updated 七月 12, 2016, 2:01 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 49943: Made vector reserve some spaces for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49943/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/ --- (Updated July 12, 2016, 1:25 a.m.) Review request for mesos, Vinod Kone and

Re: Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review141827 --- Patch looks great! Reviews applied: [49688, 49862, 49863, 49870,

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 11, 2016, 6:11 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 49926: Added Windows build batch script.

> On July 11, 2016, 5:35 p.m., Daniel Pravat wrote: > > support/windows-build.bat, line 71 > > > > > > If you add one more target Clean you don't need to delete any folder. Do you mean the "build/include" and

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141804 --- support/windows-build.bat (line 71)

Re: Review Request 49865: Renamed `info` to `executorInfo` in `Master::Http::_getExecutors`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49865/#review141816 --- Ship it! Ship It! - Vinod Kone On July 10, 2016, 6:47 a.m.,

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

> On July 12, 2016, 12:20 a.m., Vinod Kone wrote: > > also, can you rebase the chain? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/#review141812

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/#review141812 --- src/tests/api_tests.cpp (line 2838)

Re: Review Request 49798: Added test case for 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49798/#review141811 --- src/tests/api_tests.cpp (line 2592)

Re: Review Request 49799: Added test case for 'GetTasks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49799/#review141810 --- src/tests/api_tests.cpp (lines 2703 - 2709)

Re: Review Request 49798: Added test case for 'GetExecutors' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49798/#review141809 --- Ship it! Ship It! - Vinod Kone On July 8, 2016, 4:14 p.m.,

Re: Review Request 49797: Added test case for 'GetFrameworks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49797/#review141808 --- Ship it! Ship It! - Vinod Kone On July 8, 2016, 4:14 p.m.,

Re: Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review141806 --- src/tests/master_slave_reconciliation_tests.cpp (lines 617 -

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review141802 --- Patch looks great! Reviews applied: [49913, 49914] Passed

Re: Review Request 49928: Fixed dependency on .proto sources to generate protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49928/#review141801 --- Ship it! Confirmed that this regenerates the proper protobufs

Re: Review Request 49843: Added benchmark test for sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49843/ --- (Updated 七月 11, 2016, 11:38 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141789 --- Ship it! Content-wise, looks good. I've left some comments

Re: Review Request 49840: Fixed the right angle brackets in routing tests.

> On July 11, 2016, 10:15 p.m., Qian Zhang wrote: > > Is this (">>") the coding convention of Mesos? If so, we may need to > > mention it in > > https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md. > > And I see there are still a lot of code in Mesos using "> >" now, maybe

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141793 --- LGTM from what I can understand. I'll let the Microsoft Guys take

Re: Review Request 49864: Fixed ExecutorPIDTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/#review141791 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141788 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 11, 2016, 3:19 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 49907: Added Timothy Chen to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49907/#review141787 --- Patch looks great! Reviews applied: [49907] Passed command:

Review Request 49928: Fixed dependency on .proto sources to generate protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49928/ --- Review request for mesos, Anand Mazumdar, Alex Clemmer, and Joseph Wu. Bugs:

Re: Review Request 49920: Added backport of MESOS-5576 and MESOS-5740 to 0.28.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49920/ --- (Updated July 11, 2016, 2:58 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Alex Clemmer.

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 11, 2016, 9:42 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On July 11, 2016, 4:31 p.m., Neil Conway wrote: > > src/slave/slave.cpp, line 4778 > > > > > > Should we also remove the target resources in the case when target and > > checkpointed resources are the same?

Re: Review Request 49843: Added benchmark test for sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49843/#review141779 --- src/tests/sorter_tests.cpp (lines 493 - 498)

Re: Review Request 49812: Added missing header `version.hpp` in `src/linux/perf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49812/#review141782 --- Ship it! Ship It! - Jie Yu On July 9, 2016, 10:16 a.m.,

Re: Review Request 49846: The SorterTest.RevocableResources should add total resources for slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49846/#review141775 --- Ship it! Ship It! - Benjamin Mahler On July 9, 2016, 3:59

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40487/#review141773 --- Hey Ian, It does appear that we still do not have the hostname

Re: Review Request 40456: MESOS-3950: show running task count in web ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40456/#review141770 --- It appears to be already implemented now that this review has

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

> On 七月 7, 2016, 6:38 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, lines 215-219 > > > > > > So for the case of sh=0,value=0,argv=1,Exec=1, what about the value of > >

Re: Review Request 49920: Added backport of MESOS-5576 and MESOS-5740 to 0.28.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49920/#review141768 --- Ship it! Ship It! - Benjamin Mahler On July 11, 2016, 8:26

Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141764 --- This patch looks good to me. Will come back with a ship it after

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

> On July 10, 2016, 2:50 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp, lines 101-116 > > > > > > Suggest to change to: > > ``` > > struct Info > > { > >

Review Request 49921: Fixed mesos tests to run 723 test on Unix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated July 11, 2016, 8:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated July 11, 2016, 8:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 11, 2016, 8:39 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49812: Added missing header `version.hpp` in `src/linux/perf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49812/#review141761 --- Ship it! Ship It! - Gilbert Song On July 9, 2016, 3:16

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

> On July 6, 2016, 11:38 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, lines 215-219 > > > > > > So for the case of sh=0,value=0,argv=1,Exec=1, what about the value of > >

Re: Review Request 49920: Added backport of MESOS-5576 and MESOS-5740 to 0.28.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49920/#review141758 --- Ship it! Ship It! - Jie Yu On July 11, 2016, 8:26 p.m.,

Review Request 49920: Added backport of MESOS-5576 and MESOS-5740 to 0.28.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49920/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Jie Yu.

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review141741 --- Could you address Guangya's comments? Thanks.

Re: Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review141756 --- src/slave/main.cpp (lines 175 - 179)

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review141755 --- Changing the linking structure of this project has a few very

Re: Review Request 49906: Add lawrencew to contributors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49906/#review141752 --- Bad patch! Reviews applied: [49906] Failed command:

Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. Bugs:

Re: Review Request 49903: Printed empty set if `Resources` instance is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141750 --- Ship it! Ship It! - Isabel Jimenez On July 11, 2016, 4:31

Re: Review Request 49903: Printed empty set if `Resources` instance is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141748 --- Ship it! Thanks for improving the logging Alex - I am a great

Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5725

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review141305 --- Partial review. Let's discuss first. src/master/master.cpp

Re: Review Request 49907: Added Timothy Chen to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49907/#review141737 --- Ship it! Ship It! - Jie Yu On July 11, 2016, 5:49 p.m.,

Review Request 49907: Added Timothy Chen to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49907/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 49906: Add lawrencew to contributors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49906/#review141735 --- Ship it! Ship It! - Jie Yu On July 11, 2016, 5:47 p.m.,

  1   2   >