Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated Aug. 4, 2016, 5:05 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49862: Changed libmesos from static library to a shared library.

> On Aug. 2, 2016, 1:31 a.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 70 > > > > > > Oh. This is especially pertinent given that you seem to remove this > > line in #49874. I cannot

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/#review144713 --- Patch looks great! Reviews applied: [50762, 50763] Passed

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review144708 --- Can you please remove the review ID `50258, 50229` from the

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review144706 --- src/docker/docker.hpp (lines 73 - 75)

Re: Review Request 50739: Updated '--fetcher_cache_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50739/#review144704 --- Bad patch! Reviews applied: [50739, 50737, 50736, 40512, 40268,

Re: Review Request 49851: Implemented `MemorySubsystem`.

> On July 27, 2016, 10:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review144702 --- Bad patch! Reviews applied: [49571, 45967, 45966, 45964, 45963,

Re: Review Request 50775: Fixed sign comparisons in logrotate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50775/#review144699 --- Ship it! Ship It! - Jie Yu On Aug. 4, 2016, 12:05 a.m.,

Review Request 50775: Fixed sign comparisons in logrotate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50775/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/ --- (Updated Aug. 3, 2016, 5:03 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 50774: Added `-Wsign-compare` to global compiler flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50774/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Michael

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/ --- (Updated Aug. 3, 2016, 11:14 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

> On Aug. 3, 2016, 7:58 p.m., Adam B wrote: > > src/master/master.cpp, lines 5164-5166 > > > > > > Maybe increment `metrics->invalid_status_updates` in the else case here? > > And log here, as before? > >

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144677 --- Fix it, then Ship it! src/master/master.cpp (lines 5201 -

Re: Review Request 50767: Updated logrotation module to use `os::pagesize()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50767/ --- (Updated Aug. 3, 2016, 10:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50713: Documented behavior of content-type header in presence of errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50713/ --- (Updated Aug. 3, 2016, 10:12 p.m.) Review request for mesos and Anand

Re: Review Request 50640: Improved HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50640/#review144683 --- Ship it! LGTM - Anand Mazumdar On July 31, 2016, 2:53 p.m.,

Re: Review Request 50641: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50641/#review144682 --- Ship it! Ship It! - Anand Mazumdar On July 31, 2016, 2:53

Re: Review Request 50762: Updated 'NvidiaVolume' to not error out when binary is missing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50762/#review144680 --- Ship it! Ship It! - Benjamin Mahler On Aug. 3, 2016, 7:10

Re: Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50766/#review144679 --- Ship it! Ship It! - Joseph Wu On Aug. 3, 2016, 2:16 p.m.,

Review Request 50769: Fixed a broken link to CNI repo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50769/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5985

Re: Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50766/ --- (Updated Aug. 3, 2016, 9:16 p.m.) Review request for mesos, Benjamin Mahler

Review Request 50771: Added coverity build to build_docker.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50771/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5984

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 3, 2016, 2:18 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50766/#review144668 --- src/slave/container_loggers/lib_logrotate.hpp (lines 118 - 119)

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

> On Aug. 3, 2016, 12:58 p.m., Adam B wrote: > > src/master/master.cpp, lines 5164-5166 > > > > > > Maybe increment `metrics->invalid_status_updates` in the else case here? > > And log here, as before? > >

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

> On Aug. 3, 2016, 7:58 p.m., Adam B wrote: > > src/master/master.cpp, lines 5164-5166 > > > > > > Maybe increment `metrics->invalid_status_updates` in the else case here? > > And log here, as before? This was

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/ --- (Updated Aug. 3, 2016, 8:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/master/master.cpp, line 5142 > > > > > > Seems like we should still be logging when we get a status update from > > an unknown framework. +1, my bad. >

Review Request 50767: Updated logrotation module to use `os::pagesize()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50767/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Repository: mesos

Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50766/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-5983

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144662 --- src/master/master.cpp (lines 5154 - 5156)

Re: Review Request 49736: Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.

> On July 12, 2016, 4:40 p.m., Alex Clemmer wrote: > > 3rdparty/CMakeLists.txt, line 141 > > > > > > This probably won't work on Windows. You will notice that for (_e.g._) > > `HTTP_PARSER_PATCH_CMD`, we have

Review Request 50762: Updated 'NvidiaVolume' to not error out when binary is missing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50762/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5982

Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5969

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated Aug. 3, 2016, 7 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 50739: Updated '--fetcher_cache_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50739/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 50738: Improved performance in addition and subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50738/#review144639 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 3, 2016, 12:36

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review144638 --- Patch looks great! Reviews applied: [49819, 49820, 49821, 49823,

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144633 --- src/master/master.cpp

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 3, 2016, 5:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 3, 2016, 5:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 3, 2016, 5:57 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 3, 2016, 5:57 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 3, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 3, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Aug. 3, 2016, 5:37 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone. Bugs:

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 3, 2016, 5:30 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50736: Added SSL support to libprocess HTTP request helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50736/ --- Review request for mesos, Joseph Wu and Vinod Kone. Bugs: MESOS-5966

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 3, 2016, 5:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 3, 2016, 5:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Added `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated Aug. 3, 2016, 5:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 3, 2016, 5:17 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 3, 2016, 5:16 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 3, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 3, 2016, 5:14 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Aug. 3, 2016, 5:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 3, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49862: Changed libmesos from static library to a shared library.

> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote: > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake, line 51 > > > > > > You're right to split this out, but just for my own education, was > > there a specific reason

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Aug. 3, 2016, 4:40 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49736: Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49736/ --- (Updated Aug. 3, 2016, 9:21 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 3, 2016, 2:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 3, 2016, 2:35 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review144614 --- Bad patch! Reviews applied: [50751, 50750, 50749, 50748, 50733,

Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Re: Review Request 49360: Supported TCP check in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review144613 --- src/health-check/health_checker.hpp (line 316)

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144598 --- include/mesos/v1/mesos.proto (line 339)

Re: Review Request 50738: Improved performance in addition and subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50738/#review144612 --- Patch looks great! Reviews applied: [50738] Passed command:

Re: Review Request 50563: Made HierarchicalAllocatorProcess specify a process ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50563/#review144611 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016,

Re: Review Request 50521: Added "zookeeper" prefix to ZK process IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50521/#review144610 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016,

Re: Review Request 50639: Made all Actor IDs outside of libprocess follow the same schema.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50639/#review144609 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016,

Re: Review Request 50519: Made libprocess Actor IDs consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50519/#review144608 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016,

Re: Review Request 50515: Added missing process IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50515/#review144603 --- Fix it, then Ship it! I'll fix the outstanding issues and will

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50637/#review144606 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016,

Re: Review Request 50513: Added missing process IDs in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50513/#review144607 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2016,

Re: Review Request 50513: Added missing process IDs in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50513/#review144599 --- 3rdparty/libprocess/include/process/collect.hpp (line 136)

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/#review144596 --- Patch looks great! Reviews applied: [50570, 50609] Passed

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144591 --- Patch looks great! Reviews applied: [50723] Passed command:

Review Request 50738: Improved performance in addition and subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50738/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5978

Re: Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review144586 --- Bad patch! Reviews applied: [49924, 49921, 49874, 49870, 49863,