Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated March 17, 2017, 5:39 a.m.) Review request for mesos, Jie Yu and Qian

Review Request 57719: Fixed some coding style issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57719/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6022

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated March 17, 2017, 5:33 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 57628: Added a utility function to get back non-loopback address on the host.

> On March 16, 2017, 6:38 p.m., Jie Yu wrote: > > src/tests/utils.hpp > > Line 83 (original), 84 (patched) > > > > > > 2 lines apart. Can you fix this style issue in this file in a separate > > patch? Will do. >

Re: Review Request 57628: Added a utility function to get back non-loopback address on the host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57628/ --- (Updated March 17, 2017, 5:12 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

> On March 16, 2017, 7:42 p.m., kaiyu shi wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > > Lines 171 (patched) > > > > > > Perhaps a typo > > `OVERLAY_BACKEND` should be `AUFS_BACKEND`

Re: Review Request 57707: Added multi-role framework support to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57707/#review169252 --- Patch looks great! Reviews applied: [57707] Passed command:

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review169251 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 17, 2017, 2:10 a.m.) Review request for mesos and Michael Park.

Re: Review Request 57527: Avoided storing weights in the allocator.

> On March 17, 2017, 1:41 a.m., Benjamin Mahler wrote: > > Thinking a little more about this, it seems odd that the sorter is storing > > weight information for clients that are unknown to it. Why? It seems > > cleaner if the sorter only understands weights for its clients, rather than > >

Re: Review Request 57527: Avoided storing weights in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/#review169247 --- Thinking a little more about this, it seems odd that the sorter

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/#review169245 --- Hm.. this seems to introduce a performance regression in the case

Re: Review Request 57622: Introduced a Roles tab in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review169246 --- Ship it! Ship It! - Jay Guo On March 16, 2017, 9:28 a.m.,

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 17, 2017, 1:12 a.m.) Review request for mesos, Benjamin

Re: Review Request 57527: Avoided storing weights in the allocator.

> On March 17, 2017, 12:42 a.m., Benjamin Mahler wrote: > > Hm.. there is no way for weights to be removed from the sorter? Is that > > intentional? If there is some non-local reasoning needed to understand why, > > it would be great to document it. > > > > Also, could we perhaps title this

Re: Review Request 57527: Avoided storing weights in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/ --- (Updated March 17, 2017, 1:12 a.m.) Review request for mesos, Benjamin

Re: Review Request 57615: Added support for auth tokens to the V1 executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/#review169240 --- Patch looks great! Reviews applied: [56474, 56476, 56475, 57663,

Re: Review Request 53264: Added test for CNI port-mapper plugin.

> On March 16, 2017, 10:42 p.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 54 (patched) > > > > > > `__MESOS_TEST_PORT_MAPPER__` The `network/cni` isolator looks for `__MESOS_TEST__`

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57713/#review169237 --- docs/windows.md Lines 26 (patched)

Re: Review Request 57528: Reordered DRFSorter member function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57528/#review169236 --- Ship it! - Benjamin Mahler On March 11, 2017, 1:33 a.m.,

Re: Review Request 57527: Moved management of weights from allocator to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/#review169233 --- Hm.. there is no way for weights to be removed from the sorter?

Review Request 57714: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57714/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 16, 2017, 6:54 a.m., Jay Guo wrote: > > What should be the correct behavior for following case: > > - parent role `/a` is quota'd with `cpus:2;mem:1024` > > - child role `/a/b` is quota'd with `cpus:1;mem:512` > > - `Framework1` subscribes to role `/a` > > - `Framework2` subscribes to

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 17, 2017, 12:40 a.m.) Review request for mesos, Benjamin

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57713/ --- (Updated March 17, 2017, 12:22 a.m.) Review request for mesos, Joseph Wu and

Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57713/ --- Review request for mesos, Joseph Wu and Michael Park. Bugs: MESOS-7255

Review Request 57712: No need to set `agent_subsystems` for all the slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57712/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 48291: Use varint comparator in replica log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/#review169227 --- I don't have a lot of context here but I tried to look through

Re: Review Request 57710: Added `register_agents` to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57710/#review169225 --- Ship it! Ship It! - Anindya Sinha On March 16, 2017, 11:07

Re: Review Request 57700: Modified a test to also check if the data was written to the volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57700/#review169223 --- Patch looks great! Reviews applied: [57469, 57700] Passed

Re: Review Request 57710: Added `register_agents` to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57710/ --- (Updated March 16, 2017, 4:07 p.m.) Review request for mesos, Adam B, Anindya

Review Request 57710: Added `register_agents` to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57710/ --- Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Vinod

Review Request 57710: Added `register_agents` to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57710/ --- Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Vinod

Review Request 57707: Added multi-role framework support to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57707/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-6762

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/#review169217 --- Fix it, then Ship it!

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review169215 --- Seems like a legitimate problem in

Re: Review Request 57631: Augmented a test to check protobuf::stripAllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57631/#review169210 --- Ship it! Ship It! - Benjamin Mahler On March 15, 2017, 3:27

Re: Review Request 57340: Remove adjustment code within Resources::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review169209 --- Ship it! Ship It! - Benjamin Mahler On March 15, 2017, 3:26

Re: Review Request 57630: Renamed `adjustOfferOperation` to `injectAllocationInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57630/#review169208 --- Ship it! Ship It! - Benjamin Mahler On March 15, 2017, 3:26

Re: Review Request 57691: Enabled AsyncExecutorProcess::execute() via a template parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57691/#review169202 --- Ship it! Ship It! - Michael Park On March 16, 2017, 6:18

Re: Review Request 57690: Replaced Boost Type Traits with STL in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57690/#review169199 --- Ship it! Ship It! - Michael Park On March 16, 2017, 6:18

Re: Review Request 57689: Replaced Boost Type Traits with STL in Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57689/#review169200 --- Ship it! Ship It! - Michael Park On March 16, 2017, 6:18

Re: Review Request 57520: Bumped up the number of args allowed in some libprocess templates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57520/#review169197 --- Ship it! Ship It! - Michael Park On March 13, 2017, 10:08

Re: Review Request 56218: Added a check test for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169195 --- Bad patch! Reviews applied: [56218, 56213, 57696, 56217, 56215,

Re: Review Request 57615: Added support for auth tokens to the V1 executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/ --- (Updated March 16, 2017, 7:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 57667: Added executor authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57667/ --- (Updated March 16, 2017, 7:13 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 57671: Allowed the agent to require executor authentication.

> On March 16, 2017, 1:37 p.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 271-276 (patched) > > > > > > I know why you did it this way, but it seems a bit unfortunate that we > > are adding the JWT

Re: Review Request 57671: Allowed the agent to require executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57671/ --- (Updated March 16, 2017, 7:07 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 57666: Added the '--authenticate_http_executors' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/ --- (Updated March 16, 2017, 7:03 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 57665: Renamed a constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57665/ --- (Updated March 16, 2017, 7 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 57664: Added the '--executor_secret_key' agent flag.

> On March 16, 2017, 1:06 p.m., Vinod Kone wrote: > > src/slave/flags.cpp > > Lines 348 (patched) > > > > > > s/default// > > > > we will generate secrets using this key for command, docker and custom > >

Re: Review Request 57664: Added the '--executor_secret_key' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57664/ --- (Updated March 16, 2017, 6:59 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/ --- (Updated March 16, 2017, 6:49 p.m.) Review request for mesos, Gilbert Song,

Review Request 57700: Modified a test to also check if the data was written to the volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57700/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 57628: Added a utility function to get back non-loopback address on the host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57628/#review169187 --- Fix it, then Ship it! src/tests/utils.hpp Line 83 (original),

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated March 16, 2017, 6:25 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 57615: Added support for auth tokens to the V1 executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/#review169183 --- Patch looks great! Reviews applied: [56474, 56476, 56475, 57663,

Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57696/ --- (Updated March 16, 2017, 5:22 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ --- (Updated March 16, 2017, 4:53 p.m.) Review request for mesos and Michael Park.

Re: Review Request 57694: Added a warning if default executor gets an unknown acknowledgement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57694/ --- (Updated March 16, 2017, 4:51 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56449: Moved health checker closer to container in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated March 16, 2017, 4:48 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56213: Added check tests for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/ --- (Updated March 16, 2017, 4:46 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56217: Added support for general checks to default executor.

> On Feb. 15, 2017, 2:32 p.m., Gastón Kleiman wrote: > > src/launcher/default_executor.cpp > > Lines 931 (patched) > > > > > > I think that it'd be useful to also log the exit status/http status > > code. > >

Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57696/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57695/ --- Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone.

Re: Review Request 56218: Added a check test for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/ --- (Updated March 16, 2017, 4:46 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56215: Reused previous task status to generate a new one in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56215/ --- (Updated March 16, 2017, 4:45 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56217: Added support for general checks to default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/ --- (Updated March 16, 2017, 4:45 p.m.) Review request for mesos, Gastón Kleiman

Review Request 57694: Added a warning if default executor gets an unknown acknowledgement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57694/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 56449: Moved health checker closer to container in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/ --- (Updated March 16, 2017, 4:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 57691: Enabled AsyncExecutorProcess::execute() via a template parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57691/#review169172 --- Patch looks great! Reviews applied: [57689, 57690, 57691]

Re: Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57627/#review169171 --- Ship it! Ship It! - Jie Yu On March 14, 2017, 11:05 p.m.,

Re: Review Request 56217: Added support for general checks to default executor.

> On Feb. 15, 2017, 2:32 p.m., Gastón Kleiman wrote: > > src/launcher/default_executor.cpp > > Lines 931 (patched) > > > > > > I think that it'd be useful to also log the exit status/http status > > code. > >

Re: Review Request 57615: Added support for auth tokens to the V1 executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/ --- (Updated March 16, 2017, 3:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56449: Moved health checker closer to container in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169155 --- Patch looks great! Reviews applied: [56016, 57394, 56017, 57594,

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- (Updated March 16, 2017, 2:31 p.m.) Review request for mesos, Alexander

Re: Review Request 57671: Allowed the agent to require executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57671/#review169141 --- src/common/http.hpp Line 216 (original), 220 (patched)

Re: Review Request 57615: Added support for auth tokens to the V1 executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/#review169149 --- src/executor/executor.cpp Lines 227 (patched)

Re: Review Request 57667: Added executor authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57667/#review169148 --- docs/authentication.md Lines 103 (patched)

Re: Review Request 57648: Improved failure message in `MesosContainerizer::remove()`.

> On March 16, 2017, 10:23 a.m., Alexander Rukletsov wrote: > > Since you're touching this area, could you please check failures and log > > messages across all existing containerizers and make them consistent? I'll do so once this chain lands. - Gastón

Re: Review Request 57666: Added the '--authenticate_http_executors' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/#review169143 --- src/slave/flags.cpp Line 881 (original), 881 (patched)

Review Request 57690: Replaced Boost Type Traits with STL in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57690/ --- Review request for mesos and Michael Park. Bugs: MESOS-7256

Review Request 57691: Enabled AsyncExecutorProcess::execute() via a template parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57691/ --- Review request for mesos and Michael Park. Bugs: MESOS-7256

Review Request 57689: Replaced Boost Type Traits with STL in Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57689/ --- Review request for mesos and Michael Park. Bugs: MESOS-7256

Re: Review Request 57670: Enabled authentication on the V1 executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57670/#review169140 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 11:37

Re: Review Request 57666: Added the '--authenticate_http_executors' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/#review169139 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 11:40

Re: Review Request 57665: Renamed a constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57665/#review169138 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 10:06

Re: Review Request 57664: Added the '--executor_secret_key' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57664/#review169137 --- Fix it, then Ship it! src/slave/flags.cpp Lines 348 (patched)

Re: Review Request 57663: Updated documentation for multiple HTTP authenticators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57663/#review169136 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 9:55

Re: Review Request 57647: Made CMD health checks not reuse the check `ContainerID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57647/#review169135 --- src/checks/health_checker.hpp Lines 197 (patched)

Re: Review Request 57646: Made COMMAND health checks resilient to agent failovers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57646/#review169133 --- src/checks/health_checker.cpp Line 497 (original), 500 (patched)

Re: Review Request 57645: Added support for pausing health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57645/#review169130 --- src/checks/health_checker.cpp Lines 278-281 (patched)

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review169120 --- Fix it, then Ship it! src/checks/health_checker.cpp Lines

Re: Review Request 56214: Hashed unacknowledged updates by UUID string in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56214/ --- (Updated March 16, 2017, 11:18 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review169123 --- Could you rebase this onto a current `HEAD`? - Benjamin Bannier

Re: Review Request 57190: Updated agent for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/#review169122 --- @bmahler @neilc, what else needs to be done here to get this

Re: Review Request 56449: Moved health checker closer to container in default executor.

> On Feb. 15, 2017, 10 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Lines 869 (patched) > > > > > > What's the guarantee that this task is still present in `containers`? > > AFAICT this is a

Re: Review Request 57648: Improved failure message in `MesosContainerizer::remove()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57648/#review169117 --- Since you're touching this area, could you please check failures

Re: Review Request 57664: Added the '--executor_secret_key' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57664/#review169108 --- Ship it! Ship It! - Jan Schlicht On March 15, 2017, 11:02

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 16, 2017, 2:54 p.m., Jay Guo wrote: > > What should be the correct behavior for following case: > > - parent role `/a` is quota'd with `cpus:2;mem:1024` > > - child role `/a/b` is quota'd with `cpus:1;mem:512` > > - `Framework1` subscribes to role `/a` > > - `Framework2` subscribes to

  1   2   >