Re: Review Request 59145: Used a helper to create ExecutorInfo in some nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59145/#review174608 --- Patch looks great! Reviews applied: [58847, 58262, 58718, 58817,

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174603 --- Ship it! Ship It! - Li Li On May 10, 2017, 8:40 p.m.,

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174601 --- Ship it! Ship It! - Li Li On May 10, 2017, 8:59 p.m.,

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174602 --- Ship it! Ship It! - Li Li On May 10, 2017, 8:59 p.m.,

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174598 --- Patch looks great! Reviews applied: [59155, 59156, 59157, 59116]

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 11, 2017, 12:38 a.m., Benjamin Mahler wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > I suspect, if my understanding is correct, you could do the

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 11, 2017, 12:38 a.m., Benjamin Mahler wrote: > > Ok, I understand now what's going on in this change. I gave some > > suggestions for comments / naming to clarify this. > > > > It feels like a hack however, since I would expect the breadcrumb '/' > > characters to be getting copied.

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/#review173475 --- docs/mesos-containerizer.md Lines 98-102 (patched)

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review174593 --- Fix it, then Ship it!

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review174594 --- Patch looks great! Reviews applied: [58095, 58096, 58097, 58099]

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174584 --- src/uri/fetchers/docker.cpp Line 492 (original), 502 (patched)

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174590 --- Fix it, then Ship it! Ok, I understand now what's going on in

Re: Review Request 59074: Updated all tests that use Containerizer::launch(...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59074/ --- (Updated May 10, 2017, 5:27 p.m.) Review request for mesos and Jie Yu.

Review Request 59164: Updated fetcher tests to reflect changed interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59164/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304

Re: Review Request 59073: Updated Docker containerizer tests to use the old naming scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59073/ --- (Updated May 10, 2017, 5:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 58910: Addressed a TODO about checkpointing in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/ --- (Updated May 10, 2017, 5:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 58898: Send task kill for non-Partition Aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/#review174194 --- My apologies for the delay in reviewing this. High-level

Review Request 59162: Added a clearefying comment to the appc spec.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59162/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 59141: Added Secret::Value to the URI fetcher interface.

> On May 10, 2017, 7:36 p.m., Chun-Hung Hsiao wrote: > > include/mesos/uri/fetcher.hpp > > Lines 78 (patched) > > > > > > I'm thinking about what is a proper interface extension for this > > fetcher plugin. Instead

Re: Review Request 59015: Implemented passing docker config depended methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174580 ---

Re: Review Request 59012: Implemented passing the secret resolver to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/#review174578 --- Ship it! Ship It! - Vinod Kone On May 10, 2017, 12:47 p.m.,

Re: Review Request 59141: Added Secret::Value to the URI fetcher interface.

> On May 10, 2017, 12:36 p.m., Chun-Hung Hsiao wrote: > > include/mesos/uri/fetcher.hpp > > Lines 78 (patched) > > > > > > I'm thinking about what is a proper interface extension for this > > fetcher plugin. Instead

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

> On May 10, 2017, 11:12 a.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 328 (patched) > > > > > > Why are we using `secretValue` instead of `config` as in other places? > > Also, it seems to

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review174575 --- Ship it! Ship It! - Vinod Kone On May 10, 2017, 1:54 p.m.,

Re: Review Request 59145: Used a helper to create ExecutorInfo in some nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59145/#review174574 --- Ship it! Ship It! - Vinod Kone On May 10, 2017, 2:28 p.m.,

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/#review174573 --- Fix it, then Ship it! include/mesos/slave/containerizer.proto

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/#review174572 --- Ship it! Ship It! - Vinod Kone On May 10, 2017, 1:55 p.m.,

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/#review174567 --- Patch looks great! Reviews applied: [59146] Passed command:

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

> On May 10, 2017, 9:21 p.m., Mesos Reviewbot Windows wrote: > > Patch looks great! > > > > Reviews applied: [59155, 59156, 59157, 59116] > > > > Passed command: support\windows-build.bat Hey look at that! Windows Reviewbot works :D - Andrew

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

> On May 10, 2017, 9:19 p.m., Jeff Coffler wrote: > > support/windows-build.bat > > Line 52 (original), 52 (patched) > > > > > > Is this correct? Did we deprecate older toolsets? I thought that, at > > this point,

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174562 --- Patch looks great! Reviews applied: [59155, 59156, 59157, 59116]

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174560 --- support/windows-build.bat Line 52 (original), 52 (patched)

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

> On May 10, 2017, 9:07 p.m., Jeff Coffler wrote: > > cmake/CompilationConfigure.cmake > > Lines 240 (patched) > > > > > > I'm not thrilled that we need to do a "hand patch" to debug using VS > > Code. I think the

Re: Review Request 59157: Windows: Fixed toolset handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59157/#review174558 --- Ship it! Ship It! - Jeff Coffler On May 10, 2017, 8:37

Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59156/#review174556 --- Ship it! Ship It! - Jeff Coffler On May 10, 2017, 8:34

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174555 --- Ship it! Ship It! - Jeff Coffler On May 10, 2017, 8:59

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174554 --- cmake/CompilationConfigure.cmake Lines 240 (patched)

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/ --- (Updated May 10, 2017, 8:59 p.m.) Review request for mesos, Jeff Coffler, John

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

> On May 10, 2017, 8:37 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 239 (patched) > > > > > > What about `STATIC`? All libraries are built with static linkage on > > Windows (at the

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

> On May 10, 2017, 8:37 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 239 (patched) > > > > > > What about `STATIC`? All libraries are built with static linkage on > > Windows (at the

Review Request 59116: Windows: Updated `support/windows-build.bat`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Review Request 59157: Windows: Fixed toolset handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59157/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174547 --- cmake/CompilationConfigure.cmake Lines 239 (patched)

Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59156/ --- (Updated May 10, 2017, 8:34 p.m.) Review request for mesos, Jeff Coffler, John

Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59156/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Re: Review Request 59073: Updated Docker containerizer tests to use the old naming scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59073/ --- (Updated May 10, 2017, 1:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 10, 2017, 1:32 p.m.) Review request for mesos and Jie Yu.

Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Re: Review Request 56681: Use glog to log EXIT() messages.

> On March 20, 2017, 8:32 p.m., Benjamin Mahler wrote: > > Have you seen the feedback > > [here](https://issues.apache.org/jira/browse/MESOS-3465?focusedCommentId=14944383=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14944383)? > > It would be nice to make it clear

Re: Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 10, 2017, 1:24 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review174543 --- Ship it! Ship It! - Alexander Rojas On May 10, 2017, 3:52

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/#review174541 --- Ship it! Ship It! - Alexander Rojas On May 10, 2017, 6:33

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/#review174542 --- Ship it! Ship It! - Alexander Rojas On May 10, 2017, 3:47

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review174540 --- Ship it! Ship It! - Alexander Rojas On May 10, 2017, 6:32

Re: Review Request 59154: Added workaround to unbreak the build with glibc <= 2.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59154/#review174538 --- Ship it! Ship It! - Michael Park On May 10, 2017, 11:59

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

> On May 10, 2017, 6:12 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 328 (patched) > > > > > > Why are we using `secretValue` instead of `config` as in other places? > > Also, it seems to

Re: Review Request 59015: Implemented passing docker config depended methods.

> On May 9, 2017, 12:19 a.m., Jie Yu wrote: > > As we discussed offline, let's not mess the URI struct. Instead, passing > > the secret to the fetcher using an function parameter in the `fetch` > > method. This will be useful in the future also because fetcher other URIs > > might need secret

Re: Review Request 59141: Added Secret::Value to the URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59141/#review174535 --- include/mesos/uri/fetcher.hpp Lines 78 (patched)

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

> On May 10, 2017, 6:53 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > > Lines 65 (patched) > > > > > > Do we need a default value here? It seems that all subclasses

Re: Review Request 59154: Added workaround to unbreak the build with glibc <= 2.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59154/#review174530 --- Ship it! Ship It! - Jiang Yan Xu On May 10, 2017, 11:59

Review Request 59154: Added workaround to unbreak the build with glibc <= 2.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59154/ --- Review request for mesos, James Peach, Michael Park, and Jiang Yan Xu. Bugs:

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174527 --- src/slave/containerizer/mesos/provisioner/docker/puller.hpp

Re: Review Request 59012: Implemented passing the secret resolver to registry puller.

> On May 9, 2017, 12:17 a.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > > Lines 48 (patched) > > > > > > no need for a default? > > Gilbert Song wrote: > it does not

Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58907/ --- (Updated May 10, 2017, 11:33 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

> On May 9, 2017, 11:25 p.m., Vinod Kone wrote: > > include/mesos/docker/spec.hpp > > Lines 83 (patched) > > > > > > no unit test for this? > > Gilbert Song wrote: > This helper was tested in unit test when the

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174511 --- Please rebase to the latest master and resolve the conflicts.

Review Request 59150: Document LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59150/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7401

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

> On May 2, 2017, 12:34 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 2878-2879 (patched) > > > > > > We could refer to the flag help for examples? I updated the text a bit. > On

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 10, 2017, 6:06 p.m.) Review request for mesos and Benjamin

Re: Review Request 58928: Update process tests to use a non-zero UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58928/ --- (Updated May 10, 2017, 6:05 p.m.) Review request for mesos and Benjamin

Re: Review Request 58977: Add local and peer address accessors to http::Connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58977/ --- (Updated May 10, 2017, 6:05 p.m.) Review request for mesos and Benjamin

Re: Review Request 59014: Implemented resolving an image secret in registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59014/#review174513 --- Ship it! Ship It! - Chun-Hung Hsiao On May 5, 2017, 8:30

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174507 --- Ship it! Ship It! - Chun-Hung Hsiao On May 10, 2017, 12:47

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated May 11, 2017, 12:33 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated May 11, 2017, 12:32 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174490 --- Bad patch! Reviews applied: [59018, 59017, 59016, 59141, 59015,

Re: Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review174485 --- include/mesos/appc/spec.proto Lines 51 (patched)

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/ --- (Updated May 10, 2017, 5:09 p.m.) Review request for mesos, Alexander

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

> On May 10, 2017, 5:05 p.m., Alexander Rukletsov wrote: > > What about V1 protos? Dang! Sorry, will add that ASAP, always forget about them. - Jan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/#review174481 --- What about V1 protos? - Alexander Rukletsov On May 10, 2017, 3

Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7415

Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.

Review Request 59145: Used a helper to create ExecutorInfo in some nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59145/ --- Review request for mesos and Gastón Kleiman. Repository: mesos Description

Re: Review Request 59136: Added functions to add/remove resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59136/ --- (Updated May 10, 2017, 4:12 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59135: Implemented resource provider bookkeeping primitives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59135/ --- (Updated May 10, 2017, 4:11 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/ --- (Updated May 10, 2017, 1:56 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/ --- (Updated May 10, 2017, 1:55 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

> On May 9, 2017, 6:08 p.m., Gastón Kleiman wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Line 579 (original), 595-598 (patched) > > > > > > Why do you prefer not to use the helper

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/ --- (Updated May 10, 2017, 1:54 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- (Updated May 10, 2017, 9:52 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- (Updated May 10, 2017, 9:47 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated May 10, 2017, 9:46 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated May 10, 2017, 9:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 59140: Fixed task_environment serializing in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59140/#review174469 --- Fix it, then Ship it!

Re: Review Request 59016: Fixed the comment style issue in docker/spec.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59016/ --- (Updated May 10, 2017, 5:49 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- (Updated May 10, 2017, 5:48 a.m.) Review request for mesos, Adam B, Chun-Hung

Review Request 59141: Added Secret::Value to the URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59141/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59017/ --- (Updated May 10, 2017, 5:47 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59015: Implemented passing docker config depended methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/ --- (Updated May 10, 2017, 5:47 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/ --- (Updated May 10, 2017, 5:47 a.m.) Review request for mesos, Adam B, Chun-Hung

  1   2   >