Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/ --- (Updated Nov. 22, 2017, 5:27 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63385: Added utility functions for CSI Plugin info and volume attributes.

> On Nov. 16, 2017, 12:33 a.m., Joseph Wu wrote: > > src/csi/utils.cpp > > Lines 41-46 (patched) > > > > > > This comparison _looks_ wrong :) > > > > You should note that the object is empty, so they must be

Re: Review Request 63385: Added utility functions for CSI Plugin info and volume attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/ --- (Updated Nov. 22, 2017, 5:21 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Nov. 22, 2017, 5:19 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62762: Added `LocalResourceProvider::principal()` for authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/ --- (Updated Nov. 22, 2017, 3:10 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 62762: Added `LocalResourceProvider::principal()` for authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/ --- (Updated Nov. 22, 2017, 2:46 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 64006: Moved registry operations into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/ --- (Updated Nov. 22, 2017, 2:04 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 63652: Added d_type check in containerizer backend validation.

> On Nov. 14, 2017, 9:32 a.m., James Peach wrote: > > This is looking pretty good. > > > > You should be able to write a test for this using the > > [ROOT_XFS_TestBase](https://github.com/apache/mesos/blob/master/src/tests/containerizer/xfs_quota_tests.cpp) > > fixture. Probably a reasonable

Review Request 64018: Added tests for the d_type support validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64018/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Re: Review Request 62762: Added `LocalResourceProvider::principal()` for authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/#review191690 --- src/resource_provider/storage/provider.cpp Lines 65-66 (patched)

Re: Review Request 62762: Added `LocalResourceProvider::principal()` for authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/#review191689 --- Fix it, then Ship it! src/resource_provider/local.cpp Lines

Re: Review Request 63969: Storage local resource provider is built when gRPC is enabled on Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63969/#review191685 --- Ship it! Ship It! - Jie Yu On Nov. 21, 2017, 12:06 a.m.,

Re: Review Request 64010: Added new overload for reviveOffers to allocator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review191682 --- Change the commit message to remove "overload"

Review Request 64014: Added reservations in `ResourceProviderInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64014/ --- Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph

Review Request 64010: Added new overload for reviveOffers to allocator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191677 --- src/master/registry_operations.hpp Lines 67 (patched)

Re: Review Request 62635: Added an optional `additional_chars` parameter to `http::encode`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62635/#review191680 --- Ship it! Need a unit test for this! I'll write one for you! -

Re: Review Request 63376: Started `LocalResourceProviderDaemon` after obtaining the slave ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63376/#review191678 --- Fix it, then Ship it! src/resource_provider/daemon.cpp Lines

Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 64008: Activate AGENT_CONFIGURATION_CHANGE capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/#review191676 --- - Move this commit to a point where the capability is actually

Review Request 64008: Activate AGENT_CONFIGURATION_CHANGE capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 64007: Added master capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64007/#review191673 --- - Expand commit message. - Add test that verifies master has

Re: Review Request 64006: Moved registry operations into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/#review191675 --- - Confirm if internal headers need to be added to

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191668 --- src/slave/slave.cpp Lines 6753 (patched)

Re: Review Request 64006: Moved registry operations into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/#review191672 --- src/master/registry_operations.hpp Lines 21 (patched)

Review Request 64007: Added master capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64007/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 64006: Moved registry operations into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63823/ --- (Updated Nov. 21, 2017, 10:28 p.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review191664 --- src/master/master.hpp Lines 2919 (patched)

Re: Review Request 63986: Refactored 'MockResourceProvider' to include default functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63986/#review191661 --- Ship it! This LGTM. although the template part is quite ugly

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 21, 2017, 11:11 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/ --- (Updated Nov. 21, 2017, 11:12 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 52006: Supported docker/volume isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52006/ --- (Updated Nov. 21, 2017, 2:08 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 63652: Added d_type check in containerizer backend validation.

> On Nov. 14, 2017, 5:32 p.m., James Peach wrote: > > This is looking pretty good. > > > > You should be able to write a test for this using the > > [ROOT_XFS_TestBase](https://github.com/apache/mesos/blob/master/src/tests/containerizer/xfs_quota_tests.cpp) > > fixture. Probably a reasonable

Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7099

Re: Review Request 63732: Reconciled offer operations between agent and master.

> On Nov. 18, 2017, 2 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7119 (patched) > > > > > > If the LRP is not yet re-registered with the agent, we shouldn't remove > > the offer operation. We should

Re: Review Request 63798: Added resource provider support for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/#review191639 --- src/slave/slave.cpp Lines 3532 (patched)

Re: Review Request 63842: Allowed removing non-terminal offer operations.

> On Nov. 18, 2017, 1:47 a.m., Jie Yu wrote: > > src/master/master.hpp > > Lines 2913-2915 (original) > > > > > > Do you need to do the same as that in `Slave::removeOfferOperation`? Of course. - Benjamin

Re: Review Request 63732: Reconciled offer operations between agent and master.

> On Nov. 16, 2017, 2:05 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7107-7121 (patched) > > > > > > Do you need to also update allocator for added or removed new > > operations? > > > > For

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 18, 2017, 1:54 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6800 (patched) > > > > > > I feel we should also call `updateOfferOpreation` here with a terminal > > state (OFFER_OPERATION_DROPPED).

Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64000/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository:

Re: Review Request 63918: Updated ResourceProviderMessage stringification with recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63918/ --- (Updated Nov. 21, 2017, 10:10 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 64001: Made sure all true allocator agent updates return correct status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64001/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/ --- (Updated Nov. 21, 2017, 10:09 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 63999: Added env var to set default flags for parallel test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63999/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 21, 2017, 10:09 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63984: Fixed build dependencies in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/#review191648 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 21, 2017,

Re: Review Request 63844: Removed acknowledged offer operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/ --- (Updated Nov. 21, 2017, 10:09 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 21, 2017, 10:08 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63730: Passed operations from resource provider to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/ --- (Updated Nov. 21, 2017, 10:08 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 21, 2017, 10:08 p.m.) Review request for mesos, Greg Mann, Jie

Review Request 63997: Added new allocator method to explicitly bookkeep existing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63997/ --- Review request for mesos. Repository: mesos Description --- In certain

Re: Review Request 63917: Renamed resource provider message UpdateTotalResources to UpdateState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63917/ --- (Updated Nov. 21, 2017, 10:08 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review191632 --- FAIL: Failed to apply the dependent review: 63767. Failed

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Nov. 21, 2017, 7:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63988: Fixed indentation in a test header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63988/#review191630 --- FAIL: Failed to apply the dependent review: 63767. Failed

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review191629 --- PASS: Mesos patch 63953 was successfully built and tested.

Re: Review Request 63984: Fixed build dependencies in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/#review191628 --- Ship it! Ship It! - Benjamin Bannier On Nov. 21, 2017, 3:15

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review191610 --- src/master/master.cpp Line 10925 (original), 10922 (patched)

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/#review191613 --- src/master/allocator/mesos/hierarchical.cpp Lines 430-437

Re: Review Request 63959: Optimized resources logging and conversion in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63959/#review191614 --- Thanks! Could you split the patch between the logging performance

Re: Review Request 63960: Preallocated buffer for resources conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63960/#review191612 --- Ship it! Ship It! - Benjamin Mahler On Nov. 20, 2017, 5:20

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/#review191605 --- src/internal/devolve.cpp Lines 194-196 (original), 194-196

Re: Review Request 62502: Added an event to publish resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review191607 --- include/mesos/resource_provider/resource_provider.proto Lines

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ --- (Updated Nov. 21, 2017, 5:53 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63830/#review191602 --- src/tests/scheduler_tests.cpp Lines 1515-1516 (original),

Re: Review Request 63914: Changed agent reregistration to work with message directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/ --- (Updated Nov. 21, 2017, 5:53 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63913: Replaced std::shared_ptr with std::unique_ptr in Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63913/ --- (Updated Nov. 21, 2017, 5:52 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63638: Added callable once support in Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63638/ --- (Updated Nov. 21, 2017, 5:51 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63830/ --- (Updated Nov. 21, 2017, 5:46 p.m.) Review request for mesos and Alexander

Re: Review Request 63943: Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63943/#review191599 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 20, 2017,

Re: Review Request 63577: Fixed a task status update race in default executor tests.

> On Nov. 16, 2017, 11:45 a.m., Alexander Rukletsov wrote: > > src/tests/mesos.hpp > > Lines 2935-2941 (original), 2935-2941 (patched) > > > > > > This guy does the same as the one below, but for the old driver.

Re: Review Request 63577: Fixed a task status update race in default executor tests.

> On Nov. 16, 2017, 11:45 a.m., Alexander Rukletsov wrote: > > src/tests/default_executor_tests.cpp > > Lines 926-928 (original), 1027-1029 (patched) > > > > > > What happens if a scheduler gets `TASK_FAILED`

Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Review Request 63991: Added helpers to create and forward offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Review Request 63990: Added the RESOURCE_PROVIDER capability to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63990/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Review Request 63989: Added the OFFER_OPERATION_DROPPED state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63989/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan

Re: Review Request 63984: Fixed build dependencies in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/#review191589 --- PASS: Mesos patch 63984 was successfully built and tested.

Review Request 63988: Fixed indentation in a test header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63988/ --- Review request for mesos and Gaston Kleiman. Repository: mesos Description

Re: Review Request 63798: Added resource provider support for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/ --- (Updated Nov. 21, 2017, 4:30 p.m.) Review request for mesos, Benjamin Bannier

Review Request 63986: Refactored 'MockResourceProvider' to include default functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63986/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/ --- (Updated Nov. 21, 2017, 4:28 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review191577 --- FAIL: Mesos tests failed to build. Reviews applied: `['63953']`

Re: Review Request 63984: Fixed build dependencies in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/ --- (Updated Nov. 21, 2017, 2:15 p.m.) Review request for mesos, Alexander

Re: Review Request 63984: Fixed build dependencies in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/#review191574 --- 3rdparty/libprocess/Makefile.am Line 399 (original), 399-401

Re: Review Request 63887: Fixed `wait()` and `destroy()` in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63887/#review191572 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp

Re: Review Request 63888: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63888/#review191573 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 16, 2017,

Review Request 63984: Fixed build dependencies in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/ --- (Updated Nov. 21, 2017, 1:12 p.m.) Review request for mesos and Alexander

Re: Review Request 62502: Added an event to publish resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/ --- (Updated Nov. 21, 2017, 12:55 p.m.) Review request for mesos, Benjamin