Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review204169 --- Patch looks great! Reviews applied: [67185] Passed command:

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/#review204167 --- FAIL: Failed to apply the dependent review: 67335. Failed

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/ --- (Updated June 1, 2018, 11:28 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67343/ --- (Updated June 1, 2018, 11:21 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67342/ --- (Updated June 1, 2018, 11:20 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`.

> On May 31, 2018, 8 a.m., Gilbert Song wrote: > > Could we also update the mesos-containerizer.md and have a new file to > > introduce the semantic, since people may rely on that document as reference. Created https://issues.apache.org/jira/browse/MESOS-8973 for that. - Qian

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

> On May 31, 2018, 8:42 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 108 (patched) > > > > > > enabled cgroup subsystems? I'd like to be consistent with the

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review204165 --- Patch looks great! Reviews applied: [67398, 67137] Passed

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/#review204155 --- 3rdparty/stout/include/stout/archiver.hpp Lines 20 (patched)

Re: Review Request 67395: Fixed socket creation bug in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204162 --- Patch looks great! Reviews applied: [67395] Passed command:

Re: Review Request 67257: Fixed filters in test `ROOT_ReconcileDroppedOperation` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67257/ --- (Updated June 1, 2018, 12:48 a.m.) Review request for mesos, Gaston Kleiman

Re: Review Request 67256: Added a unit test for CSI plugin RPC metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67256/ --- (Updated June 1, 2018, 12:47 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/ --- (Updated June 1, 2018, 12:45 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67371: Introduced a random sorter as an alternative to the DRF sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67371/#review204159 --- Fix it, then Ship it!

Re: Review Request 67303: Added documentation for resource provider and CSI plugin metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67303/ --- (Updated May 31, 2018, 11:08 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 31, 2018, 11:06 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67375: Added the `RPC` enum and `RPCTraits` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67375/ --- (Updated May 31, 2018, 11:05 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated May 31, 2018, 10:50 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67389/#review204161 --- 3rdparty/libprocess/src/libwinio_impl.cpp Lines 38 (patched)

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204160 --- Patch looks great! Reviews applied: [67118, 67064, 67065, 67066]

Re: Review Request 67370: Added a test for weighted shuffling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67370/#review204158 --- Fix it, then Ship it! src/tests/sorter_tests.cpp Lines 70

Re: Review Request 67305: Moved the "Resource Provider" section to `resource-provider.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67305/#review204157 --- Ship it! Ship It! - Jie Yu On May 25, 2018, 1:24 a.m.,

Re: Review Request 67303: Added documentation for resource provider and CSI plugin metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67303/#review204156 --- Fix it, then Ship it! Thanks! docs/monitoring.md Lines 1771

Re: Review Request 67369: Introduced a weighted shuffle algorithm implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67369/#review204153 --- Ship it! Ship It! - Meng Zhu On May 29, 2018, 5:55 p.m.,

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/#review204154 --- PASS: Mesos patch 67264 was successfully built and tested.

Re: Review Request 67328: Used italic fonts to denote placeholdes in metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67328/#review204150 --- Ship it! Ship It! - Jie Yu On May 25, 2018, 6:28 p.m.,

Re: Review Request 67258: Fixed flakiness for some `AgentResourceProviderConfigApiTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67258/#review204149 --- Ship it! Ship It! - Jie Yu On May 22, 2018, 11:39 p.m.,

Re: Review Request 67257: Fixed filters in test `ROOT_ReconcileDroppedOperation` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67257/#review204148 --- Ship it! Ship It! - Jie Yu On May 22, 2018, 11:38 p.m.,

Re: Review Request 67256: Added a unit test for CSI plugin RPC metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67256/#review204147 --- Ship it! Ship It! - Jie Yu On May 25, 2018, 12:24 a.m.,

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

> On May 31, 2018, 6:24 p.m., Ilya Pronin wrote: > > src/exec/exec.cpp > > Lines 643-646 (original), 652-655 (patched) > > > > > > We don't change executor logging flags in our tests, do we? It might be > > worth

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/ --- (Updated May 31, 2018, 1:38 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 67344: Made disk allocatable on their own.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67344/#review204142 --- Gaston is also working on making the allocation "minimums"

Re: Review Request 67393: Windows: Ported io_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67393/#review204140 --- Patch looks great! Reviews applied: [67384, 67385, 67386, 67387,

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/#review204137 --- Fix it, then Ship it! src/csi/client.hpp Lines 68 (patched)

Re: Review Request 67403: Handled race condition when removing maintenance windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67403/#review204138 --- PASS: Mesos patch 67403 was successfully built and tested.

Re: Review Request 67369: Introduced a weighted shuffle algorithm implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67369/#review204090 --- src/master/allocator/sorter/random/utils.hpp Lines 49 (patched)

Re: Review Request 67375: Added the `RPC` enum and `RPCTraits` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67375/#review204135 --- Ship it! src/csi/rpc.cpp Lines 31 (patched)

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67354/#review204131 --- Looks good to me! Just one comment about logging flags.

Re: Review Request 67401: Removed undefined behaviour in libprocess due to order-of-evaluation bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67401/#review204133 --- PASS: Mesos patch 67401 was successfully built and tested. All

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review204129 --- PASS: Mesos patch 66649 was successfully built and tested.

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review204128 --- PASS: Mesos patch 67185 was successfully built and tested.

Re: Review Request 67403: Handled race condition when removing maintenance windows.

> On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > Can you add a unit test for this? > > Benno Evers wrote: > It's tricky because we need very precise control over the scheduling, and > I'm not sure our testing infrastructure provides it. But I'll look into it. I see. The bug is in the

Re: Review Request 67401: Removed undefined behaviour in libprocess due to order-of-evaluation bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67401/#review204125 --- Ship it! Thanks for fixing this for me! I remember hearing

Re: Review Request 67403: Handled race condition when removing maintenance windows.

> On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > Can you add a unit test for this? It's tricky because we need very precise control over the scheduling, and I'm not sure our testing infrastructure provides it. But I'll look into it. - Benno

Re: Review Request 67403: Handled race condition when removing maintenance windows.

> On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Line 9459 (original), 9459 (patched) > > > > > > not yours, but can you log framework id here too? s/framework id/*framework/ > On

Re: Review Request 67403: Handled race condition when removing maintenance windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67403/#review204121 --- Can you add a unit test for this? src/master/master.cpp Line

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67354/#review204120 --- include/mesos/executor.hpp Lines 219-220 (patched)

Review Request 67403: Handled race condition when removing maintenance windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67403/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7966

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 30, 2018, 1:37 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Line 253 (original), 253-261 (patched) > > > > > > I suggest to exatract it into a funciton, say

Re: Review Request 67401: Removed undefined behaviour in libprocess due to order-of-evaluation bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67401/ --- (Updated May 31, 2018, 4:11 p.m.) Review request for mesos, Alexander

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review204117 --- PASS: Mesos patch 67137 was successfully built and tested.

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/ --- (Updated May 31, 2018, 4:05 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 67009: Added tests of resource provider registrar recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67009/#review204116 --- Ship it! Ship It! - Chun-Hung Hsiao On May 29, 2018, 8:54

Re: Review Request 67401: Fixed segfault in libprocess due to order-of-evaluation bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67401/#review204115 --- Ship it! Ship It! - Benjamin Bannier On May 31, 2018, 5:47

Re: Review Request 67401: Fixed segfault in libprocess due to order-of-evaluation bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67401/#review204114 --- Ship it! Ship It! - Alexander Rukletsov On May 31, 2018,

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- (Updated May 31, 2018, 3:55 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 67398: Changed nested container tests to not use pipes for synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/#review204113 --- src/tests/containerizer/nested_mesos_containerizer_tests.cpp

Review Request 67401: Fixed segfault in libprocess due to order-of-evaluation bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67401/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Bugs:

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- (Updated May 31, 2018, 3:14 p.m.) Review request for mesos, Armand Grillet,

Review Request 67398: Changed nested container tests to not use pipes for synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-8917

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204109 --- PASS: Mesos patch 67357 was successfully built and tested.

Re: Review Request 67009: Added tests of resource provider registrar recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67009/#review204108 --- PASS: Mesos patch 67009 was successfully built and tested.

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- (Updated May 31, 2018, 11:02 a.m.) Review request for Alexander Rukletsov.