Re: Review Request 36663: Added ip_address field to MasterInfo

. Thanks, Marco Massenzio

Re: Review Request 36663: Added ip_address field to MasterInfo

](https://github.com/massenz/zk-mesos) that the information serialized to ZK is readable and as expected). Thanks, Marco Massenzio

Re: Review Request 36742: Fixed the sanity check on OSX for persistent volumes.

indicate why this failed on OSX (and what the fix was), in case someone introduces something similar in future, we'll have a reference to guide us. Thanks for super-quick fix! - Marco Massenzio On July 23, 2015, 7:37 p.m., Jie Yu

Re: Review Request 36425: Enabling IP Discovery script

: a valid IP; a bogus one; an error exit code. Thanks, Marco Massenzio

Re: Review Request 36425: Enabling IP Discovery script

code. Thanks, Marco Massenzio

Re: Review Request 36424: Created a command executor helper method.

nclude/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 Diff: https://reviews.apache.org/r/36424/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36424: Created a command executor helper method.

tion logic. Diffs (updated) - 3rdparty/libprocess/include/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 Diff: https://reviews.apache.org/r/36424/diff/ Testing --- make che

Re: Review Request 36663: Added ip_address field to MasterInfo

s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92514 --- On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: > > ---

Review Request 36663: Added ip_address field to MasterInfo

2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 Diff: https://reviews.apache.org/r/36663/diff/ Testing --- make check (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information serialized to ZK is readable and as expected). Thanks, Marco Massenzio

Re: Review Request 36425: Enabling IP Discovery script

ocs/configuration.md babbd2f67b32d4f317cfdf8bb87f8725917b0aca src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 Diff: https://reviews.apache.org/r/36425/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36425: Enabling IP Discovery script

0039#file1010039line184> > > > > What is process::executeCommand? Did you mean process::subprocess here? it's the method I'm introducing in the patch immediately before this: https://reviews.apache.org/r/36424/ - Marco

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/#review92161 --- Ship it! Ship It! - Marco Massenzio On July 15, 2015, 4:56 a.m

Re: Review Request 36424: Created a command executor helper method.

nclude/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 Diff: https://reviews.apache.org/r/36424/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36424: Created a command executor helper method.

-- 3rdparty/libprocess/include/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 Diff: https://reviews.apache.org/r/36424/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

> On July 9, 2015, 10:24 p.m., Marco Massenzio wrote: > > src/common/protobuf_utils.hpp, lines 78-79 > > <https://reviews.apache.org/r/36318/diff/2/?file=1003766#file1003766line78> > > > > please use javadoc format > > also unnecessary semicolon

Re: Review Request 36424: Created a command executor helper method.

;https://reviews.apache.org/r/36424/diff/1/?file=1008891#file1008891line307> > > > > How about returning a tuple/struct of stdout, stderr and return code > > and let the caller decide what they want? > > Marco Massenzio wrote: > sure, that would be a possibility too

Re: Review Request 36424: Created a command executor helper method.

------ This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/#review92038 --- On July 17, 2015, 5:52 a.m., Marco Massenzio wrote: > >

Re: Review Request 36450: Introduced Address and URL protobufs.

> On July 15, 2015, 7:08 p.m., Vinod Kone wrote: > > src/common/type_utils.cpp, line 131 > > > > > > Is the order of query parameters important? Aren't these URLs > > equivalent? > > > > http://a.b.c/?k1=a&

Re: Review Request 36424: Created a command executor helper method.

subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 Diff: https://reviews.apache.org/r/36424/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36424: Created a command executor helper method.

this first because the structural simplifications needed will be very similar to those from `process::executeCommand`. Uhm - this is assuming a deeper understanding of libprocess than I currently have: let me ponder this a bit and I may reach out for more advice. And, yes, my code was largely based

Review Request 36532: Added warning in the SSL Doc about potentially failing tests in unclean build directory

Description --- Added warning in the SSL Doc about potentially failing tests in unclean build directory Diffs - docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36532/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 36389: Enable remote execution of arbitrary command.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36389/#review91784 --- On July 14, 2015, 11:20 p.m., Marco Massenzio wrote: &g

Re: Review Request 36424: Created a command executor helper method.

and return code > > and let the caller decide what they want? > > Marco Massenzio wrote: > sure, that would be a possibility too, but it seems to me that the > "approved way" in Mesos is to return a `Try` for when something *may* go > wrong. > This is c

Re: Review Request 36389: Enable remote execution of arbitrary command.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36389/#review91678 --- On July 14, 2015, 11:20 p.m., Marco Massenzio wrote: > > ---

Re: Review Request 36389: Enable remote execution of arbitrary command.

Diff: https://reviews.apache.org/r/36389/diff/ Testing --- make check lots of manual testing (using Postman, REST client) Thanks, Marco Massenzio

Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

36389/diff/ Testing --- make check lots of manual testing (using Postman, REST client) Thanks, Marco Massenzio

Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

check lots of manual testing (using Postman, REST client) Thanks, Marco Massenzio

Re: Review Request 36424: Created a command executor helper method.

cess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 Diff: https://reviews.apache.org/r/36424/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

hanks, Marco Massenzio

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

> On July 13, 2015, 8:18 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 108-110 > > > > > > Why not also add an Endpoint message to capture this part? Or a URL/I? > > > > message Endpoint

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

gs in an `Address` class, but I accept I don't really know enough of how libprocess works. include/mesos/mesos.proto (line 793) <https://reviews.apache.org/r/36450/#comment144966> nit: I think you need an extra space between ; and / - Marco Massenzio On July 13, 2015, 5

Re: Review Request 36425: Enabling IP Discovery script

onfiguration.md feee5594c88112f77ce382cb3dd8628653f92d01 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 Diff: https://reviews.apache.org/r/36425/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91518 --- On July 13, 2015, 7:25 p.m., Marco Massenzio wrote: > > -

Re: Review Request 36425: Enabling IP Discovery script

master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 Diff: https://reviews.apache.org/r/36425/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91496 --- On July 13, 2015, 4:35 p.m., Marco Massenzio wrote: > > -

Re: Review Request 36425: Enabling IP Discovery script

Abort trap: 6 ``` Looks pretty clear to me what went on? - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91492

Re: Review Request 36440: Update comments for mesos master cpp file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review91494 --- Ship it! Ship It! - Marco Massenzio On July 13, 2015, 5:42 a.m

Re: Review Request 36425: Enabling IP Discovery script

master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 Diff: https://reviews.apache.org/r/36425/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36402: Adding 'Accept' header in request

t").get()) } ``` Let's please make the most out of our newly-acquired C++11 abilities :) 3rdparty/libprocess/src/tests/http_tests.cpp (line 695) <https://reviews.apache.org/r/36402/#comment144732> same here - Marco Massenzio On July 10, 2015, 8:55 p.m., Isabel J

Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

e.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 Diff: https://reviews.apache.org/r/36389/diff/ Testing --- make check lots of manual testing (using Postman, REST client) Thanks, Marco Massenzio

Review Request 36389: [WIP] Enable remote execution of arbitrary command.

ts of manual testing (using Postman, REST client) Thanks, Marco Massenzio

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

> On July 9, 2015, 10:24 p.m., Marco Massenzio wrote: > > src/master/http.cpp, lines 311-316 > > <https://reviews.apache.org/r/36318/diff/2/?file=1003768#file1003768line311> > > > > unless you know for a fact that none of this will be `None()` you > >

Re: Review Request 36360: Adding common constants for HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91242 --- Ship it! Ship It! - Marco Massenzio On July 9, 2015, 10:34 p.m

Re: Review Request 36360: Adding common constants for HTTP API

quot; > > 3rdparty/libprocess/src/tests/decoder_tests.cpp:"Content-Type: > > text/plain\r\n" > > 3rdparty/libprocess/src/tests/http_tests.cpp: headers["Content-Type"] = > > "text/plain"; > > 3rdparty/libprocess/src/tests/http_tests.

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

lt;https://reviews.apache.org/r/36318/#comment144503> here too src/master/master.hpp (line 353) <https://reviews.apache.org/r/36318/#comment144504> use javadoc instead - Marco Massenzio On July 9, 2015, 6:49 p.m., Anand Mazumdar wrote: > >

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

> On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: > > support/post-reviews.py, line 173 > > <https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173> > > > > note that here you will be printing the whole commit message, which in

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

> On July 8, 2015, 4:35 p.m., Marco Massenzio wrote: > > Thanks for doing this! > > > > It seems to me that this is just a 'prettified' form of the `--help` > > output? perhaps we could automate its generation, removing the need of > > manually doubl

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

lowed). also, one has to *infer* that the singular form is *not* allowed (`1mins` in the default) but it would be nice to spell it out for the unwary - Marco Massenzio On July 8, 2015, 8:18 a.m., Adam B wrote: > > --- >

Re: Review Request 36037: Adding /call endpoint to Master

; I also asked her to: > > > > (a) Punt on the constants and remove master/http_constants.hpp, since these > > constants aren't adding value (CLOSE -> "close") for the added indirection, > > and our existing code doesn't follow this patter

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

> On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: > > support/post-reviews.py, line 173 > > <https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173> > > > > note that here you will be printing the whole commit message, which in

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

- On July 7, 2015, 3:19 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35777/ > --- > > (Updat

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

if pos != -1: ... print ...format(message[pos:]) ``` should make the error message clearer. - Marco Massenzio On July 7, 2015, 3:19 p.m., Michael Park wrote: > > --- > This is an automatically generate

Re: Review Request 36193: Improved Doxygen-Styleguide.

> On July 6, 2015, 6:06 p.m., Joseph Wu wrote: > > Can you comment on the use of the `@copydoc` tag? > > I used it in the associated review (36141), but it isn't mentioned in the > > Doxygen style guide. I am somewhat hesitant about us trying to "whitelist" *everything* that is allowed. I much

Re: Review Request 36037: Adding /call endpoint to Master

On July 2, 2015, 8:16 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36037/ > -

Re: Review Request 36152: Updated CHANGELOG for 0.23.0.

to me) v. `beta` features? I personally would prefer the use of "alpha" / "beta" as more standard in industry parlance than "experimental" (which makes it sound more like a science project :) ) - Marco Massenz

Re: Review Request 36106: cgroups: added cpuacct subsystem

omply with our coding style (spacing, indentation, enclosing "linkable to" classes in back-ticks ` `, etc.) but I'm not familiar enough with it to really comment. And this is in any case more documentation than 90% of our codebase, so... yay! :) - Marco Massenzio On July 2, 2

Re: Review Request 36037: Adding /call endpoint to Master

you will get this added to our Doxygen free of charge :) This looks good, Isabel! - Marco Massenzio On July 1, 2015, 7:30 p.m., Isabel Jimenez wrote: > > --- > This is an au

Re: Review Request 36040: Change Server closing connections for every request

) <https://reviews.apache.org/r/36040/#comment143185> I have the impression your change introduced tabs? (may be an RB artifact, though) can you please add `is` (header *is* not...) - Marco Massenzio On June 30, 2015, 9:06 a.m., Isabel Jimenez

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:54 p.m., Marco Massenzio wrote: > > src/linux/cgroups.cpp, line 2002 > > <https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2002> > > > > and, in any event, the variables should have a meaningful name - should >

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/tests/cgroups_tests.cpp, line 1192 > > > > > > Add using to the top of the tests > > Jojy Varghese wrote: > Since this is an alias (typedef) and scoped fo

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2060 > > > > > > Why add trailing underscore? > > Jojy Varghese wrote: > As a member variable(is accepted according to mesos codin

Re: Review Request 36106: cgroups: added cpuacct subsystem

should have a meaningful name - should these be `userTime` or something? (also, if they are time durations, please pre-pend the unit: `userTimeSec`) - Marco Massenzio On July 1, 2015, 9:38 p.m., Jojy Varghese wrote: > > --- > Thi

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

t? we can sure create a Jira for this too (tech-debt label, perhaps?) - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review90014 ---

Re: Review Request 36036: Add `version` string to MasterInfo

r.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 Diff: https://reviews.apache.org/r/36036/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36036: Add `version` string to MasterInfo

d6309f92a7f9af3ab61a878403e3d9c284ea87e0 > > > > And if you do include it, I don't think it needs to be inside > > hostname's parentheses. removed - Marco --- This is an automatically

Re: Review Request 36036: Add `version` string to MasterInfo

m removing this from the log - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89991 --- On June 30, 2

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

(1)` to extract just the URL. Looks to me like a better User Experience. - Marco Massenzio On July 1, 2015, 3:52 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

was here!!! $ echo $? 1 ``` Diffs - 3rdparty/libprocess/src/process.cpp d99947c1598c43c47c88ef3e8038081855f0d1dc Diff: https://reviews.apache.org/r/36061/diff/ Testing --- make check and manual failing the DNS Thanks, Marco Massenzio

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

ocess.cpp d99947c1598c43c47c88ef3e8038081855f0d1dc Diff: https://reviews.apache.org/r/36061/diff/ Testing --- make check and manual failing the DNS Thanks, Marco Massenzio

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review89943 --- On June 30, 2015, 6:41 p.m., Marco Massenzio wrote: > > -

Re: Review Request 36037: Adding /call endpoint to Master

ect. src/tests/call_tests.cpp (line 98) <https://reviews.apache.org/r/36037/#comment142904> can we possibly check on just getting a "type" of response (and not on the actual message)? that would be a better check, so we won't fail tests just because we fix t

Re: Review Request 36036: Add `version` string to MasterInfo

_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 Diff: https://reviews.apache.org/r/36036/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 36036: Add `version` string to MasterInfo

------ This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89933 --- On June 30, 2015, 6:28 a.m., Marco Massenzio wrote: > >

Review Request 36061: Slave exits gracefully on DNS lookup failure.

Testing --- make check and manual failing the DNS Thanks, Marco Massenzio

Re: Review Request 36036: Add `version` string to MasterInfo

re I had used an EXPECT_*), Vinod noted that, as it was the last check, an ASSERT_* was preferable. No personal preference - I'm happy to go with the flow. - Marco ------- This is an automatically generated e-mail. To reply,

Review Request 36036: Add `version` string to MasterInfo

s.cpp d7a3b46b2e437818631064ae34317e49c9aa3748 Diff: https://reviews.apache.org/r/36036/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 35934: New "Not Acceptable" HTTP response type

n the base class you just have: ``` string status() { return "" + code " " + message; } ``` which is a much better (composable) design. - Marco Massenzio On June 26, 2015, 6:30 p.m., Isabel Jimenez wrote: > > ---

Re: Review Request 35939: New "Conflict" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35939/#review89543 --- Ship it! Ship It! - Marco Massenzio On June 26, 2015, 6:58 p.m

Re: Review Request 35856: Added Revive call support to the master and C++ scheduler library.

tps://reviews.apache.org/r/35856/#comment142061> Same comment as the other review :) Great test, worth maybe factoring some of the common functionality in a helper class? - Marco Massenzio On June 25, 2015, 12:29 a.m., Vinod Kone

Re: Review Request 35861: Correct include list errors for stout

> On June 25, 2015, 8:10 a.m., Marco Massenzio wrote: > > Hey Paul, thanks for doing this! > > > > In case you are interested, I have submitted a couple of Pull Requests to > > the Google folks (without much success) but I've also > > [forked]

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

> > (Updated June 25, 2015, 12:31 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and > Marco Massenzio. > > > Bugs: MESOS-2551 > https://issues.apache.org/jira/browse/MESOS-2551 > > > Repositor

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

704) <https://reviews.apache.org/r/35855/#comment141920> could this be more specific ("exactly" one)? - Marco Massenzio On June 25, 2015, 1:11 a.m., Vinod Kone wrote: > > --- > This is an automatically genera

Re: Review Request 35861: Correct include list errors for stout

/tree/master) branch contains all the latest additions and it works - the only remaining thing for me is to detect multi-line method declaration (so that cpplint does not complain about the { on the newline). Contributions welcome :) - Marco Massenzio On June 25, 2015, 4:29 a.m., Paul Brett

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

sting --- make check Thanks, Marco Massenzio

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

tps://reviews.apache.org/r/35815/#review89297 ------- On June 24, 2015, 6:01 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail.

Review Request 35848: Fixed typo in getting started

--- Fixed typo in getting started Diffs - docs/getting-started.md 9d78ab233f165158ef5f18065d8a56af964f94c4 Diff: https://reviews.apache.org/r/35848/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .

ission denied" issues. - Marco Massenzio On June 22, 2015, 1:56 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

ting --- make check Thanks, Marco Massenzio

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

---- On June 24, 2015, 1:15 a.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35815/ > ---

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

;t make it right :) Fixed (both places) - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815/#review89122 --- On June 24,

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

correctly parsed and the correct MasterInfo information retrieved. Jira: MESOS-2898 Diffs (updated) - src/tests/master_contender_detector_tests.cpp 1b30eeb51520da7a5834768ac88a88a8a84fd976 Diff: https://reviews.apache.org/r/35815/diff/ Testing --- make check Thanks, Marco

Review Request 35815: Testing JSON paylodad in ZooKeeper

MasterInfo information retrieved. Jira: MESOS-2898 Diffs - src/tests/master_contender_detector_tests.cpp 1b30eeb51520da7a5834768ac88a88a8a84fd976 Diff: https://reviews.apache.org/r/35815/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

> On June 23, 2015, 5:39 a.m., Marco Massenzio wrote: > > Can you please add one of the committers as a reviewer? > > Till Toenshoff wrote: > Did we document such requirement somewhere? er... I was being economical with words here: I don't know if Roger is a commit

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35763/#review88925 --- Can you please add one of the committers as a reviewer? - Marco

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

`` markers. docs/network-monitoring.md (line 48) <https://reviews.apache.org/r/35763/#comment141543> please format as a markdown URL: please see [MESOS-1856](https://issues.apache.org/jira/browse/MESOS-1856) to be consistent with the rest of the document. - Marco Massen

Re: Review Request 35565: Refactored os::environment to return a std::map.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35565/#review88681 --- Ship it! Ship It! - Marco Massenzio On June 20, 2015, 7:01 p.m

Re: Review Request 35695: stout: Fixed test names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35695/#review88680 --- Ship it! Ship It! - Marco Massenzio On June 20, 2015, 7:14 p.m

Re: Review Request 35696: libprocess: Fixed test names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35696/#review88678 --- Ship it! Thanks, Michael! - Marco Massenzio On June 20, 2015, 7

Re: Review Request 35571: Adding ability to decode JSON from ZK

ira/browse/MESOS-2898) created. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35571/#review88418 --- On June 18, 2015, 3:31 p.m.,

Re: Review Request 35571: Adding ability to decode JSON from ZK

57cf8fbeff203847b5b5442f6c78ca9c09bcc66d src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0 src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048 Diff: https://reviews.apache.org/r/35571/diff/ Testing --- make check Thanks, Marco Massenzio

<    1   2   3   4   5   >