Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-31 Thread Guangya Liu
> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/docker/docker.cpp, line 388 > > > > > > Add an error here to verify correct set of permissions in the > > permissions field. > > > > Once we have

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-31 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Oct. 31, 2016, 7:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review153838 --- src/docker/docker.hpp (lines 71 - 74)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-23 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Oct. 24, 2016, 4:59 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-21 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-21 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 21, 2016, 6:28 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-20 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 20, 2016, 10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-14 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 14, 2016, 9:56 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
> On 十月 14, 2016, 3:03 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 397-398 > > > > > > ``` > > if (device.isError()) { > > return Error("Failed to parse device from HostConfig.Devices entry"

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review152514 --- src/docker/docker.hpp (line 336)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 13, 2016, 10:15 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: >

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-13 Thread Yubo Li
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: >

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review152287 --- src/docker/docker.hpp (lines 107 - 123)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-12 Thread Guangya Liu
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: >

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-11 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 11, 2016, 8:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-11 Thread Yubo Li
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 125-136 > > > > > > 2 spaces > > Yubo Li wrote: > where? > > Guangya Liu wrote: > I mean it should be the following, keep 2

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-11 Thread Guangya Liu
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 125-136 > > > > > > 2 spaces > > Yubo Li wrote: > where? I mean it should be the following, keep 2 space at the start for the

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-11 Thread Yubo Li
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 103-117 > > > > > > You can call above `parse` directly here. Good suggestion. Fixed. > On 十月 9, 2016, 10:37 a.m., Guangya Liu

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review151937 --- src/docker/docker.hpp (lines 95 - 120)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-09-22 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 九月 22, 2016, 6:20 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-09-20 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 九月 20, 2016, 9:24 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-09-19 Thread Yubo Li
> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/docker/docker.hpp, lines 73-84 > > > > > > In general, we don't typically have constructors for `structs` like > > this. Instead, we just set its fields

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review146736 --- src/docker/docker.hpp (lines 73 - 84)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-22 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 22, 2016, 10:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review146302 --- src/docker/docker.hpp (lines 101 - 102)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-15 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 15, 2016, 7:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 10, 2016, 10:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review145058 --- src/docker/docker.hpp (line 20)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-05 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 5, 2016, 9:58 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review144708 --- Can you please remove the review ID `50258, 50229` from the

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review144706 --- src/docker/docker.hpp (lines 73 - 75)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-02 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 2, 2016, 2:19 p.m.) Review request for mesos, Benjamin Mahler,