Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/ --- (Updated Feb. 18, 2016, 9:12 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 18, 2016, 11:49 a.m.) Review request for mesos and Neil Conway.

Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- Review request for mesos, Kevin Klues and Neil Conway. Repository: mesos

Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- Review request for mesos, Kevin Klues and Neil Conway. Repository: mesos

Re: Review Request 41865: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41865/#review119612 --- @mlunoe Is this change still needed, since the ticket has been

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119615 --- Fix it, then Ship it! src/tests/fetcher_cache_tests.cpp (line

Re: Review Request 36071: Add flow diagram for docker containerizer.

> On July 7, 2015, 4:51 a.m., Bernd Mathiske wrote: > > 1. Inconsistent capitalization in box labels. > > 2. You explain different paths to obtain an "executor pid" and then you > > checkpoint a "container pid". You lost me there. > > 3. What happens to the tasks? Is this diagram for the

Re: Review Request 41865: Use full width for mesos div.container

> On 二月 18, 2016, 1:32 p.m., Bernd Mathiske wrote: > > @mlunoe Is this change still needed, since the ticket has been closed given > > your patch? don't need any more. Let me discard - haosdent --- This is an automatically generated

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/#review119619 --- 3rdparty/libprocess/src/subprocess.cpp (line 303)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 18, 2016, 2:52 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 18, 2016, 2:54 p.m.) Review request for mesos, Alexander

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote: > > I see you send TASK_KILLING once the killTask() is invoked. However, > > according to the description of MESOS-4140, we may need to send such status > > update after SIGTERM is sent to the task and before SIGKILL is sent. So > > maybe you

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review119621 --- Patch looks great! Reviews applied: [43715, 43328] Passed

Re: Review Request 41865: Use full width for mesos div.container

> On Feb. 18, 2016, 1:32 p.m., Bernd Mathiske wrote: > > @mlunoe Is this change still needed, since the ticket has been closed given > > your patch? > > haosdent huang wrote: > don't need any more. Let me discard Nope, should be ok to discard (which I see is already done :) ) - Michael

Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4707

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 18, 2016, 4:01 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119627 --- Patch looks great! Reviews applied: [43715, 43716] Passed

Re: Review Request 43701: Added a command executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review119623 --- src/slave/flags.cpp (line 693)

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 18, 2016, 4:43 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 18, 2016, 4:47 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 18, 2016, 4:49 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119635 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119637 --- Seems like this patch doesn't update a lot of the endpoint

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119641 --- src/linux/fs.cpp (line 411)

Re: Review Request 38117: Added per container SNMP statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review119643 --- Seems like this commit should have updated the `v1` version of

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review119645 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:31 a.m.,

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/#review119648 --- src/CMakeLists.txt (line 219)

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review119650 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:24 a.m.,

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/ --- (Updated Feb. 18, 2016, 6:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review119653 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:29 a.m.,

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119656 --- 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119657 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 5:49 a.m.,

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review119659 --- 3rdparty/libprocess/cmake/ProcessConfigure.cmake (line 53)

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 18, 2016, 6:35 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 18, 2016, 6:36 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review119661 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 4:35 a.m.,

Re: Review Request 43716: Endpoint documents with title.

> On Feb. 18, 2016, 5:30 p.m., Neil Conway wrote: > > Seems like this patch doesn't update a lot of the endpoint documentation > > files -- `slave/state.md`, `registrar/registry.md`, and others. I don't quite understand this comment. As I see, those files are updated also! Can you mark the

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119636 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 18, 2016, 6:38 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review119665 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:26 a.m.,

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review119666 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:27 a.m.,

Re: Review Request 43716: Endpoint documents with title.

> On Feb. 18, 2016, 5:30 p.m., Neil Conway wrote: > > Seems like this patch doesn't update a lot of the endpoint documentation > > files -- `slave/state.md`, `registrar/registry.md`, and others. > > Abhishek Dasgupta wrote: > I don't quite understand this comment. As I see, those files are

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119669 --- src/linux/fs.hpp (lines 350 - 351)

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review119667 --- The description of your commit whould not be identical to the

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119673 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:28 a.m.,

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review119674 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:28 a.m.,

Re: Review Request 43712: Documented how the replicated log works.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43712/#review119679 --- Ship it! Ship It! - Jie Yu On Feb. 18, 2016, 6:19 a.m.,

Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43730/ --- Review request for mesos, Ian Downes, Jie Yu, and Neil Conway. Repository:

Re: Review Request 38117: Added per container SNMP statistics.

> On Feb. 18, 2016, 5:49 p.m., Neil Conway wrote: > > Seems like this commit should have updated the `v1` version of > > `mesos.proto`. > > Ian Downes wrote: > Ahh, you're probably right. @cwang could you please submit a fix. Sure. https://reviews.apache.org/r/43730/ - Cong

Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43730/#review119687 --- Ship it! Ship It! - Ian Downes On Feb. 18, 2016, 11:15

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/ --- (Updated Feb. 18, 2016, 11:22 a.m.) Review request for mesos, Benjamin

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/ --- (Updated Feb. 18, 2016, 11:22 a.m.) Review request for mesos, Benjamin

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119689 --- src/linux/fs.hpp (line 351)

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 18, 2016, 7:23 p.m., Benjamin Bannier wrote: > > src/linux/fs.hpp, line 351 > > > > > > Not sure how exactly this will be used later, but I would much prefer a > > less stringly-typed and more type-safe

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119701 --- src/slave/containerizer/docker.cpp (line 812)

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43518/#review119698 --- Fix it, then Ship it! Confirmed speedup (on OSX) and doesn't

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43519/#review119700 --- Fix it, then Ship it! Confirmed speedup (on OSX) and doesn't

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119703 --- Patch looks great! Reviews applied: [43718] Passed command:

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Dec. 15, 2015, 11:36 a.m., Ian Downes wrote: > > src/slave/containerizer/docker.cpp, line 838 > > > > > > Docker supports specifying the CFS period and quota to run a container > > with these flags

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119678 --- A commit addressing all my comments can be seen here:

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119708 --- See my comments on https://reviews.apache.org/r/43715 These

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 18, 2016, 7:51 p.m.) Review request for mesos and Benjamin

Re: Review Request 43384: Improved error handling in generate-endpoint-help script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/#review119710 --- support/generate-endpoint-help.py (lines 295 - 299)

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 18, 2016, 8:32 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review119715 --- Can you split up this patch into the following groups? (Its ok

Review Request 43737: Fixed typo in fetcher docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43737/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review119721 --- Patch looks great! Reviews applied: [43715, 43328] Passed

Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43730/#review119731 --- Patch looks great! Reviews applied: [38117, 43730] Passed

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119730 --- include/mesos/v1/mesos.proto (lines 1543 - 1544)

Review Request 43741: Fixed symlink generation for DESTDIR installs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/ --- Review request for mesos and James Peach. Bugs: MESOS-4714

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/#review119732 --- Ship it! Good catch. - James Peach On Feb. 18, 2016, 10:48

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/ --- (Updated Feb. 18, 2016, 5:49 p.m.) Review request for mesos and James Peach.

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/#review119734 --- Ship it! Ship It! - Anand Mazumdar On Feb. 18, 2016, 10:49

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/#review119736 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 18, 2016,

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43741/#review119737 --- Ship it! Ship It! - Kevin Klues On Feb. 18, 2016, 10:49

Re: Review Request 43260: Add net::IP parsing template to the flags parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43260/ --- (Updated Feb. 18, 2016, 10:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 43260: Add net::IP parsing template to the flags parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43260/ --- (Updated Feb. 18, 2016, 11:07 p.m.) Review request for mesos, Benjamin

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43261/ --- (Updated Feb. 18, 2016, 11:08 p.m.) Review request for mesos, Benjamin

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43261/ --- (Updated Feb. 18, 2016, 11:08 p.m.) Review request for mesos, Benjamin

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43261/ --- (Updated Feb. 18, 2016, 11:09 p.m.) Review request for mesos, Benjamin

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119738 --- src/slave/containerizer/docker.cpp (line 785)

Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43746/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 43747: Fixed ReviewBot to catch circular dependencies in review requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43747/ --- Review request for mesos, Joris Van Remoortere and Kevin Klues. Bugs:

Re: Review Request 43747: Fixed ReviewBot to catch circular dependencies in review requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43747/#review119759 --- Fix it, then Ship it! If we wren't using reviewboard (which I

Re: Review Request 43747: Fixed ReviewBot to catch circular dependencies in review requests.

> On Feb. 19, 2016, 1:16 a.m., Kevin Klues wrote: > > If we wren't using reviewboard (which I find overly cumbersome sometimes), > > I would probably have split this into two commits. One for the logic > > change (throwing an error), and one for the variable name change > >

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119763 --- Patch looks great! Reviews applied: [43715, 43716] Passed

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43519/ --- (Updated Feb. 19, 2016, 1:45 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43518/ --- (Updated Feb. 19, 2016, 1:44 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43519/ --- (Updated Feb. 19, 2016, 1:46 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43518/ --- (Updated Feb. 19, 2016, 1:46 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

> On Feb. 18, 2016, 7:34 p.m., Joseph Wu wrote: > > Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations). Thank you very much for you review, could you help check it again? - haosdent --- This is an automatically

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/ --- (Updated 二月 19, 2016, 1:52 a.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 19, 2016, 2:02 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 18, 2016, 7:23 p.m., Benjamin Bannier wrote: > > src/linux/fs.hpp, line 351 > > > > > > Not sure how exactly this will be used later, but I would much prefer a > > less stringly-typed and more type-safe

Re: Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43746/#review119782 --- Ship it! Ship It! - Guangya Liu On 二月 19, 2016, 12:26 a.m.,

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119797 --- LGTM, some minor comments around avoiding redundant use of

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 二月 19, 2016, 3:29 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 390 > > > > > > hmm ... Can't we just do: > > > > ``` > > Clock::pause(); > > Clock::advance(...); > >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 390 > > > > > > hmm ... Can't we just do: > > > > ``` > > Clock::pause(); > > Clock::advance(...); > >

Review Request 43754: WIP: Enhance allocator performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43754/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3283

  1   2   >