Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review124766 --- Bad patch! Reviews applied: [44378] Failed command:

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated March 22, 2016, 10:28 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45040: Added a test for task's kill policy.

> On March 19, 2016, 1:35 a.m., Ben Mahler wrote: > > Thanks for the test! Although I wouldn't want to ship this unless you show > > some manual testing in the 'testing done' section, since this test doesn't > > exercise the functionality :) I think since we pulled up half of the test into a

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 22, 2016, 10:30 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44993: Updated `TestContainerizer` to support default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 22, 2016, 10:28 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support Power LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review124772 --- Bad patch! Reviews applied: [44376] Failed command:

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

> On March 19, 2016, 12:38 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 366-370 > > > > > > How about following similar language from the executor info change? > > > > ``` > > // The

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/#review124752 --- What about

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 22, 2016, 2:40 p.m.) Review request for mesos, Avinash

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

Hey guys, we intentionally removed the ability to decrement Counters, please see the context here on another recent patch: https://reviews.apache.org/r/44473/ On Tue, Mar 22, 2016 at 12:00 AM, Benjamin Bannier < benjamin.bann...@mesosphere.io> wrote: > >

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

Hi Ben, thanks for the link. I had the feeling I saw this being discussed, but could not find the RR. Cheers, Benjamin > On Mar 22, 2016, at 8:06 AM, Benjamin Mahler wrote: > > Hey guys, we intentionally removed the ability to decrement Counters, please > see the

Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/ --- (Updated March 22, 2016, 6:24 a.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45097/ --- (Updated 三月 22, 2016, 6:42 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45096/ --- (Updated 三月 22, 2016, 6:42 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 22, 2016, 7:22 a.m.) Review request for mesos and Adam B.

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45096/#review124745 --- 3rdparty/libprocess/include/process/metrics/counter.hpp (line

Re: Review Request 44622: Introduced a protobuf message "NetworkInfo".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 22, 2016, 3:33 p.m.) Review request for mesos, Avinash

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review124758 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 22, 2016, 5:50 p.m.) Review request for mesos, Avinash

Re: Review Request 44512: Support to get weights info by /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- (Updated March 22, 2016, 10:02 a.m.) Review request for mesos and Adam B.

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124753 --- Patch looks great! Reviews applied: [45134] Passed command:

Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/#review124757 --- The bug should be MESOS-4997 here - Guangya Liu On 三月 22,

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124762 --- Bad patch! Reviews applied: [44372] Failed command:

Re: Review Request 44707: Added validation for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 22, 2016, 10:06 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/ --- (Updated March 22, 2016, 4:44 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 22, 2016, 5:06 p.m.) Review request for mesos, Avinash

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 22, 2016, 10:05 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44512: Support to get weights info by /weights.

> On March 21, 2016, 9:03 a.m., Adam B wrote: > > Good start, but you're missing a few things. Are these coming in subsequent > > patches? > > - Authentication for GET requests > > - Tests for GETs > > - Documentation updates I will add a separated patch for GET requet test. > On March 21,

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 22, 2016, 5:30 p.m.) Review request for mesos, Avinash

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/ --- (Updated March 22, 2016, 1:10 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated March 22, 2016, 9:22 p.m.) Review request for mesos, Alexander

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review124783 --- Patch looks great! Reviews applied: [45014] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/ --- (Updated March 22, 2016, 12:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated March 22, 2016, 8:25 p.m.) Review request for mesos, Alexander

Review Request 45158: Cleaned up formatting in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45158/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124785 --- Fix it, then Ship it! Ship It! src/tests/environment.cpp

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 22, 2016, 5:05 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 22, 2016, 5:12 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/ --- (Updated March 22, 2016, 5:20 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 22, 2016, 5:21 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/#review124840 --- Fix it, then Ship it! The changelog update would be great as

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 17, 2016, 3:37 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 279 > > > > > > I don't think we put headers here. > > Qian Zhang wrote: > I had the same concern before, because it seems most source

Re: Review Request 44707: Added validation for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 22, 2016, 5:10 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > Can you consider the feedback frmo the `write` review and rebase this? Alright, for posterity the `write` review is #44747, and I've adopted those suggestions here, too. - Alex

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

> On March 22, 2016, 5:10 p.m., Tom Runyon wrote: > > It would be helpful to update docs/container-image.md to include example > > appc deployments using mesos-execute. Created MESOS-5006. - Jojy --- This is an automatically generated

Re: Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 22, 2016, 5:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124834 --- It would be helpful to update docs/container-image.md to include

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

> On March 19, 2016, 1:52 a.m., Ben Mahler wrote: > > src/launcher/executor.cpp, line 929 > > > > > > It doesn't crash, it just exits :) Oh, right : ) - Alexander

Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45166/ --- Review request for mesos, Alexander Rojas and Neil Conway. Bugs: MESOS-4984

Review Request 45168: Removed old comment from 'mesos.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45168/ --- Review request for mesos, Adam B, Joris Van Remoortere, and Vinod Kone.

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated March 22, 2016, 5:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 22, 2016, 5:13 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/ --- (Updated March 22, 2016, 6:32 p.m.) Review request for mesos, Alexander

Re: Review Request 44852: Documented existing allocator metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44852/#review124843 --- Ship it! Ship It! - Ben Mahler On March 18, 2016, 4:08

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review124849 --- src/Makefile.am (line 788)

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 22, 2016, 5:09 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 22, 2016, 5:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44851: Renamed an allocator metric.

> On March 22, 2016, 5:50 p.m., Ben Mahler wrote: > > The changelog update would be great as well here, I'll take care of that > > before committing. Thanks! I'll also update the existing test: ``` $ grep -R allocator/event_queue_dispatches src/tests src/tests/master_tests.cpp: EXPECT_EQ(1u,

Re: Review Request 44673: Added test for registry puller normalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44673/#review124819 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 7:06 p.m.,

Re: Review Request 44674: Supported image name specified with private registry prefix.

> On March 22, 2016, 7:23 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > > > > > Just a question: Where did set the schema was set to `https` for

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124811 --- Fix it, then Ship it! src/master/master.cpp (line 3028)

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124816 --- Ship it! Ship It! - Jie Yu On March 22, 2016, 1:10 p.m.,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124827 --- BTW, should we also add `utils.cpp` to `CMakeList.txt`?

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/#review124806 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124818 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 7:06 p.m.,

Re: Review Request 45163: Reflecting rename of Tachyon to Alluxio.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45163/#review124863 --- Ship it! Ship It! - Neil Conway On March 22, 2016, 6:03

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124867 ---

Re: Review Request 44622: Introduced a protobuf message "NetworkInfo".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review124858 --- Fix it, then Ship it!

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review124836 --- Fix it, then Ship it! Looks good! I'll make some minor

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124860 --- Patch looks great! Reviews applied: [44255] Passed command:

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124881 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 22, 2016, 11:21 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 22, 2016, 11:21 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44674: Supported image name specified with private registry prefix.

> On 三月 22, 2016, 2:23 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > > > > > Just a question: Where did set the schema was set to `https` for

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124893 --- Patch looks great! Reviews applied: [44672, 44673, 44674]

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

> On March 22, 2016, 9:52 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/logging.hpp, line 57 > > > > > > I wonder whether we can use something from C++11 to avoid the need for > > non-portable

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44135/#review124898 --- 3rdparty/libprocess/include/process/logging.hpp (line 57)

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 22, 2016, 4:46 p.m., Gilbert Song wrote: > > BTW, should we also add `utils.cpp` to `CMakeList.txt`? Cmake support is going to need a lot more than that :-/ - James --- This is an automatically generated e-mail. To reply,

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/ --- (Updated March 22, 2016, 11:02 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

> On March 22, 2016, 7:58 a.m., Guangya Liu wrote: > > What about > > https://github.com/apache/mesos/blob/master/docs/multiple-disk.md#storage-management > > ? I think that we should also update here as well. Good catch! Thanks, fixed. - Neil

Review Request 45183: Implemented mounting host system config files to container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 45168: Removed old comment from 'mesos.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45168/#review124945 --- Patch looks great! Reviews applied: [45168] Passed command:

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44136/ --- (Updated March 23, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu,

Review Request 45184: Added test for mounting host system config files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45184/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Review Request 45185: Introduced an agent flag 'system_config_files'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45185/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review124937 --- Fix it, then Ship it! Thanks! Just some minor adjustments I'll

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 23, 2016, 1:59 a.m.) Review request for mesos, Adam B and

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 612 > > > > > > Not yours: We shouldn't capture temporaries by reference. > > Either: > > 1) capture by value:

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124950 --- Bad patch! Reviews applied: [45022, 45015, 45009, 44084, 44978,

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124793 ---

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/ --- (Updated March 22, 2016, 2:42 p.m.) Review request for mesos, Alexander

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124791 --- Patch looks great! Reviews applied: [41681, 43863, 44450]

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 3:08 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 32-56 > > > > > > Can we introduce paths.hpp|cpp under cni/ directory for the canonical > >

Re: Review Request 43880: Added allocated metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review124864 --- Fix it, then Ship it! Thanks for the patience Benjamin! I'll

  1   2   >