Re: Review Request 45582: Fixed Cmake build by adding CNI_SPEC to MESOS_PROTOBUF_SRC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45582/#review126590 --- Ship it! Ship It! - Jie Yu On April 1, 2016, 1:11 p.m.,

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review126588 --- Patch looks great! Reviews applied: [45039] Passed command:

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated April 1, 2016, 3:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated April 1, 2016, 2:14 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424 > > > > > > I do not think we need this. If agent crashes after removing the > >

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- (Updated April 1, 2016, 10:17 p.m.) Review request for mesos, Avinash

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 10:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424 > > > > > > I do not think we need this. If agent crashes after removing the > >

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review126586 --- docs/app-framework-development-guide.md (line 184)

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 1, 2016, 6:53 p.m., Kevin Klues wrote: > > As Neil said, I would also recommend *not* excluding the docs files. In the > > rare case that we need non-ascii cahracters in the docs, we should use HTML > > character entities. > > > > I would also not create a whole new python script

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 429 > > > > > > You had mentioned that if we return an error during `recover` the agent

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126617 --- Ship it! Ship It! - Avinash sridharan On April 1, 2016,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review126630 --- Patch looks great! Reviews applied: [42860, 42861] Passed

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/ --- (Updated April 1, 2016, 5:36 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44947: Add tests for XFS project quota utilities.

> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp, line 71 > > > > > > We have > > > > `makeQuotaInfo` vs. `mkfile` & `mkloop`. Can we make the use of the

Re: Review Request 45590: Made `Delegate` and `Handlers` libprocess tests less fragile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45590/#review126616 --- Patch looks great! Reviews applied: [45318, 45319, 45488, 45489,

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126629 --- Fix it, then Ship it! Verified the patch fix the tests

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 374 > > > > > > s/on/only > > instead of `non-host network(s)` maybe `joined a CNI

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 429 > > > > > > You had mentioned that if we return an error during `recover` the agent

Re: Review Request 44947: Add tests for XFS project quota utilities.

> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/cluster.cpp, lines 434-436 > > > > > > This can be tackled in another review because a) the tests here don't > > use cluster.cpp and b) I see other

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On March 31, 2016, 6:31 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 786 > > > > > > Shouldn't we return a failure? > > Qian Zhang wrote: > I think we

Re: Review Request 45319: Cleaned up various code in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45319/ --- (Updated April 1, 2016, 4:20 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45318: Improved libprocess comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45318/ --- (Updated April 1, 2016, 4:20 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated April 1, 2016, 8:05 p.m.) Review request for mesos and Jie Yu.

Review Request 45605: Introduced HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45605/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: mesos-4749

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > src/master/contenders/contender.cpp, lines 58-61 > > > > > > I am not sure if I understand this one here. Can you elaborate a bit? Dropped this issue since this

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated April 1, 2016, 1:25 p.m.) Review request for mesos, Artem

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review126648 --- Patch looks great! Reviews applied: [45259, 44934] Passed

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126638 --- Patch looks great! Reviews applied: [45571] Passed command:

Re: Review Request 45067: Updated the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review126646 --- src/examples/long_lived_framework.cpp (line 51)

Review Request 45606: Added default class to htb qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45606/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: mesos-4749

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review126560 --- Patch looks great! Reviews applied: [45500] Passed command:

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/#review126334 --- src/tests/cluster.cpp (lines 434 - 436)

Re: Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45533/ --- (Updated April 1, 2016, 10:07 a.m.) Review request for mesos, Alexander

Re: Review Request 45360: WIP: Added dvd client for mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review126567 --- Patch looks great! Reviews applied: [45214, 45217, 45265, 45270,

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 1, 2016, 2:31 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 786 > > > > > > Shouldn't we return a failure? I think we should not return a failure

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

> On March 30, 2016, 4:58 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1519 > > > > > > Don't you at least know that one of these parameters is the master's > > pid? > > Yongqiao Wang wrote:

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated April 1, 2016, 10:45 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 45573: Add PerfEventHandleManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated April 1, 2016, 10:45 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated April 1, 2016, 10:47 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 45577: Updated a note about quota limit in the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45577/#review126571 --- Ship it! Ship It! - Alexander Rukletsov On April 1, 2016,

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 1, 2016, 6:04 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 791-792 > > > > > > hum, what about labels and groups in NetworkInfo? I think we should > > save a

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

> On April 1, 2016, 6:22 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 781 > > > > > > Can you add some LOG(INFO) here. Maybe in a subsequent patch. Sure, fixed it in a

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126570 --- Patch looks great! Reviews applied: [45213] Passed command:

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/ --- (Updated April 1, 2016, 10:45 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated April 1, 2016, 10:45 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 1, 2016, 10:45 a.m.) Review request for mesos and Jie Yu.

Review Request 45580: Add some log messages in 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45580/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 45429: Added authentication to the '/registry' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/#review126563 --- Fix it, then Ship it! Looks great! I'll fix these little bits

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- (Updated April 1, 2016, 5:53 p.m.) Review request for mesos, Avinash

Re: Review Request 45577: Updated a note about quota limit in the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45577/ --- (Updated April 1, 2016, 10:25 a.m.) Review request for mesos and Alexander

Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/ --- (Updated April 1, 2016, 12:35 p.m.) Review request for mesos and Joris Van

Re: Review Request 45582: Fixed Cmake build by adding CNI_SPEC to MESOS_PROTOBUF_SRC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45582/ --- (Updated April 1, 2016, 11:53 a.m.) Review request for mesos, Benjamin

Re: Review Request 45580: Add some log messages in 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45580/#review126572 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 1, 2016, 10:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 2, 2016, 6:32 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- (Updated 四月 2, 2016, 5:45 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45360: Added dvd client for mount and unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 2, 2016, 5:56 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126655 --- Patch looks great! Reviews applied: [44672, 44673, 44674]

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review126613 --- src/slave/containerizer/mesos/isolators/disk/xfs.cpp (lines 501

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 2, 2016, 6:32 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126677 --- Patch looks great! Reviews applied: [45033] Passed command:

Re: Review Request 45580: Add some log messages in 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45580/ --- (Updated April 2, 2016, 11:31 a.m.) Review request for mesos, Avinash

Re: Review Request 45580: Add some log messages in 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45580/#review126678 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 45265: Plugged in dvd isolator into agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- (Updated 四月 2, 2016, 5:47 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review126674 --- Ship it! Ship It! - haosdent huang On April 1, 2016, 5:19

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- (Updated April 2, 2016, 11:18 a.m.) Review request for mesos, Avinash

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 四月 2, 2016, 5:41 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 2, 2016, 5:52 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45580: Add some log messages in 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45580/#review126658 --- Fix it, then Ship it!

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated April 1, 2016, 3:41 p.m.) Review request for mesos, Artem

Re: Review Request 45607: Move HTB qdisc out of containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45607/ --- (Updated April 1, 2016, 11:05 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 2, 2016, 1:41 a.m.) Review request for mesos, Alexander

Review Request 45607: Moved HTB out of containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45607/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: mesos-4749

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126671 --- Thanks for all the input from every one. I updated the review

Re: Review Request 45200: Duplicate flags with keywork 'slave' on master side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/#review126661 --- Can you call this out in the CHANGELOG too please? Also, all of

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126657 --- src/docker/spec.cpp (lines 103 - 105)

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126659 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126668 --- Patch looks great! Reviews applied: [44672, 44673, 44674]

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/#review126576 --- Patch looks great! Reviews applied: [45083, 45084, 45350, 45085,

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/#review126552 --- Patch looks great! Reviews applied: [45083, 45084, 45350, 45085,

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

> On March 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, please take a look. >

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/ --- (Updated 四月 1, 2016, 6:23 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, please take a look. > Besides,