Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 8:08 a.m., Anand Mazumdar wrote: > > src/launcher/http_command_executor.cpp, line 105 > > > > > > Why did you move this? Let's have the ordering of member variables the > > same as command

Review Request 45634: Update `MesosContainerizer::create` in memory_pressure_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45634/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45628: Added a flag parser for map<string, string> to src/common/parse.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45628/ --- Review request for mesos. Repository: mesos Description --- Added a

Re: Review Request 44907: Remove `Fetcher` in `DockerContainerizer::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44907/ --- (Updated April 3, 2016, 1:08 p.m.) Review request for mesos and Till

Review Request 45630: Update `Containerizer::create` in tests/cluster.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45630/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45633: Update `MesosContainerizer::create` in isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45633/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45629: Use `Parameters` as `Containerizer::create` parameters type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45629/ --- Review request for mesos. Repository: mesos Description --- Use

Review Request 45625: Add HasCustomJsonify helper struct to avoid ambiguity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45625/ --- Review request for mesos. Repository: mesos Description --- Add

Re: Review Request 44909: Update containerizer construction in docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44909/ --- (Updated April 3, 2016, 1:08 p.m.) Review request for mesos and Till

Review Request 45626: Add jsonify for FlagsBase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45626/ --- Review request for mesos. Repository: mesos Description --- Add jsonify

Review Request 45632: Update `MesosContainerizer::create` in container_logger_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45632/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45635: Update `MesosContainerizer::create` in mesos_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45635/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45636: Update `MesosContainerizer::create` in port_mapping_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45636/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45627: Add `Containerizer::parameterize` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45627/ --- Review request for mesos. Repository: mesos Description --- Add

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, line 104 > > > > > > Do we introduce 'arguments' flag? It looks like you treat 'command' > > flag as command + arguments. This comment

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". > >

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 3, 2016, 1:42 p.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 12:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 4:21 p.m., Kevin Klues wrote: > > support/mesos-style.py, line 43 > > > > > > This will not work with `re.match()`. As is, this will only match if > > the non-ascii character is the first

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126733 --- Thanks Yong for all your work on this! Just a few comments about

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126734 --- @yongtang, Thank you very much for your patch and follow up

Re: Review Request 45628: Added a flag parser for map<string, string> to src/common/parse.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45628/ --- (Updated April 3, 2016, 4:47 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45630: Update `Containerizer::create` in tests/cluster.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45630/ --- (Updated April 3, 2016, 4:47 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45627: Add `Containerizer::parameterize` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45627/ --- (Updated April 3, 2016, 4:47 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45629: Use `Parameters` as `Containerizer::create` parameters type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45629/ --- (Updated April 3, 2016, 4:47 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/containerizer.hpp, line 29 > > > > > > what is the use of this include for this patch? Thanks for your view. `ContainerState` is defined

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

> On April 3, 2016, 2:25 p.m., Guangya Liu wrote: > > It is always suggested to use past tone for the summary and ditto for the > > patch chain. Got it. I would update in next round. - haosdent --- This is an automatically generated

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4694 > > > > > > I know that those code are copied from > > `MesosContainerizerProcess::recover`, but it is better update the

Review Request 45657: Add CustomInfo to ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45657/ --- Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till Toenshoff,

Re: Review Request 45656: Enable CMake build for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45656/ --- (Updated Abr. 3, 2016, 4:24 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 4:33 p.m., haosdent huang wrote: > > support/mesos-style.py, line 47 > > > > > > Actually you could use > > > > ``` > > for line_no, line in enumerate(source_file): > > ... > >

Review Request 45656: Enable CMake build for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45656/ --- Review request for mesos, Alex Clemmer and Vinod Kone. Repository: mesos

Re: Review Request 45657: Add CustomInfo to ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45657/#review126735 --- Bad review! Reviews applied: [45657, 45655, 45654, 45653, 45652,

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 4:33 p.m., haosdent huang wrote: > > support/mesos-style.py, line 147 > > > > > > How about use `no_ascii_errors`? encoding_errors as @klueska said more meaningful. Let me drop this. -

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

> On April 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 794-797 > > > > > > const ExecutorInfo& executorInfo = recoverable.executor_info(); > > const ContainerID&

Re: Review Request 45656: Enable CMake build for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45656/ --- (Updated Abr. 3, 2016, 4:28 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 4:21 p.m., Kevin Klues wrote: > > Thanks Yong for all your work on this! > > > > Just a few comments about style and one comment regarding the use of > > `re.match()` instead of `re.search()`. > > > > Please see my patch on github which applies all of the comments I've

Re: Review Request 45656: Enable CMake build for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45656/#review126740 --- Bad patch! Reviews applied: [45656] Failed command:

Re: Review Request 45656: Enable CMake build for Linux

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45656/ --- (Updated Abr. 3, 2016, 6 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, lines 180-182 > > > > > > one line The remain spaces is not allowed to one line here. Or I missunderstanding

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 --- Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not

Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/#review126760 --- Fix it, then Ship it!

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 3, 2016, 11:47 p.m.) Review request for mesos, Alexander

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

> On April 3, 2016, 10:19 p.m., Kevin Klues wrote: > > Looks great. Glad we are finally able to catch these now! > > > > Only comment would be on the summary line. We typically phrase the summary > > line in the past tense, with a period at the end, i.e.: > > > > ``` > > Changed some

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 3, 2016, 11:45 p.m.) Review request for mesos, Alexander

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 3, 2016, 11:46 p.m.) Review request for mesos, Alexander

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

> On April 3, 2016, 10:20 p.m., Kevin Klues wrote: > > Only thing I'd suggest is to change the summary line to: > > > > ``` > > Changed some non-ascii characters in libprocess to their ascii equivalent. > > ``` Thanks the summary and the commit message have been updated. - Yong

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 3, 2016, 10:13 p.m., Kevin Klues wrote: > > Thanks Yong! > > > > Patch looks great now. The only thing I'd change at this point is the > > wording in the commit message. > > > > Probably something like: > > ``` > > Add a commit hook for checking non-printable characters

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 7:51 p.m., Kevin Klues wrote: > > support/mesos-style.py, line 108 > > > > > > I might have slipped it in a little late, but I also had a comment > > about the actual matching going on here. > >

Re: Review Request 45660: Fix non-printable chars in mesos source code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 3, 2016, 8:58 p.m.) Review request for mesos, Alexander

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126753 --- Patch looks great! Reviews applied: [45033] Passed command:

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126754 --- Ship it! Thanks Yong! Patch looks great now. The only thing

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 7:51 p.m., Kevin Klues wrote: > > Yes string.printable is a better way of handling this issue. Let me update the review request shortly. - Yong --- This is an automatically generated e-mail. To reply, visit:

Review Request 45660: Fix non-printable chars in mesos source code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- Review request for mesos, haosdent huang and Kevin Klues. Bugs: MESOS-4033

Review Request 45659: Fix non-printable chars in libprocess (format.hpp).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- Review request for mesos, haosdent huang and Kevin Klues. Bugs: MESOS-4033

Re: Review Request 45660: Fix non-printable chars in mesos source code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126758 --- Patch looks great! Reviews applied: [45033, 45659, 45660]

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126749 --- support/mesos-style.py (line 108)

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 4:21 p.m., Kevin Klues wrote: > > Thanks Yong for all your work on this! > > > > Just a few comments about style and one comment regarding the use of > > `re.match()` instead of `re.search()`. > > > > Please see my patch on github which applies all of the comments I've

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 7:51 p.m., Kevin Klues wrote: > > support/mesos-style.py, line 108 > > > > > > I might have slipped it in a little late, but I also had a comment > > about the actual matching going on here. > >

Re: Review Request 45659: Fix non-printable chars in libprocess (format.hpp).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 3, 2016, 9:01 p.m.) Review request for mesos, Alexander

Re: Review Request 45660: Fix non-printable chars in mesos source code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126755 --- Ship it! Looks great. Glad we are finally able to catch these

Re: Review Request 45659: Fix non-printable chars in libprocess (format.hpp).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/#review126756 --- Ship it! Only thing I'd suggest is to change the summary line

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On April 3, 2016, 4:21 p.m., Kevin Klues wrote: > > support/mesos-style.py, line 43 > > > > > > This will not work with `re.match()`. As is, this will only match if > > the non-ascii character is the first

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 3, 2016, 7:46 p.m.) Review request for mesos, Alexander

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126771 --- Patch looks great! Reviews applied: [45033, 45659, 45660]

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126772 --- Ship it! Ship It! - haosdent huang On April 3, 2016, 11:45

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/#review126773 --- Ship it! Ship It! - haosdent huang On April 3, 2016, 11:46

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126774 --- Ship it! Ship It! - haosdent huang On April 3, 2016, 11:47

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 3, 2016, 10:13 p.m., Kevin Klues wrote: > > Thanks Yong! > > > > Patch looks great now. The only thing I'd change at this point is the > > wording in the commit message. > > > > Probably something like: > > ``` > > Add a commit hook for checking non-printable characters

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 --- src/examples/dynamic_reservation_framework.cpp (line 52)

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 8:08 a.m., Anand Mazumdar wrote: > > src/launcher/http_command_executor.cpp, line 120 > > > > > > Let's scope all the functions after this to the `protected` namespace. > > > > I know

Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/ --- (Updated April 4, 2016, 1:56 a.m.) Review request for mesos and Michael Park.

Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

> On April 3, 2016, 11:21 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/gtest.hpp, lines 370-383 > > > > > > Can we introduce the `ASSERT_*` versions before the `EXPECT_*` versions > > for

Review Request 45663: Add AWAIT_TRUE_FOR/AWAIT_TRUE, AWAIT_FALSE_FOR/AWAIT_FALSE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45663/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112

Review Request 45664: Replace `EQ(true/false` with `_TRUE/_FALSE` in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45664/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 4, 2016, 9:58 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 12:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 8:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the

Re: Review Request 45663: Add AWAIT_TRUE_FOR/AWAIT_TRUE, AWAIT_FALSE_FOR/AWAIT_FALSE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45663/#review126781 --- Ship it! Ship It! - Michael Park On April 4, 2016, 1:58

Re: Review Request 45664: Replace `EQ(true/false` with `_TRUE/_FALSE` in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45664/#review126782 --- Ship it! Ship It! - Michael Park On April 4, 2016, 1:59

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 12:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the

Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/#review126784 --- Patch looks great! Reviews applied: [45663, 45664, 45357]

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

> On 四月 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, lines 180-182 > > > > > > one line > > haosdent huang wrote: > The remain spaces is not allowed to one line

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

> On 四月 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 825-826 > > > > > > I think that here should be `||` but not `&&` > > haosdent huang wrote: > Actually these code

<    1   2