Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5117

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127032 --- Patch looks great! Reviews applied: [45726] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-04 Thread Klaus Ma
> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, line 308 > > > > > > `static const Resources TASK_RESOURCES;` If we mark it `const`, we have to move the

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-04-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review127027 --- src/slave/containerizer/fetcher.cpp (line 150)

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-04 Thread Klaus Ma
> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 311-320 > > > > > > Conceptutally, `Try` is not something we pass around like this. A > > function

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127023 --- Can you also add a test case for the empty string case? e.g.,

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127021 --- Ship it! Ship It! - Jie Yu On April 5, 2016, 2:57 a.m.,

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review127020 --- Patch looks great! Reviews applied: [45717] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-04 Thread Klaus Ma
> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 350-364 > > > > > > We should be able to just use the ones in `src/tests/mesos.hpp`. I'd like to

Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5114

Re: Review Request 45707: Minor cleanups to command executor.

2016-04-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127009 --- Ship it! Ship It! - Klaus Ma On April 5, 2016, 5:32 a.m.,

Re: Review Request 45707: Minor cleanups to command executor.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127005 --- Patch looks great! Reviews applied: [45707] Passed command:

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126992 --- Patch looks great! Reviews applied: [45620] Passed command:

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

2016-04-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review126991 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45217: Implemented docker volume driver isolator interface.

2016-04-04 Thread Guangya Liu
> On 四月 4, 2016, 11:01 p.m., Gilbert Song wrote: > > src/Makefile.am, line 860 > > > > > > Could you move it below runtime.cpp? There are some files such as spec.proto, dvd_client.cpp, dvd_client.hpp, dvd.cpp,

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/#review126983 --- include/mesos/mesos.proto (line 1563)

Re: Review Request 45377: Updated prepare() logic for unified container.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review126981 --- Could we keep the cli/execute.cpp changes private for now? and

Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

2016-04-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-5113

Re: Review Request 45370: Implemented prepare() for dvd isolator.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review126980 --- src/cli/execute.cpp (lines 323 - 341)

Review Request 45715: Added support to grant access to /dev/nvidiactl in Nvidia GPU isolator.

2016-04-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45715/ --- Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Bugs:

Re: Review Request 44364: Added tests for the Nvidia GPU isolator.

2016-04-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44364/ --- (Updated April 4, 2016, 11:41 p.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/#review126977 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review126927 --- This looks pretty good. One more round of minor cleanups and we

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review126971 ---

Re: Review Request 45621: Added tests for docker spec helpers.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45621/#review126973 --- Patch looks great! Reviews applied: [44672, 44673, 44674, 45621]

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review126968 --- src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp

Re: Review Request 45496: Added documentation of LIBPROCESS_NUM_WORKER_THREADS.

2016-04-04 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45496/ --- (Updated April 4, 2016, 11:12 p.m.) Review request for mesos and Joris Van

Re: Review Request 45496: Added documentation of LIBPROCESS_NUM_WORKER_THREADS.

2016-04-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45496/#review126970 --- Ship it! Ship It! - Joris Van Remoortere On March 30, 2016,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-04-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review126969 --- Ship it! Ship It! - Joris Van Remoortere On March 30, 2016,

Re: Review Request 45265: Plugged in dvd isolator into agent.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/#review126967 --- src/slave/containerizer/mesos/containerizer.cpp (line 73)

Re: Review Request 45217: Implemented docker volume driver isolator interface.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/#review126794 --- src/Makefile.am (line 860)

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-04-04 Thread Joris Van Remoortere
> On March 31, 2016, 3:43 p.m., Vinod Kone wrote: > > src/tests/environment.cpp, lines 767-771 > > > > > > should this be done by the test event listener as well? Added a `TODO` as per discussion offline. - Joris

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-04-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/ --- (Updated April 4, 2016, 10:51 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-04-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/ --- (Updated April 4, 2016, 10:50 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126959 --- Patch looks great! Reviews applied: [45381] Passed command:

Re: Review Request 45707: Minor cleanups to command executor.

2016-04-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review126954 --- Ship it! Ship It! - Timothy Chen On April 4, 2016, 9:32

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

2016-04-04 Thread Jie Yu
> On April 3, 2016, 3:30 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 95 > > > > > > Can you please clarify why making `networkInfo` as an `Option`? Is > > there any

Re: Review Request 45461: Create tempfiles in test temporary directory.

2016-04-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45461/#review126951 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 5:26

Review Request 45707: Minor cleanups to command executor.

2016-04-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/#review126947 --- Patch looks great! Reviews applied: [45520, 45690] Passed

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-04 Thread Zhitao Li
> On April 4, 2016, 5:26 p.m., haosdent huang wrote: > > CHANGELOG, line 49 > > > > > > Usually we don't need change file. It would be changed by release > > manager. hmm, right now the top section of CHANGELOG is

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126938 --- Ship it! Ship It! - Alexander Rukletsov On April 4, 2016,

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126917 --- Fix it, then Ship it! Thanks for taking this on! I'll fix

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review126932 --- Patch looks great! Reviews applied: [44945, 44946, 45689, 44947,

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-04-04 Thread Michael Park
> On March 18, 2016, 7:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118 > > > > > > This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and > > below. >

Re: Review Request 45311: Added an additional template parameter to 'Try' for typed error.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/ --- (Updated April 4, 2016, 8:25 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/ --- (Updated April 4, 2016, 8:19 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45314: Updated `network::connect` to use the typed error state of `Try` .

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/ --- (Updated April 4, 2016, 8:17 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45312: Captured the error code in `ErrnoError` and `WindowsError`.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45312/ --- (Updated April 4, 2016, 8:16 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45310: Removed unnecessary constructors in `Try`.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/ --- (Updated April 4, 2016, 8:16 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45311: Added an additional template parameter to 'Try' for typed error.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/ --- (Updated April 4, 2016, 8:16 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45314: Updated `network::connect` to use the typed error state of `Try` .

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/ --- (Updated April 4, 2016, 8:11 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45311: Added an additional template parameter to 'Try' for typed error.

2016-04-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/ --- (Updated April 4, 2016, 8:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126916 --- Ship it! Thanks for doing this, I could easily imagine issues

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

2016-04-04 Thread Benjamin Bannier
> On April 4, 2016, 9:24 p.m., Benjamin Bannier wrote: > > Ship It! Thanks for doing this, I could easily imagine issues like this slipping throuh in the past since I had to look trice :D It might be a good idea to get these fixes in before the hook. - Benjamin

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/#review126914 --- Patch looks great! Reviews applied: [45083, 45084, 45350, 45085,

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

2016-04-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/#review126913 --- Ship it! Ship It! - Benjamin Bannier On April 4, 2016, 5:22

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126911 --- Ship it! Ship It! - Vinod Kone On April 4, 2016, 3:22 p.m.,

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

2016-04-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/#review126910 --- Ship it! Ship It! - Vinod Kone On April 4, 2016, 3:22 p.m.,

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126909 --- Ship it! Ship It! - Vinod Kone On April 4, 2016, 3:21 p.m.,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review126907 --- I don't like the fact that we use 'sandbox' for scratch space.

Re: Review Request 45670: Added tests for HTTP command executor.

2016-04-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review126904 --- hmm.. Would it be possible to not create a new file just for

Review Request 45698: Minor cleanups in Disk Quota tests.

2016-04-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45698/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45621: Added tests for docker spec helpers.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45621/ --- (Updated April 4, 2016, 11:49 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Kevin Klues
> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

2016-04-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126895 --- Ship it! Ship It! - Kevin Klues On April 4, 2016, 3:21

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

2016-04-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/#review126893 --- Ship it! Ship It! - Vinod Kone On April 4, 2016, 11:40

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-04 Thread Jie Yu
> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126880 --- src/cli/execute.cpp (line 284)

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

2016-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126877 --- Patch looks great! Reviews applied: [45033, 45659, 45660]

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-04 Thread Jiang Yan Xu
> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-04 Thread James Peach
> On April 4, 2016, 5:35 p.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

2016-04-04 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126871 --- Ship it! You don't have to pass the real path to all the

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-04 Thread Jiang Yan Xu
> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` +1 this is

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126867 --- Not insisting on addressing it here but just would like to

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126866 --- src/tests/cluster.cpp (line 437)

Review Request 45689: Make Cluster::Slave more tolerant of start failures.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.

Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/ --- Review request for mesos, Ian Downes and Cong Wang. Bugs: MESOS-4662

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/ --- (Updated April 4, 2016, 5:29 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-04 Thread James Peach
> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp, lines 292-294 > > > > > > Instead of doing cleanups here, we can register the projectIds with a > > member

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 4, 2016, 5:26 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review126862 --- CHANGELOG (line 49)

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45473/ --- (Updated April 4, 2016, 5:22 p.m.) Review request for mesos, Avinash

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45353/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45351/ --- (Updated April 4, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 4, 2016, 5:17 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

2016-04-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/#review126858 --- src/slave/flags.cpp (line 335)

Re: Review Request 45085: Add cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 4, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/ --- (Updated April 4, 2016, 5:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45083: Added a any mechanism for futures.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 4, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song,

  1   2   >