Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/ --- (Updated April 9, 2016, 6:09 a.m.) Review request for mesos, Alexander

Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43515/ --- (Updated April 9, 2016, 6:19 a.m.) Review request for mesos, Alexander

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review127964 --- include/mesos/resources.hpp (line 64)

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43329/#review127968 --- Patch looks great! Reviews applied: [43329] Passed command:

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/ --- (Updated 四月 9, 2016, 3:42 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/ --- (Updated 四月 9, 2016, 3:39 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review127991 --- Patch looks great! Reviews applied: [43321] Passed command:

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43522/ --- (Updated April 9, 2016, 6:16 a.m.) Review request for mesos, Alexander

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/#review127960 --- include/mesos/mesos.proto (line 756)

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127962 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 44427: Added --http_command_executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44427/ --- (Updated April 9, 2016, 4:47 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/ --- (Updated April 9, 2016, 4:48 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated April 9, 2016, 9:17 a.m.) Review request for mesos and Alexander

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43516/ --- (Updated April 9, 2016, 6:19 a.m.) Review request for mesos, Alexander

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/ --- (Updated April 9, 2016, 6:18 a.m.) Review request for mesos, Alexander

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this way

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 四月 9, 2016, 7:14 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On April 9, 2016, 2:52 a.m., Anand Mazumdar wrote: > > src/launcher/http_command_executor.cpp, lines 82-94 > > > > > > Let's move this all out of the `mesos::internal` namespace. We > > typically have `using`

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review127969 --- You may want to rebase this patch for

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review127970 --- Patch looks great! Reviews applied: [43524] Passed command:

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On April 8, 2016, 6:52 p.m., Anand Mazumdar wrote: > > src/launcher/http_command_executor.cpp, lines 82-94 > > > > > > Let's move this all out of the `mesos::internal` namespace. We > > typically have `using`

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review127975 --- Ship it! LGTM - Anand Mazumdar On April 9, 2016, 8:40 a.m.,

Re: Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review127978 --- Ship it! LGTM - Anand Mazumdar On April 9, 2016, 8:48 a.m.,

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review127979 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 396 > > > > > > Is there a need to explicitly invoke `Clock::resume()` here? If not, > > kill it. > > Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On 四月 8, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > src/tests/hook_tests.cpp, line 392 > > > > > > we don't need `settle` here because AWAIT_READY does it for us. > > However, we should resume the clock

Re: Review Request 44427: Added --http_command_executor flag.

> On April 8, 2016, 11:29 p.m., Anand Mazumdar wrote: > > src/slave/slave.cpp, line 5640 > > > > > > We typically don't spill partial arguments from a function invocation. > > > > How about: > > > >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 四月 9, 2016, 2:45 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 45953: Adding a stout interface for `sethostname` system call in linux.

> On April 9, 2016, 12:45 a.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 277-281 > > > > > > HOSTNAME max length might be variable. Will the system below checks the > >

Re: Review Request 45953: Adding a stout interface for `sethostname` system call in linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45953/ --- (Updated April 9, 2016, 2:54 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 42441: Speed up ExamplesTest test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review127984 --- Patch looks great! Reviews applied: [42441] Passed command:

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/#review127972 --- Patch looks great! Reviews applied: [43520] Passed command:

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/ --- (Updated April 9, 2016, 1:14 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45954/ --- (Updated April 9, 2016, 5:46 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 9, 2016, 5:48 p.m.) Review request for mesos, Jie Yu and Qian

Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-5160

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review128009 --- Ship it! Ship It! - Michael Park On April 9, 2016, 7:14

Re: Review Request 45861: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45861/ --- (Updated April 9, 2016, 11:51 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128015 --- Patch looks great! Reviews applied: [45953, 45954, 45955, 45956]

Re: Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45943/ --- (Updated April 10, 2016, 5:09 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45944/#review128008 --- Ship it! Ship It! - Michael Park On April 8, 2016, 8:41

Re: Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45943/#review128007 --- Fix it, then Ship it!

Re: Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review127997 --- Bad patch! Reviews applied: [45670, 44427, 44424, 44423] Failed

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45941/#review128005 --- Patch looks great! Reviews applied: [45941] Passed command:

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review128003 --- Bad patch! Reviews applied: [41787] Failed command:

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

> On April 8, 2016, 11:03 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 4989-4991 > > > > > > Any reason why this CHECK isn't below the VLOG(1) above? Having it > > above seems to make it more clear that

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45941/ --- (Updated April 9, 2016, 5:20 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review127994 --- Patch looks great! Reviews applied: [43558] Passed command:

Re: Review Request 44427: Added --http_command_executor flag.

> On April 9, 2016, 7:29 a.m., Anand Mazumdar wrote: > > src/slave/slave.cpp, line 5640 > > > > > > We typically don't spill partial arguments from a function invocation. > > > > How about: > > > >

Re: Review Request 42441: Speed up ExamplesTest test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/ --- (Updated April 9, 2016, 8:41 a.m.) Review request for mesos, Alexander

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 9, 2016, 4:40 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/#review127958 --- include/mesos/resources.hpp (line 258)