Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153556 --- 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 26)

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

- James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153347 --- On Oct. 21, 2016, 9:29 a.m., Qian Zhang wrote: > >

Re: Review Request 53076: Alphabetized 'evolve' and 'devolve' files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53076/#review153560 --- Ship it! Nice cleanup! - Anand Mazumdar On Oct. 20, 2016,

Re: Review Request 52818: Ensured agent is recovered in SlaveEndpointTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52818/#review153555 --- Ship it! Ship It! - Anand Mazumdar On Oct. 21, 2016, 9:01

Re: Review Request 53077: Redefined helper macros with existing 'create' functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53077/#review153559 --- Ship it! Ship It! - Anand Mazumdar On Oct. 20, 2016, 8:39

Re: Review Request 53031: Failure in cleanup of non-existing cgroups is treated as success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53031/#review153561 --- Ship it! Ship It! - Jiang Yan Xu On Oct. 19, 2016, 11:20

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 20, 2016, 4:03 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 64 > > > > > > You could use ``std::vector`` here to avoid manual memory > > management. > > Qian Zhang

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Oct. 21, 2016, 6:52 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52863: Refactored HealthCheck validation for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52863/#review153578 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Review Request 53099: Avoided passing `TimeInfo` by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53099/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 53097: Fixed bug when marking agents unreachable after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53097/ --- (Updated Oct. 21, 2016, 7:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

> On Oct. 20, 2016, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 592-603 > > > > > > This won't work because data services explicitly want to get limit > > above what's configured. >

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

> On Oct. 7, 2016, 5:20 p.m., Greg Mann wrote: > > Given how similar the code in the new example framework is to the existing > > persistent volumes framework, I think it could make sense to add shared > > volume features to the existing framework, which could be enabled/disabled > > via

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Oct. 21, 2016, 6:52 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6444

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review153584 --- src/health-check/health_checker.cpp (line 187)

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/#review153595 --- Ship it! Ship It! - Benjamin Mahler On Oct. 18, 2016, 6:17

Review Request 53097: Fixed bug when marking agents unreachable after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53097/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6445

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review153583 --- src/launcher/executor.cpp (lines 300 - 314)

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

> On Oct. 20, 2016, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 105 > > > > > > That makes me think if we should make 'unlimited' be more explicit. > > With the current scheme,

Re: Review Request 52864: Removed unnecessary sleep in HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52864/#review153580 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Review Request 53098: Tweaked test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53098/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 53098: Tweaked test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53098/ --- (Updated Oct. 21, 2016, 7:11 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53099: Avoided passing `TimeInfo` by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53099/ --- (Updated Oct. 21, 2016, 7:42 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52975: Factored out the create port range logic to test utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/#review153587 --- Can you introduce a new file called resources_utils.hpp / cpp? -

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Oct. 21, 2016, 6:41 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 53095: Make `slaves.recovered` in master a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53095/ --- Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.

Re: Review Request 53095: Make `slaves.recovered` in master a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53095/ --- (Updated Oct. 21, 2016, 6:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52765: Populated `recovered_slaves` in master `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/ --- (Updated Oct. 21, 2016, 6:40 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53083: Made `cgroups::create` create cgroup recursively as default behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53083/#review153567 --- Patch looks great! Reviews applied: [51031, 51185, 53082, 53083]

Re: Review Request 52637: Added `recovered_agents` in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52637/ --- (Updated Oct. 21, 2016, 6:39 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52638: Populated `recovered_agents` field in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52638/ --- (Updated Oct. 21, 2016, 6:39 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52975: Factored out the create port range logic to test resources_utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/ --- (Updated 十月 21, 2016, 11:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/ --- (Updated 十月 21, 2016, 11:27 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

> On 十月 21, 2016, 8:23 p.m., Benjamin Mahler wrote: > > Ship It! Do you have any comments on the test result? Shall we use a small range to reduce the time of this? The `contains` for a boundry case is using 38+s. ``` [ RUN ] ResourcesContains/Resources_Contains_BENCHMARK_Test.Contains/5

Re: Review Request 53067: Added log message when terminating agent ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review153602 --- src/slave/slave.cpp (lines 815 - 819)

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review153606 --- Patch looks great! Reviews applied: [53095, 52637, 52638, 52765,

Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu.

Re: Review Request 53033: Improved agent re-registration log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53033/#review153601 --- src/slave/slave.cpp (line 1161)

Re: Review Request 53035: Tweaked an agent log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53035/#review153600 --- src/slave/slave.cpp (line 937)

Re: Review Request 52637: Added `recovered_agents` in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52637/ --- (Updated Oct. 21, 2016, 9:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53098: Tweaked test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53098/#review153599 --- Ship it! Ship It! - Vinod Kone On Oct. 21, 2016, 7:11 p.m.,

Re: Review Request 53097: Fixed bug when marking agents unreachable after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53097/#review153598 --- Ship it! Ship It! - Vinod Kone On Oct. 21, 2016, 7:37 p.m.,

Re: Review Request 53099: Avoided passing `TimeInfo` by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53099/#review153597 --- Ship it! Ship It! - Vinod Kone On Oct. 21, 2016, 7:42 p.m.,

Re: Review Request 52769: Some rename for original resource benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52769/#review153625 --- Fix it, then Ship it! src/tests/resources_tests.cpp (line

Re: Review Request 51033: Added validation benchmark test for resources.

> On Oct. 19, 2016, 6:35 a.m., Guangya Liu wrote: > > After sort the `ranges` in `validate`, the elapse time was reduced from > > `25+s` to `26992us`. > > > > ``` > > [ RUN ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/2 > > Took 26992us to perform 1 'validate(r)'

Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/#review153628 --- Fix it, then Ship it! src/CMakeLists.txt (line 439)

Re: Review Request 52975: Factored out the create port range logic to test resources_utils.

> On Oct. 21, 2016, 11:52 p.m., Benjamin Mahler wrote: > > Also need two lines between top level functions in the cpp file. - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52975: Factored out the create port range logic to test resources_utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/#review153616 --- Ship it! src/tests/resources_utils.hpp (line 27)

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

> On Oct. 21, 2016, 8:23 p.m., Benjamin Mahler wrote: > > Ship It! > > Guangya Liu wrote: > Do you have any comments on the test result? Shall we use a small range > to reduce the time of this? The `contains` for a boundry case is using 38+s. > > ``` > [ RUN ] >

Re: Review Request 51033: Added validation benchmark test for resources.

> On 十月 19, 2016, 6:35 a.m., Guangya Liu wrote: > > After sort the `ranges` in `validate`, the elapse time was reduced from > > `25+s` to `26992us`. > > > > ``` > > [ RUN ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/2 > > Took 26992us to perform 1 'validate(r)'

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

> On 十月 21, 2016, 8:23 p.m., Benjamin Mahler wrote: > > Ship It! > > Guangya Liu wrote: > Do you have any comments on the test result? Shall we use a small range > to reduce the time of this? The `contains` for a boundry case is using 38+s. > > ``` > [ RUN ] >

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

> On Oct. 21, 2016, 8:23 p.m., Benjamin Mahler wrote: > > Ship It! > > Guangya Liu wrote: > Do you have any comments on the test result? Shall we use a small range > to reduce the time of this? The `contains` for a boundry case is using 38+s. > > ``` > [ RUN ] >

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/executor.cpp, lines 854-855 > > > > > > If rephrase to > > > > ``` > > The directory's absolute path of Mesos binaries > > ``` >

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 22, 2016, 4:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 22, 2016, 4:18 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53083: Made `cgroups::create` create cgroup recursively as default behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53083/ --- (Updated Oct. 22, 2016, 4:20 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Oct. 22, 2016, 4:24 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51265: Allowed clean up unknown containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51265/ --- (Updated Oct. 22, 2016, 4:23 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153632 --- src/slave/containerizer/docker.hpp (line 259)

Re: Review Request 53016: Added test case for ranges value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53016/ --- (Updated 十月 22, 2016, 3:27 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53082/ --- (Updated Oct. 22, 2016, 4:18 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- (Updated Oct. 22, 2016, 4:18 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Oct. 22, 2016, 4:25 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review153521 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines

Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/#review153634 --- src/v1/parse.hpp (line 47)

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53062/#review153635 --- Fix it, then Ship it!

Re: Review Request 52735: Removed TODO message for docker killing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated 十月 21, 2016, 6:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 21, 2016, 6:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 21, 2016, 6:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十月 21, 2016, 6:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十月 21, 2016, 6:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 21, 2016, 6:27 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 21, 2016, 6:28 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 21, 2016, 6:28 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52786: Add the health check test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153520 --- I applied this patch on top of master and the tests don't compile

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153541 --- Patch looks great! Reviews applied: [53047] Passed command:

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/executor.cpp, lines 854-855 > > > > > > If rephrase to > > > > ``` > > The directory's absolute path of Mesos binaries > > ``` >

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- (Updated Oct. 21, 2016, 5:29 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53042: Added `FsTest.Xattr` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53042/ --- (Updated Oct. 21, 2016, 5:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 21, 2016, 8:58 a.m., haosdent huang wrote: > > src/slave/containerizer/docker.cpp, line 62 > > > > > > Nit: We sort the headers according some rules which `stout` come first. > > Please move this after >

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 21, 2016, 9:34 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 52818: Ensured agent is recovered in SlaveEndpointTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52818/#review153519 --- Patch looks great! Reviews applied: [52818] Passed command:

Re: Review Request 53053: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

> On Oct. 21, 2016, 1:04 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, lines 361-382 > > > > > > If I understand this correctly, for directories AUFS relies on the >

Re: Review Request 53053: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

> On Oct. 20, 2016, 11:41 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 342 > > > > > > Is it possible to move this code to `stout`? Something on the lines of >

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 21, 2016, 8:24 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 21, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 21, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 53053: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53053/ --- (Updated Oct. 21, 2016, 5:39 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 21, 2016, 8:41 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153513 --- The patch looks pretty good. For the test case part, it should be

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153506 --- Fix it, then Ship it! Ship It!

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

> On Oct. 20, 2016, 1:33 p.m., Jie Yu wrote: > > src/linux/cgroups.hpp, line 227 > > > > > > I would suggest we set default to true to match the previous semantics. > > haosdent huang wrote: > Since

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

> On Oct. 20, 2016, 1:50 p.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 412 > > > > > > Who remove the cgroup created above? > > Jiang Yan Xu wrote: > Hmm, the intention is to have

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

> On Oct. 20, 2016, 8:33 p.m., Jie Yu wrote: > > src/linux/cgroups.hpp, line 227 > > > > > > I would suggest we set default to true to match the previous semantics. > > haosdent huang wrote: > Since

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 20, 2016, 9:55 a.m., haosdent huang wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 1501 > > > > > > This test case would not go through `parse()` method. Since we only use > >

Re: Review Request 52818: Ensured agent is recovered in SlaveEndpointTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52818/ --- (Updated Oct. 21, 2016, 11:01 a.m.) Review request for mesos and Anand

  1   2   >