Re: Review Request 64232: Add a temporary filter for overlay backend related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64232/ --- (Updated Dec. 1, 2017, 10:17 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 64264: Added excluded image parameter to containerizer pruneImages().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64264/#review192616 --- Fix it, then Ship it!

Re: Review Request 64266: Added an optional agent flag '--image_gc_config'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64266/#review192618 --- Fix it, then Ship it! docs/configuration/agent.md Lines 882

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64265/#review192619 --- Fix it, then Ship it! src/messages/flags.proto Lines 112-114

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 1, 2017, 6:46 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/ --- (Updated Dec. 1, 2017, 6:44 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63765/ --- (Updated Dec. 1, 2017, 8:47 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 64065: Allowed resubscription of resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64065/ --- (Updated Dec. 1, 2017, 9:45 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60891/#review192455 --- This patch didn't add tests in

Re: Review Request 64232: Add a temporary filter for overlay backend related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64232/#review192527 --- src/tests/environment.cpp Lines 599 (patched)

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Dec. 1, 2017, 6:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 1, 2017, 6:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64252: Convert resource format of messages entering master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64252/#review192529 --- Fix it, then Ship it! src/master/master.cpp Lines 6048

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review192539 --- src/tests/master_tests.cpp Line 2758 (original), 2785 (patched)

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review192528 --- src/status_update_manager/status_update_manager_process.hpp

Review Request 64255: Removed `os/realpath.hpp` from `posix/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64255/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 64257: Included `stout/os/realpath.hpp` where `os::realpath()` is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64257/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 64256: Included `stout/os/realpath.hpp` where `os::realpath()` is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64256/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 64258: Included `stout/os/permissions.hpp` for the secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64258/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 64252: Convert resource format of messages entering master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64252/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/ --- (Updated Dec. 1, 2017, 6:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/ --- (Updated Dec. 1, 2017, 6:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Dec. 1, 2017, 6:37 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192530 --- Fix it, then Ship it! src/master/registry_operations.cpp Line

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

> On Dec. 1, 2017, 12:24 p.m., Benjamin Bannier wrote: > > include/mesos/allocator/allocator.hpp > > Lines 211-212 (patched) > > > > > > This doesn't look what was in the original design where a framework > > could

Re: Review Request 64232: Add a temporary filter for overlay backend related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64232/#review192533 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review192513 --- Fix it, then Ship it! src/common/type_utils.cpp Lines 746

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192534 --- Lets split this review into 2 1) `updateSlave()` should take

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192535 --- src/master/master.cpp Lines 6923-6927 (original), 6894-6898

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/#review192536 --- Ship it! Ship It! - Vinod Kone On Dec. 1, 2017, 6:32 p.m.,

Re: Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192531 --- docs/task-state-reasons.md Lines 370-372 (patched)

Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review192538 --- src/resource_provider/storage/provider.cpp Lines 173 (patched)

Re: Review Request 63632: Migrated to event consumer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63632/#review192515 --- Fix it, then Ship it! src/master/master.hpp Line 548

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192519 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 64232: Add a temporary filter for overlay backend related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64232/ --- (Updated Dec. 1, 2017, 1:01 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/ --- (Updated Dec. 1, 2017, 9:06 p.m.) Review request for mesos, Ilya Pronin, James

Re: Review Request 64065: Allowed resubscription of resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64065/#review192464 --- Fix it, then Ship it! Thanks Jan! Will fix minor style nits

Re: Review Request 64238: Updated the allocator to track allocations via a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64238/#review192483 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review192473 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 64065: Allowed resubscription of resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64065/#review192475 --- FAIL: Mesos libprocess-tests failed to build Failed command:

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192477 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/#review192485 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64195/#review192484 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64158: Used helper functions instead of switches for resource extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64158/#review192462 --- Fix it, then Ship it! Thanks Jan! Will fix minor style nits

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review192472 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

> On Dec. 1, 2017, 1:30 a.m., Alexander Rojas wrote: > > This patch didn't add tests in > > [authorization_tests.cpp](https://github.com/apache/mesos/blob/master/src/tests/authorization_tests.cpp) Yeah, I have the tests up for review separately: https://reviews.apache.org/r/63828/ (which

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192478 --- include/mesos/allocator/allocator.hpp Lines 211-212 (patched)

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

> On Nov. 21, 2017, 5:53 p.m., Alexander Rukletsov wrote: > > src/tests/scheduler_tests.cpp > > Lines 1515-1516 (original), 1534-1535 (patched) > > > > > > `.WillRepeatedly(Return());` > > Jiang Yan Xu wrote: >

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

> On Nov. 21, 2017, 6:27 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 430-437 (original), 431-438 (patched) > > > > > > Do we need a lambda here? > > Jiang Yan Xu

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/#review192497 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/#review192498 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/#review192506 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 28, 2017,

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63830/#review192505 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 21, 2017,

Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.

Review Request 64248: Added `cpp17::invoke` in .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64248/ --- Review request for mesos and Dmitry Zhuk. Repository: mesos Description

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

> On Nov. 21, 2017, 6:04 p.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 203-204 (patched) > > > > > > I believe we prefer writing `CopyFrom()` explicitly, no? > > Jiang Yan Xu wrote: >

Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/ --- Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu.

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/#review192503 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 28, 2017,

Re: Review Request 63636: Added placeholder implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63636/#review192518 --- Fix it, then Ship it! 3rdparty/stout/include/stout/lambda.hpp

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192381 --- src/CMakeLists.txt Lines 487 (patched)

Re: Review Request 63630: Added support for callable once functors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63630/#review192510 --- Fix it, then Ship it! 3rdparty/stout/include/stout/lambda.hpp

Re: Review Request 64248: Added `cpp17::invoke` in .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64248/#review192508 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 63631: Separated event visiting and consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63631/#review192512 --- Fix it, then Ship it! The `ProcessBase` and `EventVisitor`

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos libprocess-tests failed to build > > > > Reviews applied: `['63859', '63860', '63861', '63862']` > > > > Failed command: `cmake.exe --build . --target libprocess-tests --config > > Debug` > > > > All the build

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192525 ---

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/#review192559 --- src/tests/health_check_tests.cpp Line 565 (original), 565

Re: Review Request 64103: Changed dependency of curl to libcurl for stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64103/#review192561 --- Ship it! Ship It! - Akash Gupta On Nov. 30, 2017, 5:18

Re: Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/#review192560 --- Ship it! Ship It! - Akash Gupta On Nov. 30, 2017, 5:18

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Dec. 1, 2017, 1:47 a.m., Jie Yu wrote: > > src/docker/docker.cpp > > Lines 742-743 (original), 742-752 (patched) > > > > > > It's weird that user specifies HOST in the API, but we use "nat" > > instead. > >

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63765/#review191665 --- src/tests/scheduler_driver_tests.cpp Lines 107 (patched)

Re: Review Request 64256: Included `stout/os/realpath.hpp` where `os::realpath()` is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64256/#review192570 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 8:11 p.m.,

Re: Review Request 64255: Removed `os/realpath.hpp` from `posix/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64255/#review192569 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 8:10 p.m.,

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

> On Dec. 1, 2017, 2:14 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/windows.hpp > > Lines 343-348 (original), 343-348 (patched) > > > > > > :/ I'd really like to fix whatever code is using

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review192544 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 64250: Added new reasons task status update.

> On Dec. 1, 2017, 1:55 p.m., Ilya Pronin wrote: > > docs/task-state-reasons.md > > Lines 474-477 (patched) > > > > > > I don't quite follow this note. A modified copy of which update? Should > > we just say that

Re: Review Request 64250: Added new reasons task status update.

> On Dec. 1, 2017, 1:55 p.m., Ilya Pronin wrote: > > docs/task-state-reasons.md > > Lines 474-477 (patched) > > > > > > I don't quite follow this note. A modified copy of which update? Should > > we just say that

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/#review192554 --- src/messages/messages.cpp Lines 132 (patched)

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192557 --- src/master/master.cpp Line 6808 (original), 6808 (patched)

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 1, 2017, 9:29 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Line 6808 (original), 6808 (patched) > > > > > > When considering the comment by Ilya in MESOS-6406 (i.e., what if > > agents GCed

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 62 (patched) > > > > > > We should probably comment as to why this doesn't use PowerShell > >

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Dec. 1, 2017, 1:47 a.m., Jie Yu wrote: > > src/docker/docker.cpp > > Lines 742-743 (original), 742-752 (patched) > > > > > > It's weird that user specifies HOST in the API, but we use "nat" > > instead. > >

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

> On Nov. 21, 2017, 9:53 a.m., Alexander Rukletsov wrote: > > src/tests/scheduler_tests.cpp > > Lines 1515-1516 (original), 1534-1535 (patched) > > > > > > `.WillRepeatedly(Return());` > > Jiang Yan Xu wrote: >

Re: Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192563 --- Fix it, then Ship it! docs/task-state-reasons.md Lines 476

Re: Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192567 --- Looks good. I just have a small suggestion about the doc.

Re: Review Request 64257: Included `stout/os/realpath.hpp` where `os::realpath()` is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64257/#review192571 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 8:11 p.m.,

Re: Review Request 64258: Included `stout/os/permissions.hpp` for the secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64258/#review192572 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 8:13 p.m.,

Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review192576 --- src/resource_provider/storage/provider.cpp Lines 188 (patched)

Re: Review Request 64044: Recover controller and node services and clean up unused containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64044/#review192537 --- Fix it, then Ship it!

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/#review192583 --- src/master/master.cpp Lines 7500-7502 (patched)

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

> On Nov. 21, 2017, 10:27 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 430-437 (original), 431-438 (patched) > > > > > > Do we need a lambda here? > > Jiang Yan Xu

Re: Review Request 64272: Improved Windows isolators with `struct Info` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64272/ --- (Updated Dec. 1, 2017, 3:37 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/ --- (Updated Dec. 1, 2017, 11:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

> On Dec. 1, 2017, 1:16 a.m., Michael Park wrote: > > src/tests/slave_tests.cpp > > Line 860 (original), 860 (patched) > > > > > > Huh... so these used to be an empty string? These used to be `"*"` (the default for

Re: Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192600 --- Ship it! Ship It! - Ilya Pronin On Dec. 1, 2017, 1:06 p.m.,

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 2, 2017, 12:12 a.m.) Review request for mesos, Ilya Pronin,

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos libprocess-tests failed to build > > > > Reviews applied: `['63859', '63860', '63861', '63862']` > > > > Failed command: `cmake.exe --build . --target libprocess-tests --config > > Debug` > > > > All the build

Re: Review Request 64075: Added the `ResourceProviderState` protobuf for resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64075/#review192578 --- Fix it, then Ship it!

Re: Review Request 64075: Added the `ResourceProviderState` protobuf for resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64075/#review192590 --- Fix it, then Ship it! src/Makefile.am Lines 935 (patched)

Re: Review Request 64250: Added new reasons task status update.

> On Dec. 1, 2017, 9:55 p.m., Ilya Pronin wrote: > > docs/task-state-reasons.md > > Lines 474-477 (patched) > > > > > > I don't quite follow this note. A modified copy of which update? Should > > we just say that

Review Request 64272: Improved Windows isolators with `struct Info` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64272/ --- Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Repository:

  1   2   >