Re: Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64428/ --- (Updated Dec. 7, 2017, 8:46 p.m.) Review request for mesos, Dmitry Zhuk and

Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64422/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 63861: Windows: Updated networking doc.

> On Dec. 7, 2017, 9:41 p.m., Andrew Schwartzmeyer wrote: > > docs/networking.md > > Lines 120 (patched) > > > > > > nit: s/is/are fixed - Akash --- This

Re: Review Request 63861: Windows: Updated networking doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/ --- (Updated Dec. 7, 2017, 10:05 p.m.) Review request for mesos, Andrew

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review193181 --- src/tests/health_check_tests.cpp Lines 102-111 (patched)

Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64428/ --- Review request for mesos, Dmitry Zhuk and Michael Park. Repository: mesos

Review Request 64425: Fixed 'getResourceProviderId' for operations without resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64425/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 63901: WIP: Added operator API to update and remove resource provider configs.

> On Nov. 17, 2017, 5:37 p.m., Jie Yu wrote: > > include/mesos/agent/agent.proto > > Lines 82 (patched) > > > > > > I'd remove the `_CONFIG` suffix. Using a config file is really a > > internal impl. details. I'll

Review Request 64436: Toggled the authenticate_http_readwrite flag in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64436/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review193173 --- src/docker/docker.cpp Lines 741-744 (original), 747-782

Re: Review Request 64352: Added default VolumeProfile module implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64352/ --- (Updated Dec. 7, 2017, 2:08 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- (Updated Dec. 7, 2017, 2:08 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64428/#review193167 --- src/master/master.hpp Line 713 (original), 713 (patched)

Re: Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64428/#review193184 --- Fix it, then Ship it! src/master/master.cpp Lines 6675-6684

Re: Review Request 64398: Renamed the resource provider PUBLISH event to PUBLISH_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64398/ --- (Updated Dec. 7, 2017, 10:20 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63555: Publish resource provider resources before container launch or update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/#review193194 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

> On Nov. 16, 2017, 11:08 p.m., Michael Park wrote: > > src/tests/fetcher_tests.cpp > > Line 469 (original), 473 (patched) > > > > > > These would ideally be a `url::join(...)`, right? > > I think for now we

Review Request 64437: Added missing filesystem isolation for SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64437/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 64427: Added a RepeatedPtrField to vector conversion overload for rvalues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64427/#review193182 --- Ship it! Ship It! - Dmitry Zhuk On Dec. 7, 2017, 8:55 p.m.,

Re: Review Request 64398: Renamed the resource provider PUBLISH event to PUBLISH_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64398/#review193185 --- Ship it! Ship It! - Jie Yu On Dec. 7, 2017, 10:20 p.m.,

Re: Review Request 64351: Moved generated CSI code into public directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64351/ --- (Updated Dec. 7, 2017, 3:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63555: Publish resource provider resources before container launch or update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/#review193187 --- Ship it! Ship It! - Jie Yu On Dec. 7, 2017, 9:33 a.m.,

Re: Review Request 64425: Fixed 'getResourceProviderId' for operations without resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64425/ --- (Updated Dec. 8, 2017, 1:17 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

> On Dec. 7, 2017, 7:47 p.m., Jie Yu wrote: > > src/messages/messages.proto > > Line 714 (original), 714 (patched) > > > > > > Should we change this to > > `optional bytes resource_version_uuid`? > > Benjamin

Re: Review Request 64423: Explicitly passed resource-provider information in UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64423/ --- (Updated Dec. 8, 2017, 1:17 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

> On Dec. 7, 2017, 7:37 p.m., Jie Yu wrote: > > src/messages/messages.proto > > Lines 720-721 (patched) > > > > > > any reason those are optional? They are required now. - Benjamin

Re: Review Request 64423: Explicitly passed resource-provider information in UpdateSlaveMessage.

> On Dec. 7, 2017, 8:15 p.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7204-7207 (original), 7223-7226 (patched) > > > > > > This probably need some adjustment given that message.offer_operations > > will

Re: Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64422/ --- (Updated Dec. 8, 2017, 1:17 a.m.) Review request for mesos, Jie Yu and Jan

Review Request 64430: Only passed agent's resource version in top-level UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8312

Re: Review Request 64351: Moved generated CSI code into public directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64351/ --- (Updated Dec. 7, 2017, 4:16 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64424/ --- (Updated Dec. 8, 2017, 1:17 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

> On Nov. 16, 2017, 11:08 p.m., Michael Park wrote: > > src/tests/fetcher_tests.cpp > > Line 469 (original), 473 (patched) > > > > > > These would ideally be a `url::join(...)`, right? > > I think for now we

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review193177 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 64429: Fixed skipping of completed frameworks in the master failover benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64429/#review193192 --- Ship it! Ship It! - Jiang Yan Xu On Dec. 7, 2017, 2:33

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193189 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

> On Dec. 7, 2017, 10:33 p.m., Michael Park wrote: > > src/master/master.cpp > > Lines 6675-6684 (original) > > > > > > It looks like we still do all of these (via move) except `tasks`. I > > would've expected to

Review Request 64431: Updated Windows documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64431/ --- Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu. Repository:

Re: Review Request 64312: Added reservation refinement documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64312/#review193200 --- Fix it, then Ship it! docs/reservation.md Lines 104 (patched)

Re: Review Request 64425: Fixed 'getResourceProviderId' for operations without resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64425/#review193206 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 62 (patched) > > > > > > We should probably comment as to why this doesn't use PowerShell > >

Re: Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

> On Dec. 7, 2017, 8:37 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Line 9480 (original), 9495 (patched) > > > > > > Should I just take a copy here to avoid forcing the caller to provide > > an

Re: Review Request 64427: Added a RepeatedPtrField to vector conversion overload for rvalues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64427/#review193183 --- Ship it! Ship It! - Michael Park On Dec. 7, 2017, 12:55

Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64400/ --- (Updated Dec. 7, 2017, 10:23 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 64432: Windows: Enabled remaining `FlagsTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64432/ --- Review request for mesos, Akash Gupta and Joseph Wu. Bugs: MESOS-3437

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193141 --- src/master/master.cpp Lines 6806-6810 (patched)

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/#review193180 --- Ship it! Ship It! - Jie Yu On Dec. 7, 2017, 6:38 p.m.,

Re: Review Request 64428: Eliminated some copying of tasks / executors in agent re-registration.

> On Dec. 7, 2017, 10:15 p.m., Dmitry Zhuk wrote: > > src/master/master.hpp > > Line 713 (original), 713 (patched) > > > > > > shall we keep a default value? I can update this to take an rvalue reference, at which

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review193172 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 64357: Updated the allocator to untrack allocations via a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64357/#review193169 --- Fix it, then Ship it!

Re: Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64399/ --- (Updated Dec. 7, 2017, 10:21 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 64429: Fixed skipping of completed frameworks in the master failover benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64429/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 64351: Moved generated CSI code into public directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64351/ --- (Updated Dec. 7, 2017, 2:17 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64298: Added ResourceVersion to RunTask and RunTaskGroup messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64298/#review193131 --- Ship it! Ship It! - Jie Yu On Dec. 4, 2017, 1:12 p.m.,

Re: Review Request 63861: Windows: Updated networking doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/#review193174 --- docs/networking.md Lines 120 (patched)

Re: Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64422/#review193148 --- src/messages/messages.proto Line 714 (original), 714 (patched)

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/ --- (Updated Dec. 7, 2017, 10:47 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

> On Nov. 16, 2017, 11:34 p.m., Jie Yu wrote: > > src/hdfs/hdfs.cpp > > Line 119 (original), 119 (patched) > > > > > > i'd kill this line to be consistent with others. I don't think you're looking at the latest

Re: Review Request 64423: Explicitly passed resource-provider information in UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64423/#review193218 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 12:17 a.m.,

Re: Review Request 64430: Only passed agent's resource version in top-level UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/#review193219 --- Let's also follow up with the change to remove

Re: Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64424/#review193217 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 12:17 a.m.,

Re: Review Request 64430: Only passed agent's resource version in top-level UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/#review193216 --- Fix it, then Ship it! src/master/master.cpp Line 7193

Re: Review Request 64437: Added missing filesystem isolation for SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64437/ --- (Updated Dec. 8, 2017, 5:54 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Dec. 8, 2017, 2:40 a.m.) Review request for mesos, Andrew

Review Request 64440: Added `MODIFY_RESOURCE_PROVIDER_CONFIG` authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64440/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-8244

Re: Review Request 63901: Added operator API to update and remove resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/#review193221 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 2:56 a.m.,

Re: Review Request 64437: Added missing filesystem isolation for SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64437/#review193220 --- Please make sure the test file only build on linux. - Jie Yu

Re: Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64399/ --- (Updated Dec. 8, 2017, 7:10 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64400/ --- (Updated Dec. 8, 2017, 7:11 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64398: Renamed the resource provider PUBLISH event to PUBLISH_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64398/ --- (Updated Dec. 8, 2017, 7:10 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/ --- (Updated Dec. 8, 2017, 2:46 a.m.) Review request for mesos, Andrew

Review Request 64434: Windows: Fixed `os::stat::size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64434/ --- Review request for mesos, Akash Gupta and Joseph Wu. Bugs: MESOS-5939

Re: Review Request 64440: Added `MODIFY_RESOURCE_PROVIDER_CONFIG` authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64440/#review193222 --- please add some unit test - Jie Yu On Dec. 8, 2017, 3:59 a.m.,

Re: Review Request 64299: Passed versions when launching tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64299/#review193226 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Nov. 16, 2017, 5:50 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 45 (patched) > > > > > > The backslash at the end check seems a bit odd. Doesn't `isdir` return > >

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

> On Nov. 16, 2017, 3:08 p.m., Michael Park wrote: > > src/tests/fetcher_tests.cpp > > Line 469 (original), 473 (patched) > > > > > > These would ideally be a `url::join(...)`, right? > > I think for now we just

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Dec. 8, 2017, 2:41 a.m.) Review request for mesos, Andrew

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review193204 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review193214 --- Some nits below. I can fix these while committing.

Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64400/ --- (Updated Dec. 8, 2017, 7:19 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ --- (Updated Dec. 8, 2017, 2:45 a.m.) Review request for mesos, Andrew

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

> On Nov. 16, 2017, 11:08 p.m., Michael Park wrote: > > src/tests/fetcher_tests.cpp > > Line 469 (original), 473 (patched) > > > > > > These would ideally be a `url::join(...)`, right? > > I think for now we

Re: Review Request 64425: Fixed 'getResourceProviderId' for operations without resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64425/#review193205 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 12:17 a.m.,

Re: Review Request 60622: Added new stout functions for path and URI conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Dec. 8, 2017, 2:43 a.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Dec. 8, 2017, 2:44 a.m.) Review request for mesos, Andrew

Re: Review Request 60622: Added new stout functions for path and URI conversions.

> On Nov. 16, 2017, 6:08 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/uri.hpp > > Lines 19 (patched) > > > > > > This looks like an accidental include? Yup, good catch, thanks. > On Nov. 16, 2017,

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Dec. 8, 2017, 2:43 a.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Dec. 8, 2017, 2:44 a.m.) Review request for mesos, Andrew

Re: Review Request 63901: Added operator API to update and remove resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/ --- (Updated Dec. 8, 2017, 2:56 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64439/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Review Request 64438: Implemented API for modifying resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64438/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Review Request 64441: Removed a CHECK that should not be there in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64441/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 64299: Passed versions when launching tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64299/#review193203 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 9203

Re: Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64422/#review193215 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 12:17 a.m.,

Re: Review Request 63390: Unit tests for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/ --- (Updated Dec. 7, 2017, 8:48 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64427: Added a RepeatedPtrField to vector conversion overload for rvalues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64427/ --- (Updated Dec. 7, 2017, 8:55 p.m.) Review request for mesos, Dmitry Zhuk and

Re: Review Request 64416: Moved tasks from completed frameworks during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64416/#review193154 --- I also have a patch I was going to send out to eliminate these

Re: Review Request 64427: Added a RepeatedPtrField to vector conversion overload for rvalues.

> On Dec. 7, 2017, 8:44 p.m., Dmitry Zhuk wrote: > > 3rdparty/libprocess/include/process/protobuf.hpp > > Lines 92 (patched) > > > > > > maybe use `std::make_move_iterator`? Ah much nicer, thanks! - Benjamin

Re: Review Request 64151: Added a V1 API call to list resource providers.

> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote: > > src/resource_provider/manager.hpp > > Lines 28 (patched) > > > > > > Unused? The latest rebase no longer changes ResourceProviderManager. Dropping. > On

Re: Review Request 64370: Provided resource providere infos in 'UPDATE_STATE' message.

> On Dec. 6, 2017, 11:27 a.m., Benjamin Bannier wrote: > > src/resource_provider/message.hpp > > Line 79 (original), 79 (patched) > > > > > > Why don't we just output the info? This would add a lot of verbosity in

Re: Review Request 64370: Provided resource provider infos in 'UpdateState' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64370/ --- (Updated Dec. 7, 2017, 4:52 p.m.) Review request for mesos, Benjamin Bannier

  1   2   >