Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/#review202415 --- PASS: Mesos patch 66924 was successfully built and tested.

Re: Review Request 66923: Added documentation on volume resize support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202341 --- Patch looks great! Reviews applied: [66218, 66049, 66733, 66050,

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202342 --- PASS: Mesos patch 66920 was successfully built and tested.

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202346 --- Patch looks great! Reviews applied: [66218, 66049, 66733, 66050,

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/#review202351 --- Patch looks great! Reviews applied: [66931] Passed command:

Re: Review Request 66849: Added missing test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66849/#review202367 --- Ship it! Ship It! - Gaston Kleiman On April 27, 2018, 3:15

Re: Review Request 66849: Added missing test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66849/#review202365 --- Ship it! Ship It! - Greg Mann On April 27, 2018, 10:15

Re: Review Request 66923: Added documentation on volume resize support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202364 --- docs/operator-http-api.md Lines 1987-1990 (patched)

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/#review202348 --- Ship it! src/tests/resource_provider_manager_tests.cpp Lines

Re: Review Request 66934: Removed credential-based authentication of 'MockResourceProvider'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202352 --- PASS: Mesos patch 66934 was successfully built and tested.

Re: Review Request 65572: Fixed two slave recovery tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65572/#review202376 --- Should this be marked as committed? - Benjamin Mahler On Feb.

Re: Review Request 66893: Documented the changes in gRPC and CSI supports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66893/#review202375 --- Ship it! Ship It! - Greg Mann On May 1, 2018, 9:47 p.m.,

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/ --- (Updated May 3, 2018, 8:55 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 66896: Updated `csi.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66896/#review202378 --- Ship it! Ship It! - Greg Mann On May 1, 2018, 9:45 p.m.,

Re: Review Request 66894: Fixed typos in `upgrades.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66894/#review202377 --- Ship it! Thanks for the cleanup!! :) - Greg Mann On May 1,

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202355 --- src/tests/persistent_volume_tests.cpp Lines 604 (patched)

Re: Review Request 66920: Improved tests for resizing persistent volumes.

> On May 3, 2018, 3:51 p.m., Zhitao Li wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 604 (patched) > > > > > > Technically we only tested that persistent volume and its data can > > still be accessed.

Re: Review Request 66934: Removed credential-based authentication of 'MockResourceProvider'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202359 --- Patch looks great! Reviews applied: [66932, 66933, 66934]

Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/#review202361 --- Fix it, then Ship it! LGTM! Benjamin, do you think you could

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202388 --- src/sched/sched.cpp Lines 1349-1352 (patched)

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/#review202383 --- Ship it! 3rdparty/stout/include/stout/strings.hpp Lines 390

Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jan Schlicht, and

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202387 --- PASS: Mesos patch 66920 was successfully built and tested.

Review Request 66940: Documented the changes in the agent flags and modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66940/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Repository:

Re: Review Request 65572: Fixed two slave recovery tests.

> On May 3, 2018, 8:56 p.m., Benjamin Mahler wrote: > > Should this be marked as committed? Let me do it since I just saw this lol - Chun-Hung --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

> On May 2, 2018, 11:51 a.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 1289 (patched) > > > > > > I don't think we need this but it doesn't hurt. I'll leave it up to you > > to

Review Request 66939: Improved validation messages for some operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/ --- Review request for mesos, Greg Mann and Jan Schlicht. Repository: mesos

Re: Review Request 66939: Improved validation messages for some operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/#review202390 --- Fix it, then Ship it! src/master/validation.cpp Line 2368

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

> On May 3, 2018, 10:25 p.m., Gaston Kleiman wrote: > > src/sched/sched.cpp > > Lines 1349-1352 (patched) > > > > > > We should call `error()` here so that the framework is gracefully > > teared down instead of

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/ --- (Updated May 3, 2018, 11:14 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202392 --- Patch looks great! Reviews applied: [66218, 66049, 66733, 66050,

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202393 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 66860: Avoid copying of register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66860/ --- (Updated May 3, 2018, 5:58 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202394 --- PASS: Mesos patch 66938 was successfully built and tested.

Re: Review Request 66939: Improved validation messages for some operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/ --- (Updated May 3, 2018, 4:54 p.m.) Review request for mesos, Greg Mann and Jan

Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Bugs: MESOS-8784

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/ --- (Updated May 4, 2018, 12:02 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 66939: Improved validation messages for some operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/#review202399 --- PASS: Mesos patch 66939 was successfully built and tested.

Re: Review Request 66940: Documented the changes in the agent flags and modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66940/#review202400 --- Patch looks great! Reviews applied: [66893, 66894, 66896, 66940]

Re: Review Request 66900: Avoid copying of re-register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66900/#review202405 --- PASS: Mesos patch 66900 was successfully built and tested.

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202404 --- PASS: Mesos patch 66920 was successfully built and tested.

Review Request 66933: Added a flag for resource provider authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66933/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Bugs:

Review Request 66934: Removed credential-based authentication of 'MockResourceProvider'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Bugs:

Review Request 66931: Fixed a race in resource provider resubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8874

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/#review202347 --- PASS: Mesos patch 66931 was successfully built and tested.

Review Request 66932: Adden token based authentication for resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66932/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Bugs:

Re: Review Request 66749: Added more logging to agent recovery path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/#review202410 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

> On May 3, 2018, 1:52 p.m., Jan Schlicht wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1130-1131 (patched) > > > > > > Nit: `disconnected` is called asynchronously. The `Clock::settle()` > >

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202413 --- Ship it! Ship It! - Gaston Kleiman On May 3, 2018, 4:14

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202412 --- Patch looks great! Reviews applied: [66938] Passed command:

Re: Review Request 66749: Added more logging to agent recovery path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/ --- (Updated May 3, 2018, 8:52 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/#review202409 --- src/tests/resource_provider_manager_tests.cpp Lines 1132

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review202368 --- Fix it, then Ship it! I'll commit with these minor fixes.

Re: Review Request 66940: Documented the changes in the agent flags and modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66940/#review202411 --- PASS: Mesos patch 66940 was successfully built and tested.