Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/ --- (Updated Dec. 4, 2015, 3:11 p.m.) Review request for mesos, Benjamin Bannier, J

Re: Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout test duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40956/ --- (Updated Dec. 4, 2015, 6:24 a.m.) Review request for mesos and Ben Mahler. Re

Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout test duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40956/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review108945 --- Patch looks great! Reviews applied: [40375, 40379] Passed command

Re: Review Request 40954: Fix comments in TaskHealthStatus message proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40954/#review108944 --- Ship it! Ship It! - Gilbert Song On Dec. 3, 2015, 9:44 p.m., Ti

Review Request 40954: Fix comments in TaskHealthStatus message proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40954/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 40953: Avoid accepting hex float literals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40953/ --- Review request for mesos, Benjamin Bannier, Ben Mahler, Jie Yu, and Michael Park

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Dec. 4, 2015, 1:17 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review108937 --- src/tests/fetcher_tests.cpp (lines 285 - 289)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review108936 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 39940: Globally ignore SIGPIPE in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39940/#review108929 --- Ship it! Thanks James, nice work. Could we also have this decisio

Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop handling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39941/#review108933 --- Ship it! Looks great, thanks! src/tests/main.cpp (line 19)

Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- Review request for mesos. Repository: mesos Description --- Initial set

Re: Review Request 40946: Made HDFS::du asynchrounous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40946/#review108930 --- Patch looks great! Reviews applied: [40941, 40806, 40942, 40943, 4

Re: Review Request 39597: Add Newbie guide.

> On Nov. 21, 2015, 1:05 a.m., Timothy Chen wrote: > > Diana are you still able to finish the comments? Hey Tim, Yes, I'll finish them up. - Diana --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/ --- (Updated Dec. 3, 2015, 5:40 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review108925 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 3, 2015, 9:10

Review Request 40946: Made HDFS::du asynchrounous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40946/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs: MES

Re: Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40935/#review108911 --- Ship it! Tested on Centos7. There still appears to be some flakin

Review Request 40945: Made HDFS::copyToLocal asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40945/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs: MES

Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/ --- Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen. R

Review Request 40943: Made HDFS::copyFromLocal asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40943/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs: MES

Review Request 40942: Made HDFS::rm asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40942/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs: MES

Re: Review Request 40806: Made HDFS::exists asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/ --- (Updated Dec. 4, 2015, 12:45 a.m.) Review request for mesos, Bernd Mathiske, Be

Re: Review Request 40941: Added a helper for HDFS client to shell out commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40941/ --- (Updated Dec. 4, 2015, 12:45 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.

> On Dec. 4, 2015, 12:24 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [40935] > > > > Failed command: export OS=ubuntu:14.04;export > > CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh > > > > Error: > > + : ubuntu:14.04 > > + : gcc > > + : --v

Re: Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40935/#review108918 --- Bad patch! Reviews applied: [40935] Failed command: export OS=ubu

Re: Review Request 40941: Added a helper for HDFS client to shell out commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40941/#review108916 --- Ship it! src/hdfs/hdfs.cpp (line 52)

Re: Review Request 40806: Made HDFS::exists asynchronous.

> On Dec. 1, 2015, 10:40 a.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.cpp, line 100 > > > > > > This block seems to be reusable in a lot of situations. Any chance we > > could abstract it and make it part of class

Re: Review Request 40806: Made HDFS::exists asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/ --- (Updated Dec. 4, 2015, 12:20 a.m.) Review request for mesos, Bernd Mathiske, Be

Re: Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40935/ --- (Updated Dec. 4, 2015, 12:17 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 40806: Made HDFS::exists asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/ --- (Updated Dec. 4, 2015, 12:09 a.m.) Review request for mesos, Bernd Mathiske, Be

Re: Review Request 40806: Made HDFS::exists asynchronous.

> On Dec. 3, 2015, 10:42 p.m., Vinod Kone wrote: > > i'm assuming there are already tests that verify this change? just checked. Not every function. I'll add tests in the subsequent reviews. - Jie --- This is an automatically generated

Review Request 40941: Added a helper for HDFS client to shell out commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40941/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 40559: Added a wait() function to Subprocess.

> On Dec. 3, 2015, 10:34 p.m., Vinod Kone wrote: > > Ship It! There's some controversy regarding this patch. I'll move this logic to hdfs.cpp as a helper. Discard this patch for now. Will send a new one shortly. - Jie --- This is an au

Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40935/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-4059

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/ --- (Updated Dec. 3, 2015, 11:37 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review108903 --- Ship it! Ship It! - Vinod Kone On Dec. 2, 2015, 10:41 p.m., Ana

Re: Review Request 40806: Made HDFS::exists asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108902 --- Ship it! i'm assuming there are already tests that verify this cha

Re: Review Request 40559: Added a wait() function to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/#review108898 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 9:06 p.m., Jie

Re: Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/#review108892 --- Ship it! Ship It! - Greg Mann On Dec. 3, 2015, 11:09 a.m., Bern

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108885 --- It would be a good idea to start writing tests for each of these ch

Re: Review Request 40797: Filtered non-whitelisted and deactivated agents once per allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40797/ --- (Updated Dec. 3, 2015, 9:11 p.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Dec. 3, 2015, 9:10 p.m.) Review request for mesos, Bernd Mathiske, Joe

Re: Review Request 40529: Added helper function to get stateless resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/#review108874 --- Looks good. Just a few nits. include/mesos/resources.hpp (line 1

Re: Review Request 40797: Filtered non-whitelisted and deactivated agents once per allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40797/ --- (Updated Dec. 3, 2015, 8:25 p.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 40797: Filtered non-whitelisted and deactivated agents once per allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40797/#review108875 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (lines 1086

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Dec. 3, 2015, 8:07 p.m.) Review request for mesos, Bernd Mathiske, Joe

Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/#review108873 --- Patch looks great! Reviews applied: [40849, 40880] Passed command

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 413-418 > > > > > > Rather than doing the math here (which I believe we're missing > > corresponding

Re: Review Request 40795: Quota: Properly initialized the sorter for quota'ed roles in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40795/#review108867 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 3, 2015, 7:30

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40551/#review108846 --- Ship it! Fixed in-line. src/master/allocator/mesos/hierarchical.

Re: Review Request 40795: Quota: Properly initialized the sorter for quota'ed roles in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40795/ --- (Updated Dec. 3, 2015, 7:30 p.m.) Review request for mesos, Bernd Mathiske, Joe

Re: Review Request 40849: Fix flaky MemoryPressureMesosTests

> On Dec. 3, 2015, 6:24 a.m., Bernd Mathiske wrote: > > src/tests/containerizer/memory_pressure_tests.cpp, line 140 > > > > > > Consider moving this comment to line 143, before "break;". It makes > > more sense to m

Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/ --- (Updated Dec. 3, 2015, 11:02 a.m.) Review request for mesos, Bernd Mathiske, Ar

Re: Review Request 40849: Fix flaky MemoryPressureMesosTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40849/ --- (Updated Dec. 3, 2015, 11:01 a.m.) Review request for mesos, Bernd Mathiske, Gr

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108854 --- Ship it! Ship It! - Michael Park On Dec. 3, 2015, 1:06 p.m., Be

Re: Review Request 40911: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40911/#review108855 --- Ship it! Ship It! - Michael Park On Dec. 3, 2015, 1:04 p.m., Be

Re: Review Request 40910: [stout]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40910/#review108856 --- Ship it! Ship It! - Michael Park On Dec. 3, 2015, 1:04 p.m., Be

Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review108853 --- Patch looks great! Reviews applied: [40872, 40873] Passed command

Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/ --- (Updated Dec. 3, 2015, 5:20 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review108845 --- LGTM, Just one minor suggestion + a query regarding why do we need

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

> On Dec. 3, 2015, 4:26 a.m., Michael Park wrote: > > Could you also create a clean-up patch to get rid of the unnecessary > > `struct` disambiguators in this file? > > Neil Conway wrote: > I kinda like leaving "struct" as-is, because we're interfacing with > C-style APIs where "struct" is

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/#review108840 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 24, 2015, 9:07

Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/#review108830 --- Ship it! Ship It! - Bernd Mathiske On Dec. 2, 2015, 12:44 p.m.,

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

> On Dec. 3, 2015, 12:24 p.m., Guangya Liu wrote: > > src/master/http.cpp, line 385 > > > > > > What about update to > > > > Expecting a 'POST' request, received a '" + request.method + "' request" > > Ale

Review Request 40913: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40913/ --- Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoorte

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108831 --- Ship it! Ship It! - Bernd Mathiske On Dec. 3, 2015, 6:33 a.m.,

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/ --- (Updated Dec. 3, 2015, 2:35 p.m.) Review request for mesos, Anand Mazumdar, Isa

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/ --- (Updated Dec. 3, 2015, 2:34 p.m.) Review request for mesos, Anand Mazumdar, Isa

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/ --- (Updated Dec. 3, 2015, 2:33 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

> On Dec. 3, 2015, 1:05 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, line 543 > > > > > > Since both ExtractNotExecutable and ExtractTar dio the same now one of > > these tests is redundant and can b

Re: Review Request 40849: Fix flaky MemoryPressureMesosTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40849/#review108829 --- Ship it! src/tests/containerizer/memory_pressure_tests.cpp (line

Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/#review108828 --- Ship it! Ship It! - Bernd Mathiske On Nov. 20, 2015, 11:52 a.m.

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1026 > > > > > > roleConsumedResources = roleConsumedResources.nonRevocable(); As you may know, `.nonRevocable(

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/#review108826 --- Bad patch! Reviews applied: [40905] Failed command: ./support/app

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

> On Dec. 3, 2015, 12:22 p.m., Guangya Liu wrote: > > src/master/http.cpp, line 555 > > > > > > I see that others using "Expecting a 'POST' request", this may be more > > clear > > > > Also, is it a MUST to

Re: Review Request 40905: Made `MethodNotAllowed` response compliant to RFC 2616.

> On Dec. 3, 2015, 12:24 p.m., Guangya Liu wrote: > > src/master/http.cpp, line 385 > > > > > > What about update to > > > > Expecting a 'POST' request, received a '" + request.method + "' request" Do you

Re: Review Request 40551: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40551/#review108817 --- src/master/allocator/mesos/hierarchical.cpp (line 1026)

Re: Review Request 40909: Made unary c-tors for `Unauthorized` response explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40909/#review108820 --- Patch looks great! Reviews applied: [40909] Passed command: expor

Re: Review Request 40909: Made unary c-tors for `Unauthorized` response explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40909/#review108818 --- Ship it! Ship It! - Till Toenshoff On Dec. 3, 2015, 11:42 a.m.,

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 3, 2015, 1:06 p.m.) Review request for mesos, Benjamin Hindman, M

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108816 --- src/tests/fetcher_tests.cpp (line 543)

Review Request 40911: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40911/ --- Review request for mesos and Michael Park. Bugs: MESOS-3581 https://issues.

Review Request 40910: [stout]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40910/ --- Review request for mesos and Michael Park. Bugs: MESOS-3581 https://issues.

Re: Review Request 40909: Made unary c-tors for `Unauthorized` response explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40909/#review108815 --- Ship it! Ship It! - Alexander Rojas On Dec. 3, 2015, 12:42 p.m.

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

> On 十二月 3, 2015, 12:22 p.m., Guangya Liu wrote: > > src/master/http.cpp, line 555 > > > > > > I see that others using "Expecting a 'POST' request", this may be more > > clear > > > > Also, is it a MUST to

Re: Review Request 40905: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review108813 --- src/master/http.cpp (line 385)

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/#review108811 --- src/master/http.cpp (line 555)

Re: Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/#review108810 --- Patch looks great! Reviews applied: [40767, 40903] Passed command

Review Request 40909: Made unary c-tors for `Unauthorized` response explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40909/ --- Review request for mesos, Alexander Rojas, Ben Mahler, and Till Toenshoff. Repo

Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/ --- Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoorte

Review Request 40905: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/ --- Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoorte

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

> On Nov. 30, 2015, 9:10 a.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 963-965 > > > > > > Do you know about Option's getOrElse? You can avoid these ternary > > expressions. > > > > Also the ?

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

> On Nov. 30, 2015, 9:10 a.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 963-965 > > > > > > Do you know about Option's getOrElse? You can avoid these ternary > > expressions. > > > > Also the ?

Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/ --- Review request for mesos, Alexander Rukletsov, Avinash sridharan, Ben Mahler, Gr

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108805 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 6:43 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, line 35 > > > > > > Is it fine to include files from "master/" in "common/*"? Addressed in https://reviews.apache.org/r/40767/

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review108799 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 38876, 3

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/#review108798 --- include/mesos/mesos.proto (lines 629 - 631)

  1   2   >