Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote:
> > Can you call this out specifically in the CHANGELOG (under "Binary API 
> > Changes) section.

Vinod?thanks for the review. I just resubmit the patch to rebase to the latest 
code, please take a look.
Besides, do I need to submit another patch for the CHANGELOG chagnes or I can 
inlude the CHANGELOG changes in this patch?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/#review126429
---


On 四月 1, 2016, 5:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45213/
> ---
> 
> (Updated 四月 1, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-3780
> https://issues.apache.org/jira/browse/mesos-3780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first patch to solve [MESOS-3780]
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 
>   src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f 
>   src/examples/no_executor_framework.cpp 
> 9223d954197ebd097f57efea5299c917b24fe41e 
>   src/examples/persistent_volume_framework.cpp 
> 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
>   src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
>   src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
>   src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
>   src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
>   src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
>   src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
>   src/tests/hierarchical_allocator_tests.cpp 
> 8f78a204d296f94f515f21511710a35c33e27255 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
>   src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 
> 
> Diff: https://reviews.apache.org/r/45213/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/
---

(Updated 四月 1, 2016, 5:57 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

rebase to the latest code


Bugs: mesos-3780
https://issues.apache.org/jira/browse/mesos-3780


Repository: mesos


Description
---

This is the first patch to solve [MESOS-3780]


Diffs (updated)
-

  src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 
  src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f 
  src/examples/no_executor_framework.cpp 
9223d954197ebd097f57efea5299c917b24fe41e 
  src/examples/persistent_volume_framework.cpp 
9ce43d2b7da3f03d24473ff22cb62a88004f5f53 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
  src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
  src/master/allocator/mesos/hierarchical.cpp 
5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
  src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
  src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
  src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
  src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
  src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
323c84a3d960a196d8ba87f753814e9d43a07957 
  src/slave/containerizer/mesos/launch.cpp 
dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
  src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
  src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
  src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d 
  src/slave/status_update_manager.cpp f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
  src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
  src/tests/hierarchical_allocator_tests.cpp 
8f78a204d296f94f515f21511710a35c33e27255 
  src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
  src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
  src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 

Diff: https://reviews.apache.org/r/45213/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 45360: WIP: Added dvd client for mount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/
---

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

Added dvd client for mount.


Diffs
-

  src/CMakeLists.txt 366a7ae8f6ef1d55202699df0502a30f15a35e1f 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/45360/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:19 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

follow haosdent's suggest, remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing (updated)
---

make test on localhost(ubuntu)


Thanks,

Deshi Xiao

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:17 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description (updated)
---

follow haosdent's suggest, remove mesos::internal:: should be enough.


Diffs (updated)
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

will testing on Linux(ubuntu,centos)


Thanks,

Deshi Xiao

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:08 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

will testing on Linux(ubuntu,centos)


Thanks,

Deshi Xiao

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:07 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

will testing on Linux(ubuntu,centos)


File Attachments (updated)


cgroups.cpp
  
https://reviews.apache.org/media/uploaded/files/2016/04/01/c782c054-1e37-4f92-ae03-55841eca9c05__cgroups.cpp


Thanks,

Deshi Xiao

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review126538
---



Patch looks great!

Reviews applied: [45572]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> ---
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
> https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> ---
> 
> Added a test in oversubciption_tests to make sure executor labels are visible 
> to ResourceEstimator and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43284: Wait for perf statistics processes exit.

[haosdent huang]

> On Feb. 8, 2016, 10:47 p.m., Ian Downes wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines 
> > 132-134
> > 
> >
> > I think you should discard the future and let it do the correct thing 
> > -- kill and reap the perf process -- rather than do a blocking await. The 
> > perf sample interval is configurable and typical values are 10's of seconds.
> > 
> > Note: I'm not sure if the correct behavior is implemented...
> 
> Ian Downes wrote:
> Actually, it looks like it might:
> 
> ```
> virtual void initialize()
> {
>   // Stop when no one cares.
>   promise.future().onDiscard(lambda::bind(
>   static_cast(terminate), self(), 
> true));
> 
>   execute();
> }
> 
> virtual void finalize()
> {
>   // Kill the perf process (if it's still running) by sending
>   // SIGTERM to the signal handler which will then SIGKILL the
>   // perf process group created by setupChild.
>   if (perf.isSome() && perf->status().isPending()) {
> kill(perf->pid(), SIGTERM);
>   }
> 
>   promise.discard();
> }
> ```
> 
> haosdent huang wrote:
> I try discard that before.
> ```
> sampleFuture.get().discard();
> sampleFuture.get().await();
> ```
> But failed. It is because in `collect()`
> 
> ```
> // Stop this nonsense if nobody cares.
> promise->future().onDiscard(defer(this, ::discarded));
> ```
> 
> Every future discarded is scheduled to run after 
> CgroupsPerfEventIsolatorProcess finalize.

@idownes, let me discard this and submit a better patch for this problem. I 
record this in [MESOS-5075](http://issues.apache.org/jira/browse/MESOS-5075).


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/#review118312
---


On Feb. 14, 2016, 7:59 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43284/
> ---
> 
> (Updated Feb. 14, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait for perf statistics processes exit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 65e731886b9e5cac07ae3ad6398faf8f50de5650 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 5ef4ae5c468580352cd16e7716b9ca4c0acde659 
> 
> Diff: https://reviews.apache.org/r/43284/diff/
> 
> 
> Testing
> ---
> 
> Without this patch, when running 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
> ```
> , would got this error
> ```
> [--] Global test environment tear-down
> ../../src/tests/environment.cpp:732: Failure
> Failed
> Tests completed with child processes remaining:
> -+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event 
> cycles --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock 
> --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
>  |   --- 16584 sleep 0.25
>  --- 16581 ()
> [==] 1 test from 1 test case ran. (4095 ms total)
> ```
> 
> This also fix similar error in 
> `MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45571/#review126530
---



Patch looks great!

Reviews applied: [45571]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 1, 2016, 1:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45571/
> ---
> 
> (Updated April 1, 2016, 1:08 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A few cleanups and simplifications in CNI isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 3a07540909ed771d1bd3b22888e04d5fb451710d 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 486c382365d5293cd9d53b8b239f70a543c46792 
> 
> Diff: https://reviews.apache.org/r/45571/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

[Jie Yu]

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 462-467
> > 
> >
> > Is it possible that agent crashes when checkpointing the output of CNI 
> > plugin in `_attach`? Will it cause this file corrupt or only contain 
> > partial output of plugin? If so, then we may log a warning message and just 
> > continue here.

Yeah, I'll add a TODO.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45571/#review126511
---


On April 1, 2016, 1:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45571/
> ---
> 
> (Updated April 1, 2016, 1:08 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A few cleanups and simplifications in CNI isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 3a07540909ed771d1bd3b22888e04d5fb451710d 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 486c382365d5293cd9d53b8b239f70a543c46792 
> 
> Diff: https://reviews.apache.org/r/45571/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

[Jie Yu]

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424
> > 
> >
> > I do not think we need this. If agent crashes after removing the 
> > interface directory in `_detach`, then we should not get into this 
> > `foreach` loop because `networkNames` returned by `paths::getNetworkNames` 
> > should be empty.

Hum, I don't think we delete network dir, do we? We delete ifdir first, if all 
are successful, we delete containerDir. But it's possible that we delete the 
ifdir, but agent crashes before the containerDir is deleted, right?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45571/#review126511
---


On April 1, 2016, 1:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45571/
> ---
> 
> (Updated April 1, 2016, 1:08 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A few cleanups and simplifications in CNI isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 3a07540909ed771d1bd3b22888e04d5fb451710d 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 486c382365d5293cd9d53b8b239f70a543c46792 
> 
> Diff: https://reviews.apache.org/r/45571/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 1, 2016, 3:06 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Please skip review this patch @jieyu. This is only used for pass local check in 
my machine.


Diffs
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing (updated)
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.

# Note: This patch would discarded eventually.


Thanks,

haosdent huang

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126510
---



Patch looks great!

Reviews applied: [44378, 45371]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 9:32 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 31, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake b89efd519eddfc96ce8fffb414d267a9770dda09 
>   LICENSE bbea085cfce1b9b3cbe002630955207f1c9ec60f 
>   src/python/native_common/ext_modules.py.in 
> 1c2fc49d0608570fa105628f28b9cc0b435e7e57 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45575/diff/


Testing
---


Thanks,

haosdent huang

Review Request 45573: Add PerfEventHandleManager.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add PerfEventHandleManager.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/45573/diff/


Testing
---


Thanks,

haosdent huang

Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45574/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Add `PerfEventSubsystem` for cgroups unified isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45574/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 1, 2016, 2:09 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45472/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Add `NetClsSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45472/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45473/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Migrate test cases for `net_cls` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45473/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45353/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45353/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45351/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Migrate test cases for `cpu` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45351/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `cgroups::memory::pressure::Counter::snapshot` method.


Diffs (updated)
-

  src/linux/cgroups.hpp 53397fc1da11a71259df1c38526a613676a60301 
  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45352/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Add `CpuacctSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45352/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45364/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Migrate test cases for `memory` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45364/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45085: Add cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45085/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Add cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45085/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `MemorySubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45084/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Add `Subsystem` abstraction for cgroups.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45084/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45083: Added a any mechanism for futures.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
---

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038


Repository: mesos


Description
---

Added a any mechanism for futures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
155e0bb75cf723a0a6c29020f9f767e3ba3d7401 

Diff: https://reviews.apache.org/r/45083/diff/


Testing
---


Thanks,

haosdent huang

Review Request 45572: Add labels to ExecutorInfo and deprecate source.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-5029
https://issues.apache.org/jira/browse/MESOS-5029


Repository: mesos


Description
---

Add labels to ExecutorInfo and deprecate source.


Diffs (updated)
-

  CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
  include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
  include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
  src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 

Diff: https://reviews.apache.org/r/45572/diff/


Testing (updated)
---

Added a test in oversubciption_tests to make sure executor labels are visible 
to ResourceEstimator and QoSController.


Thanks,

Zhitao Li

Review Request 45571: A few cleanups and simplifications in CNI isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45571/
---

Review request for mesos, Avinash sridharan and Qian Zhang.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

A few cleanups and simplifications in CNI isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
3a07540909ed771d1bd3b22888e04d5fb451710d 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
486c382365d5293cd9d53b8b239f70a543c46792 

Diff: https://reviews.apache.org/r/45571/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 45563: Added recommended config for production to the docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45563/#review126500
---



Patch looks great!

Reviews applied: [45562, 45563]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 8:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45563/
> ---
> 
> (Updated March 31, 2016, 8:47 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a table to the operational guide that contains recommended command-line 
> flag parameters for production use.
> 
> 
> Diffs
> -
> 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/45563/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45453: Minor spacing cleanups in docker containerizer.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45453/#review126499
---


Ship it!




Ship It!

- Timothy Chen


On March 29, 2016, 10:44 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45453/
> ---
> 
> (Updated March 29, 2016, 10:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-3573
> https://issues.apache.org/jira/browse/MESOS-3573
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
> 
> Diff: https://reviews.apache.org/r/45453/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review126496
---




src/slave/containerizer/mesos/isolators/xfs/utils.hpp (lines 45 - 47)


Sorry it didn't occur to to me earlier but looking at the tests I realized 
that we need to return a Result.

i.e.,

```
Result getProjectQuota(
const std::string& path,
prid_t projectId);
```

because a zero limit is "no limit", hence `None`. We use `setProjectQuota` 
and `clearProjectQuota` to carefully spearate the two use cases so here I think 
it's justified to make zero quota a special type.

(Plus we do this for `getProjectId()` already).


- Jiang Yan Xu


On March 31, 2016, 5:01 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44946/
> ---
> 
> (Updated March 31, 2016, 5:01 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add utility functions to manipulate XFS project quotas.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
>   src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 
> 
> Diff: https://reviews.apache.org/r/44946/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual verification. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/
---

(Updated April 1, 2016, 12:01 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Track sandbox directory usage by dynamically assigning XFS project
quotas. We track a range of XFS project IDs, assigning a project ID
and a project quota to each sandbox as it is created. When the task
reaches the quota, writes will fail with EDQUOT, and the task will have
an opportunity to handle that.

Quotas are not applied to volume resources since the isolator interface
has no insight into the volume lifecycle. Thus it is not currently
possible to accurately assign and reclaim project IDs.

If LOW is the lower bound of the project ID range and HIGH is the upper
bound, you can show the currently allocated project quotas using the
xfs_quota command:

  $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"

To show the project ID assigned to the file PATH, use the xfs_io command:

  $ xfs_io -r -c stat PATH


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/containerizer.cpp 
a5dd22380066aa85de04d485052084e2629681c0 
  src/slave/containerizer/mesos/isolators/xfs/disk.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
  src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/44948/diff/


Testing
---

Make check. Manual testing. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44949: Add XFS disk isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/
---

(Updated April 1, 2016, 12:01 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add basic XFS disk isolator tests by cloning the POSIX disk isolator
tests and making minor changes for the differences in semantics.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44949/diff/


Testing
---

Make check. Manual testing.


Thanks,

James Peach

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/
---

(Updated April 1, 2016, midnight)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and updated for review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add tests for XFS project quota utilities.


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/44947/diff/


Testing
---

Make check. Manual testing. These tests.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/
---

(Updated April 1, 2016, 12:01 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Add XFS disk isolator documentation.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 

Diff: https://reviews.apache.org/r/44950/diff/


Testing
---

Make check. Source inspection.


Thanks,

James Peach

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated April 1, 2016, 12:01 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and updated for review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/
---

(Updated April 1, 2016, midnight)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add autoconf tests for XFS project quotas.


Diffs (updated)
-

  configure.ac c693b825294f82ace8a14563cf2229820e159e3c 

Diff: https://reviews.apache.org/r/44945/diff/


Testing
---

Make check. Manual verification.


Thanks,

James Peach

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/#review126490
---



Bad patch!

Reviews applied: [45213]

Failed command: ./support/apply-review.sh -n -r 45213

Error:
2016-03-31 23:25:40 URL:https://reviews.apache.org/r/45213/diff/raw/ 
[96857/96857] -> "45213.patch" [1]
error: patch failed: src/cli/execute.cpp:266
error: src/cli/execute.cpp: patch does not apply
error: patch failed: src/local/local.cpp:257
error: src/local/local.cpp: patch does not apply
error: patch failed: src/master/master.cpp:1647
error: src/master/master.cpp: patch does not apply
error: patch failed: src/slave/slave.cpp:235
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/cluster.cpp:501
error: src/tests/cluster.cpp: patch does not apply
error: patch failed: src/tests/mesos.cpp:162
error: src/tests/mesos.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12249/console

- Mesos ReviewBot


On March 23, 2016, 1:07 p.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45213/
> ---
> 
> (Updated March 23, 2016, 1:07 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-3780
> https://issues.apache.org/jira/browse/mesos-3780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first patch to solve [MESOS-3780]
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
>   src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad 
>   src/examples/no_executor_framework.cpp 
> 9223d954197ebd097f57efea5299c917b24fe41e 
>   src/examples/persistent_volume_framework.cpp 
> 3848e247994b511fb2b1dcde337f8f37bb7472da 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/master/allocator/mesos/hierarchical.cpp 
> 39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 
>   src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 134b6c759b769cf335539e49eff817973c7f96a4 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 
>   src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 
>   src/tests/hierarchical_allocator_tests.cpp 
> e9cfcfc0ad8b0b89bbac459b7db39183f6c189be 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
>   src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 
> 
> Diff: https://reviews.apache.org/r/45213/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Vinod Kone]

> On March 14, 2016, 10:18 p.m., Anand Mazumdar wrote:
> > Qian, any updates on this?
> 
> Qian Zhang wrote:
> Sorry Anand, I am a little busy on the implementation of CNI support in 
> Mesos, will get back to this patch soon.

Do you still have cycles to work on this? If not, I can ask someone else to 
take it on.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review123517
---


On March 6, 2016, 9:08 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> ---
> 
> (Updated March 6, 2016, 9:08 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45557: Clean up the health check launcher code in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45557/#review126486
---



Patch looks great!

Reviews applied: [4, 45556, 45557]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 6:52 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45557/
> ---
> 
> (Updated March 31, 2016, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change cleans up the code a bit making it easier to read:
> 
> - Bail out early wherever possible to reduce nestedness of code
> making it easier to read.
> - Minor cleanups around merging conditions together wherever
> possible.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/45557/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 45567: Added an interface to insert `iptables` rules in linux.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45567/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-5066
https://issues.apache.org/jira/browse/MESOS-5066


Repository: mesos


Description
---

Added an interface to insert `iptables` rules in linux.


Diffs
-

  src/CMakeLists.txt 366a7ae8f6ef1d55202699df0502a30f15a35e1f 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/linux/netfilter/iptables/iptables.hpp PRE-CREATION 
  src/linux/netfilter/iptables/iptables.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45567/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45376/#review126481
---


Ship it!




Ship It!

- Vinod Kone


On March 31, 2016, 9:49 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45376/
> ---
> 
> (Updated March 31, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4312
> https://issues.apache.org/jira/browse/MESOS-4312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> I carried this patch from upstream zookeeper, since the
> fetch_and_add function in zookeeper is not 64bit-compatible.
> Details see: https://issues.apache.org/jira/browse/ZOOKEEPER-1643
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45376/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45557: Clean up the health check launcher code in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45557/#review126480
---


Ship it!




Ship It!

- Timothy Chen


On March 31, 2016, 6:52 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45557/
> ---
> 
> (Updated March 31, 2016, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change cleans up the code a bit making it easier to read:
> 
> - Bail out early wherever possible to reduce nestedness of code
> making it easier to read.
> - Minor cleanups around merging conditions together wherever
> possible.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/45557/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45555: Fix indent in docker executor health check code.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review126479
---


Ship it!




Ship It!

- Timothy Chen


On March 31, 2016, 6:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4/
> ---
> 
> (Updated March 31, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/4/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45556: Minor style cleanups to docker health check code.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45556/#review126478
---


Ship it!




Ship It!

- Timothy Chen


On March 31, 2016, 6:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45556/
> ---
> 
> (Updated March 31, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Minor cleanups around:
> 
> - Remove periods at end of cerr/cout messages.
> - Line spacings.
> - A few of the `string` variables can be made `const`.
> 
> This review mainly helps in reviewing r45557 easier.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/45556/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

[Avinash sridharan]

> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 151
> > 
> >
> > Should have pointed in the earlier patches, why do we need `Info` to be 
> > a smart pointer. We can have it as an object. We are not going to share 
> > this information with any other class or thread.
> 
> Qian Zhang wrote:
> I think `Owned` is the suggested way, please see:
> 
> https://github.com/apache/mesos/blob/0.28.0/src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp#L110
> 
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/cgroups/mem.hpp#L129
> 
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp#L115

That's because they ended up using an `Info*` to begin with. I think there were 
historical reasons for using `Info*` instead of an Info object. In this case I 
don't see the need for storing the `Info` as a pointer since it is not being 
passed around.


> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 136
> > 
> >
> > Why do we have this change as part of this patch? Can we move this out 
> > to a different patch?
> 
> Qian Zhang wrote:
> Because when I wrote this patch, I found I need a new method to parse 
> `NetworkInfo`, but I can not name it as `parse()` since there is already a 
> `parse()` method for parsing `NetworkConfig`, so I have to rename that one as 
> `parseNetworkConfig()`, and introduce the new one as `parseNetworkInfo()`.

Sure, but can we make it a separate patch ?


> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 817
> > 
> >
> > Isn't this a problem? We are returning `Nothing` here, which implies 
> > that in the `recover` method the container information is assumed to have 
> > been stored correctly. However, there is NO container informationt that has 
> > been stored!! I thought we should never run into this issue, since we 
> > should be creating the directories before calling the CNI plugin?
> 
> Qian Zhang wrote:
> > which implies that in the recover method the container information is 
> assumed to have been stored correctly.
> 
> It does not imply the container info has been stored correctly, actually 
> it implies that for this kind of container (which has no networkInfoDir 
> created yet), we do not need to store anything for it (actually we have 
> nothing to restore from since there is no networkInfoDir for the container).

That doesn't sound right. This effectively means that we have a container 
without a IP address or even a veth associated with the network namespace? This 
seems like an error.


> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 832-835
> > 
> >
> > What if the isolator dies right after creating the directories, but 
> > after invoking the plugin? If we just return `Nothing` we might end up 
> > leaking state information from the CNI plugin (IPAM). I think we should 
> > return `Error` here and ask the isolator to cleanup the containers and 
> > start over.
> 
> Qian Zhang wrote:
> If the plugin has been invoked, then the `networkDirs` will not be empty.

Well, the ip address and DNS information returned by the plugin would have been 
lost, because the plugin would be a zombie process (child died). In this case 
not sure if it makes sense to recover the containers.


> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 878
> > 
> >
> > This error doesn't make sense. Maybe:
> > "Found multiple interfaces for a given CNI network. This should not be 
> > allowed" ?
> 
> Qian Zhang wrote:
> But it will miss the case that interfaces.get().size() == 0.

Do we throw an error in `isolate` if a container tries to join the same network 
with multiple `NetworkInfo` messages ? I agree with your comment though. If we 
are handling the case that a container can never have more than one interface 
attached to the network, we can replace the existing string by
"Unable to find any interface attached to " +  +" for this 
container" 


> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp, line 53
> > 
> >
> > Why not just return 

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45082/#review126475
---


Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 776)


Can you add some LOG(INFO) here. Maybe in a subsequent patch.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 783)


Ditto on adding some LOG(INFO) here.


- Jie Yu


On March 31, 2016, 11:28 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45082/
> ---
> 
> (Updated March 31, 2016, 11:28 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented cleanup() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 873e0c52475f4868e611bd24a6782ad5eb261a99 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
> 
> Diff: https://reviews.apache.org/r/45082/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
---


Fix it, then Ship it!





docs/configuration.md (line 354)


Not yours but why isn't that flag in the common master/agent section above?



docs/configuration.md (line 361)


are *only* suitable for short-term?


- Joerg Schad


On March 31, 2016, 9:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated March 31, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

> On March 31, 2016, 5:12 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 336
> > 
> >
> > Plural?
> > 
> > We often use a trailing understore: `char* directory_[]`. 
> > (s/path/directory/ is due to the suggestion on generalizing the method)
> > 
> > Also, no padding space in `{}`.
> > 
> > Therefore:
> > 
> > ```
> > char* directory_[] = {const_cast(path.c_str()), nullptr};
> > ```

This is identical to the code in ``src/linux/cgroups.cpp``.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review126200
---


On March 30, 2016, 10:18 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44946/
> ---
> 
> (Updated March 30, 2016, 10:18 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add utility functions to manipulate XFS project quotas.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44946/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual verification. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

[Jie Yu]

> On March 30, 2016, 6:12 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339
> > 
> >
> > I think this is not needed because if recover fails, slave will restart.
> 
> Qian Zhang wrote:
> Agree, but I see other isolators do the similar, e.g., 
> CgroupsCpushareIsolatorProcess::recover(), 
> CgroupsMemIsolatorProcess::recover(), etc., maybe we need to fix them as well?

yeah, those are not done correctly.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45383/#review126143
---


On March 31, 2016, 11:33 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45383/
> ---
> 
> (Updated March 31, 2016, 11:33 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented recover() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 873e0c52475f4868e611bd24a6782ad5eb261a99 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> f627ec9499a34ca104d2c1a4d28e1d2f4b849f64 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp 
> 611f3869402b9033081b7f9ecc1bdf006f61918b 
>   src/slave/containerizer/mesos/isolators/network/cni/spec.hpp 
> 6a3c33645bab73edaf5af4d298a671852ea59c46 
>   src/slave/containerizer/mesos/isolators/network/cni/spec.cpp 
> 5b5f904def9ef6dcc4462a03a2d024ad4eb3d946 
> 
> Diff: https://reviews.apache.org/r/45383/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45546/#review126469
---




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 791 - 792)


hum, what about labels and groups in NetworkInfo? I think we should save a 
copy during launch/recover, and fill the missing ip if needed here.


- Jie Yu


On March 31, 2016, 2:55 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45546/
> ---
> 
> (Updated March 31, 2016, 2:55 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented status() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
> 
> Diff: https://reviews.apache.org/r/45546/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45532: Renamed 'getNetworkInfoDir' to 'getContainerDir'.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45532/#review126467
---


Ship it!




Ship It!

- Jie Yu


On March 31, 2016, 11:31 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45532/
> ---
> 
> (Updated March 31, 2016, 11:31 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed 'getNetworkInfoDir' to 'getContainerDir'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> f627ec9499a34ca104d2c1a4d28e1d2f4b849f64 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp 
> 611f3869402b9033081b7f9ecc1bdf006f61918b 
> 
> Diff: https://reviews.apache.org/r/45532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45531: Made 'ROOT_DIR' a shared mount.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45531/#review126466
---


Ship it!




Ship It!

- Jie Yu


On March 31, 2016, 11:30 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45531/
> ---
> 
> (Updated March 31, 2016, 11:30 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made 'ROOT_DIR' a shared mount.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
> 
> Diff: https://reviews.apache.org/r/45531/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44674: Supported image name specified with private registry prefix.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126465
---




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 192 
- 209)


Can we move this logic into docker spec file:
```
Result spec::getRegistryPort(const string& registry);
Result spec::getRegistryScheme(const string& registry);
Try spec::getRegistryHost(const string& registry);
```


- Jie Yu


On March 17, 2016, 4:57 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> ---
> 
> (Updated March 17, 2016, 4:57 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported image name specified with private registry prefix.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44674/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
> 
> Tested with private registry localhost:80/ubuntu
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

[Zhiwei Chen]

> On April 1, 2016, 1:38 a.m., Vinod Kone wrote:
> > 3rdparty/zookeeper-3.4.8.patch, line 13
> > 
> >
> > Can you explain in the description what this patch is doing? It's not 
> > obvious.
> > 
> > How does this affect non-PPC platforms?

This patch was carried from upstream zookeeper repo and it will be in zookeeper 
3.5.0, so I think it will affect non-PPC platforms.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45376/#review126364
---


On April 1, 2016, 5:49 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45376/
> ---
> 
> (Updated April 1, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4312
> https://issues.apache.org/jira/browse/MESOS-4312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> I carried this patch from upstream zookeeper, since the
> fetch_and_add function in zookeeper is not 64bit-compatible.
> Details see: https://issues.apache.org/jira/browse/ZOOKEEPER-1643
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45376/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

[Anurag Singh]

> On March 31, 2016, 5:25 p.m., Kapil Arya wrote:
> > include/mesos/master/contender.hpp, line 65
> > 
> >
> > I am wondering if `type` can be replaced with `moduleName` or something 
> > more explicit.

as discussed, we'll be dropping this method so I'll skip this comment.


- Anurag


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review125914
---


On March 23, 2016, 11:04 p.m., Anurag Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> ---
> 
> (Updated March 23, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector 
> implementations.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44287/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/
---

(Updated April 1, 2016, 5:32 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Bugs: MESOS-4803
https://issues.apache.org/jira/browse/MESOS-4803


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
c3dcbb59816c0ff6d929ef0aad9a136d38cf84cb 
  3rdparty/libprocess/3rdparty/libev-4.15.patch 
bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
  3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
4c282b573aa9331fd16197ef286faf323b6515eb 
  3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
  3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/versions.am 
7f5a61867e341e4ed67ff9f9127e5739b5a48b1d 

Diff: https://reviews.apache.org/r/44378/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

(Updated April 1, 2016, 5:32 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake b89efd519eddfc96ce8fffb414d267a9770dda09 
  LICENSE bbea085cfce1b9b3cbe002630955207f1c9ec60f 
  src/python/native_common/ext_modules.py.in 
1c2fc49d0608570fa105628f28b9cc0b435e7e57 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126454
---



Bad patch!

Reviews applied: [45371, 44378]

Failed command: ./support/apply-review.sh -n -r 44378

Error:
2016-03-31 21:29:45 URL:https://reviews.apache.org/r/44378/diff/raw/ 
[1351149/1351149] -> "44378.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/versions.am:6
error: 3rdparty/libprocess/3rdparty/versions.am: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12247/console

- Mesos ReviewBot


On March 31, 2016, 5:14 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 31, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
>   LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated March 31, 2016, 9:22 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Changes
---

Addressed comment.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

[Jie Yu]

> On March 31, 2016, 5:59 p.m., Cong Wang wrote:
> > Why /var/run/netns could be in the same mount peer group with its parent? 
> > At least on fedora21 this is not the case.
> > 
> > Also, why do you fix two bugs in one patch? I know you don't care about 
> > bisect, but even so this is still not a good practice at all.
> 
> Jie Yu wrote:
> I'll split the patch. Regarding the mount peer groups issue, here is the 
> test I did on fedora23:
> ```
> [vagrant@localhost build]$ cat /proc/self/mountinfo 
> 17 58 0:17 / /sys rw,nosuid,nodev,noexec,relatime shared:6 - sysfs sysfs 
> rw,seclabel
> 18 58 0:4 / /proc rw,nosuid,nodev,noexec,relatime shared:5 - proc proc rw
> 19 58 0:6 / /dev rw,nosuid shared:2 - devtmpfs devtmpfs 
> rw,seclabel,size=4076012k,nr_inodes=1019003,mode=755
> 20 17 0:18 / /sys/kernel/security rw,nosuid,nodev,noexec,relatime 
> shared:7 - securityfs securityfs rw
> 21 19 0:19 / /dev/shm rw,nosuid,nodev shared:3 - tmpfs tmpfs rw,seclabel
> 22 19 0:13 / /dev/pts rw,nosuid,noexec,relatime shared:4 - devpts devpts 
> rw,seclabel,gid=5,mode=620,ptmxmode=000
> 23 58 0:20 / /run rw,nosuid,nodev shared:22 - tmpfs tmpfs 
> rw,seclabel,mode=755
> 24 17 0:21 / /sys/fs/cgroup ro,nosuid,nodev,noexec shared:8 - tmpfs tmpfs 
> ro,seclabel,mode=755
> 25 24 0:22 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime 
> shared:9 - cgroup cgroup 
> rw,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd
> 26 17 0:23 / /sys/fs/pstore rw,nosuid,nodev,noexec,relatime shared:19 - 
> pstore pstore rw,seclabel
> 27 24 0:24 / /sys/fs/cgroup/blkio rw,nosuid,nodev,noexec,relatime 
> shared:10 - cgroup cgroup rw,blkio
> 28 24 0:25 / /sys/fs/cgroup/net_cls,net_prio 
> rw,nosuid,nodev,noexec,relatime shared:11 - cgroup cgroup rw,net_cls,net_prio
> 29 24 0:26 / /sys/fs/cgroup/freezer rw,nosuid,nodev,noexec,relatime 
> shared:12 - cgroup cgroup rw,freezer
> 30 24 0:27 / /sys/fs/cgroup/memory rw,nosuid,nodev,noexec,relatime 
> shared:13 - cgroup cgroup rw,memory
> 31 24 0:28 / /sys/fs/cgroup/perf_event rw,nosuid,nodev,noexec,relatime 
> shared:14 - cgroup cgroup rw,perf_event
> 32 24 0:29 / /sys/fs/cgroup/cpu,cpuacct rw,nosuid,nodev,noexec,relatime 
> shared:15 - cgroup cgroup rw,cpu,cpuacct
> 33 24 0:30 / /sys/fs/cgroup/devices rw,nosuid,nodev,noexec,relatime 
> shared:16 - cgroup cgroup rw,devices
> 34 24 0:31 / /sys/fs/cgroup/hugetlb rw,nosuid,nodev,noexec,relatime 
> shared:17 - cgroup cgroup rw,hugetlb
> 35 24 0:32 / /sys/fs/cgroup/cpuset rw,nosuid,nodev,noexec,relatime 
> shared:18 - cgroup cgroup rw,cpuset
> 56 17 0:33 / /sys/kernel/config rw,relatime shared:20 - configfs configfs 
> rw
> 58 0 8:1 / / rw,relatime shared:1 - ext4 /dev/sda1 
> rw,seclabel,data=ordered
> 36 17 0:16 / /sys/fs/selinux rw,relatime shared:21 - selinuxfs selinuxfs 
> rw
> 37 18 0:34 / /proc/sys/fs/binfmt_misc rw,relatime shared:23 - autofs 
> systemd-1 rw,fd=30,pgrp=1,timeout=0,minproto=5,maxproto=5,direct
> 38 19 0:35 / /dev/hugepages rw,relatime shared:24 - hugetlbfs hugetlbfs 
> rw,seclabel
> 39 19 0:15 / /dev/mqueue rw,relatime shared:25 - mqueue mqueue rw,seclabel
> 40 17 0:7 / /sys/kernel/debug rw,relatime shared:26 - debugfs debugfs 
> rw,seclabel
> 70 23 0:36 / /run/user/1001 rw,nosuid,nodev,relatime shared:27 - tmpfs 
> tmpfs rw,seclabel,size=817560k,mode=700,uid=1001,gid=1001
> [vagrant@localhost build]$ sudo mount^C
> [vagrant@localhost build]$ sudo mkdir /run/netns
> [vagrant@localhost build]$ sudo mount --bind /run/netns /run/netns
> [vagrant@localhost build]$ cat /proc/self/mountinfo 
> 17 58 0:17 / /sys rw,nosuid,nodev,noexec,relatime shared:6 - sysfs sysfs 
> rw,seclabel
> 18 58 0:4 / /proc rw,nosuid,nodev,noexec,relatime shared:5 - proc proc rw
> 19 58 0:6 / /dev rw,nosuid shared:2 - devtmpfs devtmpfs 
> rw,seclabel,size=4076012k,nr_inodes=1019003,mode=755
> 20 17 0:18 / /sys/kernel/security rw,nosuid,nodev,noexec,relatime 
> shared:7 - securityfs securityfs rw
> 21 19 0:19 / /dev/shm rw,nosuid,nodev shared:3 - tmpfs tmpfs rw,seclabel
> 22 19 0:13 / /dev/pts rw,nosuid,noexec,relatime shared:4 - devpts devpts 
> rw,seclabel,gid=5,mode=620,ptmxmode=000
> 23 58 0:20 / /run rw,nosuid,nodev shared:22 - tmpfs tmpfs 
> rw,seclabel,mode=755
> 24 17 0:21 / /sys/fs/cgroup ro,nosuid,nodev,noexec shared:8 - tmpfs tmpfs 
> ro,seclabel,mode=755
> 25 24 0:22 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime 
> shared:9 - cgroup cgroup 
> rw,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd
> 26 17 0:23 / /sys/fs/pstore rw,nosuid,nodev,noexec,relatime shared:19 - 
> pstore pstore rw,seclabel
> 27 24 0:24 / /sys/fs/cgroup/blkio rw,nosuid,nodev,noexec,relatime 
> shared:10 - cgroup cgroup rw,blkio
> 28 24 0:25 / /sys/fs/cgroup/net_cls,net_prio 
> rw,nosuid,nodev,noexec,relatime shared:11 - cgroup cgroup 

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated March 31, 2016, 9 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126442
---




docs/configuration.md (line 361)


What's an "automatic garbage collection service"? Can we spell out what bad 
stuff might happen if `/tmp` is used for `work_dir`?



docs/configuration.md (line 1598)


Might be worth noting that the default value _is_ not consistent with this 
warning.


- Neil Conway


On March 31, 2016, 8:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated March 31, 2016, 8:47 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 45562: Edited `--work_dir` help strings and docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Review Request 45563: Added recommended config for production to the docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45563/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Added a table to the operational guide that contains recommended command-line 
flag parameters for production use.


Diffs
-

  docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 

Diff: https://reviews.apache.org/r/45563/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45553: Minor cleanups in validation logic for operator endpoints.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45553/#review126441
---


Ship it!




Ship It!

- Vinod Kone


On March 31, 2016, 5:53 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45553/
> ---
> 
> (Updated March 31, 2016, 5:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial patch cleans up the following things:
> - Style in-consistencies where we used to take the hashmap
> as constant reference in other places but not in `teardown`
> call handler.
> - Avoid lookups twice in the hash map but save it in an
> `Option` variable. This is more consistent with the code
> at other places.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 
> 
> Diff: https://reviews.apache.org/r/45553/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/#review126429
---



Can you call this out specifically in the CHANGELOG (under "Binary API Changes) 
section.

- Vinod Kone


On March 23, 2016, 1:07 p.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45213/
> ---
> 
> (Updated March 23, 2016, 1:07 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-3780
> https://issues.apache.org/jira/browse/mesos-3780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first patch to solve [MESOS-3780]
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
>   src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad 
>   src/examples/no_executor_framework.cpp 
> 9223d954197ebd097f57efea5299c917b24fe41e 
>   src/examples/persistent_volume_framework.cpp 
> 3848e247994b511fb2b1dcde337f8f37bb7472da 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/master/allocator/mesos/hierarchical.cpp 
> 39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 
>   src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 134b6c759b769cf335539e49eff817973c7f96a4 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 
>   src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 
>   src/tests/hierarchical_allocator_tests.cpp 
> e9cfcfc0ad8b0b89bbac459b7db39183f6c189be 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
>   src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 
> 
> Diff: https://reviews.apache.org/r/45213/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45439/#review126415
---


Ship it!




Looks good!

We'll add some comments to the top of the class and the commit message to 
mention the current caveats.

- Ben Mahler


On March 31, 2016, 4:48 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45439/
> ---
> 
> (Updated March 31, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-4625
> https://issues.apache.org/jira/browse/MESOS-4625
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current implementation includes some code for generic device
> isolation. Once we start isolating more devices, we should abstract
> this out and figure out an architecture to support "sub-device"
> isolation.
> 
> This was joint work with Rob Todd from Nvidia .
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp 
> 1e17df1f7d1daf913e0c03e0290dd85b51c2ade0 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
> c2cdc8fde7a85741be6494ea664d3719d1f13a43 
> 
> Diff: https://reviews.apache.org/r/45439/diff/
> 
> 
> Testing
> ---
> 
> Test to come in subsequent patch.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45381/#review126360
---




src/Makefile.am 


Please update cmakefile.txt as well.



src/slave/slave.hpp (line 549)


Can you move this field to Http class because this is a limiter for the 
http endpoint. Also, `limiter` sounds too general. Maybe rename it?

```
class Http {
private:
  Slave* slave;
  RateLimiter statisticsLimiter;
}

```



src/slave/slave.cpp (lines 5013 - 5051)


Instead of putting the logic here, can you move it to 
Slave::Http::statistics?
```
return slave->limiter.acquire()
.then(defer(slave->self(), ::usage))
.then([=](const ResourceUsage& usage) {
  ...
})
.repair([](const Future& future) {
  LOG(WARNING) << ...;
  return InternalServerError();
});
```


- Jie Yu


On March 30, 2016, 5:30 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45381/
> ---
> 
> (Updated March 30, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These two endpoints and their underlying logics are moved from
> ResourceMonitorProcess to slave process. ResourceMonitor is removed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/http.cpp 7a872c6e21b115500c5291b7cb9fb240ec9dc8ed 
>   src/slave/monitor.hpp 70a7c88fefd4577f53f85e3eccdd6b69ab6f3acd 
>   src/slave/monitor.cpp 5c1dd354595e67e5eb603c5d49850f84b84b 
>   src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
> 
> Diff: https://reviews.apache.org/r/45381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> https://issues.apache.org/jira/browse/MESOS-4891
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Review Request 45556: Minor style cleanups to docker health check code.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45556/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

Minor cleanups around:

- Remove periods at end of cerr/cout messages.
- Line spacings.
- A few of the `string` variables can be made `const`.

This review mainly helps in reviewing r45557 easier.


Diffs
-

  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/45556/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 45557: Clean up the health check launcher code in docker executor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45557/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

This change cleans up the code a bit making it easier to read:

- Bail out early wherever possible to reduce nestedness of code
making it easier to read.
- Minor cleanups around merging conditions together wherever
possible.


Diffs
-

  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/45557/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 45555: Fix indent in docker executor health check code.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/4/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/#review126405
---


Ship it!




Ship It!

- Vinod Kone


On March 23, 2016, 1:07 p.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45213/
> ---
> 
> (Updated March 23, 2016, 1:07 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-3780
> https://issues.apache.org/jira/browse/mesos-3780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first patch to solve [MESOS-3780]
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
>   src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad 
>   src/examples/no_executor_framework.cpp 
> 9223d954197ebd097f57efea5299c917b24fe41e 
>   src/examples/persistent_volume_framework.cpp 
> 3848e247994b511fb2b1dcde337f8f37bb7472da 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/master/allocator/mesos/hierarchical.cpp 
> 39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 
>   src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 134b6c759b769cf335539e49eff817973c7f96a4 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 
>   src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 
>   src/tests/hierarchical_allocator_tests.cpp 
> e9cfcfc0ad8b0b89bbac459b7db39183f6c189be 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
>   src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 
> 
> Diff: https://reviews.apache.org/r/45213/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126401
---



can you rebase this?

- Vinod Kone


On March 31, 2016, 5:14 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 31, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
>   LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

[Jie Yu]

> On March 31, 2016, 5:59 p.m., Cong Wang wrote:
> > Why /var/run/netns could be in the same mount peer group with its parent? 
> > At least on fedora21 this is not the case.
> > 
> > Also, why do you fix two bugs in one patch? I know you don't care about 
> > bisect, but even so this is still not a good practice at all.

I'll split the patch. Regarding the mount peer groups issue, here is the test I 
did on fedora23:
```
[vagrant@localhost build]$ cat /proc/self/mountinfo 
17 58 0:17 / /sys rw,nosuid,nodev,noexec,relatime shared:6 - sysfs sysfs 
rw,seclabel
18 58 0:4 / /proc rw,nosuid,nodev,noexec,relatime shared:5 - proc proc rw
19 58 0:6 / /dev rw,nosuid shared:2 - devtmpfs devtmpfs 
rw,seclabel,size=4076012k,nr_inodes=1019003,mode=755
20 17 0:18 / /sys/kernel/security rw,nosuid,nodev,noexec,relatime shared:7 - 
securityfs securityfs rw
21 19 0:19 / /dev/shm rw,nosuid,nodev shared:3 - tmpfs tmpfs rw,seclabel
22 19 0:13 / /dev/pts rw,nosuid,noexec,relatime shared:4 - devpts devpts 
rw,seclabel,gid=5,mode=620,ptmxmode=000
23 58 0:20 / /run rw,nosuid,nodev shared:22 - tmpfs tmpfs rw,seclabel,mode=755
24 17 0:21 / /sys/fs/cgroup ro,nosuid,nodev,noexec shared:8 - tmpfs tmpfs 
ro,seclabel,mode=755
25 24 0:22 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime shared:9 - 
cgroup cgroup 
rw,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd
26 17 0:23 / /sys/fs/pstore rw,nosuid,nodev,noexec,relatime shared:19 - pstore 
pstore rw,seclabel
27 24 0:24 / /sys/fs/cgroup/blkio rw,nosuid,nodev,noexec,relatime shared:10 - 
cgroup cgroup rw,blkio
28 24 0:25 / /sys/fs/cgroup/net_cls,net_prio rw,nosuid,nodev,noexec,relatime 
shared:11 - cgroup cgroup rw,net_cls,net_prio
29 24 0:26 / /sys/fs/cgroup/freezer rw,nosuid,nodev,noexec,relatime shared:12 - 
cgroup cgroup rw,freezer
30 24 0:27 / /sys/fs/cgroup/memory rw,nosuid,nodev,noexec,relatime shared:13 - 
cgroup cgroup rw,memory
31 24 0:28 / /sys/fs/cgroup/perf_event rw,nosuid,nodev,noexec,relatime 
shared:14 - cgroup cgroup rw,perf_event
32 24 0:29 / /sys/fs/cgroup/cpu,cpuacct rw,nosuid,nodev,noexec,relatime 
shared:15 - cgroup cgroup rw,cpu,cpuacct
33 24 0:30 / /sys/fs/cgroup/devices rw,nosuid,nodev,noexec,relatime shared:16 - 
cgroup cgroup rw,devices
34 24 0:31 / /sys/fs/cgroup/hugetlb rw,nosuid,nodev,noexec,relatime shared:17 - 
cgroup cgroup rw,hugetlb
35 24 0:32 / /sys/fs/cgroup/cpuset rw,nosuid,nodev,noexec,relatime shared:18 - 
cgroup cgroup rw,cpuset
56 17 0:33 / /sys/kernel/config rw,relatime shared:20 - configfs configfs rw
58 0 8:1 / / rw,relatime shared:1 - ext4 /dev/sda1 rw,seclabel,data=ordered
36 17 0:16 / /sys/fs/selinux rw,relatime shared:21 - selinuxfs selinuxfs rw
37 18 0:34 / /proc/sys/fs/binfmt_misc rw,relatime shared:23 - autofs systemd-1 
rw,fd=30,pgrp=1,timeout=0,minproto=5,maxproto=5,direct
38 19 0:35 / /dev/hugepages rw,relatime shared:24 - hugetlbfs hugetlbfs 
rw,seclabel
39 19 0:15 / /dev/mqueue rw,relatime shared:25 - mqueue mqueue rw,seclabel
40 17 0:7 / /sys/kernel/debug rw,relatime shared:26 - debugfs debugfs 
rw,seclabel
70 23 0:36 / /run/user/1001 rw,nosuid,nodev,relatime shared:27 - tmpfs tmpfs 
rw,seclabel,size=817560k,mode=700,uid=1001,gid=1001
[vagrant@localhost build]$ sudo mount^C
[vagrant@localhost build]$ sudo mkdir /run/netns
[vagrant@localhost build]$ sudo mount --bind /run/netns /run/netns
[vagrant@localhost build]$ cat /proc/self/mountinfo 
17 58 0:17 / /sys rw,nosuid,nodev,noexec,relatime shared:6 - sysfs sysfs 
rw,seclabel
18 58 0:4 / /proc rw,nosuid,nodev,noexec,relatime shared:5 - proc proc rw
19 58 0:6 / /dev rw,nosuid shared:2 - devtmpfs devtmpfs 
rw,seclabel,size=4076012k,nr_inodes=1019003,mode=755
20 17 0:18 / /sys/kernel/security rw,nosuid,nodev,noexec,relatime shared:7 - 
securityfs securityfs rw
21 19 0:19 / /dev/shm rw,nosuid,nodev shared:3 - tmpfs tmpfs rw,seclabel
22 19 0:13 / /dev/pts rw,nosuid,noexec,relatime shared:4 - devpts devpts 
rw,seclabel,gid=5,mode=620,ptmxmode=000
23 58 0:20 / /run rw,nosuid,nodev shared:22 - tmpfs tmpfs rw,seclabel,mode=755
24 17 0:21 / /sys/fs/cgroup ro,nosuid,nodev,noexec shared:8 - tmpfs tmpfs 
ro,seclabel,mode=755
25 24 0:22 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime shared:9 - 
cgroup cgroup 
rw,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd
26 17 0:23 / /sys/fs/pstore rw,nosuid,nodev,noexec,relatime shared:19 - pstore 
pstore rw,seclabel
27 24 0:24 / /sys/fs/cgroup/blkio rw,nosuid,nodev,noexec,relatime shared:10 - 
cgroup cgroup rw,blkio
28 24 0:25 / /sys/fs/cgroup/net_cls,net_prio rw,nosuid,nodev,noexec,relatime 
shared:11 - cgroup cgroup rw,net_cls,net_prio
29 24 0:26 / /sys/fs/cgroup/freezer rw,nosuid,nodev,noexec,relatime shared:12 - 
cgroup cgroup rw,freezer
30 24 0:27 / /sys/fs/cgroup/memory rw,nosuid,nodev,noexec,relatime shared:13 - 
cgroup cgroup rw,memory
31 24 0:28 / /sys/fs/cgroup/perf_event rw,nosuid,nodev,noexec,relatime 
shared:14 - cgroup cgroup rw,perf_event
32 24 0:29 / 

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45439/#review126395
---



Bad patch!

Reviews applied: [45439, 44364, 44366, 44365, 44363, 44361, 44360, 44779, 
44778, 44777, 44776]

Failed command: ./support/apply-review.sh -n -r 44778

Error:
2016-03-31 18:33:48 URL:https://reviews.apache.org/r/44778/diff/raw/ 
[1015/1015] -> "44778.patch" [1]
error: patch failed: src/common/parse.hpp:87
error: src/common/parse.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12245/console

- Mesos ReviewBot


On March 31, 2016, 4:48 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45439/
> ---
> 
> (Updated March 31, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-4625
> https://issues.apache.org/jira/browse/MESOS-4625
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current implementation includes some code for generic device
> isolation. Once we start isolating more devices, we should abstract
> this out and figure out an architecture to support "sub-device"
> isolation.
> 
> This was joint work with Rob Todd from Nvidia .
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp 
> 1e17df1f7d1daf913e0c03e0290dd85b51c2ade0 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
> c2cdc8fde7a85741be6494ea664d3719d1f13a43 
> 
> Diff: https://reviews.apache.org/r/45439/diff/
> 
> 
> Testing
> ---
> 
> Test to come in subsequent patch.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45546/#review126388
---


Fix it, then Ship it!




Ship It!


src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 786)


Shouldn't we return a failure?



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 790)


Maybe s/netInfo/_networkInfo


- Avinash sridharan


On March 31, 2016, 2:55 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45546/
> ---
> 
> (Updated March 31, 2016, 2:55 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented status() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
> 
> Diff: https://reviews.apache.org/r/45546/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44382/#review126382
---


Ship it!




Ship It!

- Vinod Kone


On March 22, 2016, 8:44 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44382/
> ---
> 
> (Updated March 22, 2016, 8:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4802
> https://issues.apache.org/jira/browse/MESOS-4802
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update leveldb-1.4.patch to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/leveldb-1.4.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 
> 
> Diff: https://reviews.apache.org/r/44382/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45546/#review126376
---



Patch looks great!

Reviews applied: [44004, 44200, 44549, 44555, 44622, 44514, 44706, 45082, 
45383, 45531, 45532, 45546]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 2:55 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45546/
> ---
> 
> (Updated March 31, 2016, 2:55 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented status() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
> 
> Diff: https://reviews.apache.org/r/45546/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45520/#review126372
---



Why /var/run/netns could be in the same mount peer group with its parent? At 
least on fedora21 this is not the case.

Also, why do you fix two bugs in one patch? I know you don't care about bisect, 
but even so this is still not a good practice at all.

- Cong Wang


On March 31, 2016, 1:47 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45520/
> ---
> 
> (Updated March 31, 2016, 1:47 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Cong Wang.
> 
> 
> Bugs: MESOS-4662
> https://issues.apache.org/jira/browse/MESOS-4662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the bind mount root issue in port mapping isolator. This patch fixed 
> two issues:
> 1) no long assume /var/run/netns is a realpath
> 2) made sure /var/run/netns is a shared mount in its own mount peer group
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 0fe2f486eb733acf738c1c61fc44f820d7401afc 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45520/diff/
> 
> 
> Testing
> ---
> 
> sudo make check on Fedora23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 45553: Minor cleanups in validation logic for operator endpoints.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45553/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

This trivial patch cleans up the following things:
- Style in-consistencies where we used to take the hashmap
as constant reference in other places but not in `teardown`
call handler.
- Avoid lookups twice in the hash map but save it in an
`Option` variable. This is more consistent with the code
at other places.


Diffs
-

  src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 

Diff: https://reviews.apache.org/r/45553/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45376/#review126364
---




3rdparty/zookeeper-3.4.8.patch (line 13)


Can you explain in the description what this patch is doing? It's not 
obvious.

How does this affect non-PPC platforms?


- Vinod Kone


On March 28, 2016, 6:52 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45376/
> ---
> 
> (Updated March 28, 2016, 6:52 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add zookeeper patch for 3.4.8 to support PPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45376/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review125914
---




include/mesos/master/contender.hpp (line 19)


Please include header for `std::string`.



include/mesos/master/contender.hpp (lines 26 - 27)


Alphabetize please!

Also #include stout/try.hpp?



include/mesos/master/contender.hpp (line 65)


I am wondering if `type` can be replaced with `moduleName` or something 
more explicit.



include/mesos/master/detector.hpp (line 62)


Same as with contender, can we replace `type` with a more explicit name?


- Kapil Arya


On March 23, 2016, 7:04 p.m., Anurag Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> ---
> 
> (Updated March 23, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector 
> implementations.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44287/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/#review126359
---



- Kapil Arya


On March 23, 2016, 7:04 p.m., Anurag Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44288/
> ---
> 
> (Updated March 23, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also modified users of MasterContender and MasterDetector to use this
> namespace.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 
>   src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/scheduler/scheduler.cpp 6a834473ef35540eedac7e211b5204ab5f4eb7b2 
>   src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
>   src/tests/cluster.hpp 06424dd741aed2261a926429bb0fc7dea141c11b 
>   src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 
>   src/tests/command_executor_tests.cpp 
> 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
>   src/tests/container_logger_tests.cpp 
> 71101c31cee6a400b89cf285cf0a105d2d1534a8 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> f6fce7df82417e029fadf805d6e0b793f396aa69 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 5e2116355418f5a0716cfd1573bab48ba75df596 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> b3bd5a03266150a0cd83c966d646a32c419bf512 
>   src/tests/containerizer/isolator_tests.cpp 
> 6a2e25b967742c034364d19372f06aa9f9cdf828 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> be6c3a118b528c39c534da423c15e9dcbb970dbc 
>   src/tests/containerizer/port_mapping_tests.cpp 
> de4b6f99f3a994bcedafa801eed9c4a7b79bac23 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> e4b30b9e51cd1191bfa9d9cf68a274814fdc4873 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> 9f3b0b08da7cebba722062a9932fae1b5f825efb 
>   src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a 
>   src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
>   src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 
>   src/tests/executor_http_api_tests.cpp 
> ff7b672e03185fca8b408b8805223a314fa3e483 
>   src/tests/fault_tolerance_tests.cpp 
> f99413f56e96a796d3d45decad1f049e6a238789 
>   src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 
>   src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 
>   src/tests/health_check_tests.cpp d32164aeb1eb439bd062afa28614dd919e24f06b 
>   src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c 
>   src/tests/http_fault_tolerance_tests.cpp 
> c06e07daf6d6519c10489310cd4275ae94f302c6 
>   src/tests/master_allocator_tests.cpp 
> b41ba2bda4d680f6fc42f525719973d56c11fe31 
>   src/tests/master_authorization_tests.cpp 
> 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
>   src/tests/master_contender_detector_tests.cpp 
> bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 
>   src/tests/master_maintenance_tests.cpp 
> b42a81fc2e0982e8fca669bffb798c0acda684fc 
>   src/tests/master_quota_tests.cpp c2b46d23002481e63ff162e8628f9b974e3e8ef9 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 988f1d46580ab5a707fe801824e24f94d4f50da7 
>   src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 
>   src/tests/master_validation_tests.cpp 
> 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d 
>   src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
>   src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
>   

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/#review125919
---




include/mesos/v1/scheduler.hpp (lines 31 - 33)


Can we keep the fwd declaration and remove the #include?



src/cli/resolve.cpp (lines 35 - 36)


Can we just do `using mesos::master::detector::MasterDetector;` instead 
(like we do for local.cpp below)?



src/master/contender.cpp (line 25)


This needs to be moved above process headers.



src/master/contender.cpp (line 45)


Looks like we can get rid of this using stmt. We don't seem to be using 
stuff from `internal` namespace anyways (except at the bottom with an explicit 
declaration).



src/master/detector.cpp (line 33)


Move above process headers.



src/master/detector.cpp (line 281)


drop `mesos::` for consistency?



src/master/detector.cpp (line 305)


ditto



src/master/detector.cpp (line 440)


Please align it with the paren.

Also drop `mesos::`



src/master/detector.cpp (line 453)


same as above.



src/slave/main.cpp (line 263)


Can we revert this since it's not directly related to review chain?



src/tests/authentication_tests.cpp (lines 38 - 39)


Alphabetize



src/tests/cluster.cpp (lines 55 - 56)


Please move the `using` stmts below #includes.

Also, you might want to consider using:
```
using mesos::master::contender::StandAlonContender;
...
```

instead of doing the full namespace thing here.



src/tests/cluster.cpp (line 58)


This is redundant with the above `using namespace` stmts, right?



src/tests/credentials_tests.cpp (line 38)


Add a new line before this one.



src/tests/fault_tolerance_tests.cpp (lines 64 - 65)


Alphabetize pls.



src/tests/master_allocator_tests.cpp (lines 59 - 60)


alphabetize pls.



src/tests/master_authorization_tests.cpp (lines 52 - 53)


ditto.



src/tests/master_contender_detector_tests.cpp (line 65)


Move in front of MasterContender decl.



src/tests/master_contender_detector_tests.cpp (line 70)


same as above.



src/tests/master_tests.cpp (lines 82 - 83)


Alphabetize



src/tests/oversubscription_tests.cpp (lines 61 - 62)


Alphabetize pls



src/tests/partition_tests.cpp (lines 50 - 51)


ditto.



src/tests/persistent_volume_endpoints_tests.cpp (lines 49 - 53)


alphabetize.



src/tests/persistent_volume_tests.cpp (lines 58 - 59)


same



src/tests/reconciliation_tests.cpp (lines 51 - 52)


Same



src/tests/reservation_tests.cpp (lines 56 - 57)


same



src/tests/scheduler_event_call_tests.cpp (lines 45 - 46)


Alphabetize



src/tests/scheduler_tests.cpp (line 78)


this should come together with MasterDetector above.



src/tests/slave_recovery_tests.cpp (lines 78 - 79)


Alphabetize.



src/tests/slave_tests.cpp (lines 71 - 72)


ditto


- Kapil Arya


On March 23, 2016, 7:04 p.m., Anurag Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44288/
> ---
> 
> (Updated March 23, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
> 

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44543/#review126358
---


Ship it!




Ship It!

- Kapil Arya


On March 23, 2016, 7:04 p.m., Anurag Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44543/
> ---
> 
> (Updated March 23, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MasterContender and MasterDetector are now defined in
> include/mesos/master/contender.hpp and detector.hpp.
> 
> 
> Diffs
> -
> 
>   src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
>   src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
> 
> Diff: https://reviews.apache.org/r/44543/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>

Re: Review Request 44289: Added support for contender and detector modules.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44289/#review126353
---



Can we rename test_contender_module.cpp to test_master_contender_module.cpp and 
so on?


src/master/contenders/zookeeper.cpp (line 27)


This should come near the top.


- Kapil Arya


On March 23, 2016, 7:06 p.m., Anurag Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44289/
> ---
> 
> (Updated March 23, 2016, 7:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for contender and detector modules.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/contender.hpp PRE-CREATION 
>   include/mesos/module/detector.hpp PRE-CREATION 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/test_contender_module.cpp PRE-CREATION 
>   src/examples/test_detector_module.cpp PRE-CREATION 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/master/contenders/zookeeper.cpp 
> 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/detectors/zookeeper.cpp PRE-CREATION 
>   src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
>   src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
>   src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a 
> 
> Diff: https://reviews.apache.org/r/44289/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/
---

(Updated March 31, 2016, 5:15 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 

Diff: https://reviews.apache.org/r/44081/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[Jiang Yan Xu]

> On March 31, 2016, 10:12 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, lines 366-368
> > 
> >
> > In this method we can just validate the projectId first and then 
> > 
> > ```
> > traverse(
> > path,
> > std::bind(internal::setProjectId,
> > lambda::_1,
> > projectId,
> > lambda::_2));
> > ```

The above wasn't indented correctly...

```
traverse(
path,
std::bind(
internal::setProjectId,
lambda::_1,
projectId,
lambda::_2));
```


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review126200
---


On March 30, 2016, 3:18 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44946/
> ---
> 
> (Updated March 30, 2016, 3:18 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add utility functions to manipulate XFS project quotas.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44946/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual verification. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

(Updated March 31, 2016, 5:14 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Changes
---

set "depends on" field -- @vinodkone


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
  LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/
---

(Updated March 31, 2016, 5:14 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Changes
---

removed the incorrect "depends on" field. this should block the mesos review 
r/45371 instead. -- @vinodkone


Bugs: MESOS-4803
https://issues.apache.org/jira/browse/MESOS-4803


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
04a4cf4241b8188c093f4942d27b050fa7b20397 
  3rdparty/libprocess/3rdparty/libev-4.15.patch 
bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
  3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
4c282b573aa9331fd16197ef286faf323b6515eb 
  3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
  3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/versions.am 
462a867f4c4e8fce0b62f95bac05ae069281393f 

Diff: https://reviews.apache.org/r/44378/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

[Alex Clemmer]

> On March 18, 2016, 7:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118
> > 
> >
> > This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and 
> > below.

That's right, but the only platform that's not true on is Windows, where this 
functionality is not really available. Since we have no chance to generalize it 
to the Windows case, my inclination is to keep it as is.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
---


On March 14, 2016, 9:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 14, 2016, 9:10 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review126200
---




src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 17)


Now that this header was moved: `s/__XFS_HPP__/__XFS_UTILS_HPP__/`



src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 39)


s/operator ==/operator==/ as per convention.



src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 61)


It would be great if we can have consitently named two set of methods:

```
[get|set|clear]ProjectQuota()
[get|set|clear]ProjectId()
```

set|assign & remove|clear are basically synonymous so we can choose either 
but keep them consistent.



src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 62)


s/path/direcotry/ and we can do a `isdir` check inside.



src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 67)


4 space indetation & s/path/directory/.



src/slave/containerizer/mesos/isolators/xfs/utils.hpp (lines 70 - 72)


Since we don't do recursive calls for `getProjectId`, I think we can just 
internally detect if the path is a directory without concerns about performance.

Therefore:

```
Result getProjectId(const std::string& path);
```



src/slave/containerizer/mesos/isolators/xfs/utils.hpp (lines 75 - 83)


These two methods don't need to appear in the header as they are in fact 
just two internal callbacks driven by the public version of their namesakes.

We can put them in the cpp file: 

```
namespace internal {
static Try setProjectId(
const string& path, 
prid_t projectId,
const struct stat& stat);

static Try clearProjectId(
const string& path, 
prid_t projectId,
const struct stat& stat)
}
```

In fact, I think we can further simplify by removing `clearProjectId()` as 
it is really just a special case of `setProjectId()`. 

I understand that separating them is for clarity and you go a check

```
if (projectId == NON_PROJECT_ID) {
  return NonProjectError();
}
```

in `setProjectId()` so it's less error-prone to use.

However we can do the check in the public version of `setProjectId()` so 
the private `setProjectId()` doesn't need it do it again per file/directory.

Without this check the private versions of `setProjectId()` and 
`clearProjectId()` are identical and we reduce code duplication by consolidate 
them into one.

See my comments on `xfsSetProjectQuota()` for the internal namespace 
explanation.

Also I see that in the tests you have directly used `setProjectId(path)` on 
a file directly so moving this into cpp would force you to change it. I'll 
comment on that test directly.



src/slave/containerizer/mesos/isolators/xfs/utils.cpp (lines 19 - 20)


I think the last sentence is too specific to CentOS and the first two 
sentences have already provided sufficient infomation, i.e., "xfsprogs versions 
earlier than 4.5", so we can remove the last sentence.



src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 59)


Nit: 512u.



src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 60)


Add an empty line.



src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 67)


This is capitalized so it works like a class?

Can we call it `nonProjectError()`?



src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 69)


s/invalid/Invalid/



src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 131)


It would be more idiomatic to put this in a 

```
namespace internal {
  static Try setProjectQuota(
  const string& path,
  prid_t projectId,
  Bytes limit)
  {
...
  }
}
```

So when in your public `setProjectQuota()` it'll be calling 
`internal::setProjectQuota()`, which is clear that a wrapper is calling some 
internal helper, as compared to calling `xfsSetProjectQuota()`. (Because this 
entire file is for XFS so a `xfs` prefix doesn't disambiguate as effectively. 
The same applies to using "assign vs. 

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/#review126352
---


Ship it!




Ship It!

- Vinod Kone


On March 29, 2016, 10:34 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44378/
> ---
> 
> (Updated March 29, 2016, 10:34 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4803
> https://issues.apache.org/jira/browse/MESOS-4803
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 04a4cf4241b8188c093f4942d27b050fa7b20397 
>   3rdparty/libprocess/3rdparty/libev-4.15.patch 
> bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
>   3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
> 4c282b573aa9331fd16197ef286faf323b6515eb 
>   3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 462a867f4c4e8fce0b62f95bac05ae069281393f 
> 
> Diff: https://reviews.apache.org/r/44378/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126351
---


Ship it!




Ship It!

- Vinod Kone


On March 29, 2016, 10:28 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 29, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
>   LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45368/#review126349
---


Ship it!




Ship It!

- Vinod Kone


On March 29, 2016, 10:47 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45368/
> ---
> 
> (Updated March 29, 2016, 10:47 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4678
> https://issues.apache.org/jira/browse/MESOS-4678
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz 
> e600ac57be4c88efb5f146e4b3ec226d8f685033 
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 
> 462a867f4c4e8fce0b62f95bac05ae069281393f 
> 
> Diff: https://reviews.apache.org/r/45368/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45367/#review126350
---


Ship it!




Ship It!

- Vinod Kone


On March 29, 2016, 7:14 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45367/
> ---
> 
> (Updated March 29, 2016, 7:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-4678
> https://issues.apache.org/jira/browse/MESOS-4678
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 
>   src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af 
>   src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
>   src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b 
> 
> Diff: https://reviews.apache.org/r/45367/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>