Review Request 45731: Introduced '--networks' flag to mesos-execute.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45731/
---

Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5117
https://issues.apache.org/jira/browse/MESOS-5117


Repository: mesos


Description
---

Introduced '--networks' flag to mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 

Diff: https://reviews.apache.org/r/45731/diff/


Testing (updated)
---

Ran the following command:
  `sudo src/mesos-execute --master=192.168.122.171:5050 --name=test 
--docker_image=library/busybox --command="sleep 30" --shell=true 
--networks=net1,net2`

The created container successfully joined the CNI networks `net1` and `net2`.


Thanks,

Qian Zhang

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45726/#review127032
---



Patch looks great!

Reviews applied: [45726]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 5, 2016, 2:57 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45726/
> ---
> 
> (Updated April 5, 2016, 2:57 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5114
> https://issues.apache.org/jira/browse/MESOS-5114
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
> 6313b6b1f535822e1dee39f5780895a3691ff78c 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> e87bee24b8c57d15f3903ecd8d55e0e51e00f0ff 
> 
> Diff: https://reviews.apache.org/r/45726/diff/
> 
> 
> Testing
> ---
> 
> Added a new test case that fails before the changes to `parse.hpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Klaus Ma]

> On April 4, 2016, 9:40 a.m., Michael Park wrote:
> > src/examples/dynamic_reservation_framework.cpp, line 308
> > 
> >
> > `static const Resources TASK_RESOURCES;`

If we mark it `const`, we have to move the following code into constructor's 
init, is that OK?

```
Resources::parse(
"cpus:" + stringify(CPUS_PER_TASK) +
";mem:" + stringify(MEM_PER_TASK)).get();
```


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review126769
---


On March 22, 2016, 11:44 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated March 22, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45046/#review127027
---




src/slave/containerizer/fetcher.cpp (line 150)


What does this check against?

`Path(filename).basename()` never returns an Error().


- Jiang Yan Xu


On March 20, 2016, 8:14 p.m., Michael Browning wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45046/
> ---
> 
> (Updated March 20, 2016, 8:14 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-4735
> https://issues.apache.org/jira/browse/MESOS-4735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created URI.filename to name fetched files in sandbox where appropriate.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 
>   docs/fetcher.md f70939d8410516c9387a8cba86b5b75539a5fe9a 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
>   src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 
>   src/slave/containerizer/fetcher.hpp 
> bbdce88da6e41dbb88681bc9d604b00923033b3d 
>   src/slave/containerizer/fetcher.cpp 
> 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 
>   src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 
>   src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e 
> 
> Diff: https://reviews.apache.org/r/45046/diff/
> 
> 
> Testing
> ---
> 
> There are two paths by which a file gets fetched to the executor sandbox: the 
> without-cache path, where the fetcher downloads the file directly from the 
> specified URI, and the with-cache path, where it copies it from the cache. In 
> both cases, we verify that the file is saved to the sandbox directory with 
> the name specified by the "filename" field in the CommandInfo.URI proto.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Klaus Ma]

> On April 4, 2016, 9:40 a.m., Michael Park wrote:
> > src/examples/dynamic_reservation_framework.cpp, lines 311-320
> > 
> >
> > Conceptutally, `Try` is not something we pass around like this. A 
> > function returning a `Try` is emulating a function that throws an 
> > exception. So if a `Try` results in an error, we need to handle it 
> > immediately, or propagate the error. We do not pass it along to a 
> > subsequent function.
> > 
> > There are other issues here as well. Even if we were to pass it around, 
> > it should have been passed by `const &`. What does `rc` stand for?
> > 
> > Functionally speaking, this says that if `rc` is an error, we log 
> > saying we failed to update the state of an agent. But `reserveResources` 
> > returns `Error` if the offer doesn't contain sufficient amount of 
> > resources. This has really little to do with "failing to update the state 
> > of an agent."

Thanks very much for your explaintation on `Try`; that's clear to me :).

BTW, `rc` means `return code`.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review126769
---


On March 22, 2016, 11:44 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated March 22, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45726/#review127023
---



Can you also add a test case for the empty string case? e.g., `--name=`.

Do you think this should an Error case or not?

- Jie Yu


On April 5, 2016, 2:57 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45726/
> ---
> 
> (Updated April 5, 2016, 2:57 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5114
> https://issues.apache.org/jira/browse/MESOS-5114
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
> 6313b6b1f535822e1dee39f5780895a3691ff78c 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> e87bee24b8c57d15f3903ecd8d55e0e51e00f0ff 
> 
> Diff: https://reviews.apache.org/r/45726/diff/
> 
> 
> Testing
> ---
> 
> Added a new test case that fails before the changes to `parse.hpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45726/#review127021
---


Ship it!




Ship It!

- Jie Yu


On April 5, 2016, 2:57 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45726/
> ---
> 
> (Updated April 5, 2016, 2:57 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5114
> https://issues.apache.org/jira/browse/MESOS-5114
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
> 6313b6b1f535822e1dee39f5780895a3691ff78c 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> e87bee24b8c57d15f3903ecd8d55e0e51e00f0ff 
> 
> Diff: https://reviews.apache.org/r/45726/diff/
> 
> 
> Testing
> ---
> 
> Added a new test case that fails before the changes to `parse.hpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review127020
---



Patch looks great!

Reviews applied: [45717]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 11:55 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> ---
> 
> (Updated April 4, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
> https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Klaus Ma]

> On April 4, 2016, 9:40 a.m., Michael Park wrote:
> > src/examples/dynamic_reservation_framework.cpp, lines 350-364
> > 
> >
> > We should be able to just use the ones in `src/tests/mesos.hpp`.

I'd like to de-couple example from Mesos internal code, e.g. `tests/mesos.hpp`. 
Ideally, the user can build example with installed Mesos binaries & headers.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review126769
---


On March 22, 2016, 11:44 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated March 22, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45726/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5114
https://issues.apache.org/jira/browse/MESOS-5114


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
6313b6b1f535822e1dee39f5780895a3691ff78c 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
e87bee24b8c57d15f3903ecd8d55e0e51e00f0ff 

Diff: https://reviews.apache.org/r/45726/diff/


Testing
---

Added a new test case that fails before the changes to `parse.hpp`.


Thanks,

Michael Park

Re: Review Request 45707: Minor cleanups to command executor.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45707/#review127009
---


Ship it!




Ship It!

- Klaus Ma


On April 5, 2016, 5:32 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45707/
> ---
> 
> (Updated April 5, 2016, 5:32 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trivial cleanups: 
> - Not capture boolean arguments by reference.
> - Added newline after a statement.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 
> 
> Diff: https://reviews.apache.org/r/45707/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45707: Minor cleanups to command executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45707/#review127005
---



Patch looks great!

Reviews applied: [45707]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 9:32 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45707/
> ---
> 
> (Updated April 4, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trivial cleanups: 
> - Not capture boolean arguments by reference.
> - Added newline after a statement.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 
> 
> Diff: https://reviews.apache.org/r/45707/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45620/#review126992
---



Patch looks great!

Reviews applied: [45620]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 2, 2016, 6:44 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45620/
> ---
> 
> (Updated April 2, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4764
> https://issues.apache.org/jira/browse/MESOS-4764
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also does a few minor cleanups.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b1173d5adee6b4eb45dbed5e693f40ffb5275210 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review126991
---




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 325)


Do we need to check `pluginDir` here? I think in `recover()`, `pluginDir` 
will not be used, it should only be used in `attach` and `detach`. And in 
another hand, `rootDir` and `pluginDir` are always both set or both not set, it 
is not possible that we have one set but another not set, so I think checking 
one (`rootDir`) should be enough.


- Qian Zhang


On April 5, 2016, 7:55 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> ---
> 
> (Updated April 5, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
> https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45217: Implemented docker volume driver isolator interface.

[Guangya Liu]

> On 四月 4, 2016, 11:01 p.m., Gilbert Song wrote:
> > src/Makefile.am, line 860
> > 
> >
> > Could you move it below runtime.cpp?

There are some files such as spec.proto, dvd_client.cpp, dvd_client.hpp, 
dvd.cpp, dvd.hpp etc, I want to put them into ta single folder to make it 
clear, comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review126794
---


On 四月 2, 2016, 5:45 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> ---
> 
> (Updated 四月 2, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented docker volume driver isolator interface.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45217/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review126983
---




include/mesos/mesos.proto (line 1563)


We cannot simply do that change. That'll make the rollback impossible. This 
needs to go through a deprecation cycle.


- Jie Yu


On April 4, 2016, 8:39 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated April 4, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45377: Updated prepare() logic for unified container.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45377/#review126981
---



Could we keep the cli/execute.cpp changes private for now?

and rebase this with the prepare() method implementation.

- Gilbert Song


On April 4, 2016, 2:28 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45377/
> ---
> 
> (Updated April 4, 2016, 2:28 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated prepare() logic for unified container.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45377/diff/
> 
> 
> Testing
> ---
> 
> Updating the execute.cpp for test, will remove it once test finished.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-5113
https://issues.apache.org/jira/browse/MESOS-5113


Repository: mesos


Description
---

`rootDir` and `pluginDir` can be `None` in case the operator does not
specify the network cni flags. In this case invoking `recover` on the
isolator without checking the `rootDir` and `pluginDir` for `isSome`
will cause the Agent to crash.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
af5f49007e0afe57006c9db940611e56eb75a621 

Diff: https://reviews.apache.org/r/45717/diff/


Testing
---

make

Bought a slave and master and verified that the slave does not crash.


Thanks,

Avinash sridharan

Re: Review Request 45370: Implemented prepare() for dvd isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45370/#review126980
---




src/cli/execute.cpp (lines 323 - 341)


let's keep this as a private branch for testing. This should not be merged 
into cli/execute.cpp



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 77)


Add comments.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (lines 105 - 106)


Use `const string&`


- Gilbert Song


On April 4, 2016, 2:21 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45370/
> ---
> 
> (Updated April 4, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented prepare() for dvd isolator.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45370/diff/
> 
> 
> Testing
> ---
> 
> The execute.cpp is mainly for test, will remove this file once test finished.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 45715: Added support to grant access to /dev/nvidiactl in Nvidia GPU isolator.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45715/
---

Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Bugs: MESOS-5115
https://issues.apache.org/jira/browse/MESOS-5115


Repository: mesos


Description
---

Previously, calls to 'nvidia-smi' would fail inside a container even
if access to a GPU had been granted. Moreover, access to
/dev/nvidiactl is actually required for a container to do anything
useful with a GPU even if it has access to it.

This patch explicitly grants/revokes access to /dev/nvidiactl as GPUs
are added and removed from a container in the Nvidia GPU isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
b0f58035c7c819b42e5f249fadd97312f9e3ac7b 

Diff: https://reviews.apache.org/r/45715/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 44364: Added tests for the Nvidia GPU isolator.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44364/
---

(Updated April 4, 2016, 11:41 p.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
---

Added a more complete test to actually test that GPUs can be added to a 
container and accessed via 'nvidia-smi'


Summary (updated)
-

Added tests for the Nvidia GPU isolator.


Bugs: MESOS-4863
https://issues.apache.org/jira/browse/MESOS-4863


Repository: mesos


Description (updated)
---

This commit also includes a test filter called 'NvidiaGpuFilter' that
checks for the existence of 'nvidia-smi' before running any tests that
contain the 'NVIDIA_GPU_' prefix.


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp PRE-CREATION 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/44364/diff/


Testing (updated)
---

On an Nvidia GPU equipped machine:

```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
bin/mesos-tests.sh

SUCCESS
```

On a **non** Nvidia GPU equipped machine:

```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
bin/mesos-tests.sh

which: no nvidia-smi in (/sbin:/bin:/usr/sbin:/usr/bin)
--
No 'nvidia-smi' command found so no 'NvidiaGpu' tests will run
--
```


Thanks,

Kevin Klues

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/#review126977
---




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 471)


VLOG(1) << "Ignored the 'DOCKER_VOLUME' volume source";


- Gilbert Song


On April 4, 2016, 1:49 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45373/
> ---
> 
> (Updated April 4, 2016, 1:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored the DOCKER_VOLUME volume source.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 9fc7c48f99155750fd3c18c7c102507e2726362b 
> 
> Diff: https://reviews.apache.org/r/45373/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review126927
---



This looks pretty good. One more round of minor cleanups and we would get there.


src/launcher/http_command_executor.cpp (line 51)


Can you reorder alphabetically?



src/launcher/http_command_executor.cpp (line 74)


Nit: Can you move this above `std::string`?



src/launcher/http_command_executor.cpp (lines 80 - 88)


Can you reorder these alphabetically?



src/launcher/http_command_executor.cpp (line 89)


Nit: Newline before



src/launcher/http_command_executor.cpp (line 158)


s/launchTask/launch

This is more in sync with what we have been using as the name for the 
launch function for the v1 API.



src/launcher/http_command_executor.cpp (line 163)


s/killTask/kill



src/launcher/http_command_executor.cpp (lines 195 - 199)


How about:

```cpp
// TODO(qianzhang): Currently, the `mesos-health-check` binary can only 
send unversioned `TaskHealthStatus` messages. This needs to be revisited as 
part of MESOS-5103.
```



src/launcher/http_command_executor.cpp (line 216)


We use 4 line indent for function arguments. Can you fix this?



src/launcher/http_command_executor.cpp (lines 217 - 218)


I would fix the corresponding command executor to not take boolean 
arguments by reference as part of  https://reviews.apache.org/r/45707/ 

Can you fix it here?



src/launcher/http_command_executor.cpp (line 227)


Indent?



src/launcher/http_command_executor.cpp (line 260)


It looks a bit weird that the other function `kill` has an argument of just 
`TaskID` and this has an argument of `Event`.

Can we modify the argument to be just `const Task& _task`



src/launcher/http_command_executor.cpp (line 289)


2 space indent for continuation statements.



src/launcher/http_command_executor.cpp (line 297)


2 space indent for continuation statements.



src/launcher/http_command_executor.cpp (line 423)


Why new line? Also, should fit in one line, no?



src/launcher/http_command_executor.cpp (lines 464 - 466)


Why change this? What's wrong with the previous version spanning 2 lines?



src/launcher/http_command_executor.cpp (line 592)


The default argument for the last argument is anyways `None()`. Why have 
this redundant bit here? Also, would fit in one line neverthless.



src/launcher/http_command_executor.cpp (line 594)


Why not do this after L273 i.e. as soon as you have verified if a task has 
not yet been launched and right before you capture the `TaskID` i.e.

```cpp
// Capture the task.
task = _task;
```

We can then directly use it instead of using `_task`. Sound reasonable?



src/launcher/http_command_executor.cpp (lines 652 - 655)


Should fit in one line, no?

Also if we have `healthy` as a default argument, we can get rid of the 
explicit `None()` too.



src/launcher/http_command_executor.cpp (line 813)


Indent should be 4 spaces.



src/launcher/http_command_executor.cpp (line 815)


hmm ... Why isn't this argument default initialized to `None()` too?



src/launcher/http_command_executor.cpp (lines 1003 - 1011)


2 space indent here.


- Anand Mazumdar


On April 4, 2016, 9:11 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> ---
> 
> (Updated April 4, 2016, 9:11 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> 

Re: Review Request 45360: Added dvd client for mount and unmount.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/#review126971
---




src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp (line 33)


s/DVDClient/DvdClient/g



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp (line 38)


s/dvdCLIPath/dvdcliPath/g



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 54)


`driver_options` is an optional field, right? This may lead to segfault.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 65)


let's make it
```
VLOG(1) << "Mount command '" << cmd << "'";
```



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (lines 67 - 
71)


could we set `dvdcliPath + /dvdcli` as cmd, and append the rest as argv?



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 77)


Should we user await()?

```
reutrn await(
s.get().status(),
io::read(s.get().out().get()),
io::read(s.get().err().get()))
  .then(...)
```



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 86)


ditto for umount.


- Gilbert Song


On April 1, 2016, 10:56 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45360/
> ---
> 
> (Updated April 1, 2016, 10:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dvd client for mount and unmount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45360/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45621: Added tests for docker spec helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/#review126973
---



Patch looks great!

Reviews applied: [44672, 44673, 44674, 45621]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 6:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45621/
> ---
> 
> (Updated April 4, 2016, 6:49 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for docker spec helpers.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> a0de305553cd21bcf266e902a73138862c348a4f 
> 
> Diff: https://reviews.apache.org/r/45621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review126968
---




src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp (line 28)


Should we add a inline parse method here?



src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp (line 29)


s/function/functions/g


- Gilbert Song


On April 1, 2016, 10:52 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 1, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45496: Added documentation of LIBPROCESS_NUM_WORKER_THREADS.

[Maged Michael]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45496/
---

(Updated April 4, 2016, 11:12 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4353
https://issues.apache.org/jira/browse/MESOS-4353


Repository: mesos


Description
---

Added documentation of LIBPROCESS_NUM_WORKER_THREADS. Documentation related to 
https://reviews.apache.org/r/43144/ for 
https://issues.apache.org/jira/browse/MESOS-4353.


Diffs
-

  docs/configuration.md 75c9a0ae7d63ff8b4337778aa7bb28676a1b9f56 

Diff: https://reviews.apache.org/r/45496/diff/


Testing
---


Thanks,

Maged Michael

Re: Review Request 45496: Added documentation of LIBPROCESS_NUM_WORKER_THREADS.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45496/#review126970
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 30, 2016, 10:32 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45496/
> ---
> 
> (Updated March 30, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation of LIBPROCESS_NUM_WORKER_THREADS. Documentation related 
> to https://reviews.apache.org/r/43144/ for 
> https://issues.apache.org/jira/browse/MESOS-4353.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 75c9a0ae7d63ff8b4337778aa7bb28676a1b9f56 
> 
> Diff: https://reviews.apache.org/r/45496/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review126969
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 30, 2016, 5:12 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated March 30, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Joris Van Remoortere, Klaus Ma, and 
> Qian Zhang.
> 
> 
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp feaffa4 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
> The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 45265: Plugged in dvd isolator into agent.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45265/#review126967
---




src/slave/containerizer/mesos/containerizer.cpp (line 73)


One newline above.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line 77)


update the msg.


- Gilbert Song


On April 1, 2016, 10:47 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45265/
> ---
> 
> (Updated April 1, 2016, 10:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Plugged in dvd isolator into agent.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5dd22380066aa85de04d485052084e2629681c0 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45265/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45217: Implemented docker volume driver isolator interface.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review126794
---




src/Makefile.am (line 860)


Could you move it below runtime.cpp?



src/Makefile.am (line 882)


ditto.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 26)


Could we add a brief comment above? Thanks.


- Gilbert Song


On April 1, 2016, 10:45 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> ---
> 
> (Updated April 1, 2016, 10:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented docker volume driver isolator interface.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45217/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

[Joris Van Remoortere]

> On March 31, 2016, 3:43 p.m., Vinod Kone wrote:
> > src/tests/environment.cpp, lines 767-771
> > 
> >
> > should this be done by the test event listener as well?

Added a `TODO` as per discussion offline.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45537/#review126318
---


On April 4, 2016, 10:51 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45537/
> ---
> 
> (Updated April 4, 2016, 10:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5044
> https://issues.apache.org/jira/browse/MESOS-5044
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated testing `Environment` to remove temp dirs after each test.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.hpp 9932f7c530dee3180bbbdf6c06e1e0ec424b46b9 
>   src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 
> 
> Diff: https://reviews.apache.org/r/45537/diff/
> 
> 
> Testing
> ---
> 
> Verified that make check doesn't leak any temporary directories.
> The exception seems to be some mesos-X directories created by example 
> frameworks.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45537/
---

(Updated April 4, 2016, 10:51 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-5044
https://issues.apache.org/jira/browse/MESOS-5044


Repository: mesos


Description
---

Updated testing `Environment` to remove temp dirs after each test.


Diffs (updated)
-

  src/tests/environment.hpp 9932f7c530dee3180bbbdf6c06e1e0ec424b46b9 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/45537/diff/


Testing
---

Verified that make check doesn't leak any temporary directories.
The exception seems to be some mesos-X directories created by example 
frameworks.


Thanks,

Joris Van Remoortere

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45536/
---

(Updated April 4, 2016, 10:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Fixed the root issue, which is that disks were not being created as 
subdirectories correctly.


Bugs: MESOS-5044
https://issues.apache.org/jira/browse/MESOS-5044


Repository: mesos


Description (updated)
---

Added missing `path::join()` call.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
7cb153cc6c0a8ca25cd31096686c63e829f746cf 

Diff: https://reviews.apache.org/r/45536/diff/


Testing
---

Vverified all temporary directories are accounted for by `Environment`.


Thanks,

Joris Van Remoortere

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45381/#review126959
---



Patch looks great!

Reviews applied: [45381]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 2, 2016, 10:31 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45381/
> ---
> 
> (Updated April 2, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These two endpoints and their underlying logics are moved from
> ResourceMonitorProcess to slave process. ResourceMonitor is removed.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/http.cpp 7a872c6e21b115500c5291b7cb9fb240ec9dc8ed 
>   src/slave/monitor.hpp 70a7c88fefd4577f53f85e3eccdd6b69ab6f3acd 
>   src/slave/monitor.cpp 5c1dd354595e67e5eb603c5d49850f84b84b 
>   src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/tests/mesos.hpp 98f97101d89cb91ca5e773e7a91f04ee1b8a0d88 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
> 
> Diff: https://reviews.apache.org/r/45381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> https://issues.apache.org/jira/browse/MESOS-4891
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 45707: Minor cleanups to command executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45707/#review126954
---


Ship it!




Ship It!

- Timothy Chen


On April 4, 2016, 9:32 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45707/
> ---
> 
> (Updated April 4, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trivial cleanups: 
> - Not capture boolean arguments by reference.
> - Added newline after a statement.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 
> 
> Diff: https://reviews.apache.org/r/45707/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

[Jie Yu]

> On April 3, 2016, 3:30 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 95
> > 
> >
> > Can you please clarify why making `networkInfo` as an `Option`? Is 
> > there any chances that `status()` is called before 
> > `ContainerNetwork.networkInfo` is set in `prepare()` and `_recover()`?

I was mainly thinking about the orphan container case. We still create 'Info' 
struct for orphan containers. IN that case, the 'networkInfo' in the 'Info' 
struct does not make sense. Instead of leaving a 'default' networkInfo, I 
prefer to be more explicit using Option.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45620/#review126713
---


On April 2, 2016, 6:44 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45620/
> ---
> 
> (Updated April 2, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4764
> https://issues.apache.org/jira/browse/MESOS-4764
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also does a few minor cleanups.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b1173d5adee6b4eb45dbed5e693f40ffb5275210 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 45461: Create tempfiles in test temporary directory.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45461/#review126951
---


Ship it!




Ship It!

- Vinod Kone


On March 30, 2016, 5:26 p.m., Michael Browning wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45461/
> ---
> 
> (Updated March 30, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Create tempfiles in test temporary directory.
> 
> Previously, some tests were creating tempfiles outside of the temporary 
> directory created by the test case and then manually removing them, which 
> could lead to their being leaked if the test were interrupted.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 84c8d487bbf61c77452bd293062a80fa132e069f 
> 
> Diff: https://reviews.apache.org/r/45461/diff/
> 
> 
> Testing
> ---
> 
> This change merely creates all temporary files used in the process of running 
> fetcher tests inside of the temp directories created by the test case, so no 
> further testing was performed.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>

Review Request 45707: Minor cleanups to command executor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45707/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

Trivial cleanups: 
- Not capture boolean arguments by reference.
- Added newline after a statement.


Diffs
-

  src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 

Diff: https://reviews.apache.org/r/45707/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45690/#review126947
---



Patch looks great!

Reviews applied: [45520, 45690]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 5:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45690/
> ---
> 
> (Updated April 4, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Cong Wang.
> 
> 
> Bugs: MESOS-4662
> https://issues.apache.org/jira/browse/MESOS-4662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is for the port mapping isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
> 
> Diff: https://reviews.apache.org/r/45690/diff/
> 
> 
> Testing
> ---
> 
> sudo make check on Fedora 23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

[Zhitao Li]

> On April 4, 2016, 5:26 p.m., haosdent huang wrote:
> > CHANGELOG, line 49
> > 
> >
> > Usually we don't need change file. It would be changed by release 
> > manager.

hmm, right now the top section of CHANGELOG is written by each feature author 
in git blame, and this was also my impression that we should collectively help 
on changelog documentation so work load of release manager can be reduced.

Please let me know if my understanding of the process is incorrect and I'll 
happily drop this change.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review126862
---


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> ---
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
> https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> ---
> 
> Added a test in oversubciption_tests to make sure executor labels are visible 
> to ResourceEstimator and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126938
---


Ship it!




Ship It!

- Alexander Rukletsov


On April 4, 2016, 3:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> ---
> 
> (Updated April 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126917
---


Fix it, then Ship it!




Thanks for taking this on! I'll fix remaining issues and commit this for you.


docs/versioning.md (line 85)


Let's do it as part of #45660.



support/mesos-style.py (line 101)


/All/Source code



support/mesos-style.py (line 116)


S/Non printable/Non-printable



support/mesos-style.py (lines 116 - 117)


How about a more consistent output? My suggestion is:
```
"{path}:{line_number}: Non-printable characters"
" found at [{chars}]: \"{line}\"\n".format(
```



support/mesos-style.py (line 120)


Let's call it `offset` for consistency with L112.



support/mesos-style.py (line 121)


let's `.rstrip` to remove the newline.


- Alexander Rukletsov


On April 4, 2016, 3:21 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
> 
> (Updated April 4, 2016, 3:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
> 
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
> 
> Note: Scanning .md files is skipped based on feedback from reviews.
> 
> Note: This commit includes patches from Kevin Klues and haosdent.
> 
> 
> Diffs
> -
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> ---
> 
> Tested manually and found two non ascii characters in docs/versioning.md 
> (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44950: Add XFS disk isolator documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review126932
---



Patch looks great!

Reviews applied: [44945, 44946, 45689, 44947, 44948, 44949, 44950]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 5:27 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> ---
> 
> (Updated April 4, 2016, 5:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> ---
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

[Michael Park]

> On March 18, 2016, 7:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118
> > 
> >
> > This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and 
> > below.
> 
> Alex Clemmer wrote:
> That's right, but the only platform that's not true on is Windows, where 
> this functionality is not really available. Since we have no chance to 
> generalize it to the Windows case, my inclination is to keep it as is.

Sounds good.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
---


On March 31, 2016, 5:15 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> ---
> 
> (Updated March 31, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45311: Added an additional template parameter to 'Try' for typed error.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45311/
---

(Updated April 4, 2016, 8:25 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
---

Added a meaningful `static_assert` error message.


Bugs: MESOS-5110
https://issues.apache.org/jira/browse/MESOS-5110


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
c444c0118d39ee6a5da4618d7c62784464377280 

Diff: https://reviews.apache.org/r/45311/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45313/
---

(Updated April 4, 2016, 8:19 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5112
https://issues.apache.org/jira/browse/MESOS-5112


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
64102e1f31437d4271a1126e339fb2f33f0181b8 

Diff: https://reviews.apache.org/r/45313/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45314: Updated `network::connect` to use the typed error state of `Try` .

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/
---

(Updated April 4, 2016, 8:17 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5111
https://issues.apache.org/jira/browse/MESOS-5111


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/network.hpp 
9976257d2d13316062bc95a22ab564ca0df165e5 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/45314/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45312: Captured the error code in `ErrnoError` and `WindowsError`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45312/
---

(Updated April 4, 2016, 8:16 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5109
https://issues.apache.org/jira/browse/MESOS-5109


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 
1e9db7e1cd2f411efb94893ba2c29bd0694e4ddc 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
64102e1f31437d4271a1126e339fb2f33f0181b8 

Diff: https://reviews.apache.org/r/45312/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45310: Removed unnecessary constructors in `Try`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45310/
---

(Updated April 4, 2016, 8:16 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5110
https://issues.apache.org/jira/browse/MESOS-5110


Repository: mesos


Description
---

Correctly constrained the templated constructor.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
c444c0118d39ee6a5da4618d7c62784464377280 

Diff: https://reviews.apache.org/r/45310/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45311: Added an additional template parameter to 'Try' for typed error.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45311/
---

(Updated April 4, 2016, 8:16 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5110
https://issues.apache.org/jira/browse/MESOS-5110


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
c444c0118d39ee6a5da4618d7c62784464377280 

Diff: https://reviews.apache.org/r/45311/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45314: Updated `network::connect` to use the typed error state of `Try` .

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/
---

(Updated April 4, 2016, 8:11 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Summary (updated)
-

Updated `network::connect` to use the typed error state of `Try` .


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/network.hpp 
9976257d2d13316062bc95a22ab564ca0df165e5 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/45314/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45311: Added an additional template parameter to 'Try' for typed error.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45311/
---

(Updated April 4, 2016, 8:08 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Summary (updated)
-

Added an additional template parameter to 'Try' for typed error.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
c444c0118d39ee6a5da4618d7c62784464377280 

Diff: https://reviews.apache.org/r/45311/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126916
---


Ship it!




Thanks for doing this, I could easily imagine issues like this slipping throuh 
in the past since I had to look trice :D

It might be a good idea to get these fixes in before the hook.

- Benjamin Bannier


On April 4, 2016, 5:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> ---
> 
> (Updated April 4, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

[Benjamin Bannier]

> On April 4, 2016, 9:24 p.m., Benjamin Bannier wrote:
> > Ship It!

Thanks for doing this, I could easily imagine issues like this slipping throuh 
in the past since I had to look trice :D

It might be a good idea to get these fixes in before the hook.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126913
---


On April 4, 2016, 5:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> ---
> 
> (Updated April 4, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
> a1bfc808eb1b1c372acb028019901f0ab3f15238 
> 
> Diff: https://reviews.apache.org/r/45659/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/#review126914
---



Patch looks great!

Reviews applied: [45083, 45084, 45350, 45085, 45086, 45087, 45351, 45352, 
45353, 45354, 45362, 45363, 45364, 45472, 45473, 43283, 43284, 45573, 45574, 
45575]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 5:23 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45575/
> ---
> 
> (Updated April 4, 2016, 5:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-5047
> https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> c4e467c8227f9e4129b05d173812592f39a04e06 
> 
> Diff: https://reviews.apache.org/r/45575/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126913
---


Ship it!




Ship It!

- Benjamin Bannier


On April 4, 2016, 5:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> ---
> 
> (Updated April 4, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
> a1bfc808eb1b1c372acb028019901f0ab3f15238 
> 
> Diff: https://reviews.apache.org/r/45659/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126911
---


Ship it!




Ship It!

- Vinod Kone


On April 4, 2016, 3:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> ---
> 
> (Updated April 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126910
---


Ship it!




Ship It!

- Vinod Kone


On April 4, 2016, 3:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> ---
> 
> (Updated April 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
> a1bfc808eb1b1c372acb028019901f0ab3f15238 
> 
> Diff: https://reviews.apache.org/r/45659/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126909
---


Ship it!




Ship It!

- Vinod Kone


On April 4, 2016, 3:21 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
> 
> (Updated April 4, 2016, 3:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
> 
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
> 
> Note: Scanning .md files is skipped based on feedback from reviews.
> 
> Note: This commit includes patches from Kevin Klues and haosdent.
> 
> 
> Diffs
> -
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> ---
> 
> Tested manually and found two non ascii characters in docs/versioning.md 
> (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review126907
---



I don't like the fact that we use 'sandbox' for scratch space. There are two 
reasons: 1) for command tasks, we'll bind mount rootfs into the sandbox. I 
don't want to introduce the complexity of cyclic dependency (rootfs depends on 
sandbox, sandbox has rootfs bind mounts). 2) we don't remove scratch space 
after container terminates. I'd like to avoid that.

Instead, could you please use the provisioner directory for that. More 
precisely, this is probably what you need:
1) in paths.hpp|cpp, introduce a method to get the backend directory: 
`getBackendDir(provisionerDir, containerId, backend);`
2) create scratch space for each container under 
backends/overlay/scratch/.
3) For `provision` interface, you need to add a new parameter which is the 
backend dir for that container (provision(layers, rootfs, backendDir);)

In `provision`, you can use 'basename' to get the rootfsid and create the 
scratch space under backends/overlay/scratch.

- Jie Yu


On March 27, 2016, 2:41 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated March 27, 2016, 2:41 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> e7f7e7fd1304e14dbfaab8b53cea16efc0417911 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45670: Added tests for HTTP command executor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review126904
---



hmm.. Would it be possible to not create a new file just for these two tests? 
IIUC, the existing tests in `src/tests/command_executor_tests.cpp` can be 
easily parameterized by value. The parameterization argument can be a boolean 
flag to the tests to enable/disable the HTTP based executor. You can look at 
some possible examples in `SlaveRecoveryTest`/`SchedulerTest` for possible 
examples.

In the near future, we would like to make `flags.http_command_executor=true` as 
the default i.e. always run our test suite with this option set to `true`. I 
did a quick run using your patches and there would be around ~20 tests mostly 
slave recovery tests that would need their expectations modified. We can do 
that as part of a follow up JIRA later and not worry about them for now.

- Anand Mazumdar


On April 4, 2016, 9:12 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 4, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/tests/http_command_executor_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 45698: Minor cleanups in Disk Quota tests.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45698/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This trivial patch cleans up the disk quota tests:

- Removed some extraneous extra blank lines.
- Modified some variables to be captured by reference.
- Removed `.get()` and replaced it with `->` operator.


Diffs
-

  src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 

Diff: https://reviews.apache.org/r/45698/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45621: Added tests for docker spec helpers.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/
---

(Updated April 4, 2016, 11:49 a.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4939
https://issues.apache.org/jira/browse/MESOS-4939


Repository: mesos


Description
---

Added tests for docker spec helpers.


Diffs (updated)
-

  src/tests/containerizer/docker_spec_tests.cpp 
a0de305553cd21bcf266e902a73138862c348a4f 

Diff: https://reviews.apache.org/r/45621/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

[Kevin Klues]

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote:
> > support/mesos-style.py, line 120
> > 
> >
> > It would be great if we could `+ 1` the `chars`  here like we already 
> > do for the `line_number` in order to keep this all in one place. We could 
> > also use this opportunity to go for less incidental list formatting, e.g.,
> > 
> > chars=', '.join([str(char + 1) for char in char_errors])  # gives 
> > e.g., "Line: 10, Chars: 1, 2, 3: 
> 
> Yong Tang wrote:
> Thanks Benjamin. In Ln 112 the "+ 1" of the Chars has already been 
> processed ("offset + 1").
> 
> Benjamin Bannier wrote:
> Exactly! My point was that I wasn't sure that doing these operations on 
> `line_numer` and `char_errors` in different operations helped clarity.
> 
> Yong Tang wrote:
> Oh I see. Let me update the review request.
> 
> Yong Tang wrote:
> Thanks for the review Benjamin. The review request has been updated. Let 
> me know if there are any other issues.

I agree. This is better.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126806
---


On April 4, 2016, 3:21 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
> 
> (Updated April 4, 2016, 3:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
> 
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
> 
> Note: Scanning .md files is skipped based on feedback from reviews.
> 
> Note: This commit includes patches from Kevin Klues and haosdent.
> 
> 
> Diffs
> -
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> ---
> 
> Tested manually and found two non ascii characters in docs/versioning.md 
> (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126895
---


Ship it!




Ship It!

- Kevin Klues


On April 4, 2016, 3:21 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
> 
> (Updated April 4, 2016, 3:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
> 
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
> 
> Note: Scanning .md files is skipped based on feedback from reviews.
> 
> Note: This commit includes patches from Kevin Klues and haosdent.
> 
> 
> Diffs
> -
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> ---
> 
> Tested manually and found two non ascii characters in docs/versioning.md 
> (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45528/#review126893
---


Ship it!




Ship It!

- Vinod Kone


On April 4, 2016, 11:40 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45528/
> ---
> 
> (Updated April 4, 2016, 11:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5069
> https://issues.apache.org/jira/browse/MESOS-5069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to v2.6.2 [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 35d7e98e9de7dcebbba3b7cdf4d139c918b6f6de 
>   LICENSE 1c0355c1462654e1c30546b448f503cd6365dc46 
> 
> Diff: https://reviews.apache.org/r/45528/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

[Jie Yu]

> On March 31, 2016, 7:14 p.m., Jie Yu wrote:
> > src/slave/slave.hpp, line 550
> > 
> >
> > Can you move this field to Http class because this is a limiter for the 
> > http endpoint. Also, `limiter` sounds too general. Maybe rename it?
> > 
> > ```
> > class Http {
> > private:
> >   Slave* slave;
> >   RateLimiter statisticsLimiter;
> > }
> > 
> > ```
> 
> Jay Guo wrote:
> Renamed it.
> 
> Although there is a problem moving it to http class: `Http http = 
> Http(this);` yields compilation error since RateLimiter class copy operator 
> is deleted.

You can use Shared instead.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45381/#review126360
---


On April 2, 2016, 10:31 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45381/
> ---
> 
> (Updated April 2, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These two endpoints and their underlying logics are moved from
> ResourceMonitorProcess to slave process. ResourceMonitor is removed.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/http.cpp 7a872c6e21b115500c5291b7cb9fb240ec9dc8ed 
>   src/slave/monitor.hpp 70a7c88fefd4577f53f85e3eccdd6b69ab6f3acd 
>   src/slave/monitor.cpp 5c1dd354595e67e5eb603c5d49850f84b84b 
>   src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/tests/mesos.hpp 98f97101d89cb91ca5e773e7a91f04ee1b8a0d88 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
> 
> Diff: https://reviews.apache.org/r/45381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> https://issues.apache.org/jira/browse/MESOS-4891
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---




src/cli/execute.cpp (line 284)


Could you test --command="sh,-c,echo 'hello world'"
and
--command="sh,-c,echo 'hello,world'"

It seems to me that maybe we should add a flag for arguement, since that is 
identical to developer's behavior on writting a framework. Also, tokenize seems 
not sufficient enough to me. Let's discuss today.



src/cli/execute.cpp (line 287)


This is incorrect. We handle this merging operation in runtime isolator.


- Gilbert Song


On April 3, 2016, 6:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126877
---



Patch looks great!

Reviews applied: [45033, 45659, 45660]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 3:22 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> ---
> 
> (Updated April 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

[Jiang Yan Xu]

> On April 4, 2016, 10:35 a.m., haosdent huang wrote:
> > src/tests/cluster.cpp, line 437
> > 
> >
> > how about
> > 
> > ```
> > if (!containerizer) {
> >   return;
> > }
> > ```
> 
> Jiang Yan Xu wrote:
> +1 this is better.
> 
> James Peach wrote:
> You can't early return because you have to call ``terminate()``.

Alright, overlooked it :) However it looks like the lines above this suffer 
from the same problem:

```
if (!cleanUpContainersInDestructor) {
  return;
}
```

In generl I think this is OK:


How about 

```
if (!containerizer || !cleanUpContainersInDestructor) {
  terminate();
  return;
}

...
```


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45689/#review126866
---


On April 4, 2016, 10:31 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45689/
> ---
> 
> (Updated April 4, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Cluster::Slave::start() fails, make sure we don't crash in the
> destructor.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 
> 
> Diff: https://reviews.apache.org/r/45689/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

[James Peach]

> On April 4, 2016, 5:35 p.m., haosdent huang wrote:
> > src/tests/cluster.cpp, line 437
> > 
> >
> > how about
> > 
> > ```
> > if (!containerizer) {
> >   return;
> > }
> > ```
> 
> Jiang Yan Xu wrote:
> +1 this is better.

You can't early return because you have to call ``terminate()``.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45689/#review126866
---


On April 4, 2016, 5:31 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45689/
> ---
> 
> (Updated April 4, 2016, 5:31 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Cluster::Slave::start() fails, make sure we don't crash in the
> destructor.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 
> 
> Diff: https://reviews.apache.org/r/45689/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45520/#review126871
---


Ship it!




You don't have to pass the real path to all the places, other places than the 
mount table checking should be fine. But I am totally fine with this patch too.

Please consider to backport this to other releases.

- Cong Wang


On April 4, 2016, 5:29 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45520/
> ---
> 
> (Updated April 4, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Cong Wang.
> 
> 
> Bugs: MESOS-4662
> https://issues.apache.org/jira/browse/MESOS-4662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used realpath for the bind mount root in port mapping isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 0fe2f486eb733acf738c1c61fc44f820d7401afc 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45520/diff/
> 
> 
> Testing
> ---
> 
> sudo make check on Fedora23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

[Jiang Yan Xu]

> On April 4, 2016, 10:35 a.m., haosdent huang wrote:
> > src/tests/cluster.cpp, line 437
> > 
> >
> > how about
> > 
> > ```
> > if (!containerizer) {
> >   return;
> > }
> > ```

+1 this is better.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45689/#review126866
---


On April 4, 2016, 10:31 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45689/
> ---
> 
> (Updated April 4, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Cluster::Slave::start() fails, make sure we don't crash in the
> destructor.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 
> 
> Diff: https://reviews.apache.org/r/45689/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45689/#review126867
---



Not insisting on addressing it here but just would like to mention that we'd 
better not use assertions in here because we want to clean up all containers 
and not terminate early.

This can be done by addressing this 
[TODO](https://github.com/apache/mesos/blob/f921302b0a0d7c37ba1205ad12857ade614d04ff/3rdparty/libprocess/include/process/gtest.hpp#L206)
 and using it:
```
TODO(bmahler): Differentiate EXPECT and ASSERT here.
```

- Jiang Yan Xu


On April 4, 2016, 10:31 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45689/
> ---
> 
> (Updated April 4, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Cluster::Slave::start() fails, make sure we don't crash in the
> destructor.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 
> 
> Diff: https://reviews.apache.org/r/45689/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45689/#review126866
---




src/tests/cluster.cpp (line 437)


how about

```
if (!containerizer) {
  return;
}
```


- haosdent huang


On April 4, 2016, 5:31 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45689/
> ---
> 
> (Updated April 4, 2016, 5:31 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Cluster::Slave::start() fails, make sure we don't crash in the
> destructor.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 
> 
> Diff: https://reviews.apache.org/r/45689/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 45689: Make Cluster::Slave more tolerant of start failures.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45689/
---

Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.


Repository: mesos


Description
---

If Cluster::Slave::start() fails, make sure we don't crash in the
destructor.


Diffs
-

  src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 

Diff: https://reviews.apache.org/r/45689/diff/


Testing
---

Make check.


Thanks,

James Peach

Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45690/
---

Review request for mesos, Ian Downes and Cong Wang.


Bugs: MESOS-4662
https://issues.apache.org/jira/browse/MESOS-4662


Repository: mesos


Description
---

This is for the port mapping isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
323c84a3d960a196d8ba87f753814e9d43a07957 

Diff: https://reviews.apache.org/r/45690/diff/


Testing
---

sudo make check on Fedora 23


Thanks,

Jie Yu

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45520/
---

(Updated April 4, 2016, 5:29 p.m.)


Review request for mesos, Ian Downes and Cong Wang.


Changes
---

Split the patch per review comments.


Summary (updated)
-

Used realpath for the bind mount root in port mapping isolator.


Bugs: MESOS-4662
https://issues.apache.org/jira/browse/MESOS-4662


Repository: mesos


Description (updated)
---

Used realpath for the bind mount root in port mapping isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
0fe2f486eb733acf738c1c61fc44f820d7401afc 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
323c84a3d960a196d8ba87f753814e9d43a07957 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45520/diff/


Testing
---

sudo make check on Fedora23


Thanks,

Jie Yu

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/
---

(Updated April 4, 2016, 5:28 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Track sandbox directory usage by dynamically assigning XFS project
quotas. We track a range of XFS project IDs, assigning a project ID
and a project quota to each sandbox as it is created. When the task
reaches the quota, writes will fail with EDQUOT, and the task will have
an opportunity to handle that.

Quotas are not applied to volume resources since the isolator interface
has no insight into the volume lifecycle. Thus it is not currently
possible to accurately assign and reclaim project IDs.

If LOW is the lower bound of the project ID range and HIGH is the upper
bound, you can show the currently allocated project quotas using the
xfs_quota command:

  $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"

To show the project ID assigned to the file PATH, use the xfs_io command:

  $ xfs_io -r -c stat PATH


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/containerizer.cpp 
a5dd22380066aa85de04d485052084e2629681c0 
  src/slave/containerizer/mesos/isolators/xfs/disk.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
  src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/44948/diff/


Testing
---

Make check. Manual testing. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44949: Add XFS disk isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/
---

(Updated April 4, 2016, 5:28 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and addressed some review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add basic XFS disk isolator tests by cloning the POSIX disk isolator
tests and making minor changes for the differences in semantics.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44949/diff/


Testing
---

Make check. Manual testing.


Thanks,

James Peach

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated April 4, 2016, 5:27 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/
---

(Updated April 4, 2016, 5:27 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Add XFS disk isolator documentation.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 

Diff: https://reviews.apache.org/r/44950/diff/


Testing
---

Make check. Source inspection.


Thanks,

James Peach

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote:
> > src/tests/containerizer/xfs_quota_tests.cpp, lines 292-294
> > 
> >
> > Instead of doing cleanups here, we can register the projectIds with a 
> > member variable:
> > 
> > ```
> > vector projectIds;
> > ```
> > 
> > This way in the `tearDown()` method we can go through all the them and 
> > call `clearProjectQuota()` on each.

I don't think we need this anymore since we are constructing a fresh filesystem 
each time.


> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote:
> > src/tests/containerizer/xfs_quota_tests.cpp, lines 273-280
> > 
> >
> > So for this we can also create
> > 
> > ```
> > directory
> >  |
> >  |- link
> > ```
> > 
> > Then:
> > ```
> > getProjectId(link);
> > setProjectId(directory);
> > getProjectId(link);
> > clearProjectId(directory);
> > getProjectId(link);
> > ```
> > 
> > Even if the reason for `EXPECT_ERROR(getProjectId(path));` to pass is 
> > due to FTS_PHYSICAL (so we didn't attempt to set it on the link instead of 
> > we cannot set it on the link), that's the situation we are ever going to 
> > run into in real scnearios anyways so it's OK.

These tests were restructured due to feedback in other reviews.


> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote:
> > src/tests/containerizer/xfs_quota_tests.cpp, line 215
> > 
> >
> > This test can be extended to include files:
> > 
> > ```
> > directory
> >   |
> >   |- file
> > ```
> > 
> > You can call `set|clearProjectId()` on the directory and verify 
> > `getProjectId()` on the file inside (and the directory).

These tests were restructured due to feedback in other reviews.


> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote:
> > src/tests/cluster.cpp, lines 434-436
> > 
> >
> > This can be tackled in another review because a) the tests here don't 
> > use cluster.cpp and b) I see other issuse here as well (see below).
> 
> James Peach wrote:
> The isolator tests use ``cluster.cpp``. I hit this when I had a bug in 
> those tests that passed invalid flags arguments to the Slave. Let me know 
> whether you want me to move or just drop this diff. However, it is a fairly 
> annoying problem to debug.

Moved this change to a separate review.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/#review126334
---


On April 1, 2016, midnight, James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44947/
> ---
> 
> (Updated April 1, 2016, midnight)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for XFS project quota utilities.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
>   src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
>   src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 
> 
> Diff: https://reviews.apache.org/r/44947/diff/
> 
> 
> Testing
> ---
> 
> Make check. Manual testing. These tests.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/
---

(Updated April 4, 2016, 5:27 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased and addressed review comments.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add tests for XFS project quota utilities.


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/44947/diff/


Testing
---

Make check. Manual testing. These tests.


Thanks,

James Peach

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/
---

(Updated April 4, 2016, 5:26 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add autoconf tests for XFS project quotas.


Diffs (updated)
-

  configure.ac c693b825294f82ace8a14563cf2229820e159e3c 

Diff: https://reviews.apache.org/r/44945/diff/


Testing
---

Make check. Manual verification.


Thanks,

James Peach

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review126862
---




CHANGELOG (line 49)


Usually we don't need change file. It would be changed by release manager.


- haosdent huang


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> ---
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
> https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp 
> ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> ---
> 
> Added a test in oversubciption_tests to make sure executor labels are visible 
> to ResourceEstimator and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45473/
---

(Updated April 4, 2016, 5:22 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, Guangya Liu, Ian 
Downes, Jie Yu, and Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Migrate test cases for `net_cls` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45473/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45364/
---

(Updated April 4, 2016, 5:21 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Migrate test cases for `memory` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45364/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

(Updated April 4, 2016, 5:21 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `MemorySubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

(Updated April 4, 2016, 5:21 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `cgroups::memory::pressure::Counter::snapshot` method.


Diffs (updated)
-

  src/linux/cgroups.hpp 53397fc1da11a71259df1c38526a613676a60301 
  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45353/
---

(Updated April 4, 2016, 5:19 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45353/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45354/
---

(Updated April 4, 2016, 5:19 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45354/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45352/
---

(Updated April 4, 2016, 5:19 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Add `CpuacctSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45352/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45351/
---

(Updated April 4, 2016, 5:18 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Migrate test cases for `cpu` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45351/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated April 4, 2016, 5:17 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/containerizer.cpp 
a5dd22380066aa85de04d485052084e2629681c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/#review126858
---




src/slave/flags.cpp (line 335)


Remove the whitespace before "\n".


- Neil Conway


On April 4, 2016, 5:14 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45350/
> ---
> 
> (Updated April 4, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, 
> Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-5040
> https://issues.apache.org/jira/browse/MESOS-5040
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `--cgroups_subsystems` in agent flags.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45350/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45085: Add cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45085/
---

(Updated April 4, 2016, 5:15 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Add cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45085/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated April 4, 2016, 5:14 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin 
Klues, and Neil Conway.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45083: Added a any mechanism for futures.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
---

(Updated April 4, 2016, 5:12 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038


Repository: mesos


Description
---

Added a any mechanism for futures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
155e0bb75cf723a0a6c29020f9f767e3ba3d7401 

Diff: https://reviews.apache.org/r/45083/diff/


Testing
---


Thanks,

haosdent huang