Re: Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45943/
---

(Updated April 10, 2016, 5:09 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4465
https://issues.apache.org/jira/browse/MESOS-4465


Repository: mesos


Description
---

Stout:[1/2] transitioned codebase to use `os::pagesize`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
6606e60266d003bbce38bb7cff103ffb603de315 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
6b81bf1ea3d571e8f5fb170076b85223b02efe2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
182ac9cfbacd4535fb355aac6ec38559d786e63a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
edaa76a5322d0bf60b7172405aa754b5aca95458 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/45943/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45983/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-5160
https://issues.apache.org/jira/browse/MESOS-5160


Repository: mesos


Description
---

Enabled the `network/cni` isolator in `MesosContainerizer`.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
a5dd22380066aa85de04d485052084e2629681c0 

Diff: https://reviews.apache.org/r/45983/diff/


Testing
---

make

* Ran the Agent without the `network/cni` enabled in the `--isolation` flags. 
Without the `--network_cni_plugins_dir` and the `--network_cni_config_dir`, 
container using a docker image was launched on the host-network. With the 
`--network_cni_plugins_dir` and the `--network_cni_config_dir` specified the 
CNI network isolator correctly invoked the specified plugin to given the 
container its own network namespace.


Thanks,

Avinash sridharan

Re: Review Request 45956: Added the `_isolate` method.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45956/#review128015
---



Patch looks great!

Reviews applied: [45953, 45954, 45955, 45956]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 5:48 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45956/
> ---
> 
> (Updated April 9, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Once the `isolate` is successful, the `_isolate` method calls out the
> `mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and
> /etc/resolv.conf for the container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 654137c552a7c416f394365e43ea80770fe1ef8d 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 159152a01b68a667dbd57fa6452c6c2a3422787c 
> 
> Diff: https://reviews.apache.org/r/45956/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> *Ran mesos_execute with single master/slave setup to verify that containers 
> get the right hostname and network files when attached to a CNI network.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review128009
---


Ship it!




Ship It!

- Michael Park


On April 9, 2016, 7:14 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> ---
> 
> (Updated April 9, 2016, 7:14 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
> 
> 
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow setting role in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 
> 
> Diff: https://reviews.apache.org/r/43935/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
> 
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
> --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
> 
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --resources="cpus:1;mem:512"
> 
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test" --resources="cpus:2;mem:512"
> 
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test1" --resources="cpus:2;mem:512"
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45944/#review128008
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 8:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45944/
> ---
> 
> (Updated April 8, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4465
> https://issues.apache.org/jira/browse/MESOS-4465
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/tests/containerizer/cgroups_tests.cpp 
> ecd83c7427353790d93e98ab3d62c46a8da43c96 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
> 
> Diff: https://reviews.apache.org/r/45944/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45943/#review128007
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 87)


This __NOTE__ should move to `posix/pagesize.hpp` or be removed.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp (line 
23)


`= {0};` only initializes the first member of the struct, it does __not__ 
zero-initialize the struct. Is this what we want?

Do we need to initialize this at all? `GetSystemInfo` is going to write to 
it anyway.

If we want to be explicit, and zero-initialize, we should do `= {}`.


- Michael Park


On April 8, 2016, 8:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45943/
> ---
> 
> (Updated April 8, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4465
> https://issues.apache.org/jira/browse/MESOS-4465
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 6606e60266d003bbce38bb7cff103ffb603de315 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> 6b81bf1ea3d571e8f5fb170076b85223b02efe2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> 182ac9cfbacd4535fb355aac6ec38559d786e63a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
> 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/45943/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45941/#review128005
---



Patch looks great!

Reviews applied: [45941]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 5:20 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45941/
> ---
> 
> (Updated April 9, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5131
> https://issues.apache.org/jira/browse/MESOS-5131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add check in agent for incorrect oversubscribed resource.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
> 
> Diff: https://reviews.apache.org/r/45941/diff/
> 
> 
> Testing
> ---
> 
> Running existing test, and verify manually that offending resource crashes 
> the agent.
> 
> (Any suggestion to test `CHECK` is welcomed).
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 45861: Windows: Fixed non-blocking connect.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/
---

(Updated April 9, 2016, 11:51 p.m.)


Review request for mesos, Alex Clemmer and switched to 'mcypark'.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/45861/diff/


Testing
---

OSX: make check -j8


Thanks,

Daniel Pravat

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review128003
---



Bad patch!

Reviews applied: [41787]

Failed command: ./support/apply-review.sh -n -r 41787

Error:
2016-04-09 22:34:09 URL:https://reviews.apache.org/r/41787/diff/raw/ 
[7795/7795] -> "41787.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12431/console

- Mesos ReviewBot


On April 9, 2016, 3:42 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> ---
> 
> (Updated April 9, 2016, 3:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests are sped up by using clock, while some relies on the fix of 
> MESOS-4111 and a comment is put.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
> 
> Diff: https://reviews.apache.org/r/41787/diff/
> 
> 
> Testing
> ---
> 
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 45670: Added tests for HTTP command executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review127997
---



Bad patch!

Reviews applied: [45670, 44427, 44424, 44423]

Failed command: ./support/apply-review.sh -n -r 44423

Error:
2016-04-09 21:02:50 URL:https://reviews.apache.org/r/44423/diff/raw/ 
[30696/30696] -> "44423.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12429/console

- Mesos ReviewBot


On April 9, 2016, 8:48 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 9, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 843233adaa68ab1f5cedb7b075439bb8b77469a8 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/#review127994
---



Patch looks great!

Reviews applied: [43558]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 1:14 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43558/
> ---
> 
> (Updated April 9, 2016, 1:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-4663
> https://issues.apache.org/jira/browse/MESOS-4663
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up ExamplesTest.PersistentVolumeFramework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/tests/persistent_volume_framework_test.sh 
> 074cdcbc4a738170e84887c1773cd7c118112d58 
> 
> Diff: https://reviews.apache.org/r/43558/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 
> --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45956: Added the `_isolate` method.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45956/
---

(Updated April 9, 2016, 5:48 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Using realpath of `/etc/resolv.conf`


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

Once the `isolate` is successful, the `_isolate` method calls out the
`mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and
/etc/resolv.conf for the container.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
654137c552a7c416f394365e43ea80770fe1ef8d 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
159152a01b68a667dbd57fa6452c6c2a3422787c 

Diff: https://reviews.apache.org/r/45956/diff/


Testing
---

make

*Ran mesos_execute with single master/slave setup to verify that containers get 
the right hostname and network files when attached to a CNI network.


Thanks,

Avinash sridharan

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45954/
---

(Updated April 9, 2016, 5:46 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Using fs::mount instead of `mount` executable to mount the network files.


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

The `subcommand` allow configuring the container hostname and setting
up network files in the container such as /etc/hosts, /etc/hostname,
/etc/resolv.conf. This will allow for correct name to IP resolution
within the container network namespace.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
654137c552a7c416f394365e43ea80770fe1ef8d 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
159152a01b68a667dbd57fa6452c6c2a3422787c 

Diff: https://reviews.apache.org/r/45954/diff/


Testing
---

make

* Ran mesos_execute along with a single master/slave setup to verify that the 
container joins the CNI network and the hostname and /etc/hosts, 
/etc/resolv.conf are setup correctly.


Thanks,

Avinash sridharan

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45941/
---

(Updated April 9, 2016, 5:20 p.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Move check location.


Bugs: MESOS-5131
https://issues.apache.org/jira/browse/MESOS-5131


Repository: mesos


Description (updated)
---

Add check in agent for incorrect oversubscribed resource.


Diffs (updated)
-

  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 

Diff: https://reviews.apache.org/r/45941/diff/


Testing
---

Running existing test, and verify manually that offending resource crashes the 
agent.

(Any suggestion to test `CHECK` is welcomed).


Thanks,

Zhitao Li

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

[Zhitao Li]

> On April 8, 2016, 11:03 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 4989-4991
> > 
> >
> > Any reason why this CHECK isn't below the VLOG(1) above? Having it 
> > above seems to make it more clear that we're validating the input from the 
> > estimator, no?
> > 
> > Also, for the comment here, we should avoid talking about the 
> > hierarchical allocator since that just happens to be where the failure 
> > manifests.
> > 
> > Perhaps something like:
> > 
> > ```
> > // Oversubscrbable resources must be considered revocable.
> > //
> > // TODO(bmahler): Consider tagging input as revocable
> > // rather than rejecting and crashing here.
> > ```

I'll move it.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45941/#review127914
---


On April 8, 2016, 8:02 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45941/
> ---
> 
> (Updated April 8, 2016, 8:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5131
> https://issues.apache.org/jira/browse/MESOS-5131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add check in agent for incorrect oversubscribed resource.
> 
> I've decided to let agent crash explicitly here instead of fail more silently.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
> 
> Diff: https://reviews.apache.org/r/45941/diff/
> 
> 
> Testing
> ---
> 
> Running existing test, and verify manually that offending resource crashes 
> the agent.
> 
> (Any suggestion to test `CHECK` is welcomed).
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/#review127991
---



Patch looks great!

Reviews applied: [43321]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 9:17 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43321/
> ---
> 
> (Updated April 9, 2016, 9:17 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4175
> https://issues.apache.org/jira/browse/MESOS-4175
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up SchedulerTest.Decline by advancing the clock.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7956da3480c06637b6893e05f2ed92c4bb8d089f 
> 
> Diff: https://reviews.apache.org/r/43321/diff/
> 
> 
> Testing
> ---
> 
> sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*
> 
> ```sh
> [ RUN  ] ContentType/SchedulerTest.Decline/0
> [   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
> [ RUN  ] ContentType/SchedulerTest.Decline/1
> [   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
> ```
> 
> Repeatedly tested with:
> 
> ```sh
> ./bin/mesos-tests.sh --gtest_filter=ContentType/SchedulerTest.Decline/* 
> --gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 四月 9, 2016, 3:42 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Summary (updated)
-

Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 四月 9, 2016, 3:39 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

rebase


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Speed up Speed up SlaveRecoveryTest.*.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 42441: Speed up ExamplesTest test cases.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42441/#review127984
---



Patch looks great!

Reviews applied: [42441]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 8:41 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42441/
> ---
> 
> (Updated April 9, 2016, 8:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jian Qiu.
> 
> 
> Bugs: MESOS-4155
> https://issues.apache.org/jira/browse/MESOS-4155
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up ExamplesTest test cases by decrease scheduler authenticate
> timeout.
> 
> 
> Diffs
> -
> 
>   src/sched/constants.hpp df8a1cc83ee3986400d633b2192b6da7fbe6b626 
>   src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
>   src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 
>   src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 
>   src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 
>   src/tests/no_executor_framework_test.sh 
> 4fa154ee52454fe3f56161abaa29e58793e627e3 
>   src/tests/persistent_volume_framework_test.sh 
> 074cdcbc4a738170e84887c1773cd7c118112d58 
>   src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 
>   src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 
>   src/tests/test_http_framework_test.sh 
> 3a2b24cd5017f3535340cb8ade13b34e341cd7ce 
> 
> Diff: https://reviews.apache.org/r/42441/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45953: Adding a stout interface for `sethostname` system call in linux.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/
---

(Updated April 9, 2016, 2:54 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Fixed Jie's comments.


Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
---

Adding a stout interface for `sethostname` system call in linux.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
3c80910653ad2f3b663f19395f10214029f1a75e 

Diff: https://reviews.apache.org/r/45953/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 45953: Adding a stout interface for `sethostname` system call in linux.

[Avinash sridharan]

> On April 9, 2016, 12:45 a.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 277-281
> > 
> >
> > HOSTNAME max length might be variable. Will the system below checks the 
> > length as well. Why bother adding this additional check?

My bad. Didn't realize sethostname is returning EINVAL if hostname exceeds 
MAXHOSTNAMELEN.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/#review127935
---


On April 8, 2016, 9:59 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45953/
> ---
> 
> (Updated April 8, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding a stout interface for `sethostname` system call in linux.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> 3c80910653ad2f3b663f19395f10214029f1a75e 
> 
> Diff: https://reviews.apache.org/r/45953/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 396
> > 
> >
> > Is there a need to explicitly invoke `Clock::resume()` here? If not, 
> > kill it.
> 
> Alexander Rukletsov wrote:
> Let's leave the test with resumed clock for consistency.
> 
> Anand Mazumdar wrote:
> Alex, what consistency are you referring to here? Does this file follow 
> the pattern of explicitly doing so?
> 
> Alexander Rukletsov wrote:
> We've discussed it with BenM here recently: 
> https://reviews.apache.org/r/44994/#comment186808
> 
> Anand Mazumdar wrote:
> Don't we explicitly resume the clock at the end of the test if an 
> assertion fails making the `resume` call redundant? 
> https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/gtest.hpp#L47
> 
> Looks like I am missing something here.

Change the test here to explicitly destroy container instead of waiting for 
timeout.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
---


On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 四月 9, 2016, 2:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 四月 8, 2016, 2:52 p.m., Alexander Rukletsov wrote:
> > src/tests/hook_tests.cpp, line 392
> > 
> >
> > we don't need `settle` here because AWAIT_READY does it for us. 
> > However, we should resume the clock since in the future we may have a check 
> > that the clock is unpaused when test finishes.

Since we explicitly destroy the container, there is no need to pause/resume 
clock here.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review127792
---


On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 四月 9, 2016, 2:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated 四月 9, 2016, 2:45 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

Address alex's comments.


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Speed up HookTest.VerifySlaveLaunchExecutorHook.


Diffs (updated)
-

  src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review127979
---



Patch looks great!

Reviews applied: [43935]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 7:14 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> ---
> 
> (Updated April 9, 2016, 7:14 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
> 
> 
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow setting role in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 
> 
> Diff: https://reviews.apache.org/r/43935/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
> 
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
> --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
> 
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --resources="cpus:1;mem:512"
> 
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test" --resources="cpus:2;mem:512"
> 
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test1" --resources="cpus:2;mem:512"
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 45670: Added tests for HTTP command executor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review127978
---


Ship it!




LGTM

- Anand Mazumdar


On April 9, 2016, 8:48 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 9, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 843233adaa68ab1f5cedb7b075439bb8b77469a8 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44427: Added --http_command_executor flag.

[Anand Mazumdar]

> On April 8, 2016, 11:29 p.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 5640
> > 
> >
> > We typically don't spill partial arguments from a function invocation.
> > 
> > How about:
> > 
> > ```cpp
> > executorPath = os::realpath(
> >   path::join(slave->flags.launcher_dir, ..));
> > ```
> 
> Qian Zhang wrote:
> Agree, but I think it should 4 space indent, see the followings as 
> example:
> 
> https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5901:L5902
> 
> https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5955:L5956

Yep, was a bad copy paste typo on my part. Thanks for noticing it and updating 
the patch with the correct fix!


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44427/#review127910
---


On April 9, 2016, 8:47 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44427/
> ---
> 
> (Updated April 9, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added --http_command_executor flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
>   src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
>   src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
> 
> Diff: https://reviews.apache.org/r/44427/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127975
---


Ship it!




LGTM

- Anand Mazumdar


On April 9, 2016, 8:40 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> ---
> 
> (Updated April 9, 2016, 8:40 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Anand Mazumdar]

> On April 8, 2016, 6:52 p.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, lines 82-94
> > 
> >
> > Let's move this all out of the `mesos::internal` namespace. We 
> > typically have `using` declarations at the top of the cpp file.
> > 
> > Also, I synced up with Vinod offline let's put all the cpp code in 
> > `mesos::v1::internal` namespace. Then, you won't have all the naming 
> > ambiguities that made you add the using declarations in `mesos::internal` 
> > namespace.
> 
> Qian Zhang wrote:
> Thanks Anand! And I think we do not need the followings since we are 
> already in `mesos::v1` namespace.
> using mesos::v1::CommandInfo;
> using mesos::v1::FrameworkInfo;
> using mesos::v1::KillPolicy;
> using mesos::v1::TaskID;
> using mesos::v1::TaskInfo;
> using mesos::v1::TaskState;
> using mesos::v1::TaskStatus;

Thanks for cleaning them up.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127791
---


On April 9, 2016, 8:40 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> ---
> 
> (Updated April 9, 2016, 8:40 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43558/
---

(Updated April 9, 2016, 1:14 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4663
https://issues.apache.org/jira/browse/MESOS-4663


Repository: mesos


Description
---

Speed up ExamplesTest.PersistentVolumeFramework.


Diffs (updated)
-

  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/tests/persistent_volume_framework_test.sh 
074cdcbc4a738170e84887c1773cd7c118112d58 

Diff: https://reviews.apache.org/r/43558/diff/


Testing (updated)
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh 
--gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 
--gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review127972
---



Patch looks great!

Reviews applied: [43520]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 6:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated April 9, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
> interval.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> 
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43524/#review127970
---



Patch looks great!

Reviews applied: [43524]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 4:11 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43524/
> ---
> 
> (Updated April 9, 2016, 4:11 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and haosdent huang.
> 
> 
> Bugs: MESOS-4160
> https://issues.apache.org/jira/browse/MESOS-4160
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up RecoverTest.AutoInitialization by advacing the clock.
> 
> 
> Diffs
> -
> 
>   src/tests/log_tests.cpp 8f208bac13a7276074278213119d8894766e84ea 
> 
> Diff: https://reviews.apache.org/r/43524/diff/
> 
> 
> Testing
> ---
> 
> `$ sudo make check -j2 GTEST_FILTER='RecoverTest.AutoInitialization'`
> 
> ```sh
> [--] 1 test from RecoverTest
> [ RUN  ] RecoverTest.AutoInitialization
> [   OK ] RecoverTest.AutoInitialization (630 ms)
> [--] 1 test from RecoverTest (631 ms total)
> ```
> 
> Repeatly tested with:
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter=RecoverTest.AutoInitialization 
> --gtest_repeat=1000 --gtest_break_on_failure'
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/
---

(Updated April 9, 2016, 9:17 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased to latest master.


Bugs: MESOS-4175
https://issues.apache.org/jira/browse/MESOS-4175


Repository: mesos


Description
---

Speeded up SchedulerTest.Decline by advancing the clock.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 7956da3480c06637b6893e05f2ed92c4bb8d089f 

Diff: https://reviews.apache.org/r/43321/diff/


Testing (updated)
---

sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*

```sh
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
```

Repeatedly tested with:

```sh
./bin/mesos-tests.sh --gtest_filter=ContentType/SchedulerTest.Decline/* 
--gtest_repeat=1000 --gtest_break_on_failure
```


Thanks,

Shuai Lin

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45959/#review127969
---



You may want to rebase this patch for dynamic_reservation_framework.cpp as well.

- Guangya Liu


On 四月 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45959/
> ---
> 
> (Updated 四月 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new struct Resoure_ is added to keep track of Resource and its
> consumer count. As a result, Resources maintains a single container
> for all resources. Private operators for addition and subtraction
> to/from Resource_ have been added.
> 
> All resources have consumer counts that is tracked within Resources. For
> resource addition and subtraction, the consumer counts are adjusted for
> shared resources as follows:
> a) Addition: If shared resource is absent from original, then the
>resource is added with a consumer count of 0. Otherwise, the
>consumer count for the shared resource is incremented by 1.
> b) Subtraction: If shared resource's consumer count is already 0, then
>the shared resource is removed from the original. Otherwise, its
>consumer count is decremented by 1.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
>   include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
>   src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 
>   src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> cba520e326ff8b0b4ed36a0f4cea6879b57f400c 
>   src/hook/manager.cpp 17a42f8362f58f0857acabeb2c3113354589fa1b 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
>   src/slave/containerizer/containerizer.cpp 
> d0cae79834e451594d7675f00c5f7d2d2cd3a264 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/slave/state.hpp 0de2a4ee4fabaad612c4526166157b001c380bdb 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 7accd32fba5eed196a82b1a171cb16d37b9e0539 
>   src/tests/containerizer/isolator_tests.cpp 
> 7b4d47bd9e99b71269093d7c11559f3b74a3e22b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> a11a3ffb1df1c5bb760041125c83b7b66d44300b 
>   src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e 
>   src/tests/hierarchical_allocator_tests.cpp 
> a5dd57a4e0c244fb099433eb7b5777982698ebfd 
>   src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
>   src/tests/master_tests.cpp a5b21d3d60f944fd52ceacb4bbbad2613f384db7 
>   src/tests/master_validation_tests.cpp 
> 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
>   src/tests/oversubscription_tests.cpp 
> 23671746da2ac505d75bc2bd59114697d9161d52 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/persistent_volume_tests.cpp 
> d246f35046fff469b847c908de2b305ae629212f 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
>   src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e 
>   src/tests/role_tests.cpp 24959d6e0f83ef7b62b0586be18661aa3cac91dd 
>   src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
>   src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 
> 
> Diff: https://reviews.apache.org/r/45959/diff/
> 
> 
> Testing
> ---
> 
> New tests added to demonstrate arithmetic operations for shared resources 
> with consumer counts.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/#review127958
---




include/mesos/resources.hpp (line 258)


s/destroy_allowed/destroyAllowed


- Guangya Liu


On 四月 8, 2016, 11:17 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45960/
> ---
> 
> (Updated 四月 8, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added interfaces to handle and track shareable resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
>   include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
>   src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
>   src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 
> 
> Diff: https://reviews.apache.org/r/45960/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review127968
---



Patch looks great!

Reviews applied: [43329]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 3:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> ---
> 
> (Updated April 9, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
> https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> 404ff098baf89bf2a1c6e32424d591a6ea1a093c 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> ---
> 
> ```
> [--] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator torProcess mesos::internal::master::allocator::DRFSorter> >
> [ RUN  ] MasterAllocatorTest/0.SlaveLost
> [   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [--] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [--] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module (mesos::internal::tests::ModuleID)6>
> [ RUN  ] MasterAllocatorTest/1.SlaveLost
> [   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [--] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> Tested repeatedly with:
> ```
> ./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost 
> --gtest_repeat=1000 --gtest_break_on_failure'
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45959/#review127964
---




include/mesos/resources.hpp (line 64)


s/regular/non-shareable

We often user `regular` resources as `non revocable` resources, so here it 
is better use `non-shareable` to make it more clear



include/mesos/v1/resources.hpp (lines 466 - 467)


adjust the comment to make it less jagged.

// The add and subtract operators on Resource_ is only allowed
// from within Resources class, so we hide these operators.



src/common/resources.cpp (lines 296 - 304)


Why not return false if the resource type is not `SCALAR` because only 
`SCALAR` was supportted for now



src/common/resources.cpp (line 892)


So for such case, do you mean that a shareable resource with 3 cpus can 
contain a shareable resource with 5 cpus?



src/common/resources.cpp (lines 1282 - 1283)


blank line here



src/common/resources.cpp (lines 1430 - 1431)


void Resources::_addConsumers(
const Resource& resource,
Option num_consumers)



src/common/resources.cpp (lines 1474 - 1476)


void Resources::_replaceConsumers(
const Resource& from,
const Resource& to,
Option consumers)



src/tests/resources_tests.cpp (line 2409)


Can you please add more test cases for two resources with consumer greater 
than 1?

Ditto for the subtracble case.



src/tests/resources_tests.cpp (lines 2423 - 2424)


EXPECT_SOME_EQ(0, r1.getConsumerCount(disk1));

This can cover Line 2423 and Line 2424

Ditto for the following in this test: Combine `EXPECT_SOME` and `EXPECT_EQ` 
to `EXPECT_SOME_EQ`



src/tests/resources_tests.cpp (lines 2437 - 2438)


EXPECT_SOME_EQ(0, r2.getConsumerCount(disk2));



src/tests/resources_tests.cpp (lines 2449 - 2450)


EXPECT_SOME_EQ(1, sum.getConsumerCount(disk1));



src/tests/resources_tests.cpp (lines 2453 - 2454)


EXPECT_SOME_EQ(1, sum.getConsumerCount(disk2));



src/tests/resources_tests.cpp (lines 2466 - 2467)


EXPECT_SOME_EQ(1, r.getConsumerCount(disk1));



src/tests/resources_tests.cpp (lines 2470 - 2471)


EXPECT_EQ(1, r.getConsumerCount(disk2));



src/tests/resources_tests.cpp (lines 2501 - 2502)


EXPECT_SOME_EQ(1, r1.getConsumerCount(disk1));


- Guangya Liu


On 四月 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45959/
> ---
> 
> (Updated 四月 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new struct Resoure_ is added to keep track of Resource and its
> consumer count. As a result, Resources maintains a single container
> for all resources. Private operators for addition and subtraction
> to/from Resource_ have been added.
> 
> All resources have consumer counts that is tracked within Resources. For
> resource addition and subtraction, the consumer counts are adjusted for
> shared resources as follows:
> a) Addition: If shared resource is absent from original, then the
>resource is added with a consumer count of 0. Otherwise, the
>consumer count for the shared resource is incremented by 1.
> b) Subtraction: If shared resource's consumer count is already 0, then
>the shared resource is removed from the original. Otherwise, its
>consumer count is decremented by 1.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
>   include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
>   src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 
>   src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> 

Re: Review Request 45670: Added tests for HTTP command executor.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/
---

(Updated April 9, 2016, 4:48 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Added tests for HTTP command executor.


Diffs (updated)
-

  src/tests/command_executor_tests.cpp 843233adaa68ab1f5cedb7b075439bb8b77469a8 

Diff: https://reviews.apache.org/r/45670/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 44427: Added --http_command_executor flag.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44427/
---

(Updated April 9, 2016, 4:47 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Added --http_command_executor flag.


Diffs (updated)
-

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
  src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
  src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 

Diff: https://reviews.apache.org/r/44427/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 42441: Speed up ExamplesTest test cases.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42441/
---

(Updated April 9, 2016, 8:41 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jian Qiu.


Changes
---

Update according to @alexr's comments.


Summary (updated)
-

Speed up ExamplesTest test cases.


Bugs: MESOS-4155
https://issues.apache.org/jira/browse/MESOS-4155


Repository: mesos


Description (updated)
---

Speed up ExamplesTest test cases by decrease scheduler authenticate
timeout.


Diffs (updated)
-

  src/sched/constants.hpp df8a1cc83ee3986400d633b2192b6da7fbe6b626 
  src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
  src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 
  src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 
  src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 
  src/tests/no_executor_framework_test.sh 
4fa154ee52454fe3f56161abaa29e58793e627e3 
  src/tests/persistent_volume_framework_test.sh 
074cdcbc4a738170e84887c1773cd7c118112d58 
  src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 
  src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 
  src/tests/test_http_framework_test.sh 
3a2b24cd5017f3535340cb8ade13b34e341cd7ce 

Diff: https://reviews.apache.org/r/42441/diff/


Testing (updated)
---

Repeat test in CentOS 7.1
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --gtest_repeat=200 
--gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/
---

(Updated April 9, 2016, 4:40 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Updated http_command_executor.cpp to use v1 API.


Diffs (updated)
-

  src/launcher/http_command_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44424/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44427: Added --http_command_executor flag.

[Qian Zhang]

> On April 9, 2016, 7:29 a.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 5640
> > 
> >
> > We typically don't spill partial arguments from a function invocation.
> > 
> > How about:
> > 
> > ```cpp
> > executorPath = os::realpath(
> >   path::join(slave->flags.launcher_dir, ..));
> > ```

Agree, but I think it should 4 space indent, see the followings as example:
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5901:L5902
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5955:L5956


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44427/#review127910
---


On March 6, 2016, 12:37 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44427/
> ---
> 
> (Updated March 6, 2016, 12:37 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added --http_command_executor flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
> 
> Diff: https://reviews.apache.org/r/44427/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Qian Zhang]

> On April 9, 2016, 2:52 a.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, lines 82-94
> > 
> >
> > Let's move this all out of the `mesos::internal` namespace. We 
> > typically have `using` declarations at the top of the cpp file.
> > 
> > Also, I synced up with Vinod offline let's put all the cpp code in 
> > `mesos::v1::internal` namespace. Then, you won't have all the naming 
> > ambiguities that made you add the using declarations in `mesos::internal` 
> > namespace.

Thanks Anand! And I think we do not need the followings since we are already in 
`mesos::v1` namespace.
using mesos::v1::CommandInfo;
using mesos::v1::FrameworkInfo;
using mesos::v1::KillPolicy;
using mesos::v1::TaskID;
using mesos::v1::TaskInfo;
using mesos::v1::TaskState;
using mesos::v1::TaskStatus;


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127791
---


On April 7, 2016, 10:13 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> ---
> 
> (Updated April 7, 2016, 10:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45731/#review127962
---



Patch looks great!

Reviews applied: [45731]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 2:53 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45731/
> ---
> 
> (Updated April 9, 2016, 2:53 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5117
> https://issues.apache.org/jira/browse/MESOS-5117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced '--networks' flag to mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 
> 
> Diff: https://reviews.apache.org/r/45731/diff/
> 
> 
> Testing
> ---
> 
> Ran the following command:
>   `sudo src/mesos-execute --master=192.168.122.171:5050 --name=test 
> --docker_image=library/busybox --command="sleep 30" --shell=true 
> --networks=net1,net2`
> 
> The created container successfully joined the CNI networks `net1` and `net2`.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 四月 9, 2016, 7:14 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

rebase


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review127960
---




include/mesos/mesos.proto (line 756)


s/containers/tasks ? Tasks may be more clear here.



include/mesos/mesos.proto (line 757)


What about `ShareableInfo`? This is also consistent with `RevocableInfo`.



include/mesos/mesos.proto (line 759)


s/i.e./i.e.,



include/mesos/mesos.proto (line 761)


Can you please add a note here that this pareameter is only work for 
persiste volume for now?



include/mesos/mesos.proto (line 762)


s/optional ShareInfo share/optional ShareableInfo shareable


- Guangya Liu


On 四月 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated 四月 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Juan Larriba]

> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote:
> > support/docker_build.sh, line 125
> > 
> >
> > See the ASF CI build error on the attached ticket.
> > 
> > I think specifying configuration options this way doesn't work with 
> > cmake.
> > 
> > Not sure what the right way is. cc @hausdorff

export CONFIGURATION='-DVERBOSE="1"'


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
---


On Abr. 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Abr. 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/
---

(Updated April 9, 2016, 6:19 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4165
https://issues.apache.org/jira/browse/MESOS-4165


Repository: mesos


Description (updated)
---

Speed up MasterTest.MasterInfoOnReElection by advance allocation
interval.


Diffs
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43515/diff/


Testing
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43516/
---

(Updated April 9, 2016, 6:19 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4166
https://issues.apache.org/jira/browse/MESOS-4166


Repository: mesos


Description (updated)
---

Speed up MasterTest.LaunchCombinedOfferTest by advance allocation
interval.


Diffs
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43516/diff/


Testing
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.LaunchCombinedOfferTest" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 9, 2016, 6:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description (updated)
---

Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
interval.


Diffs
-

  src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 

Diff: https://reviews.apache.org/r/43520/diff/


Testing
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43522/
---

(Updated April 9, 2016, 6:16 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4171
https://issues.apache.org/jira/browse/MESOS-4171


Repository: mesos


Description (updated)
---

Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover by
advance allocation interval.


Diffs
-

  src/tests/oversubscription_tests.cpp 23671746da2ac505d75bc2bd59114697d9161d52 

Diff: https://reviews.apache.org/r/43522/diff/


Testing
---

Repeat test on CentOS 7.1

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 9, 2016, 6:09 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description
---

Speed up GarbageCollectorIntegrationTest.Restart.


Diffs (updated)
-

  src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 

Diff: https://reviews.apache.org/r/43520/diff/


Testing (updated)
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang